Re: [PATCH v2] staging: ks7010: call 'hostif_mib_set_request_int' instead of 'hostif_mib_set_request_bool'

On Fri, Jul 13, 2018 at 06:46:57AM +0200, Sergio Paracuellos wrote: > 'hostif_mib_set_request_bool' function receives a bool as value and > send the received value with MIB_VALUE_TYPE_BOOL type. There is > one case where the value passed is not a boolean one but > 'MCAST_FILTER_PROMISC' which is '2

[PATCH v3] staging: ks7010: call 'hostif_mib_set_request_int' instead of 'hostif_mib_set_request_bool'

'hostif_mib_set_request_bool' function receives a bool as value and send the received value with MIB_VALUE_TYPE_BOOL type. There is one case where the value passed is not a boolean one but 'MCAST_FILTER_PROMISC' which is '2'. Call hostif_mib_set_request_int instead for related multicast enumeration

Re: [PATCH v2] staging: ks7010: call 'hostif_mib_set_request_int' instead of 'hostif_mib_set_request_bool'

On Fri, Jul 13, 2018 at 12:26:46AM -0700, Dan Carpenter wrote: > On Fri, Jul 13, 2018 at 06:46:57AM +0200, Sergio Paracuellos wrote: > > 'hostif_mib_set_request_bool' function receives a bool as value and > > send the received value with MIB_VALUE_TYPE_BOOL type. There is > > one case where the val

[PATCH] staging/rtl8192u: hide unused procfs helpers

When CONFIG_PROC_FS isn't set, gcc warning this: drivers/staging/rtl8192u/r8192U_core.c:508:12: warning: ‘proc_get_stats_ap’ defined but not used [-Wunused-function] static int proc_get_stats_ap(struct seq_file *m, void *v) ^ drivers/staging/rtl8192u/r8192U_core.c:527:12: warning: ‘p

[PATCH 1/3] staging: gasket: remove GASKET_SYSFS_REG()

In an attempt to start to clean up the monstrosity of the sysfs abuse in the gasket driver, let's remove code that is not used at all. The GASKET_SYSFS_REG() macro is never used, so delete it. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging

[PATCH 2/3] staging: gasket: remove gasket_sysfs_register_show()

In an attempt to start to clean up the monstrosity of the sysfs abuse in the gasket driver, let's remove code that is not used at all. The gasket_sysfs_register_show() function is never used, so delete it. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- dr

[PATCH 3/3] staging: gasket: sysfs: remove legacy_device field

This field is only ever checked, never actually set, and looks to be left-over from some old interface of some sort. As it's not being used at all here, and is just adding to the complexity, delete it. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- driver

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

On Thu, Jul 12, 2018 at 04:12:39PM -0700, Jann Horn wrote: > On Thu, Jul 12, 2018 at 3:47 PM Al Viro wrote: > > > > On Fri, Jul 13, 2018 at 12:29:36AM +0200, Jann Horn wrote: > > > From: Samuel Thibault > > > > > > From: Samuel Thibault > > > > > > If softsynthx_read() is called with `count < 3`

Re: [PATCH 4/4] staging: gasket: Use __func__ instead of hardcoded string - Style

On Fri, Jul 13, 2018 at 12:58:47AM +0200, Felix Siegel wrote: > > Function calls that do nothing but log "Look at this function I just > > entered/exited!" need to just be deleted entirely, as ftrace should be > > used instead. > > > > Care to do that here, and then send a patch for the remaining

Re: [PATCH v2 2/2] staging: gasket: Use __func__ instead of hardcoded string - Style

On Fri, Jul 13, 2018 at 12:58:49AM +0200, Felix Siegel wrote: > Changed logging statements to use %s and __func__ instead of hard coding > the function name in a string. > > Signed-off-by: Felix Siegel > --- > drivers/staging/gasket/apex_driver.c | 7 --- > drivers/staging/gasket/gask

Re: [PATCH] staging/rtl8192u: hide unused procfs helpers

Pls ignore this, there has a fix. [PATCH] staging/rtl8192u: fix defined but not used build warnings On 2018/7/13 16:01, YueHaibing wrote: > When CONFIG_PROC_FS isn't set, gcc warning this: > > drivers/staging/rtl8192u/r8192U_core.c:508:12: warning: ‘proc_get_stats_ap’ > defined but not used [-W

Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote: > Simple rename of the preprosessor switch, protecting against multiple > inclusion of the header file. Change to clear the checkpatch coding style > issue. > > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/r8192U.h |

[PATCH 1/5] staging: gasket: remove pointless gasket_interrupt_pause()

gasket_interrupt_pause() does nothing, and no one calls it, so remove it as it is dead-weight. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gasket/gasket_interrupt.c | 18 -- drivers/staging/gasket/gasket_interrupt.h | 11

[PATCH 4/5] staging: gasket: remove gasket_interrupt_get_msix_entries()

No one calls it, it is claimed to be "legacy", whatever that means, so just remove the dead code. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gasket/gasket_interrupt.c | 6 -- drivers/staging/gasket/gasket_interrupt.h | 10 -

[PATCH 2/5] staging: gasket: remove gasket_interrupt_get_eventfd_ctxs()

It is exported, yet no one calls it so just remove the dead code. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gasket/gasket_interrupt.c | 7 --- drivers/staging/gasket/gasket_interrupt.h | 12 2 files changed, 19 deleti

[PATCH 3/5] staging: gasket: remove gasket_interrupt_trigger_eventfd()

No one calls it, so just remove the dead code. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gasket/gasket_interrupt.c | 12 drivers/staging/gasket/gasket_interrupt.h | 13 - 2 files changed, 25 deletions(-) diff

[PATCH 5/5] staging: gasket: remove gasket_page_table_num_extended_entries()

It is exported, yet no one calls it so just remove the dead code. Cc: Rob Springer Cc: John Joseph Cc: Ben Chan Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gasket/gasket_page_table.c | 11 --- drivers/staging/gasket/gasket_page_table.h | 7 --- 2 files changed, 18 delet

[PATCH 01/13] staging:rtl8192u: remove typedef of enumeration SwChnlCmdID - Style

To clear a checkpatch issue removed the typedef of the enumeration SwChnlCmdID this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.h | 12 ++-- 2 files

[0/13] staging:rtl8192u: Coding style changes

This series is just coding style changes to clear checkpatch issues. I don't think that there are any changes that impact code execution. I tacked on the end a patch from my last series that failed, again just a rename to avoid CamelCase warning. jwhitmore __

[PATCH 04/13] staging:rtl8192u: remove typedef from structure SwChnlCmd - Style

Checkpatch warns against creation of new types in code. This patch simply removes the "typedef" declaration of the structure SwChnlCmd to clear this issue. Simple coding style issue which should not impact runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c

[PATCH 02/13] staging:rtl8192u: remove typdef from enumeration HW90_BLOCK_E - Style

Checkpatch warns about the creation of new types in code. This patch simply removes the typedef from the enumeration HW90_BLOCK_E to clear this warning. There should be no impact on run time code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 6 +++--- driver

[PATCH 07/13] staging:rtl8192u: rename CmdID_SetTxPowerLevel > CMD_ID_SET_TX_PWR_LEVEL

Rename enumeration label CmdID_SetTxPowerLevel to CMD_ID_SET_TX_PWR_LEVEL. This change clears a checkpatch warning on CamelCase. The change should not impact runtime execution, style change only. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 4 ++-- drivers/staging/rtl

[PATCH 03/13] staging:rtl8192u: Remove typdef from enumeration RF90_RADIO_PATH_E - Style

Checkpatch warns about the creation of new types. This patch simply removes the typedef from the enumeration RF90_RADIO_PATH_E to clear this checkpatch warning. There should be no impact on run time code execution, as this is a coding style issue only. Signed-off-by: John Whitmore --- drivers/st

[PATCH 06/13] staging:rtl8192u: Rename enum label CmdID_End > CMD_ID_END - Style

Rename enum label to clear a CamelCase warning from checkpatch. This is a simple style change and should not impact execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 10 +- drivers/staging/rtl8192u/r819xU_phy.h | 2 +- 2 files changed, 6 insertions(+),

[PATCH 08/13] staging:rtl8192u: Remove unused enum label CmdID_BBRegWrite10

The enum label CmdID_BBRegWrite10 is not used in the code, so removed from the source code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy.h b/drivers/staging/rtl8192u/r819xU_phy.h ind

[PATCH 11/13] staging:rtl8192u: Rename CmdID_WritePortUchar > CMD_ID_WRITE_PORT_UCHAR

Rename the enum label CmdID_WritePortUchar to CMD_ID_WRITE_PORT_UCHAR, to clear the checkpatch issue with CamelCase. The change is a coding style change only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl81

[PATCH 05/13] staging:rtl8192u: Rename SwChnlCmdID > switch_chan_cmd_id - Coding Style

Rename enumerated type to clear a CamelCase warning from checkpatch. The change is style only. No impact on run time execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 4 ++-- drivers/staging/rtl8192u/r819xU_phy.h | 4 ++-- 2 files changed, 4 insertions(+), 4 del

[PATCH 09/13] staging:rtl8192u: Rename CmdID_WritePortUlong > CMD_ID_WRITE_PORT_ULONG

Rename enum label CmdID_WritePortUlong to CMD_ID_WRITE_PORT_ULONG to clear the checkpatch CamelCase issue. Simple syle change which should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl8192u/r819xU_phy.h | 2 +- 2 fil

[PATCH 13/13] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

Simple rename of the preprosessor switch, protecting against multiple inclusion of the header file. Change to clear the checkpatch coding style issue. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r8192U.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 10/13] staging:rtl8192u: Rename CmdID_WritePortUshort > CMD_ID_WRITE_PORT_USHORT

Rename the enum label CmdID_WritePortUshort to CMD_ID_WRITE_PORT_USHORT to clear the checkpatch warning on CamelCase naming. This is a coding style change only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 2 +- drivers/staging/rtl

[PATCH 12/13] staging:rtl8192u: Rename CmdID_RF_WriteReg > CMD_ID_RF_WRITE_REG - Style

Rename enum label CmdID_RF_WriteReg to CMD_ID_RF_WRITE_REG. This change clears the checkpatch issue with CamelCase. The change is style only and should not impact code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/r819xU_phy.c | 6 +++--- drivers/staging/rtl8192u/r819xU_ph

Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style

On Fri, Jul 13, 2018 at 11:39:38AM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote: > > Simple rename of the preprosessor switch, protecting against multiple > > inclusion of the header file. Change to clear the checkpatch coding style > > issue. > > > > Signe

[PATCH 4/4] staging: mt7621: Add SPDX license identifier

Signed-off-by: Oliver Hübers Signed-off-by: Vanessa Borgmann --- drivers/staging/mt7621-pci/pci-mt7621.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index c118d78..fbffa3e 100644 --- a/drivers/staging/mt76

[PATCH 3/4] staging: mt7621: Add braces around macro argument

Add braces around macro argument to avoid precedence problems. This fixes the corresponding checkpatch warning. Signed-off-by: Oliver Hübers Signed-off-by: Vanessa Borgmann --- drivers/staging/mt7621-pci/pci-mt7621.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 2/4] staging: mt7621-pci: Fix coding style issues reported by checkpatch

From: Vanessa Borgmann Fix errors: space errors, braces Fix warnings: comment warnings Signed-off-by: Oliver Hübers Signed-off-by: Vanessa Borgmann --- drivers/staging/mt7621-pci/pci-mt7621.c | 230 1 file changed, 112 insertions(+), 118 deletions(-) diff --g

[PATCH 1/4] staging: mt7621-pci: Include preferred headers

This fixes the following checkpatch warnings: Use #include instead of Use #include instead of Signed-off-by: Oliver Hübers Signed-off-by: Vanessa Borgmann --- drivers/staging/mt7621-pci/pci-mt7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt76

RE: [PATCH] Drivers: hv: vmbus: Reset the channel callback in vmbus_onoffer_rescind()

From: Dexuan Cui Sent: Thursday, July 12, 2018 10:53 PM > > Before setting channel->rescind in vmbus_rescind_cleanup(), we should make > sure the channel callback won't run any more, otherwise a high-level > driver like pci_hyperv, which may be infinitely waiting for the host VSP's > response and

Re: [PATCH v3] staging: ks7010: call 'hostif_mib_set_request_int' instead of 'hostif_mib_set_request_bool'

Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: gasket remove current_kernel_time usage

A new user of the deprecated current_kernel_time() function has appeared here. This code won't work correct during leap seconds or a concurrent settimeofday() call, and it probably doesn't do what the author intended even for the normal case, as it passes a timeout in nanoseconds but reads the time

Re: [PATCH] staging: gasket remove current_kernel_time usage

On Fri, Jul 13, 2018 at 05:06:37PM +0200, Arnd Bergmann wrote: > A new user of the deprecated current_kernel_time() function has appeared > here. This code won't work correct during leap seconds or a concurrent > settimeofday() call, and it probably doesn't do what the author intended > even for th

Re: [PATCH] staging: gasket remove current_kernel_time usage

On Fri, Jul 13, 2018 at 05:33:51PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 13, 2018 at 05:06:37PM +0200, Arnd Bergmann wrote: > > A new user of the deprecated current_kernel_time() function has appeared > > here. This code won't work correct during leap seconds or a concurrent > > settimeofd

[PATCH] staging: rtl8188eu: remove is_{multicast,broadcast}_mac_addr

Remove custom is_multicast_mac_addr() and is_broadcast_mac_addr(). Use is_multicast_ether_addr() instead. By definition the broadcast address is also a multicast address. is_multicast_ether_addr() returns true for broadcast addresses. Hence checking for multicast in the conditional is sufficient.

staging:rtl8192u: [0/10] Coding style changes.

All coding style changes, but the second [2/10] is a bit more hairy then most. The original code combined two typedef declarations into one with both the structure and a pointer to the structure defined. I've totally removed the pointer to the structure type since it uses Hungarian notation, which

[PATCH 03/10] staging:rtl8192u: Rename List > list - Coding style

In struct TS_COMMON_INFO rename the member List to list. This clears the checkpatch issue concerning CamelCase naming of variables. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- .../rtl8192u/ieee80211/rtl819x_TSProc.c | 64 +-- 2 fi

[PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style

To clear a checkpatch issue removed the typedef of the structure TS_COMMON_INFO. This change removes the previous declaration, which defined two types, both TS_COMMON_INFO and a pointer type PTS_COMMON_INFO: typedef struct _TS_COMMON_INFO { ... } TS_COMMON_INFO, *PTS_COMMON_INFO; The poi

[PATCH 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc - Style

Rename the struct TS_COMMON_INFO member variable TClasProc to t_clas_proc. This change clears the checkpatch issue with CamelCase variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/s

[PATCH 07/10] staging:rtl8192u: Rename TSpec > t_spec - Style

Rename the TS_COMMON_INFO structure's member TSpec to t_spec. This change clears the checkpatch issue with CamelCase naming of variables. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +- drivers/staging/r

[PATCH 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style

Rename the struct TS_COMMON_INFO member SetupTimer to setup_timer. This clears the checkpatch issue with CamelCase variable names. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 8 2 file

[PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style

To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++-- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

[PATCH 06/10] staging:rtl8192u: Rename Addr > addr - Style

Rename the TX_COMMON_INFO structure's member Addr to addr. This change clears the checkpatch issue with CamelCase naming. This is a coding style change only and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 10 +

[PATCH 05/10] staging:rtl8192u: Rename InactTimer > inact_timer - Style

Rename the struct TS_COMMON_INFO member InactTimer to inact_timer. This change clears the checkpatch issue with CamelCase naming. The change should not have any impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/stag

[PATCH 08/10] staging:rtl8192u: Rename TClass > t_class - Style

Rename the struct TS_COMMON_INFO member variable from TClass to t_class. This change clears the checkpatch issue with CamelCase Variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/sta

[PATCH 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num - Style

Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This change clears the checkpatch issue with CamelCase naming. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging/rtl

Re: [PATCH 2/3] staging: mt7621-pci: use generic kernel pci subsystem read and write

On Tue, Jul 10 2018, Sergio Paracuellos wrote: > map_bus callback is called before every .read/.write operation. > Implement it and change custom read write operations for the > pci subsystem generics. Make the probe function to assign data > for controller data and get pci register base from devi

[PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,6 +5

[PATCH 11/18] staging: gasket: always allow root open for write

From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++-- drivers/staging/gasket/gas

[PATCH 04/18] staging: gasket: device registration error and unregister fixups

From: Todd Poynor Remove device registration on class creation fail. Hold mutex around device removal updates for proper ordering of updates. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletio

[PATCH 18/18] staging: gasket: various cleanups

From: Todd Poynor Cleanups to error codes, code style, error conditions, etc. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 ++- drivers/staging/gasket/apex_driver.c | 50 - drivers/sta

[PATCH 01/18] staging: gasket: remove X86 Kconfig restriction

From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig ind

[PATCH 10/18] staging: gasket: gasket_open use container_of()

From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket/gask

[PATCH 12/18] staging: gasket: annotate ioctl arg with __user

From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 12 ++--- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h | 4 +- drivers/staging/gasket

[PATCH 14/18] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 13/18] staging: gasket: gasket_enable_dev fixups

From: Todd Poynor Remove unnecessary variable. Bail out if no physical device. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/g

[PATCH 03/18] staging: gasket: typo and whitespace cleanups

From: Todd Poynor Trivial typo and whitespace fixes. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- drivers/staging/gasket/gasket_core.h | 2 +- drivers/staging/gasket/gasket_page_table.c | 2 +- 3 files changed, 3 insertions(

[PATCH 17/18] staging: gasket: don't release coherent mappings

From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

[PATCH 05/18] staging: gasket: sysfs mapping creation fixups

From: Todd Poynor Return EBUSY for attempt to create a mapping already in use. Remove stale pointers on error allocating attr array. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 de

[PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator

From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

From: Todd Poynor Return -ETIMEDOUT on timeouts. Don't need 64-bit sized retry count. Use msleep(). Return immediately when condition hit. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers/stag

[PATCH 00/18] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (18): staging: gasket: remove X86 Kconfig restriction MAINTAINERS: Add maintainer for drivers/staging/gasket staging: gasket: typo and whitespace cleanups staging: gaske

[PATCH 16/18] staging: gasket: gasket core error handling fixups

From: Todd Poynor Minor fixups to error codes and error handling in gasket core. No device reset callback registered is not an error condition. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error

From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return

From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b

[PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,7 +5

Re: [PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

On Fri, Jul 13, 2018 at 10:58:00PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Todd Poynor will be a maintainer of the Gasket > and Apex drivers. > > Signed-off-by: Todd Poynor I need an ack, or signed-off-by by the current maintainers that this is ok. And 4 maintainers is a lot, are y

Re: [PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

On Fri, Jul 13, 2018 at 11:04:07PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Todd Poynor will be a maintainer of the Gasket > and Apex drivers. > > Signed-off-by: Todd Poynor > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) What changed from v1? Always put that below the

Re: [PATCH 18/18] staging: gasket: various cleanups

On Fri, Jul 13, 2018 at 10:58:16PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Cleanups to error codes, code style, error conditions, etc. You you need to break this up into "one type of logical change per patch" here for this change, sorry. thanks, greg k-h _

Re: [PATCH 03/18] staging: gasket: typo and whitespace cleanups

On Fri, Jul 13, 2018 at 10:58:01PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Trivial typo and whitespace fixes. typos are different from whitespace issues. Please break this up. Yeah, it's a pain, sorry, but that's a requirement for kernel patches. It's to make it easier on the reviewe

Re: [PATCH 05/18] staging: gasket: sysfs mapping creation fixups

On Fri, Jul 13, 2018 at 10:58:03PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return EBUSY for attempt to create a mapping already in use. Why? > Remove stale pointers on error allocating attr array. This should be a different patch. thanks, greg k-h __

Re: [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return -ETIMEDOUT on timeouts. > > Don't need 64-bit sized retry count. > > Use msleep(). > > Return immediately when condition hit. Huge hint, when you have to list the different things you do in a patch, th

Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

On Fri, Jul 13, 2018 at 10:58:10PM -0700, Todd Poynor wrote: > From: Todd Poynor > > For sparse checking. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > --- Are you sure this patch even applies? What tree did you make it against? I ask because t

Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

On Fri, Jul 13, 2018 at 10:58:04PM -0700, Todd Poynor wrote: > From: Todd Poynor > > g_mutex held across pci_unregister_driver() call, also held in > gasket_pci_remove(), which deadlocks. Which reminds me, why in the world do you all wrap pci register/unregister within your new subsystem? That'

Re: [PATCH 13/18] staging: gasket: gasket_enable_dev fixups

On Fri, Jul 13, 2018 at 10:58:11PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Remove unnecessary variable. > > Bail out if no physical device. > > Signed-off-by: Todd Poynor > --- > drivers/staging/gasket/gasket_core.c | 19 ++- > 1 file changed, 6 insertions(+), 13 del