On Mon, Jul 09, 2018 at 11:52:30AM -0400, Janani Sankara Babu wrote:
> This driver uses the same unregistered vendor id that the
> firewire core does (0xd00d1e). Hence it is exposed as a
> define in firewire.h.
>
> Signed-off-by:Janani Sankara Babu
> ---
> drivers/staging/fwserial/fwserial.c | 1
On Mon, Jul 9, 2018 at 3:10 AM, Tetsuo Handa
wrote:
> While at it, let's add cond_resched() to binder_thread_write(),
> binder_transaction() and binder_release_work() loops because they might
> take long time.
This should be a separate patch, and I would love to see some
benchmark data around thi
On Mon, Jul 09, 2018 at 10:10:34AM +0900, Tetsuo Handa wrote:
> >From 62ddef96020cb397dcbf4b8574f1859b32f983de Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa
> Date: Mon, 9 Jul 2018 09:54:01 +0900
> Subject: [PATCH] ANDROID: binder: Latelimit binder_debug().
>
> syzbot is reporting hung tasks [1]
On Mon, Jul 09, 2018 at 06:30:07AM +0200, Sergio Paracuellos wrote:
> On Mon, Jul 09, 2018 at 09:40:18AM +1000, NeilBrown wrote:
> > On Thu, Jun 28 2018, Sergio Paracuellos wrote:
> >
> > > We don't really need initialization of this at such an early stage.
> > > Just use builtin_platform_driver t
On Mon, Jul 09, 2018 at 06:41:15AM +0200, Sergio Paracuellos wrote:
> On Mon, Jul 09, 2018 at 11:08:58AM +1000, NeilBrown wrote:
> > On Sun, Jul 08 2018, Sergio Paracuellos wrote:
> >
> > > This patch series clean up a bit mt7621-pci driver.
> > >
> > > Changes from v2:
> > > - It includes new
On Sun, Jul 08, 2018 at 02:25:38PM -0400, jacob feder wrote:
> On Sun, Jul 8, 2018 at 9:28 AM Greg KH wrote:
>
> On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > Hi all,
> > I have developed this driver for a Xilinx-provided IP block for their
> Zynq
> > SoC. I
On Sun, Jul 08, 2018 at 08:30:50PM +0300, Kamal Heib wrote:
> This patch add description for the module parameters and remove the task
> to do it from the TODO file.
>
> Signed-off-by: Kamal Heib
> ---
> drivers/staging/gasket/TODO | 1 -
> drivers/staging/gasket/apex_driver.c | 8 +
On Sun, May 20, 2018 at 04:48:46PM +0300, Dmitry Osipenko wrote:
> Hook up Memory Client reset of the Video Decoder to the decoders DT node.
>
> Signed-off-by: Dmitry Osipenko
> ---
> arch/arm/boot/dts/tegra30.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Thi
On Sun, May 20, 2018 at 04:48:44PM +0300, Dmitry Osipenko wrote:
> Hook up Memory Client reset of the Video Decoder to the decoders DT node.
>
> Signed-off-by: Dmitry Osipenko
> ---
> arch/arm/boot/dts/tegra20.dtsi | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Applied, thanks.
From: root
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga
---
drivers/staging/gdm724x/gdm_tty.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
Hyper-V provides a para-virtualization hypercall
HvFlushGuestPhysicalAddressSpace
to flush nested VM address space mapping in l1 hypervisor and it's to reduce
overhead
of flushing ept tlb among vcpus. The tradition way is to send IPIs to all
affected
vcpus and executes INVEPT on each vcpus. It w
Register tlb_remote_flush callback for vmx when hyperv capability of
nested guest mapping flush is detected. The interface can help to
reduce overhead when flush ept table among vcpus for nested VM. The
tradition way is to send IPIs to all affected vcpus and executes
INVEPT on each vcpus. It will t
This patch is to check ept table pointer of each cpus when set ept
tables and store identical ept table pointer if all ept table pointers
of single VM are same. This is for support of para-virt ept flush
hypercall.
Signed-off-by: Lan Tianyu
---
Change since v1:
Replace identical_ept_pointe
This patch is to add hyperv_nested_flush_guest_mapping support to trace
hvFlushGuestPhysicalAddressSpace hypercall.
Signed-off-by: Lan Tianyu
---
arch/x86/hyperv/nested.c| 3 +++
arch/x86/include/asm/trace/hyperv.h | 14 ++
2 files changed, 17 insertions(+)
diff --git a
Hyper-V supports a pv hypercall HvFlushGuestPhysicalAddressSpace to
flush nested VM address space mapping in l1 hypervisor and it's to
reduce overhead of flushing ept tlb among vcpus. This patch is to
implement it.
Signed-off-by: Lan Tianyu
---
arch/x86/hyperv/Makefile | 2 +-
arch/x8
This patch is to provide a way for platforms to register hv tlb remote
flush callback and this helps to optimize operation of tlb flush
among vcpus for nested virtualization case.
Signed-off-by: Lan Tianyu
---
Change since v1:
Add kvm_arch_hv_flush_remote_tlb() to avoid compilation issue
f
On Mon, Jul 09, 2018 at 02:14:06PM +0530, Jaya Durga wrote:
> From: root
That's an odd author name :)
>
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
>
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fix checkpath check
>
> Signed-off-by: Jaya Durga
It doesn't m
On Sun, Jul 08, 2018 at 05:38:11PM +0200, Greg KH wrote:
> On Sat, Jul 07, 2018 at 03:55:04PM +0100, John Whitmore wrote:
> > Coding style change to simply remove the unrequired spaces before a closing
> > brace or before an opening brace.
>
> That would be good, but that's not what this patch doe
From: root
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga
---
drivers/staging/gdm724x/gdm_tty.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
That patch causes the network interface on the device to stop working.
device_initcall() is called much later than core_initcall_sync() and
that seem to be a problem. Revert it to get a correct behaviour.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 7 +
On Mon, Jul 09, 2018 at 09:39:19AM +0200, Greg KH wrote:
> On Mon, Jul 09, 2018 at 06:30:07AM +0200, Sergio Paracuellos wrote:
> > On Mon, Jul 09, 2018 at 09:40:18AM +1000, NeilBrown wrote:
> > > On Thu, Jun 28 2018, Sergio Paracuellos wrote:
> > >
> > > > We don't really need initialization of th
On Mon, Jul 09, 2018 at 09:38:59AM +0200, Greg KH wrote:
> On Mon, Jul 09, 2018 at 06:41:15AM +0200, Sergio Paracuellos wrote:
> > On Mon, Jul 09, 2018 at 11:08:58AM +1000, NeilBrown wrote:
> > > On Sun, Jul 08 2018, Sergio Paracuellos wrote:
> > >
> > > > This patch series clean up a bit mt7621-p
On Mon, Jul 09, 2018 at 03:30:20PM +0530, Jaya Durga wrote:
> From: root
Please send the patch to yourself first and make sure it's right. Then
resend to the list.
>
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
>
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fi
On Mon, Jul 09, 2018 at 12:18:46PM +0200, Sergio Paracuellos wrote:
> That patch causes the network interface on the device to stop working.
> device_initcall() is called much later than core_initcall_sync() and
> that seem to be a problem. Revert it to get a correct behaviour.
>
> Signed-off-by:
From: root
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga
---
drivers/staging/gdm724x/gdm_tty.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
That patch causes the network interface on the device to stop working.
device_initcall() is called much later than core_initcall_sync() and
that seem to be a problem. Revert it to get a correct behaviour.
Reported-by: NeilBrown
Signed-off-by: Sergio Paracuellos
---
Changes in v2:
- Add Reporte
On Mon, Jul 09, 2018 at 01:35:57PM +0300, Dan Carpenter wrote:
> On Mon, Jul 09, 2018 at 12:18:46PM +0200, Sergio Paracuellos wrote:
> > That patch causes the network interface on the device to stop working.
> > device_initcall() is called much later than core_initcall_sync() and
> > that seem to b
On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
wrote:
> Add a devicetree binding documentation for the mt7621 gpio.
>
> Signed-off-by: Sergio Paracuellos
> Reviewed-by: NeilBrown
Patch applied with Rob's review tag.
Yours,
Linus Walleij
___
devel
Also, you really should be sending this as a [PATCH v3] with a note
under the --- cut off that says "V3: fix From header, and indenting"
Google for how to send a v2 patch.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http:
On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
wrote:
> Add driver support for gpio of MT7621 SoC.
>
> Signed-off-by: Sergio Paracuellos
> Reviewed-by: NeilBrown
This is looking really good.
Patch applied: anything remaining can surely be patched up
in-tree.
> +/*
> + * Copyright (C) 2009
On Mon, Jul 09, 2018 at 04:27:58PM +0530, Jaya Durga wrote:
> From: root
Again, wrong address :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jul 09, 2018 at 01:37:09PM +0200, Linus Walleij wrote:
> On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
> wrote:
>
> > Add a devicetree binding documentation for the mt7621 gpio.
> >
> > Signed-off-by: Sergio Paracuellos
> > Reviewed-by: NeilBrown
>
> Patch applied with Rob's review
On Mon, Jul 09, 2018 at 10:29:54AM +0100, John Whitmore wrote:
> On Sun, Jul 08, 2018 at 05:38:11PM +0200, Greg KH wrote:
> > On Sat, Jul 07, 2018 at 03:55:04PM +0100, John Whitmore wrote:
> > > Coding style change to simply remove the unrequired spaces before a
> > > closing
> > > brace or before
From: root
CHECK: Macro argument reuse 'gdm' - possible side-effects?
convert GDM_TTY_READY to gdm_tty_ready static function
to fix checkpath check
Signed-off-by: Jaya Durga
---
drivers/staging/gdm724x/gdm_tty.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git
I don't understand why you have sent this patch four times.
Are you a script which has a bug? Please answer us so that we know you
are a human being.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
Hi ,
I have updated the patch --subject-prefix="PATCH v3" and made the
commit as per your suggestion ,
i don't know why does the script doesn't update my changes,will try to
sort out the issue ,
sorry for the inconvenience.
Regards,
Jaya Durga
On Mon, Jul 9, 2018 at 6:26 PM, Dan Carpenter wrote:
Hi Roy,
Couple of comments inline.
On 05.07.2018 22:41, Roy Pledge wrote:
> Move the NXP DPIO (Datapath I/O Driver) out of the
> drivers/staging directory and into the drivers/soc/fsl directory.
>
> The DPIO driver enables access to Queue and Buffer Manager (QBMAN)
> hardware on NXP DPAA2 device
Dmitry, do you know how/why syzbot is enabling debug messages?
On 2018/07/09 16:38, Greg Kroah-Hartman wrote:
> On Mon, Jul 09, 2018 at 10:10:34AM +0900, Tetsuo Handa wrote:
>> >From 62ddef96020cb397dcbf4b8574f1859b32f983de Mon Sep 17 00:00:00 2001
>> From: Tetsuo Handa
>> Date: Mon, 9 Jul 2018 0
On Mon, Jul 09, 2018 at 01:45:22PM +0200, Linus Walleij wrote:
> On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
> wrote:
>
> > Add driver support for gpio of MT7621 SoC.
> >
> > Signed-off-by: Sergio Paracuellos
> > Reviewed-by: NeilBrown
>
> This is looking really good.
>
> Patch applied:
On Mon, Jul 09, 2018 at 03:28:50PM +0200, Sergio Paracuellos wrote:
> On Mon, Jul 09, 2018 at 01:45:22PM +0200, Linus Walleij wrote:
> > On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
> > wrote:
> >
> > > Add driver support for gpio of MT7621 SoC.
> > >
> > > Signed-off-by: Sergio Paracuellos
On Mon, Jul 09, 2018 at 09:43:28AM +0200, Greg KH wrote:
> On Sun, Jul 08, 2018 at 02:25:38PM -0400, jacob feder wrote:
> > On Sun, Jul 8, 2018 at 9:28 AM Greg KH wrote:
> >
> > On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> > > Hi all,
> > > I have developed this driv
Use mac_pton() instead of custom approach.
Remove the now unused hex2num_i() and hwaddr_aton_i().
Signed-off-by: Michael Straube
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 41 +--
1 file changed, 1 insertion(+), 40 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_
On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov wrote:
> I know almost nothing about binder. How these debug messages are
> enabled? I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the
> config:
> https://github.com/google/syzkaller/blob/master/dashboard/config/upstream-kasan.config
> Also
On Sat, Jul 07, 2018 at 10:19:40PM -0400, Jacob Feder wrote:
> +static ssize_t sysfs_write(struct device *dev, const char *buf,
> +size_t count, unsigned int addr_offset)
> +{
> + struct axis_fifo_local *device_wrapper = dev_get_drvdata(dev);
What does the "local" mean
On 2018/07/09 23:02, Martijn Coenen wrote:
> On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov wrote:
>> I know almost nothing about binder. How these debug messages are
>> enabled? I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the
>> config:
>> https://github.com/google/syzkaller/blob/mas
On 7/9/2018 6:37 AM, Laurentiu Tudor wrote:
> Hi Roy,
>
> Couple of comments inline.
>
> On 05.07.2018 22:41, Roy Pledge wrote:
>> Move the NXP DPIO (Datapath I/O Driver) out of the
>> drivers/staging directory and into the drivers/soc/fsl directory.
>>
>> The DPIO driver enables access to Queue an
Remove driver from staging. It has been accepted in
the linux-gpio tree.
Signed-off-by: Sergio Paracuellos
---
Refer to commits in linux-gpio:
-
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/commit/?h=devel&id=af2b04d19242686a2c30e526c9b7a9e9c57bbce9
-
https://git.ker
On Mon, Jul 9, 2018 at 3:30 PM, Dan Carpenter wrote:
> On Mon, Jul 09, 2018 at 03:28:50PM +0200, Sergio Paracuellos wrote:
>> On Mon, Jul 09, 2018 at 01:45:22PM +0200, Linus Walleij wrote:
>> > On Thu, Jul 5, 2018 at 3:43 PM Sergio Paracuellos
>> > wrote:
>> >
>> > > Add driver support for gpio o
From: Haiyang Zhang
If out ring is full temporarily and receive completion cannot go out,
we may still need to reschedule napi if other conditions are met.
Otherwise the napi poll might be stopped forever, and cause network
disconnect.
Fixes: 7426b1a51803 ("netvsc: optimize receive completions")
Commit 2b7c86eb7bf3 ("staging: fsl-dpaa2/eth: Don't enable FAS on Tx")
removed the status field from the TX confirm frame annotation,
but a reference to it remained in the description of free_tx_fd().
Remove it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c |
We don't need to call dev_set_drvdata(dev, NULL) on driver
remove since core kernel code also performs this step.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b
Don't set the lower MTU limit explicitly, since we use
the default value anyway.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers/stagi
One bug fix, one small functional change and a couple of
cleanup patches.
Ioana Radulescu (5):
staging: fsl-dpaa2/eth: Fix DMA mapping direction
staging: fsl-dpaa2/eth: Remove obsolete reference
staging: fsl-dpaa2/eth: Remove pointless instruction
staging: fsl-dpaa2/eth: MTU cleanup
stag
We are using DMA_FROM_DEVICE when mapping RX frame buffers,
but DMA_BIDIRECTIONAL for unmap. Fix the direction for DMA
unmapping operation.
Fixes: 87eb55e418b7 ("staging: fsl-dpaa2/eth: Fix potential endless loop")
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.
Most Ethernet drivers don't enforce the MTU value as upper limit
for ingress frames. We too support receiving frames larger than
MTU, so allow that.
Remove our ndo_change_mtu implementation, letting the default
stack implementation handle things. Also, set the max frame length
allowed by hardware
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI
enlightenment") made it possible to observe VP_INVAL returned from
hv_cpu_number_to_vp_number() and cpumask_to_vpset() and PV TLB flush
code needs to be adjusted.
The window when VP_INVAL is observable is very short, I'm not e
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI
enlightenment") made cpumask_to_vpset() return '-1' when there is a CPU
with unknown VP index in the supplied set. This needs to be checked before
we pass 'nr_bank' to hypercall.
Fixes: 1268ed0c474a ("x86/hyper-v: Fix the circul
Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI
enlightenment") pre-filled hv_vp_index with VP_INVAL so it is now
(theoretically) possible to observe hv_cpu_number_to_vp_number()
returning VP_INVAL. We need to check for that in hyperv_flush_tlb_others().
Not checking for VP_
On Mon, 9 Jul 2018 16:43:19 +
Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> If out ring is full temporarily and receive completion cannot go out,
> we may still need to reschedule napi if other conditions are met.
> Otherwise the napi poll might be stopped forever, and cause network
> dis
> -Original Message-
> From: Stephen Hemminger
> Sent: Monday, July 9, 2018 2:15 PM
> To: Haiyang Zhang
> Cc: Haiyang Zhang ; da...@davemloft.net;
> net...@vger.kernel.org; o...@aepfle.de; Stephen Hemminger
> ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; vkuzn...@redh
On Mon, Jul 09, 2018 at 10:01:11AM -0500, Ioana Radulescu wrote:
> @@ -2385,6 +2365,12 @@ static int netdev_init(struct net_device *net_dev)
>
> /* Set MTU upper limit; lower limit is 68B (default value) */
> net_dev->max_mtu = DPAA2_ETH_MAX_MTU;
> + err = dpni_set_max_frame_lengt
PCI controller dependant register was handled with different
custom macros including very ugly pointer aritmethics. Simplify
them adding an array of offset per controller and a macro to get
the relative offset for each register for the controller. To avoid
arithmetics add two simple mt7621_pci_reg_
This patch series clean up a bit mt7621-pci driver.
Chnages in v3:
- PATCH 1 has been splited in several patches for better review
- PATCH "avoid pointer arithmetics in some macros" gets back
a needed switch statement as it has been pointed out here:
http://driverdev.linuxdriv
Re-implement pci_config_write and pci_config_read makes some
functions and definitions to be dead code. Remove all of them.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 93 -
1 file changed, 93 deletions(-)
diff --git a/drivers/
RALINK_PCI_MEMBASE, RALINK_PCI_IOBASE, RALINK_PCI_PCICFG_ADDR and
RALINK_PCI_PCIMSK_ADDR are using very ugly pointer arithmetics to
read and write along the code. Instead of doing this, use the
mt7621_pci_reg_read and mt7621_pci_reg_write functions making
this a bit cleaner.
Signed-off-by: Sergio
This macro is not being used at all along the code.
Just remove it.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621.c
index c12447d
This macros are not being used anymore along the code.
Just remove all of them.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/p
To get config address the same pattern is repeated in some functions
along the code. Factor out a new mt7621_pci_get_cfgaddr for calculate
it and use it in convenient places. Adjust types to match to u32 where
is neccesary.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7
The logic for this functions is kind of mess calling to other
functions which ends up in using very ugly macros. Reimplement
this two using kernel write[b,w,l] and read[b,w,l] and the variable
'mt7621_pci_base'. Function prototypes have changed style to avoid
long lines.
Signed-off-by: Sergio Para
Add new 'mt7621_pci_base' variable as a pointer to definition
RALINK_PCI_BASE to use it along the code.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/
There was a missing line between declarations and code statements in function
setup_cm_memory_region. this improves readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621
There are a lot of definitions that are not being used at all.
Just remove them cleaning the code a bit.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/mt7621-
set_pcie_phy can be refactor to use mt7621_pci_reg_write and
mt7621_pci_reg_read functions intead of use pointer arithmetics.
Use them and simplify implicated calls and definitions along the
code.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 122 +++
Factor out mt7621_pci_configure function to avoid a lot of
duplicated code in driver probe function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 35 -
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/stagi
This two prototypes are very long. Indent them in a proper way.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621
Factor out mt7621_pci_enable function to avoid duplicate code
in driver probe function. This increase readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 36 ++---
1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a
Driver probe function is a mess and need a very big refactor.
Factor out mt7621_pci_enable_irqs and mt7621_pci_disable to
handle interrupts if pci status is as expected. To get the correct
bits for each controller define a new 'pcie_controller_data'
including clk_en, rst, irq and offset fields. Con
ASSERT_SYSRST_PCIE and DEASSERT_SYSRST_PCIE are defined as preprocessor
macros and can be defined as inline functions instead which are preferred.
Do it and rename to mt7621_pcie_assert_sysrst and mt7621_pcie_deassert_sysrst
respectively.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7
There are some comments not needed at all. Remove them.
Adjust one comment to follow kernel style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
There are some definitions which are using its custom
implementation of BIT macro. Just just BIT macro instead.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/driv
Use a for loop to check pci port N_FTS in each controller.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt76
This two functions are called with bus and func being always 0.
Remove non sensense 'bus' and 'func' parameters and pass '0' to
other calls inside the function. Review return and parameter types
also to be more proper with the rest of the code. Adapt properly
calls to those function to match the ne
RALINK_PCI_CONFIG_DATA_VIRTUAL_REG is a very long name and makes
lines to be very long when it is used. Rename it to a shorter one
RALINK_PCI_CONFIG_DATA.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-
Functions 'read_config' and 'write_config' are using some custom
macros to write and read registers. Use kernel architecture functions
readl and writel instead.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 10 --
1 file changed, 4 insertions(+), 6 delet
In driver probe function there are some ugly initialization to
use gpios. Factor out to mt7621_pci_init_gpios function making
use of readl and writel to read and write memory.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 35 +++--
1
On Mon, 9 Jul 2018 16:43:19 +
Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> If out ring is full temporarily and receive completion cannot go out,
> we may still need to reschedule napi if other conditions are met.
> Otherwise the napi poll might be stopped forever, and cause network
> dis
Rename the imx-media root async notifier from "subdev_notifier" to
simply "notifier", so as not to confuse it with true subdev notifiers.
No functional changes.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-dev.c | 14 +++---
drivers/staging/media/imx/imx-media.
The move to subdev notifiers fixes one assumption of OF graph parsing.
If a subdevice has non-video related ports, the subdev driver knows not
to follow those ports when adding remote devices to its subdev notifier.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/TODO | 29 +++-
Switch to v4l2_async_notifier_add_*_subdev() when adding async subdevs
to the imx-media root notifier. This removes the need to check for
an already added asd, since v4l2_async_notifier_add_*_subdev() does this
check. Also no need to allocate a subdevs array when registering the
root notifier, or k
Parse neighbor remote devices on the MIPI CSI-2 input port, add
them to a subdev notifier, and register the subdev notifier for the
MIPI CSI-2 receiver, by calling v4l2_async_register_fwnode_subdev().
csi2_parse_endpoints() is modified to be the parse_endpoint callback.
Signed-off-by: Steve Longe
The root imx-media notifier no longer sees all bound subdevices because
some of them will be bound to subdev notifiers. So imx_media_create_links()
now needs to loop through all subdevices registered with the v4l2-device,
not just the ones in the root notifier's done list. This should be safe
becau
Parse neighbor remote devices on the CSI port, and add them to a subdev
notifier, by calling v4l2_async_notifier_parse_fwnode_endpoints_by_port()
using the CSI's port id. And register the subdev notifier for the CSI.
Signed-off-by: Steve Longerbeam
---
Changes since v5:
- add call to v4l2_async_n
After moving to subdev notifiers, it's no longer necessary to recursively
walk the OF graph, because the subdev notifiers will discover and add
devices from the graph for us.
So the recursive of_parse_subdev() function is gone, replaced with
of_add_csi() which adds only the CSI port fwnodes to the
Hi,
On 07/08, Baoquan He wrote:
>Hi,
>
>On 07/05/18 at 01:00am, kbuild test robot wrote:
>> Hi Baoquan,
>>
>> I love your patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.18-rc3 next-20180704]
>> [if your patch is applied to the wrong
On 07/10/18 at 08:59am, Ye Xiaolong wrote:
> Hi,
>
> On 07/08, Baoquan He wrote:
> >Hi,
> >
> >On 07/05/18 at 01:00am, kbuild test robot wrote:
> >> Hi Baoquan,
> >>
> >> I love your patch! Yet something to improve:
> >>
> >> [auto build test ERROR on linus/master]
> >> [also build test ERROR on
95 matches
Mail list logo
