Re: Question about disabling of CONFIG_ANDROID_BINDER_IPC_32BIT in upcomng kernel 4.18

2018-06-17 Thread Mauro Rossi
+ de...@linuxdriverproject.org resending to Greg KH as instructed by his mail bot I a few words the question is: Has CONFIG_ANDROID_BINDER_IPC_32BIT been removed in 1190b4e38f97023154e6b3bef61b251aa5f970d0 ("ANDROID: binder: remove 32-bit binder interface") for a mandatory reason (incompatibilty

Re: [PATCH] staging: wilc1000: Fix type of argument in ieee80211_is_action()

2018-06-17 Thread Nishad Kamdar
On Tue, Jun 12, 2018 at 04:14:13PM +0300, Dan Carpenter wrote: > On Sun, Jun 10, 2018 at 12:40:17PM +0530, Nishad Kamdar wrote: > > Type used is unsigned char but expected is restricted __le16. > > Warning reported by sparse. Part of eudyptula challenge. > > > > The code is buggy, but this fix ju

[PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

2018-06-17 Thread Omer Efrat
The BIT macro uses unsigned long which some architectures handle as 32 bit and therefore might cause macro's shift to overflow when used on a value equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). Since 'filled' member in station_info changed to u64, BIT_ULL macro should be

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

2018-06-17 Thread Greg KH
On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: > The BIT macro uses unsigned long which some architectures handle as 32 bit > and therefore might cause macro's shift to overflow when used on a value > equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). > > Since 'f

[PATCH] Staging: lustre: Use kmemdup() instead of kzalloc and memcpy

2018-06-17 Thread Shreeya Patel
Replace calls to kzalloc or kmalloc followed by a memcpy with a direct call to kmemdup to shorten the code. The Coccinelle semantic patch used to make this change is as follows: @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,fla

Re: [PATCH] Staging: lustre: Use kmemdup() instead of kzalloc and memcpy

2018-06-17 Thread Greg KH
On Sun, Jun 17, 2018 at 04:46:55PM +0530, Shreeya Patel wrote: > Replace calls to kzalloc or kmalloc followed by a memcpy with > a direct call to kmemdup to shorten the code. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression from,to,size,flag; > statement

[PATCH v3 0/5] use BIT_ULL for NL80211_STA_INFO_* attribute types

2018-06-17 Thread Omer Efrat
The BIT macro uses unsigned long which some architectures handle as 32 bit and therefore might cause macro's shift to overflow when used on a value equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards). Since 'filled' member in station_info changed to u64, BIT_ULL macro should be

Re: [PATCH v3 0/5] use BIT_ULL for NL80211_STA_INFO_* attribute types

2018-06-17 Thread Johannes Berg
On Sun, 2018-06-17 at 13:05 +0300, Omer Efrat wrote: > > Note: The following patch series only does some code clean up. > The previous versions mentioned a bug fix but it appears as a mix up > with some local changes because NL80211_STA_INFO_TID_STATS value actually > equals 31. Interesting. Than

[PATCH 2/2] rtl8192u/rtl819x_BAProc.c: Adjust spaces to coding guidelines

2018-06-17 Thread Fabian Bläse
This patch improves spacing according to the coding guidelines, mainly around braces. This patch fixes errors reported by checkpatch. Signed-off-by: Fabian Bläse Signed-off-by: Maximilian Ott --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 71 ++ 1 file changed, 31

[PATCH 0/2] rtl8192u: Improve coding style

2018-06-17 Thread Fabian Bläse
This Patch series improves coding style in rtl8192u staging driver to fix checkpath errors. Fabian Bläse (2): rtl8192u/rtl819x_Qos.h: Adjust spaces to coding guidelines rtl8192u/rtl819x_BAProc.c: Adjust spaces to coding guidelines .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 71 +

[PATCH 1/2] rtl8192u/rtl819x_Qos.h: Adjust spaces to coding guidelines

2018-06-17 Thread Fabian Bläse
This patch improves spacing according to the coding guidelines, mainly around braces. This patch fixes errors reported by checkpatch. Signed-off-by: Fabian Bläse Signed-off-by: Maximilian Ott --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 94 1 file changed, 47

[PATCH] staging: pi433: fix race condition in pi433_open

2018-06-17 Thread Hugo Lefeuvre
Whenever pi433_open and pi433_remove execute concurrently, a race condition potentially resulting in use-after-free might happen. Let T1 and T2 be two kernel threads. 1. T1 executes pi433_open and stops before "device->users++". 2. The pi433 device was removed inbetween, so T2 executes pi433_remo

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-17 Thread Gregory Nowak
On Tue, Jun 12, 2018 at 08:31:06AM +0200, Samuel Thibault wrote: > The load/unload is about the module itself, i.e. modprobe speakup_bns ; > modprobe speakup_soft, switch between them, then rmmod speakup_bns ; > speakup_soft or the converse (to exercise both orders). # uname -a Linux p41box 4.17.1

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-17 Thread Samuel Thibault
Thanks for the tests! Samuel ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/3] Staging:rtl8192e Fix Comparison to true is error prone

2018-06-17 Thread Janani Sankara Babu
This patch removes the comaprison to bool value in the code Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAPro

[PATCH 1/3] Staging:rtl8192e Fix Comparison to False is error prone

2018-06-17 Thread Janani Sankara Babu
This patch removes comparison to False and boolean values in the code which can be written as !var Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819

[PATCH 3/3] Staging:rtl8192e Cleanup comparison to NULL

2018-06-17 Thread Janani Sankara Babu
This patch replaces the comparison of var to NULL with !var Signed-off-by: Janani Sankara Babu --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c