On Thu, 10 May 2018 08:35:29 +0300
Claudiu Beznea wrote:
> On 09.05.2018 22:17, Ajay Singh wrote:
> > On Wed, 9 May 2018 16:42:59 +0300
> > Claudiu Beznea wrote:
> >
> >> On 07.05.2018 11:43, Ajay Singh wrote:
> >>> Use kmemdup instead of kmalloc & memcpy in
> >>> add_network_to_shadow().
>
Hi Eric,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc4 next-20180510]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
From: Colin Ian King
Trivial fix to spelling mistake in ODM_RT_TRACE message text
Signed-off-by: Colin Ian King
---
drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_rainfo.c
b/drivers/staging/r
Hi Doug,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc4 next-20180510]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
Under upstream staging commit 5a2ca43fa54f561c252c2, the list handling
code in kiblnd_handle_early_rxs() got changed to list_for_each_safe().
That protects against the current thread from deleting the current entry
it is looking at. It does not protect against another thread from deleting
the next
Hi Doug,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc4 next-20180510]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
From: Mohammed Gamal
Date: Wed, 9 May 2018 10:17:34 +0200
> On older windows hosts the net_device instance is returned to
> the caller of rndis_filter_device_add() without having the presence
> bit set first. This would cause any subsequent calls to network device
> operations (e.g. MTU change,
This allows bcm2835-camera to automatically probe after VCHI has
loaded, rather than only successfully probing if the arbitrary probe
order chooses us after VCHI.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/TODO | 11 ---
.../bcm2835-camera/bcm2835-camera.c
From: Dave Stevenson
mmal-parameters.h didn't have the normal
...
protection to stop it being included multiple times. Add it.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/mmal-parameters.h | 5 +
1 file changed, 5 insertions(+
From: Dave Stevenson
The MMAL and V4L2 buffers had been disassociated, and linked on
demand. Seeing as both are finite and low in number, and we now have
the same number of each, link them for the duration. This removes the
complexity of maintaining lists as the struct mmal_buffer context
comes
From: Dave Stevenson
Fix a typo flagged by checkpatch, and another in the same line.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
drivers/staging/vc04_services/bcm2835-camera/mmal-msg-port.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc
Fixes a compiler warning about a set-but-not-used variable. I think
this was just leftover dead code from before set_framerate_params(),
since that also sets up some mmal_parameter_rational structs for fps.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c
The v4l2 uapi uses u8[] for strings, so cast those to char * to avoid
compiler warnings about unsigned vs signed with sprintf() and friends.
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c| 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
dif
From: Dave Stevenson
There is no requirement to serialise bulk transfers as that is all
done in VCHI, and if a second MMAL_MSG_TYPE_BUFFER_TO_HOST happened
before the VCHI_CALLBACK_BULK_RECEIVED, then the service_callback
thread is deadlocked.
Remove the bulk_mutex so that multiple receives can
From: Dave Stevenson
The error conditions don't warrant taking the kernel down, so remove
BUG_ON.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/
From: Dave Stevenson
The struct mmal_msg_context was being allocated for every message
being sent to the VPU, and freed when it came back. Whilst that is
required behaviour for some messages (mainly the synchronous ones), it
is wasteful for the video buffers that make up the majority of the
traf
From: Dave Stevenson
As requested by Mauro Carvalho Chehab in review.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 289 +-
1 file changed, 139 insertions(+), 150 deletions(-)
diff --git a/drivers/staging/vc04_ser
From: Dave Stevenson
For historical reasons, the number of buffers passed to the VPU over
MMAL did not match that passed from V4L2. That is a silly situation
as the driver has to duplicate serialisation and other functions that
have already been implemented in V4L2/videobuf2.
As we had more V4L
From: Dave Stevenson
As requested by Mauro Carvalho Chehab in review.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../bcm2835-camera/bcm2835-camera.c | 289 +-
1 file changed, 139 insertions(+), 150 deletions(-)
diff --git a/drivers/staging/vc04_ser
I'm going to try to get Dave Stevenson's new zero-copy v4l2 M2M codec
driver merged to staging (my primary motivation for getting vchi
merged in the first place!), and this series makes the camera driver
probe successfully (an important first step!) and brings in some of
his cleanup changes. Also
The arg is a u32 *, so switch over to that in our declarations.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b/dr
From: Dave Stevenson <6...@users.noreply.github.com>
Interleaved RGB and single plane YUV formats can be delivered by the
GPU without the secondary step of removing padding, as the
bytesperline field can be set appropriately.
Planar YUV needs the GPU to still remove padding, as there is no way
to
From: Dave Stevenson
struct vchiq_mmal_rect is only referenced from mmal-parameters.h, yet
was defined in mmal-vchiq.h.
Move it to avoid having to include multiple headers for no reason.
Signed-off-by: Dave Stevenson
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal-parame
We had the camera driver set up in a module_init function, but that
meant that the camera driver would fail to load if it was initialized
before VCHI. By attaching to this platform_device, it can get a
defined load order.
Signed-off-by: Eric Anholt
---
.../staging/vc04_services/interface/vchiq_
Add a static prefix to the declaration for libcfs_dev. This would fix
the following sparse warning:
drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol
'libcfs_dev' was not declared. Should it be static?
Signed-off-by: Justin Skists
---
drivers/staging/lustre/lnet/libcfs/module.
Eric Anholt writes:
> From: Dave Stevenson
>
> As requested by Mauro Carvalho Chehab in review.
>
> Signed-off-by: Dave Stevenson
> Signed-off-by: Eric Anholt
Ignore this one, the other 12/12 is just this with "identation" spelled
right.
signature.asc
Description: PGP signature
The overlay code is non-functional since it relies on firmware control
of the HVS.
Signed-off-by: Stefan Schake
---
Dave, does this match your understanding?
drivers/staging/vc04_services/bcm2835-camera/TODO | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging/vc04_servic
We just need some integer handles that can map back to our message
struct when we're handling a reply, which struct idr is perfect for.
Signed-off-by: Eric Anholt
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 135 --
1 file changed, 31 insertions(+), 104 deletions(-)
diff
Hi Eric,
> Eric Anholt hat am 11. Mai 2018 um 01:31 geschrieben:
>
>
> We just need some integer handles that can map back to our message
> struct when we're handling a reply, which struct idr is perfect for.
>
> Signed-off-by: Eric Anholt
> ---
> .../vc04_services/bcm2835-camera/mmal-vchiq.
Make the sysfs attributes in_proximity0_calibscale_available, and
in_intensity0_{calibscale,integration_time}_available be created
using info_mask_separate_available on the channel configuration.
The driver assumed that the ALS increment was 2.72 ms, and the upper
range was 696 ms. Some other supp
Hopefully this is the last of the changes that are required for a
staging graduation. Changes since v2:
- Correct values returned in in_intensity0_integration_time_available so
that it doesn't break expected ABI. The driver now uses the read_avail
for all three *_available sysfs attributes.
-
This patch removes unnecessary whitespace in preparation for moving this
driver out of staging.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2x7x.c | 22 +++---
drivers/staging/iio/light/tsl2x7x.h | 1 -
2 files changed, 11 insertions(+), 12 deletions(-)
diff --
The CALIBBIAS and INT_TIME masks in tsl2x7x_write_raw did not have any
range checking in place so this patch adds the appropriate range
checking. The defines TSL2X7X_ALS_GAIN_TRIM_{MIN,MAX} are also
introduced by this patch.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2x7x.c | 1
This patch turns the chip off if IIO device registration fails so that
the error handling mirrors the device remove to make review easier in
preparation for moving this driver out of staging.
This patch also adds a missing error check in the call to
tsl2x7x_chip_on() in tsl2x7x_probe().
Signed-of
This patch changes the functions tsl2x7x_read_event_value() and
tsl2x7x_read_raw() to use direct returns to simplify the code.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2x7x.c | 49 -
1 file changed, 16 insertions(+), 33 deletions(-)
diff -
The thresh periods assumed an integration time of 3ms. This patch adds
support for the correct integration time (2.72ms or 2.73ms). The code
had the ALS filter values as going up to 15, however the values actually
went up to 60 since the values scaled in increments of 5 once the
persistence value w
This patch creates a macro that populates the tsl2X7X_device_info
structure to reduce duplicated code in the driver.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2x7x.c | 61 ++---
1 file changed, 16 insertions(+), 45 deletions(-)
diff --git a/dri
This patch renames this driver from tsl2x7x to tsl2772 since it is
highly likely that additional devices will be added to this driver that
do not match that wildcard. The tsl2772 driver name was selected since
that is currently the device with the most features that are supported
by this driver.
T
Move the tsl2772 driver out of staging and into mainline.
Signed-off-by: Brian Masney
---
drivers/iio/light/Kconfig | 8
drivers/iio/light/Makefile | 1 +
drivers/{staging => }/iio/light/tsl2772.c | 2 +
On Thu, May 10, 2018 at 08:12:23PM -0400, Brian Masney wrote:
> Move the tsl2772 driver out of staging and into mainline.
Hey Jonathan,
Here is the .c and .h file to make your review easier. Thanks for all
your feedback on all of these changes to this driver plus the other 3
that I've already mov
Stefan Wahren writes:
> Hi Eric,
>
>> Eric Anholt hat am 11. Mai 2018 um 01:31 geschrieben:
>>
>>
>> We just need some integer handles that can map back to our message
>> struct when we're handling a reply, which struct idr is perfect for.
>>
>> Signed-off-by: Eric Anholt
>> ---
>> .../vc04
On Thu, May 10 2018, Justin Skists wrote:
> Add a static prefix to the declaration for libcfs_dev. This would fix
> the following sparse warning:
>
> drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol
> 'libcfs_dev' was not declared. Should it be static?
Thanks - that was my faul
On Wed, May 09 2018, Doug Oucharek wrote:
> Under upstream staging commit 5a2ca43fa54f561c252c2, the list handling
> code in kiblnd_handle_early_rxs() got changed to list_for_each_safe().
> That protects against the current thread from deleting the current entry
> it is looking at. It does not pro
On 7.5.2018 03:20, James Kelly wrote:
> Replace existing CCF clock providers with new clock provider that can
> be enhanced to meet our needs.
>
> AXI clock prepare/enable/disable/unprepare is now managed by regmap APIs.
>
> Unregistering of clk instances now handled by devm APIs.
>
> Drop warni
On 7.5.2018 03:20, James Kelly wrote:
> Publish clock divider/multiplier ratios and flags specific to our
> clock provider implementation as these are not available via the
> debugfs entries provided by the common clock framework.
>
> Signed-off-by: James Kelly
> ---
> .../clocking-wizard/clk-xl
On 7.5.2018 03:20, James Kelly wrote:
> Add support for the clk_round_rate API to our CCF clock provider.
>
> Signed-off-by: James Kelly
> ---
> .../clocking-wizard/clk-xlnx-clock-wizard.c| 107
> +
> 1 file changed, 107 insertions(+)
>
> diff --git a/drivers/stagin
On 7.5.2018 03:20, James Kelly wrote:
> Provide initial support for CCF clk_set_rate API on all clock components.
>
> Clock consumers that want to set the first divider or PLL clock will need
> to use clk_get_parent on one of the output clocks as there is no support
> for CLK_SET_RATE_PARENT yet.
On 7.5.2018 03:20, James Kelly wrote:
> Replace existing CCF clock providers with new clock provider that can
> be enhanced to meet our needs.
>
> AXI clock prepare/enable/disable/unprepare is now managed by regmap APIs.
>
> Unregistering of clk instances now handled by devm APIs.
>
> Drop warni
On 7.5.2018 03:20, James Kelly wrote:
> The CCF clock providers that are currently used by the driver are not
> capable of supporting the Clocking Wizard IP register interface for
> fractional ratios, nor are they able to enforce constraints require to
> ensure the PLL will always lock.
>
> None o
49 matches
Mail list logo
