Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Geert Uytterhoeven
Hi Mark, On Fri, Apr 20, 2018 at 6:48 PM, Mark Brown wrote: > On Fri, Apr 20, 2018 at 03:28:26PM +0200, Geert Uytterhoeven wrote: >> The first 6 patches can be applied independently by subsystem >> maintainers. >> The last two patches depend on the first 6 patches, and are thus marked >> RFC. > >

Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:31PM +0200, Geert Uytterhoeven wrote: > Emma Mobile is a Renesas ARM SoC. Since commit 9b5ba0df4ea4f940 ("ARM: > shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate > platform dependency than the legacy ARCH_SHMOBILE, hence use the > former. > > Thi

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:30PM +0200, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy > CONFIG_ARCH_SHMOBILE, hence use the former. > > Renesas SuperH SH-Mobile SoCs a

Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:32PM +0200, Geert Uytterhoeven wrote: > Change the menu title to refer to "Renesas SoCs" instead of "SuperH", as > both SuperH and ARM SoCs are supported. > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is ARCH_RENESAS a more appropriate

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > > is ARCH_RENESAS a more appropriate platform dependency than the legacy > >"ARCH_RENESAS is", n

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:29PM +0200, Geert Uytterhoeven wrote: > The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs > only. Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce > ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency > than the legacy A

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:28PM +0200, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy > CONFIG_ARCH_SHMOBILE, hence use the former. > > Renesas SuperH SH-Mobile SoCs a

Re: [PATCH v2] ANDROID: binder: prevent transactions into own process.

2018-04-23 Thread Martijn Coenen
On Wed, Mar 28, 2018 at 1:34 PM, Martijn Coenen wrote: > On Wed, Mar 28, 2018 at 1:28 PM, Greg KH wrote: >> What is different from "v2" you sent before this? No change information >> from v1? Greg, is this in your queue, or should I just send a v3 to clean this up? See below for my original rep

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Geert Uytterhoeven
Hi Laurent, On Sun, Apr 22, 2018 at 10:46 AM, Laurent Pinchart wrote: > On Saturday, 21 April 2018 11:07:11 EEST Laurent Pinchart wrote: >> On Friday, 20 April 2018 16:28:29 EEST Geert Uytterhoeven wrote: >> > The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs >> > only. Sin

Re: [PATCH v2] ANDROID: binder: prevent transactions into own process.

2018-04-23 Thread Greg KH
On Mon, Apr 23, 2018 at 10:07:43AM +0200, Martijn Coenen wrote: > On Wed, Mar 28, 2018 at 1:34 PM, Martijn Coenen wrote: > > On Wed, Mar 28, 2018 at 1:28 PM, Greg KH wrote: > >> What is different from "v2" you sent before this? No change information > >> from v1? > > Greg, is this in your queue

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-23 Thread Greg Kroah-Hartman
On Mon, Apr 02, 2018 at 04:26:50PM +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisiti

Re: KASAN: use-after-free Read in binder_release_work

2018-04-23 Thread Martijn Coenen
On Thu, Apr 19, 2018 at 11:35 PM, Eric Biggers wrote: > Martijn, this is going to be fixed by > https://patchwork.kernel.org/patch/10312345/ > ("ANDROID: binder: prevent transactions into own process"), right? > The syzbot bug ID in that patch is for a bug that is already closed, > so if it's not

Re: [PATCH] android: binder: Change return type to vm_fault_t

2018-04-23 Thread Greg KH
On Mon, Apr 16, 2018 at 08:41:21PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler > in struct vm_operations_struct. For now, this is > just documenting that the function returns a > VM_FAULT value rather than an errno. Once all > instances are converted, vm_faul

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940 ("AR

Re: KASAN: use-after-free Read in binder_release_work

2018-04-23 Thread Martijn Coenen
On Mon, Apr 23, 2018 at 11:28 AM, Dmitry Vyukov wrote: > https://syzkaller.appspot.com/bug?extid=09e05aba06723a94d43d > and that happened in binder. But then syzkaller found a reproducer for > it, but it turned out to be in rdma subsystem. It's generally not > possible to properly distinguish diff

Re: KASAN: use-after-free Read in binder_release_work

2018-04-23 Thread Dmitry Vyukov
On Mon, Apr 23, 2018 at 11:18 AM, Martijn Coenen wrote: > On Thu, Apr 19, 2018 at 11:35 PM, Eric Biggers wrote: >> Martijn, this is going to be fixed by >> https://patchwork.kernel.org/patch/10312345/ >> ("ANDROID: binder: prevent transactions into own process"), right? >> The syzbot bug ID in th

Re: [PATCH] android: binder: Change return type to vm_fault_t

2018-04-23 Thread Souptick Joarder
On Mon, Apr 23, 2018 at 2:48 PM, Greg KH wrote: > On Mon, Apr 16, 2018 at 08:41:21PM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler >> in struct vm_operations_struct. For now, this is >> just documenting that the function returns a >> VM_FAULT value rather than

Re: KASAN: use-after-free Read in binder_release_work

2018-04-23 Thread Martijn Coenen
On Mon, Apr 23, 2018 at 11:49 AM, Dmitry Vyukov wrote: > Since it's already in Greg's queue, it's not worth bothering. We can > fix up things here with these "#syz fix" tags in emails, which > associate fixes with bugs. I meant, when I sent the original patch a month or so ago, could syzbot have

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

2018-04-23 Thread Dan Carpenter
On Thu, Apr 19, 2018 at 07:07:59AM +0200, Sergio Paracuellos wrote: > This commit changes an if-else block used to just assign a > variable to use a ternary operator to do the same improving > readability. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/ks7010/ks_wlan_net.c | 5 +--

Re: [PATCH v2 10/75] staging: ks7010: Remove unused 'struct hostif_mib_get_confirm_t'.

2018-04-23 Thread Greg KH
On Fri, Mar 30, 2018 at 11:07:50PM -0700, Quytelda Kahja wrote: > 'struct hostif_mib_get_confirm_t' is not used in this driver. Remove > 'struct hostif_mib_get_confirm_t'. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks_hostif.h | 6 -- > 1 file changed, 6 deletions(-) >

Re: [PATCH v2 23/75] staging: ks7010: Remove unused 'struct rsn_t'.

2018-04-23 Thread Greg KH
On Fri, Mar 30, 2018 at 11:08:03PM -0700, Quytelda Kahja wrote: > 'struct rsn_t' is not used in this driver. Remove 'struct rsn_t'. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks_hostif.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_

your photos need work

2018-04-23 Thread Lance
I wanted to follow up from last week. We provide image editing like – photos cutting out and retouching. We assure you the top quality. We provide below image editing services : Clipping path Image cut out Image shadow creation Image masking Photo retouching Beauty retouching - (skin, face, body

Re: [PATCH v2 75/75] staging: ks7010: Replace memcpy() with ether_addr_copy().

2018-04-23 Thread Greg KH
On Fri, Mar 30, 2018 at 11:08:55PM -0700, Quytelda Kahja wrote: > ether_addr_copy() is the function for copying a hardware address, > so replace the manual memcpy() operation with ether_addr_copy(). > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file cha

Re: [PATCH v3 11/16] staging: ks7010: avoid casts in michael_mic_function calls

2018-04-23 Thread Greg KH
On Fri, Apr 06, 2018 at 02:37:46PM +0200, Sergio Paracuellos wrote: > This commit removes casts in calls to michael_mic_function. > Most of them are nosense because types match perfectly function > parameters. To avoid also int casting for len parameter just > pass unsigned len to function which ma

Re: [PATCH] staging: android: ion: remove duplicate buffer field initializes

2018-04-23 Thread Sumit Semwal
Hello Todd, Thanks for the patch. On 21 April 2018 at 08:26, Todd Poynor wrote: > As a result of various previous patches, ion_buffer_create() now > has two sets of identical statements for initializing two fields of > the buffer struct, next to each other. Remove one set. > > Move the initiali

Re: [PATCH 01/10] staging: ks7010: use linux circular buffer header macros to handle tx and rx queues

2018-04-23 Thread Greg KH
On Mon, Apr 16, 2018 at 12:29:23PM +0200, Sergio Paracuellos wrote: > This commit replace current custom implementation of some circular > buffer head and tail logic in favour of the use of macros defined > in linux circ_buf.h header. Queue related inline function names > have been review also. >

Re: [PATCH 01/21] staging: ks7010: remove struct ieee802_1x_eapol_key

2018-04-23 Thread Greg KH
On Thu, Apr 19, 2018 at 07:07:55AM +0200, Sergio Paracuellos wrote: > This commit removes ieee802_1x_eapol_key struct because > it is not being used at all. It also removes definitions > related to some fields of the removed struct. > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/k

Re: [PATCH 21/21] staging: ks7010: init local variables when they are declared in ks7010_sdio_probe

2018-04-23 Thread Dan Carpenter
On Thu, Apr 19, 2018 at 07:08:15AM +0200, Sergio Paracuellos wrote: > This commit change init point of two variables to forward them to > init time. This variables are just being assigned some lines after > and it is more clear to init them when the init value is known and > in this case this is kn

Re: [PATCH 00/22] staging: lustre: llite: fix xattr handling

2018-04-23 Thread Greg Kroah-Hartman
On Mon, Apr 16, 2018 at 12:14:49AM -0400, James Simmons wrote: > From: James Simmons > > Lustre utilities and user land APIs heavly depend on special xattr > handling. Sadly much of the xattr handling for lustre client has > been broken for awhile. This is all the fixes needed to make xattr > han

Re: [PATCH 00/25] staging: lustre: libcfs: SMP rework

2018-04-23 Thread Greg Kroah-Hartman
On Mon, Apr 16, 2018 at 12:09:42AM -0400, James Simmons wrote: > Recently lustre support has been expanded to extreme machines with as > many as a 1000+ cores. On the other end lustre also has been ported > to platforms like ARM and KNL which have uniquie NUMA and core setup. > For example some dev

Re: [PATCH 01/10] staging: ks7010: use linux circular buffer header macros to handle tx and rx queues

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 2:30 PM, Greg KH wrote: > On Mon, Apr 16, 2018 at 12:29:23PM +0200, Sergio Paracuellos wrote: >> This commit replace current custom implementation of some circular >> buffer head and tail logic in favour of the use of macros defined >> in linux circ_buf.h header. Queue rela

Re: [PATCH 21/21] staging: ks7010: init local variables when they are declared in ks7010_sdio_probe

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 2:45 PM, Dan Carpenter wrote: > On Thu, Apr 19, 2018 at 07:08:15AM +0200, Sergio Paracuellos wrote: >> This commit change init point of two variables to forward them to >> init time. This variables are just being assigned some lines after >> and it is more clear to init the

Re: [PATCH 01/10] staging: ks7010: use linux circular buffer header macros to handle tx and rx queues

2018-04-23 Thread Greg KH
On Mon, Apr 23, 2018 at 03:02:20PM +0200, Sergio Paracuellos wrote: > On Mon, Apr 23, 2018 at 2:30 PM, Greg KH wrote: > > On Mon, Apr 16, 2018 at 12:29:23PM +0200, Sergio Paracuellos wrote: > >> This commit replace current custom implementation of some circular > >> buffer head and tail logic in f

Re: [PATCH 01/10] staging: ks7010: use linux circular buffer header macros to handle tx and rx queues

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 3:19 PM, Greg KH wrote: > On Mon, Apr 23, 2018 at 03:02:20PM +0200, Sergio Paracuellos wrote: >> On Mon, Apr 23, 2018 at 2:30 PM, Greg KH wrote: >> > On Mon, Apr 16, 2018 at 12:29:23PM +0200, Sergio Paracuellos wrote: >> >> This commit replace current custom implementation

Re: [PATCH 21/21] staging: ks7010: init local variables when they are declared in ks7010_sdio_probe

2018-04-23 Thread Dan Carpenter
On Mon, Apr 23, 2018 at 03:19:49PM +0200, Sergio Paracuellos wrote: > On Mon, Apr 23, 2018 at 2:45 PM, Dan Carpenter > wrote: > > On Thu, Apr 19, 2018 at 07:08:15AM +0200, Sergio Paracuellos wrote: > >> This commit change init point of two variables to forward them to > >> init time. This variabl

Re: [PATCH] staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings()

2018-04-23 Thread Greg KH
On Tue, Apr 03, 2018 at 10:30:50PM -0300, Jefferson Capovilla wrote: > Fix 'line over 80 characters' issue found by checkpatch.pl script in > mtk_set_link_ksettings(). > > Signed-off-by: Jefferson Capovilla > --- > drivers/staging/mt7621-eth/ethtool.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 2:09 PM, Dan Carpenter wrote: > On Thu, Apr 19, 2018 at 07:07:59AM +0200, Sergio Paracuellos wrote: >> This commit changes an if-else block used to just assign a >> variable to use a ternary operator to do the same improving >> readability. >> >> Signed-off-by: Sergio Parac

Re: KASAN: use-after-free Read in binder_release_work

2018-04-23 Thread Martijn Coenen
On Mon, Apr 23, 2018 at 12:17 PM, Dmitry Vyukov wrote: > syzbot does not extract this info from patch emails. Ok so IIUC, Reported-By tags will only be considered when they are actually part of commits in one of the tested trees - makes sense. So does sending "#syz fix: xyz" cause syzbot to look

Re: [PATCH 21/21] staging: ks7010: init local variables when they are declared in ks7010_sdio_probe

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 3:24 PM, Dan Carpenter wrote: > On Mon, Apr 23, 2018 at 03:19:49PM +0200, Sergio Paracuellos wrote: >> On Mon, Apr 23, 2018 at 2:45 PM, Dan Carpenter >> wrote: >> > On Thu, Apr 19, 2018 at 07:08:15AM +0200, Sergio Paracuellos wrote: >> >> This commit change init point of

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

2018-04-23 Thread Dan Carpenter
To be honest, it wasn't even the right thing for me to comment this patch. If you think it makes the code nicer then go ahead, you've earned that. The patchset is nice and makes a bunch of tricky improvements to the code. I reviewed it pretty carefully and couldn't find any new bugs. regards, d

Re: [PATCH v2 06/10] staging: mt7621-mmc: Fix dereference before check in msdc_drv_pm

2018-04-23 Thread Greg Kroah-Hartman
On Sat, Apr 07, 2018 at 10:16:21AM +0200, Christian Lütke-Stetzkamp wrote: > In the msdc_drv_pm function the variable mmc is dereferenced before > checked. Reordering fixes that. > > Reported-by: Dan Carpenter > Signed-off-by: Christian Lütke-Stetzkamp > Reviewed-by: NeilBrown > --- > drivers/

Re: [PATCH 00/31] staging: mt7621-mmc: Next cleanups

2018-04-23 Thread Greg Kroah-Hartman
On Wed, Apr 18, 2018 at 05:27:19PM +0200, Christian Lütke-Stetzkamp wrote: > Here are the next cleanups for the mt7621-mmc driver. Most of them > just remove some unused code, but there are also some other cleanups > and fixes. This also changes the default to always using DMA for data > transfer,

Re: [PATCH 2/2] staging: nvec: convert to use GPIO descriptors

2018-04-23 Thread Linus Walleij
On Thu, Apr 19, 2018 at 1:01 PM, Marc Dietrich wrote: > Use GPIO descriptors instead of relying on the old method. > > Cc: Linus Walleij > Signed-off-by: Marc Dietrich > --- > This obsolets the ToDo reminder sent by Linus a few hours ago. Awesome :) Reviewed-by: Linus Walleij Yours, Linus W

Re: [PATCH] staging: pi433: break long lines in pi433_if.c

2018-04-23 Thread Greg KH
On Fri, Apr 06, 2018 at 10:48:17PM +0200, Simon Sandström wrote: > Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: > "WARNING: line over 80 characters" > > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/pi433_if.c | 19 ++- > 1 file changed, 14 inser

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-04-23 Thread Greg KH
On Wed, Apr 04, 2018 at 10:45:25AM +0530, Ajay Singh wrote: > Hi Greg, > > On Wed, 28 Mar 2018 13:31:01 +0200 > Greg KH wrote: > > > On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > > > > > Please let me know, in case I have to rework and resubmit this > > > patch series to make

[PATCH 05/24] staging: ks7010: add REG suffix to sdio register definitions

2018-04-23 Thread Sergio Paracuellos
This commit adds REG suffix to register definitions related with SDIO in order to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 96 ++-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/sta

[PATCH 04/24] staging: ks7010: delete not used definitions in ks7010_sdio source

2018-04-23 Thread Sergio Paracuellos
This commit removes two definitions inside ks7010_sdio source file because they are not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks70

[PATCH 06/24] staging: ks7010: review comment style in ks7010_sdio source file

2018-04-23 Thread Sergio Paracuellos
This commit reviews comment style used in ks7010_sdio source file in order to be coherent with the rest of the code. Most comments in this source are before definitions but only two of them have been written at the right. So, be coherent moving this two to the top of definitions. Also fix one multi

[PATCH 00/24] staging: ks7010: remaining cleanups from previous series

2018-04-23 Thread Sergio Paracuellos
This patch series contains those patches which wasn't be applied from previous series. Just rebase and resend them to be applied. Sergio Paracuellos (24): staging: ks7010: avoid casts in michael_mic_function calls staging: ks7010: move ROM_FILE definition into source file staging: ks7010: m

[PATCH 22/24] staging: ks7010: review includes of ks_hostif file

2018-04-23 Thread Sergio Paracuellos
This commit reviews includes of ks_hostif.c source file. Those which are not being used at all have been removed. Driver header includes have been moved after the kernel header includes to make style consistent in different files of the driver. The need of ks_wlan.h header include is only because o

[PATCH 17/24] staging: ks7010: remove superfluous comments in ks_hostif source file

2018-04-23 Thread Sergio Paracuellos
This commit removes some comments which are not necessary at all because code is clear enough to understand its intention. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 39 +++--- 1 file changed, 7 insertions(+), 32 deletions(-) diff

[PATCH 21/24] staging: ks7010: removes data_buff field of ks_wlan_private struct

2018-04-23 Thread Sergio Paracuellos
This commit removes data_buff array field of ks_wlan_private which is not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index a4d0

[PATCH 13/24] staging: ks7010: use u8 instead of unsigned char for firmware buffers

2018-04-23 Thread Sergio Paracuellos
This commit replaces type unsigned char which is the one which is being used for firmware buffers with u8 type which is preferred. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/

[PATCH 11/24] staging: ks7010: check sdio_set_block_size return value

2018-04-23 Thread Sergio Paracuellos
This commit checks sdio_set_block_size function return value. If it fails abort driver initialization. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/

[PATCH 09/24] staging: ks7010: move MODULE_DEVICE_TABLE related code

2018-04-23 Thread Sergio Paracuellos
This commit moves MODULE_DEVICE_TABLE related code to the end of the file. This is not necessary at all but moving it just before its use improves readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 delet

[PATCH 03/24] staging: ks7010: move sdio specific register definitions into source file

2018-04-23 Thread Sergio Paracuellos
This commit moves SDIO related register definitions from header to source file. There is no need to have those into the header because they are only being used in specific SDIO code. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 72 +

[PATCH 15/24] staging: ks7010: change name and type for device_open_status field

2018-04-23 Thread Sergio Paracuellos
This commit changes type for device_open_status field of ks_wlan_private structure from int to bool. This variable is only be set to 1 on ks_wlan_net_start and set to 0 on ks_wlan_net_stop. For this purpose it is not necessary at all to use an integer because a bool is enough. This also renames fie

[PATCH 20/24] staging: ks7010: remove two fields of ks_wlan_private struct

2018-04-23 Thread Sergio Paracuellos
This commit removes l2_dev and l2_fd fields of ks_wlan_private struct because they are not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_w

[PATCH 01/24] staging: ks7010: avoid casts in michael_mic_function calls

2018-04-23 Thread Sergio Paracuellos
This commit removes casts in calls to michael_mic_function. Most of them are nosense because types match perfectly function parameters. To avoid also int casting for len parameter just pass unsigned len to function which makes sense because is only being called with unsigned int len parameters. Si

[PATCH 02/24] staging: ks7010: move ROM_FILE definition into source file

2018-04-23 Thread Sergio Paracuellos
This commit moves ROM_FILE from header to source file because there is not being used outside this. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 1 + drivers/staging/ks7010/ks7010_sdio.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH 19/24] staging: ks7010: avoid blank line between definitions in hostif_data_request

2018-04-23 Thread Sergio Paracuellos
This commit removes a blank line between definition in hostif_data_request function. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index cf79ba3.

[PATCH 08/24] staging: ks7010: avoid one extra level indentation in ks_wlan_hw_rx function

2018-04-23 Thread Sergio Paracuellos
This commit use an and operator in a if condition to avoid one indentation level which is not needed at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c

[PATCH 16/24] staging: ks7010: avoid one level indentation in devio_rec_ind function

2018-04-23 Thread Sergio Paracuellos
This commit changes logic to handle with the status of the device at first checking for close state to return directly instead of just do the stuff when device is open. This improves readability avoiding one level indentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hosti

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

2018-04-23 Thread Greg KH
On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > This patch series is based on top of > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > malloc memory properly" and its not applied yet.[1] I don't have that patch set in my queue. So please resend all outstanding pat

[PATCH 12/24] staging: ks7010: fix error paths in ks7010_sdio_remove function

2018-04-23 Thread Sergio Paracuellos
This commit reviews and fixes error paths in ks7010_sdio_remove driver function. It change logic to handle error directly after priv dereference to avoid one level indentation. It also removes a temporal netdev variable which wasn't being used in all of the function calls. Also if send_stop_request

[PATCH 07/24] staging: ks7010: review debug and error messages in ks7010_sdio source

2018-04-23 Thread Sergio Paracuellos
This commit reviews debug and error messages in code located in ks7010_sdio source file avoiding to use 'error' or 'ks7010' because this file is using netdev_* functions and has non sense to repeat information in log messages. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_s

[PATCH 10/24] staging: ks7010: replace create_workqueue with alloc_workqueue

2018-04-23 Thread Sergio Paracuellos
This commit replaces deprecated create_workqueue call with the alloc_workqueue one which is the one to be used now for this purpose. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks70

[PATCH 18/24] staging: ks7010: fix warning aout long line in init_request

2018-04-23 Thread Sergio Paracuellos
This commit fix length of the definition line of init_request function. Warning from checkpatch script for this is fixed. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hosti

[PATCH 14/24] staging: ks7010: assign dev_alloc_name() result to variable before check it

2018-04-23 Thread Sergio Paracuellos
This commit assigns dev_alloc_name() call to 'ret' variable to check it after instead of check directly the call in the if condition. This improves a bit readability. It also add an empty line before the new assignment to separate it from the previous check statement block. Signed-off-by: Sergio P

[PATCH 23/24] staging: ks7010: use IW_HANDLER macro in ks_wlan_handler

2018-04-23 Thread Sergio Paracuellos
This commit make use of IW_HANDLER to set wext operations of the device. Using this, comments are not neccessary anymore and also NULL entries so readability is clearly increased. In order to avoid casting because of the use of a different prototype in all related functions, those which are affecte

[PATCH 24/24] staging: ks7010: remove KSC_OPNOTSUPP related code

2018-04-23 Thread Sergio Paracuellos
This commit reviews KSC_OPNOTSUPP related code. The preprocessor KSC_OPNOTSUPP is defined by default so related wext functions are not being used. Just clean code removing all of this stuff. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan_net.c | 79 -

[PATCH v2 00/15] media: staging/imx7: add i.MX7 media driver

2018-04-23 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case. T

[PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent

2018-04-23 Thread Rui Miguel Silva
Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase -

[PATCH v2 02/15] media: staging/imx7: add imx7 CSI subdev driver

2018-04-23 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media-csi.c | 1345 +++

[PATCH v2 01/15] media: staging/imx: add support to media dev for no IPU systems

2018-04-23 Thread Rui Miguel Silva
Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev.c | 18 +- .

[PATCH v2 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-04-23 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1149 2 files changed, 1150 insertions(+) create mode

[PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

2018-04-23 Thread Rui Miguel Silva
Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate some runtime behaviors. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev

[PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root

2018-04-23 Thread Rui Miguel Silva
To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Cc: linux-...@vger.kernel.org Signed-off-by: Rui Miguel Silv

[PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

2018-04-23 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 158 ++ 1 file changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt diff --git a/Documentation/devic

[PATCH v2 09/15] ARM: dts: imx7s: add mipi phy power domain

2018-04-23 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 142ea709d296..d913c3f9c284 100644 --- a/arch/arm/b

[PATCH v2 12/15] ARM: dts: imx7s: add capture subsystem

2018-04-23 Thread Rui Miguel Silva
Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 6b49b73053f9..333d9fe6b989 100644 --- a/arch/arm/bo

[PATCH v2 07/15] ARM: dts: increase default cma size to 40MB

2018-04-23 Thread Rui Miguel Silva
To support camera in i.MX7 the cma heap is used to allocate frame buffers. The default size of CMA is 16MB which is not enough for higher resolutions (ex: 1600x1200). So, increase the default CMA size to 40MB. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 14 ++

Re: [PATCH 04/11] staging: vchiq_arm: Clear VLA warning

2018-04-23 Thread Greg Kroah-Hartman
On Wed, Apr 04, 2018 at 09:25:54PM +0200, Stefan Wahren wrote: > > > kbuild test robot hat am 1. April 2018 um 01:36 > > geschrieben: > > > > > > Hi Stefan, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on staging/staging-testing] > > [also build t

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

2018-04-23 Thread Sergio Paracuellos
On Mon, Apr 23, 2018 at 3:30 PM, Dan Carpenter wrote: > To be honest, it wasn't even the right thing for me to comment this > patch. If you think it makes the code nicer then go ahead, you've > earned that. The patchset is nice and makes a bunch of tricky > improvements to the code. I reviewed

[PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls

2018-04-23 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file changed, 8 insertions(+), 1

[PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-04-23 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva ---

[PATCH v2 13/15] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-04-23 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch

[PATCH v2 15/15] media: staging/imx: add i.MX7 entries to TODO file

2018-04-23 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 --- a/drivers/stagi

[PATCH v2 14/15] media: imx7.rst: add documentation for i.MX7 media driver

2018-04-23 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files c

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

2018-04-23 Thread Greg Kroah-Hartman
On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > > Here is how this comm

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

2018-04-23 Thread Ajay Singh
On Mon, 23 Apr 2018 15:45:38 +0200 Greg KH wrote: > On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > > This patch series is based on top of > > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > > malloc memory properly" and its not applied yet.[1] > > I don't have

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

2018-04-23 Thread Greg KH
On Mon, Apr 23, 2018 at 07:31:38PM +0530, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH wrote: > > > On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > > > This patch series is based on top of > > > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > >

Re: [PATCH] staging: wilc1000: fix NULL pointer exception in host_int_parse_assoc_resp_info()

2018-04-23 Thread Claudiu Beznea
Reviewed-by: Claudiu Beznea On 12.04.2018 10:21, Ajay Singh wrote: > Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for general info > message from firmware) introduced a bug by using wrong source address in > kmemdup(). 'conn_info.req_ies' is used for source address in kempdup() >

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

2018-04-23 Thread Claudiu Beznea
Hi Ajay, You can add: Reviewed-by: Claudiu Beznea On 23.04.2018 16:01, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH wrote: > >> On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: >>> This patch series is based on top of >>> "[PATCH 00/11] staging: wilc1000: fix for

[PATCH] Revert "staging: nvec: Augment TODO file with GPIO work item"

2018-04-23 Thread Marc Dietrich
This reverts commit 5a3e59ce3acf2f52c8b4a6fc656c3b1e4a329f06, because the necessary changes were applied in the "staging: nvec: convert to use GPIO descriptors" patch. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/stagi

Re: [PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-04-23 Thread Philipp Zabel
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related wi

Re: [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

2018-04-23 Thread Philipp Zabel
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > Add imx7 capture subsystem to imx-media core to allow the use some of the > existing modules for i.MX5/6 with i.MX7 SoC. > > Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate > some runtime behaviors. > > Sign

[PATCH v2] android: binder: Change return type to vm_fault_t

2018-04-23 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change r

[RESEND 00/33] staging: wilc1000: code cleanup and checkpatch fixes

2018-04-23 Thread Ajay Singh
This resend patch series contains patches from [1] & [2] clubbed together. [1] https://www.mail-archive.com/linux-wireless@vger.kernel.org/msg43998.html [2] https://www.mail-archive.com/linux-wireless@vger.kernel.org/msg45006.html Ajay Singh (33): staging: wilc1000: refactor scan() to free kmal

  1   2   >