On Tue, Apr 03, 2018 at 01:40:52PM +0300, Dan Carpenter wrote:
> > desc->rd_info = kzalloc(sizeof(*desc->rd_info), GFP_KERNEL);
> > -
> > + if (!desc->rd_info) {
> > + ret = -ENOMEM;
> > + goto error;
> > + }
> > if (!d
On Tue, Apr 03, 2018 at 01:59:08PM -0700, mhkelle...@gmail.com wrote:
> From: Michael Kelley
>
> Add standard interrupt handler annotations to
> hyperv_vector_handler().
>
> Signed-off-by: Michael Kelley
> ---
> Changes in v2:
> * Fixed From: line
> ---
> arch/x86/kernel/cpu/mshyperv.c | 2 +-
On Wed, Apr 04, 2018 at 04:24:10PM +0900, Ji-Hun Kim wrote:
> > Since we only partially allocated the
> > rd0 ring, device_free_rd0_ring() will crash when we do:
> >
> > dma_unmap_single(&priv->pcid->dev, rd_info->skb_dma,
> > priv->rx_buf_sz, DMA_FROM_DEVI
Looks good. Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The following changes since commit 3eb2ce825ea1ad89d20f7a3b5780df850e4be274:
Linux 4.16-rc7 (2018-03-25 12:44:30 -1000)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.17-rc1
for you to fetch changes up to 049b5e2ae30
Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence)
also gets cross posted to all the relevant gfx/memory lists. Doing the
same for ION means people won't miss relevant patches.
Cc: Laura Abbott
Cc: Sumit Semwal
Cc: de...@driverdev.osuosl.org
Cc: dri-de...@lists.freedesktop.or
On Mon, Mar 26, 2018 at 05:10:35PM -0400, Mauro Carvalho Chehab wrote:
> Use make coccicheck in patch mode to do some coding style
> improvements. Adjust the results manually.
>
> Signed-off-by: Mauro Carvalho Chehab
Hi Mauro,
For patches 2--18, please add:
Acked-by: Sakari Ailus
--
Sakari
[ To be honest, it looks like commit 5befa937e8da: "staging: rtl8723bs:
Fix IEEE80211 authentication algorithm constants." was just wrong and
should be reverted. The names look similar, yes but *all* three
values are different.
Quytelda, can you send a revert patch or fix it or something?
On 04/04/2018 03:30 AM, Daniel Vetter wrote:
Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence)
also gets cross posted to all the relevant gfx/memory lists. Doing the
same for ION means people won't miss relevant patches.
No problem from me, the rate of checkpatch fixups sh
On Wed, Apr 04, 2018 at 07:17:39AM -0700, Laura Abbott wrote:
> On 04/04/2018 03:30 AM, Daniel Vetter wrote:
> > Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence)
> > also gets cross posted to all the relevant gfx/memory lists. Doing the
> > same for ION means people won't miss
On Wed, Apr 4, 2018 at 4:30 PM, Greg Kroah-Hartman
wrote:
> On Wed, Apr 04, 2018 at 07:17:39AM -0700, Laura Abbott wrote:
>> On 04/04/2018 03:30 AM, Daniel Vetter wrote:
>> > Most of the other cross-driver gfx infrastructure (dma_buf, dma_fence)
>> > also gets cross posted to all the relevant gfx/
On Wed, Apr 04, 2018 at 05:17:08PM +0200, Daniel Vetter wrote:
> On Wed, Apr 4, 2018 at 4:30 PM, Greg Kroah-Hartman
> wrote:
> > On Wed, Apr 04, 2018 at 07:17:39AM -0700, Laura Abbott wrote:
> >> On 04/04/2018 03:30 AM, Daniel Vetter wrote:
> >> > Most of the other cross-driver gfx infrastructure
On Wed, Apr 4, 2018 at 12:04 PM, Dan Carpenter wrote:
> Looks good. Thanks!
>
> Reviewed-by: Dan Carpenter
Thanks for reviewing, Dan!
>
> regards,
> dan carpenter
>
Best regards,
Sergio Paracuellos
___
devel mailing list
de...@linuxdriverproject
> -Original Message-
> From: Greg KH
> Sent: Wednesday, April 4, 2018 1:16 AM
> To: Michael Kelley (EOSG)
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com;
> leann.ogasaw...@canonical.com; m
On Wed, Apr 04, 2018 at 03:47:03PM +, Michael Kelley (EOSG) wrote:
> > -Original Message-
> > From: Greg KH
> > Sent: Wednesday, April 4, 2018 1:16 AM
> > To: Michael Kelley (EOSG)
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > o...@aepfle.de;
> > a...@canoni
> kbuild test robot hat am 1. April 2018 um 01:36 geschrieben:
>
>
> Hi Stefan,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on staging/staging-testing]
> [also build test WARNING on v4.16-rc7 next-20180329]
> [if your patch is applied to the wrong git tre
Ulf Hansson writes:
> On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>> Hi,
>>
>> This serie is aimed at removing the dmaengine slave compat use, and transfer
>> knowledge of the DMA requestors into architecture code.
>> As this looks like a patch bomb, each maintainer expressing for his tree
On Wed, 04 Apr 2018 21:49:26 +0200
Robert Jarzmik wrote:
> Ulf Hansson writes:
>
> > On 2 April 2018 at 16:26, Robert Jarzmik wrote:
> >> Hi,
> >>
> >> This serie is aimed at removing the dmaengine slave compat use, and
> >> transfer
> >> knowledge of the DMA requestors into architecture co
Current code saves the need for polling in a global variable, that
leeds to problems, when the driver should handle multiple devices with
different capabilities. By looking up the capability in the mmc_host
capabilities, they now have per device scope.
Signed-off-by: Christian Lütke-Stetzkamp
---
Fix checkpatch error: GLOBAL_INITIALISERS
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index 60c704d6adc2..1e4c95b659da 1
Remove code, that is checking for old kernel versions, leaving only
the case for current versions.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/stagi
Remove a piece of code that is guarded by a config option, that is
nonexistent, the function it calls is also nonexistent.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/driv
Remove unused datastructures and comments referring to their former use.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
inde
This fixes the indentaions in the file dbg.c
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 258 +++
1 file changed, 129 insertions(+), 129 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mm
Remove the unnecessary field data_pins from msdc_hw, later this
information should be taken from the device tree.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/board.h | 1 -
drivers/staging/mt7621-mmc/sd.c| 10 --
2 files changed, 4 insertions(+), 7 deleti
The whitespace errors in the file mt6575_sd.h are fixed by using the
cleanfile script. Indentations with whitespaces are not changed
in this patch.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 49 +-
1 file changed, 24 inse
Fix checkpatch errors, warnings, checks about braces:
BRACES, ELSE_AFTER_BRACE, OPEN_BRACE
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 31 +++
drivers/staging/mt7621-mmc/mt6575_sd.h | 3 +-
drivers/staging/mt7621-mmc/sd.c| 154
This fixes the indentaions in the file mt7621_sd.h
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 820 -
1 file changed, 410 insertions(+), 410 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/mt6575_sd.h
b/drivers/stag
The whitespace errors in the file sd.c are fixed by using the
cleanfile script. Indentations with whitespaces are not changed
in this patch.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 1142 +++
1 file changed, 571 insertions
Remove code that is intended for soc other then the mt7621 because
this driver is only for that soc. This also removes some conditions.
However the remaining code is also at the wrong place, it just selects
the mode of the pins, this is a job for pinctl not for the sdxc driver.
Signed-off-by: Chri
Fixes checkpatch warning: NEW_TYPEDEFS
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 2 +-
drivers/staging/mt7621-mmc/dbg.h | 11 +-
drivers/staging/mt7621-mmc/mt6575_sd.h | 305 +++--
drivers/staging/mt7621-mmc/sd.c
Current code calls release_mem_regin on driver remove without
requesting it explicit first. The region is only requested via
devm_ioremap_resource and that releases it automatically. Removing the
release_mem_region calls fixes this.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt
Fixes checkpatch errors, warnings, checks:
SPACING, LEADING_SPACE, LINE_SPACING
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/board.h | 3 +-
drivers/staging/mt7621-mmc/dbg.c | 67 -
drivers/staging/mt7621-mmc/dbg.h | 16 +--
drivers/staging/
This fixes the indentaions in the file board.h
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/board.h | 68 +++---
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/board.h
b/drivers/staging/mt7621
Remove defines that are both in board.h and sd.c from sd.c, this file
already includes board.h
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
Refactor msdc_drv_{suspend, resume} by adding a new function
msdc_drv_pm, that cleans up the code and removes double code.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a
Remove the owner assignment form the platform driver as
platform_driver_register() already initializes the owner.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt76
The dma_alloc_coherent (and also dma_free_coherent) should get the
device, the dma memory is allocated for as the first parameter.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/
The probe function contains lots of code, that is never used, because
the fields it checks for in the msdc_hw structure are never
initialized. Removing them should be safe.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 20
1 file changed, 20
This patch series does the first cleanups in this driver. At some
points I already tried to get the code of this driver as near as
possible to the mk-sd driver in mainline.
Changes in v2:
* fix typos
* Clearify comment regarding request irq
Christian Lütke-Stetzkamp (34):
staging: mt7621-mmc: R
In case of dma_alloc_coherent failing the current code just called
BUG_ON. By adding error handling for that case this can be avoided.
This also fixes a memory leek in case of a fail later on in the probe
function.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 12
Fix checkpatch error: POINTER_LOCATION
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/board.h | 2 +-
drivers/staging/mt7621-mmc/dbg.c | 8 +++---
drivers/staging/mt7621-mmc/sd.c| 56 +++---
3 files changed, 33 insertions(+), 33 de
The whitespace errors in the file dbg.c are fixed by using the
cleanfile script. Indentations with whitespaces are not changed
in this patch.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 190 +++
1 file changed, 95 insertions
Replace seq_printf with seq_puts when the string is const.
Fix checkpatch warning: PREFER_SEQ_PUTS
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/d
If the base address is not successfully obtained in the probe
function, then the mmc_host struct is not freed. Adding an exit for
that case fixes the bug.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
di
In the probe function, pdev->dev.platform_data is set to &msdc0_hw,
but the only get access to that is also in the probe function. So that
assignment is removed. The msdc0_hw structure is still available to the
driver as part of the msdc_host structure.
Signed-off-by: Christian Lütke-Stetzkamp
--
The request of the irq line is not correctly handled by the current
code, platform_get_irq may fail and if the irq is requested via
devm_request_irq, its release is automatically done.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 34 ++---
The whitespace errors in the file board.h are fixed by using the
cleanfile script. Indentations with whitespaces are not changed
in this patch.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/board.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
This fixes the indentaions in the file dbg.h
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.h | 60
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/
Cleanup the mt_msdc_init function, remove excceding printk.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/sd.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index 1d689657e7b1..d7869b665255 10064
The whitespace errors in the file dbg.h are fixed by using the
cleanfile script. Indentations with whitespaces are not changed
in this patch.
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.h | 38 +++---
1 file changed, 19 insertions(+
Fix checkpatch error: TRAILING_STATEMENTS
Signed-off-by: Christian Lütke-Stetzkamp
---
drivers/staging/mt7621-mmc/dbg.c | 25 ++---
drivers/staging/mt7621-mmc/dbg.h | 3 ++-
drivers/staging/mt7621-mmc/sd.c | 39 ++-
3 files changed, 46 in
On Wed, Apr 04 2018, Christian Lütke-Stetzkamp wrote:
> This patch series does the first cleanups in this driver. At some
> points I already tried to get the code of this driver as near as
> possible to the mk-sd driver in mainline.
>
> Changes in v2:
> * fix typos
> * Clearify comment regarding r
On Thu, Apr 05, 2018 at 08:06:47AM +1000, NeilBrown wrote:
> On Wed, Apr 04 2018, Christian Lütke-Stetzkamp wrote:
>
> > This patch series does the first cleanups in this driver. At some
> > points I already tried to get the code of this driver as near as
> > possible to the mk-sd driver in mainli
On Thu, Apr 05 2018, Christian Lütke-Stetzkamp wrote:
> On Thu, Apr 05, 2018 at 08:06:47AM +1000, NeilBrown wrote:
>> On Wed, Apr 04 2018, Christian Lütke-Stetzkamp wrote:
>>
>> > This patch series does the first cleanups in this driver. At some
>> > points I already tried to get the code of this
On Mon, Apr 02 2018, Sergio Paracuellos wrote:
> This commit replaces some bare unsigned definitions in some
> function parameters in favour of 'unsigned int' which is
> preferred.
>
> This also fix checkpatch warnings about this.
>
> Signed-off-by: Sergio Paracuellos
Reviewed-by: NeilBrown
Th
On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
wrote:
> Hi all,
>
> If NO_DMA=y, get_dma_ops() returns a reference to the non-existing
> symbol bad_dma_ops, thus causing a link failure if it is ever used.
>
> The intention of this is twofold:
> 1. To catch users of the DMA API on sy
On Wed, Apr 4, 2018 at 3:32 AM, Greg KH wrote:
>
> It is a lot, over 500 changes, but not huge by previous kernel release
> standards. We deleted more lines than we added again (27k added vs. 91k
> remvoed), thanks to finally being able to delete the IRDA drivers and
> networking code.
Hmm. The
On 4 April 2018 at 21:56, Boris Brezillon wrote:
> On Wed, 04 Apr 2018 21:49:26 +0200
> Robert Jarzmik wrote:
>
>> Ulf Hansson writes:
>>
>> > On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>> >> Hi,
>> >>
>> >> This serie is aimed at removing the dmaengine slave compat use, and
>> >> transfe
On Thu, Apr 5, 2018 at 8:29 AM, Ulf Hansson wrote:
> On 4 April 2018 at 21:56, Boris Brezillon wrote:
>> On Wed, 04 Apr 2018 21:49:26 +0200
>> Robert Jarzmik wrote:
>>
>>> Ulf Hansson writes:
>>>
>>> > On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>>> >> Hi,
>>> >>
>>> >> This serie is aimed
60 matches
Mail list logo
