The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rsn_mode_t' with 'struct rsn_mode'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_power_mgmt_confirm_t' with 'struct
hostif_power_mgmt_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_cache_t' with 'struct pmk_cache'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_data_indication_t' with 'struct
hostif_data_indication'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_get_confirm_t' with 'struct
hostif_mib_get_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct channel_list_t' with 'struct channel_list'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 8
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_data_request_t' with 'struct
hostif_data_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hos
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ibss_parms_t' with 'struct ibss_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_start_request_t' with 'struct
hostif_start_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rate_set8_t' with 'struct rate_set8'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 6 +++---
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_set_request_t' with 'struct
hostif_mib_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct erp_params_t' with 'struct erp_params'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_value_t' with 'struct
hostif_mib_value'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_start_confirm_t' with 'struct
hostif_start_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ds_parms_t' with 'struct ds_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_suite_t' with 'struct wpa_suite'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 fi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct link_ap_info_t' with 'struct link_ap_info'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
This macro, provided in 'linux/kernel.h', will calculate the size
more succinctly than a division operation.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/d
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_set_confirm_t' with 'struct
hostif_mib_set_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ssid_t' with 'struct ssid'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 10 +-
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_get_request_t' with 'struct
hostif_mib_get_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_infrastructure_set_request_t' with
'struct hostif_infrastructure_set_request'.
Signed-off-by: Quytelda Kahja
---
d
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_ps_adhoc_set_request_t' with 'struct
hostif_ps_adhoc_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/stagi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct fh_parms_t' with 'struct fh_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_infrastructure_set_confirm_t' with
'struct hostif_infrastructure_set_confirm'.
Signed-off-by: Quytelda Kahja
---
d
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_power_mgmt_request_t' with 'struct
hostif_power_mgmt_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct cf_parms_t' with 'struct cf_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_connect_indication_t' with 'struct
hostif_connect_indication'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_stop_request_t' with 'struct
hostif_stop_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rsn_t' with 'struct rsn'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 2 +-
1 file changed, 1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_adhoc_set_request_t' with 'struct
hostif_adhoc_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_stop_confirm_t' with 'struct
hostif_stop_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hos
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_ps_adhoc_set_confirm_t' with 'struct
hostif_ps_adhoc_set_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/stagi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_request_t' with 'struct hostif_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct association_response_t' with 'struct
association_response'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct last_associate_t' with 'struct last_associate'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 2
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rate_set16_t' with 'struct rate_set16'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ap_info_t' with 'struct ap_info'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 8
driv
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_adhoc_set_confirm_t' with 'struct
hostif_adhoc_set_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_adhoc_set2_request_t' with 'struct
hostif_adhoc_set2_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct association_request_t' with 'struct
association_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hos
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_sleep_request_t' with 'struct
hostif_sleep_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_sleep_confirm_t' with 'struct
hostif_sleep_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_bss_scan_request_t' with 'struct
hostif_bss_scan_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks701
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_phy_information_request_t' with 'struct
hostif_phy_information_request'.
Signed-off-by: Quytelda Kahja
---
drivers
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mic_failure_request_t' with 'struct
hostif_mic_failure_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_phy_information_confirm_t' with 'struct
hostif_phy_information_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_associate_indication_t' with 'struct
hostif_associate_indication'.
Signed-off-by: Quytelda Kahja
---
drivers/stagi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_bss_scan_confirm_t' with 'struct
hostif_bss_scan_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks701
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_aplist_t' with 'struct local_aplist'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_eeprom_sum_t' with 'struct
local_eeprom_sum'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h |
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostt_t' with 'struct hostt'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file changed
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mic_failure_confirm_t' with 'struct
hostif_mic_failure_confirm'.
Signed-off-by: Quytelda Kahja
---
drivers/staging
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_key_t' with 'struct wpa_key'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/
The 'device_open_status' member of 'struct ks_wlan_private' is only
ever set to zero or one, so it makes more sense for it to be a bool
instead of an int.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 2 +-
drivers/staging/ks7010/ks_wlan_net.c | 5 ++---
2 files change
ether_addr_copy() is the function for copying a hardware address,
so replace the manual memcpy() operation with ether_addr_copy().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_ho
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rsn_ie_t' with 'struct rsn_ie'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 6 +++---
1 file cha
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_ap_t' with 'struct local_ap'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 10 +
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_list_t' with 'struct pmk_list'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file c
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct scan_ext_t' with 'struct scan_ext'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file c
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_gain_t' with 'struct local_gain'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct power_save_status_t' with 'struct
power_save_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct michael_mic_t' with 'struct michael_mic'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++-
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wps_status_t' with 'struct wps_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
The ethernet address of the network device is already stored in the
'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private'
keeps a pointer to the driver's 'struct net_device', there is no reason
to duplicate this information in 'struct ks_wlan_private'.
Signed-off-by: Quytelda Ka
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct mic_failure_t' with 'struct mic_failure'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
dr
Copying the dummy HW address into the struct net_device doesn't need
to be done byte by byte; use ether_addr_copy() instead.
Additionally, dev->dev_addr is not eight bytes long.
ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6)
in the net core code.
Signed-off-by: Quytelda Kahja
---
The casts used when initializing members of this data structure mirror
the types the variables already have. Remove the casts.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wps_ie_t' with 'struct wps_ie'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file chang
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct sleep_status_t' with 'struct sleep_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
The ethernet address of the network device is already stored in the
'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private'
keeps a pointer to the driver's 'struct net_device', there is no reason
to duplicate this information in 'struct ks_wlan_private'.
Signed-off-by: Quytelda Ka
Setting a dummy address during the driver probe is not necessary.
The dev_addr field is already zeroed out from alloc_etherdev().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
All of the net_device_ops callbacks are named after their counterparts
in the kernel's 'struct net_device_ops', except
ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for
greater consistency.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 +++---
1 f
All of the net_device_ops callbacks are named after their counterparts
in the kernel's 'struct net_device_ops', except
ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for
greater consistency.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 +++---
1 f
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_status_t' with 'struct wpa_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
Remove an extra blank line indicated by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
drivers/staging/ks7010/ks_hostif.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/k
ether_addr_equal() is the function for comparing HW addresses,
so remove the manual memcmp operation and replace it with
ether_addr_equals().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Remove an extra blank line indicated by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
drivers/staging/ks7010/ks_hostif.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_t' with 'struct pmk'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/
On Fri, 2018-03-30 at 00:07 -0700, Quytelda Kahja wrote:
> The "_t" suffix is not needed for structure names in this driver, and is a
> reflection of an older typedef system that is no longer in place. Replace
> all occurences of 'struct hostif_mib_set_confirm_t' with 'struct
> hostif_mib_set_confi
On Sun, 25 Mar 2018 13:36:40 -0700
John Syne wrote:
> > On Mar 25, 2018, at 9:29 AM, Jonathan Cameron wrote:
> >
> > On Sat, 24 Mar 2018 15:45:21 -0700
> > John Syne wrote:
> >
> >>> On Mar 24, 2018, at 8:02 AM, Jonathan Cameron wrote:
> >>>
> >>> On Mon, 19 Mar 2018 22:57:16 -0700
> >>>
On Sun, 25 Mar 2018 13:53:02 -0700
John Syne wrote:
> > On Mar 25, 2018, at 9:54 AM, Jonathan Cameron wrote:
> >
> > On Sun, 25 Mar 2018 01:29:41 -0700
> > John Syne wrote:
> >
> >> Hi Jonathan,
> > Hi John,
> >
> > Please wrap your normal emails (excepting tables) to 80 chars.
> Yeah,
On Fri, Mar 30, 2018 at 12:07:35AM -0700, Quytelda Kahja wrote:
> The "_t" suffix is not needed for structure names in this driver, and is a
> reflection of an older typedef system that is no longer in place. Replace
> all occurences of 'struct hostif_mib_set_confirm_t' with 'struct
> hostif_mib_se
Local variable irq is not used. Remove it.
Signed-off-by: Nguyen Phan Quang Minh
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index c723a04bc3d6..a698498b8537 100
On Thu, 29 Mar 2018 14:42:02 +0530
Shreeya Patel wrote:
> Have indentation in field definitions to make them
> clearly different from the register addresses.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
On Thu, 29 Mar 2018 14:43:23 +0530
Shreeya Patel wrote:
> Prefer reverse christmas tree ordering of declarations to
> improve readability.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
On Thu, 29 Mar 2018 14:44:42 +0530
Shreeya Patel wrote:
> Add a blank line after return statements to improve the code
> readability.
>
> Signed-off-by: Shreeya Patel
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> --
On Thu, 29 Mar 2018 14:49:22 +0530
Shreeya Patel wrote:
> Remove few unused header files since the adis core handles
> the sysfs and buffer support.
>
> Signed-off-by: Shreeya Patel
Applied,
Thanks,
Jonathan
> ---
>
> Changes in v6
> -Introduce this new patch in the series.
>
> drivers/
On Thu, 29 Mar 2018 14:51:19 +0530
Shreeya Patel wrote:
> Use GENMASK to improve readability and remove the local
> variables used to store intermediate data.
>
> Signed-off-by: Shreeya Patel
See below.
Fixed up and applied to the togreg branch of iio.git and pushed out
as testing for the auto
On Thu, 29 Mar 2018 14:52:51 +0530
Shreeya Patel wrote:
> Move the adis16209 driver out of staging directory and merge to the
> mainline IIO subsystem.
>
> Signed-off-by: Shreeya Patel
Other than fixing up for the patch 5 indentation change there
was some 'fuzz' due to the adis16201 moving befo
This commit fixs the label to jump to when in case
an error occurs disabling interrupts. At this point
of the code sdio_enable_func() function has been
successfully called.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
1 file changed, 2 insertions(+), 1 dele
This commit extracts sdio irq enable process to a new function
ks7010_sdio_init_irqs to improve readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 43 ++--
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/drive
This patch series factors out some functions to improve
a bit readability in ks7010_sdio source file.
Sergio Paracuellos (8):
staging: ks7010: remove unnecessary 'out of memory' message
staging: ks7010: factor out irq enable process to
ks7010_sdio_init_irqs
staging: ks7010: fix label to
This commit extract initial enqueue process into a new
ks7010_sme_enqueue_events function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ks7010/ks7
This commit extract sdio irq setup process into a new
function ks7010_sdio_setup_irqs to improve readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/
This commit extract ks_wlan_private initialization process
into a new function ks7010_private_init to improve a bit
readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 50
1 file changed, 28 insertions(+), 22 deletions(-)
This commit removes unnecessay out of memory message
fixing the following checkpach.pl warning:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/
This commit extracts process to check if firmware is running
into a new inline function called ks7010_is_firmware_running.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drive
This commit extracts firmware copy process into a new function
ks7010_copy_firmware. Because rom_buf is only needed for this
process, memory request for it has been also moved to this new
function so the error handling label release_host_and_free has
been renamed to release_host into ks7010_upload_
On 03/28/2018 09:06 AM, Li Jun wrote:
While set polarity, we should keep the not connecting cc line to be
open.
The more I look at this code, the more I am confused by it.
The original code doesn't touch the CC lines. This function only sets the
polarity.
Is it really appropriate to touch th
1 - 100 of 188 matches
Mail list logo
