On Mon, Mar 19, 2018 at 01:24:57PM +0900, Ji-Hun Kim wrote:
> > 1294 } else if (to && !from && size) {
> > 1295 rval = module_if->set(ipipe, NULL);
> > 1296 if (rval)
> > 1297
I don't really understand this patch...
On Fri, Mar 16, 2018 at 04:40:21PM -0700, Doug Oucharek wrote:
> We have found that MLX5 will trigger a dump_cqe if we don't
> invalidate the rkey on a newly alloated MR for FastReg usage.
>
> This fix just tags the MR as invalid on its creation if we are
>
On Sun, Mar 18, 2018 at 10:53:02PM +0800, Jia-Ju Bai wrote:
> hv_pci_onchannelcallback() is not called in atomic context.
>
> The call chain ending up at hv_pci_onchannelcallback() is:
> [1] hv_pci_onchannelcallback() <- hv_pci_probe()
> hv_pci_probe() is only set as ".probe" in hv_driver
> struc
Looks ok.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2018/3/19 16:38, Dan Carpenter wrote:
On Sun, Mar 18, 2018 at 10:53:02PM +0800, Jia-Ju Bai wrote:
hv_pci_onchannelcallback() is not called in atomic context.
The call chain ending up at hv_pci_onchannelcallback() is:
[1] hv_pci_onchannelcallback() <- hv_pci_probe()
hv_pci_probe() is only s
FYI, we noticed the following commit (built with gcc-6):
commit: 184ecc5ceb379b43b29fc373f497fca88c73ad38 ("staging: lustre: allow
monolithic builds")
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git staging-testing
in testcase: trinity
with following parameters:
runtime
Smatch tracks information about every function call. When a function
pointer is called it maybe looks something like this:
kernel/module.c | SYSC_delete_module | (struct module)->exit |
INTERNAL | -1 | | void(*)()
So then we just have to know what functions are assigned to
module->e
If the server is malicious then *bytes_read could be larger than the
size of the "target" buffer. It would lead to memory corruption when we
do the memcpy().
Reported-by: Dr Silvio Cesare of InfoSect
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/ncpfs/ncplib_kernel.c
b/drivers/sta
From: Colin Ian King
Trivial fix: rename function resizer_configure_in_continious_mode to
resizer_configure_in_continuous_mode to fix spelling mistake.
Signed-off-by: Colin Ian King
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Mon, Mar 19, 2018 at 02:07:45PM +0300, Dan Carpenter wrote:
> If the server is malicious then *bytes_read could be larger than the
> size of the "target" buffer. It would lead to memory corruption when we
> do the memcpy().
>
> Reported-by: Dr Silvio Cesare of InfoSect
> Signed-off-by: Dan C
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os
ERROR: do not initialise statics to NULL
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
b/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
index 9a885e626d1c..
WARNING: Missing a blank line after declarations
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index 117fda4fa1bf..b4
ERROR: spaces required around that '<' (ctx:VxV)
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/rtw_proc.c
b/drivers/staging/rtl8723bs/os_dep/rtw_pr
ERROR: that open brace { should be on the previous line
Signed-off-by: Paul McQuade
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os_dep/rec
On Mon, Mar 19, 2018 at 02:34:56PM +, Paul McQuade wrote:
> ERROR: do not initialise statics to NULL
You are going to have to do a bit more writing in the changelog than
just dumping in random output from checkpatch.pl. I know that's where
that line came from, but no one else will.
And your
On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
wrote:
Hi Geert,
This essentially removes this commit
commit 1c8cb409491403036919dd1c6b45013dc8835a44
Author: Sudip Mukherjee
Date: Wed Aug 3 13:45:46 2016 -0700
drivers/fpga/Kconfig: fix build failure
While building m32r allmodco
On Thu, Mar 15, 2018 at 02:53:46PM -0700, Doug Oucharek wrote:
> OPA driver optimizations are based on the MPI model where it is
> expected to have multiple endpoints between two given nodes. To
> enable this optimization for Lustre, we need to make it possible,
> via an LND-specific tuneable, to c
On Wed, Mar 14, 2018 at 11:18:30PM -0700, Doug Oucharek wrote:
> The FastReg support in ko2iblnd was not unmapping pool items
> causing the items to leak. In addition, the mapping code
> is not growing the pool like we do with FMR.
>
> This patch makes sure we are unmapping FastReg pool elements
Salut l'ami.
S'il vous plaît allumer contactez-moi, il y a un problème important
dont j'ai besoin pour
discuter avec vous concernant mon client décédé une nationalité de votre
pays qui a quitté le fonds immobilier non réclamé évalué USD 5,3
millions de dollars
avant sa mort. S'il vous plaît écrivez
On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com wrote:
> From: HariPrasath Elango
>
> In this case,there is only a single switch case statement.So replacing
> by a simple if condition.
>
> Signed-off-by: HariPrasath Elango
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgope
On Thu, Mar 15, 2018 at 08:09:20PM +0100, Sergio Paracuellos wrote:
> The following patch series includes some cleanups of useless traces as well
> as some replaces in order to use preferred macros for debugging and others.
>
> v2:
> * Review deleted DPRINTK traces
> * Minor checkpatch warning cle
On Thu, Mar 15, 2018 at 11:26:59PM -0700, Quytelda Kahja wrote:
> Some of the code for reading IEs is replicated multiple times in the
> switch statement for get_ap_information(). Factor that code out into
> read_ie().
>
> Signed-off-by: Quytelda Kahja
> ---
> drivers/staging/ks7010/ks_hostif.c
On Tue, Feb 27, 2018 at 10:59 PM, Yisheng Xie wrote:
> ashmem_mutex may create a chain of dependencies like:
>
> CPU0CPU1
> mmap syscall ioctl syscall
> -> mmap_sem (acquired) -> ashmem_ioctl
> -> ashmem_mmap
Hi Hans,
Thanks for taking the time to take a look at this.
> This should definitely use the V4L2 API. I guess it could be added
> to staging/media with a big fat TODO that this should be converted to
> the V4L2 mem2mem framework.
>
> But it makes no sense to re-invent the V4L2 streaming API :-)
On Sat, Mar 17 2018, Justin Skists wrote:
> Fix sparse warning:
>
> CHECK drivers/staging//lustre/lnet/lnet/acceptor.c
> drivers/staging//lustre/lnet/lnet/acceptor.c:243:30: warning: cast to
> restricted __le32
>
> LNET_PROTO_TCP_MAGIC, as a define, is already CPU byte-ordered when
> compared
Hi,
On 03/17, Jonathan Cameron wrote:
> On Tue, 13 Mar 2018 13:05:28 -0300
> Rodrigo Siqueira wrote:
>
> > The ad2s1210 does not contain any channel for the fclkin and fexcit. As
> > a result, it uses IIO_DEVICE_ATTR to expose this information. This patch
> > adds one channel for fclkin and anot
Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit :
> Hi Hans,
>
> Thanks for taking the time to take a look at this.
>
> > This should definitely use the V4L2 API. I guess it could be added
> > to staging/media with a big fat TODO that this should be converted
> > to
> > the V4L2 mem2m
On 03/18, Jonathan Cameron wrote:
> On Fri, 16 Mar 2018 19:48:33 -0300
> Rodrigo Siqueira wrote:
>
> > The original code does not correctly handle the error related to I2C
> > read and write. This patch fixes the error handling related to all
> > read/write functions for I2C. This patch is an ada
On Mon, Mar 19 2018, kernel test robot wrote:
> FYI, we noticed the following commit (built with gcc-6):
>
> commit: 184ecc5ceb379b43b29fc373f497fca88c73ad38 ("staging: lustre: allow
> monolithic builds")
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git
> staging-testing
>
> in
Dear Sir/Madam
I remain convinced that you will be surprised by this mail, but this
remains the utmost truth. I know that it is against my official duty to
release confidential issue like this to an outsider.There is nothing I can
do to help you beside this; I am taking this bold step because of
Hi Jonathan,
Thank you for all your hard work. Your feedback is really helpful. I’m
surprised that no one from Analog Device has offered any suggestions.
Anyway, please see my comments inline below
Regards,
John
> On Mar 18, 2018, at 5:23 AM, Jonathan Cameron wrote:
>
> On Sat, 17 Mar 20
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions(+)
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_h
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18..00b9
Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8e9b4f..2de4dbbcd
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions(+)
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
On Mon, Mar 19, 2018 at 07:45:46PM +0100, Greg KH wrote:
> On Wed, Mar 14, 2018 at 06:15:03PM +0530, hariprasath.ela...@gmail.com wrote:
> > From: HariPrasath Elango
> >
> > In this case,there is only a single switch case statement.So replacing
> > by a simple if condition.
> >
> > Signed-off-by
Hi Jonathan,
I broke out the {Direction}_{Type}_{Index}_{Modifier}_{Info_Mask} into separate
columns to make sure I understand your instructions. Good way to check the
results.
Probably easier to copy and paste this table into a spreadsheet. Let me know if
there is anything I got wrong. Thank
On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote:
> There is no reason for comment describing the BSSID check for loop
> to be spaced so far to the right. Move it above the for loop.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c
> b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -844,7
41 matches
Mail list logo
