Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Greg Kroah-Hartman
On Tue, Mar 13, 2018 at 09:00:54PM +0100, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer > --- > drivers/staging/media/imx/imx-media-csi.c | 5 + > 1 file changed, 5 insertions(+) I know I don't take patches with an empty changelog description, but other maintainers might be much more

Re: [PATCH 1/3] staging: ks7010: remove useless DPRINTK traces

2018-03-14 Thread Dan Carpenter
On Tue, Mar 13, 2018 at 05:55:20PM +0100, Sergio Paracuellos wrote: > @@ -786,14 +723,6 @@ void hostif_connect_indication(struct ks_wlan_private > *priv) > > switch (connect_code) { > case RESULT_CONNECT:/* connect */ > - DPRINTK(3, "connect :: scan_ind_count=%d\n", >

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-03-14 Thread Dan Carpenter
On Tue, Mar 13, 2018 at 08:06:50PM +0100, Mohammed Gamal wrote: > @@ -791,6 +791,7 @@ static inline int netvsc_send_pkt( > > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); > } > > + ring_avail = hv_ringbuf_avail_percent(&out_channel->outbound); >

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Dan Carpenter
We need a changelog. How does this affect user space? What bug does this fix? On Tue, Mar 13, 2018 at 09:00:54PM +0100, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer > --- > drivers/staging/media/imx/imx-media-csi.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-03-14 Thread Mohammed Gamal
On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote: > On Tue, 13 Mar 2018 20:06:50 +0100 > Mohammed Gamal wrote: > > > Dring high network traffic changes to network interface parameters > > such as number of channels or MTU can cause a kernel panic with a > > NULL > > pointer dereference.

Re: [PATCH 1/3] staging: ks7010: remove useless DPRINTK traces

2018-03-14 Thread Sergio Paracuellos
On Wed, Mar 14, 2018 at 9:13 AM, Dan Carpenter wrote: > On Tue, Mar 13, 2018 at 05:55:20PM +0100, Sergio Paracuellos wrote: >> @@ -786,14 +723,6 @@ void hostif_connect_indication(struct ks_wlan_private >> *priv) >> >> switch (connect_code) { >> case RESULT_CONNECT:/* connect */ >>

[PATCH] staging: pi433: Remove comments inside code

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango Remove comments inbetween code as in this case. Signed-off-by: HariPrasath Elango --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 88da91d.

[GIT PULL] Staging fixes for 4.16-rc6

2018-03-14 Thread Greg KH
The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.16-rc6 for you to fetch changes up to 740a5759bf2

Re: [PATCH] staging: wilc1000: use kmemdup to replace kmalloc/memcpy

2018-03-14 Thread Greg Kroah-Hartman
On Tue, Mar 13, 2018 at 06:19:32PM +0530, hariprasath.ela...@gmail.com wrote: > From: HariPrasath Elango > > kmalloc followed by memcpy can be replaced by kmemdup.Also added the > related error handling part > > Signed-off-by: HariPrasath Elango > --- > drivers/staging/wilc1000/host_interface.

Re: [PATCH] Fix partial warnings of checkpatch.pl for drivers/staging/greybus/i2c.c

2018-03-14 Thread Greg KH
On Tue, Mar 06, 2018 at 07:52:46PM +0100, Horatiu Vultur wrote: > Fix partial warnings of checkpatch.pl for drivers/staging/greybus/i2c.c What do you mean by "partial"? And why did you not cc: the people that scripts/get_maintainer.pl told you to? Please provide a better description here in the

Re: [PATCH] Update rf_type_definition

2018-03-14 Thread Greg KH
On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0g...@gmail.com wrote: > From: Kangmin Park Your subject line should say the subsystem and driver you are modifying. Look at the hundreds of other patches on the mailing lists for examples of how to properly format it. > > enum RT_RF_TYPE_DEFINITI

Re: [PATCH] staging: ks7010: remove unnecessary brackets in single statement block

2018-03-14 Thread Greg KH
On Sun, Mar 11, 2018 at 08:22:55AM +0100, Sergio Paracuellos wrote: > This patch fix the following sparse warning: > braces {} are not necessary for single statement blocks sparse gives you this warning? Are you sure it's not checkpatch that does this? Please fix up and resend. thanks, gre

Re: [PATCH v3 6/6] PCI: hv: fix 2 hang issues in hv_compose_msi_msg()

2018-03-14 Thread Lorenzo Pieralisi
On Tue, Mar 13, 2018 at 06:23:39PM +, Dexuan Cui wrote: [...] > Hi Lorenzo, Bjorn, and all, > Do you need more ACKs? Currently Michael and Haiyang reviewed and ack'd > the patchset. > > Should I send a v4 that just removes the "CC: sta...@vger.kernel.org" tag > for patches 1, 2, 4 and 5? I

Re: [PATCH] staging: lustre: o2iblnd: fix race at kiblnd_connect_peer

2018-03-14 Thread Greg Kroah-Hartman
On Fri, Mar 09, 2018 at 02:49:18AM -0500, Doug Oucharek wrote: > From: Alexander Boyko > > cmid will be destroyed at OFED if kiblnd_cm_callback return error. > if error happen before the end of kiblnd_connect_peer, it will touch > destroyed cmid and fail as > (o2iblnd_cb.c:1315:kiblnd_connect_pee

Re: [PATCH] staging: ccree: remove ccree staging copy

2018-03-14 Thread Greg Kroah-Hartman
On Mon, Mar 12, 2018 at 05:56:57AM -0700, Gilad Ben-Yossef wrote: > On Thu, Mar 8, 2018 at 9:14 AM, Greg Kroah-Hartman > wrote: > > On Thu, Mar 08, 2018 at 08:44:38AM +, Gilad Ben-Yossef wrote: > >> Now when the ccree driver has been accepted into the cryptodev tree > >> we can remove the stag

Re: [PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2018-03-14 Thread Greg KH
On Tue, Mar 13, 2018 at 08:51:51AM -0500, Razvan Stefanescu wrote: > Add the command build/parse APIs for operating on DPSW objects through > the DPAA2 Management Complex. > > Signed-off-by: Razvan Stefanescu > --- > Changelog: > v2: > - use u8 for en parameter of dpsw_if_set_flooding/broadc

Re: [PATCH] staging: wilc1000: use kmemdup to replace kmalloc/memcpy

2018-03-14 Thread
On Wed, Mar 14, 2018 at 12:38:18PM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 13, 2018 at 06:19:32PM +0530, hariprasath.ela...@gmail.com wrote: > > From: HariPrasath Elango > > > > kmalloc followed by memcpy can be replaced by kmemdup.Also added the > > related error handling part > > > > Si

[PATCH 0/7] Cleanup patches for wilc1000 driver

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango This patchset has few cleanup patches related to coding guidelines and few trivial changes HariPrasath Elango (7): staging: wilc1000: Fix code block alignment staging: wilc1000: Destroy mutex object in deinitialization staging: wilc1000: use kmemdup instead of kmal

[PATCH 3/7] staging: wilc1000: use kmemdup instead of kmalloc and memcpy

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango Kmalloc followed by memcpy can be replaced by kmemdup. Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/driv

[PATCH 2/7] staging: wilc1000: Destroy mutex object in deinitialization

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango Destroy the mutex object that is initialized in wlan_init_locks() Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/s

[PATCH 4/7] staging: wilc1000: destroy initialized mutex object

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango A mutex object that is initialized but not destroyed.This patch destroys the mutex object Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgop

[PATCH 6/7] staging: wilc1000: remove unwanted braces and correct code alignment

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango Remove the unwated brace and corrected the code block alignment accordingly Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/host_interface.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/w

[PATCH 1/7] staging: wilc1000: Fix code block alignment

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango Fix the code alignment for a block of code to adhere to coding guidelines Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc

[PATCH 5/7] staging: wilc1000: replace switch statement by simple if condition

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango In this case,there is only a single switch case statement.So replacing by a simple if condition. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/s

[PATCH 7/7] staging: wilc1000: use kmemdup to replace kmalloc/memcpy

2018-03-14 Thread hariprasath . elango
From: HariPrasath Elango kmalloc followed by memcpy can be replaced by kmemdup.Also added the related error handling part Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/host_interface.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/stagi

Re: [PATCH 6/7] staging: wilc1000: remove unwanted braces and correct code alignment

2018-03-14 Thread Ajay Singh
On Wed, 14 Mar 2018 18:15:04 +0530 wrote: > From: HariPrasath Elango > > Remove the unwated brace and corrected the code block alignment > accordingly Changes done in this patch are already taken care. Today, Greg has applied the patch which had these changes. This patch can be ignore from the

RE: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, March 13, 2018 5:26 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; Alexander Graf > ; a...@arndb.de; Alexan

RE: [PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2018-03-14 Thread Razvan Stefanescu
> > Can you resend this series and just use the correct SPDX identifiers for > all of the new files, instead of all of this horrid boiler-plate code? > > That will save me time when I have to go delete all of this in the near > future :) > > Also, why dual license it? Are you _SURE_ you want to

[PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so this driver is now obsolete. Signed-off-by: Arnd Bergmann --- drivers/staging/irda/drivers/Kconfig| 45 -- drivers/staging/irda/drivers/Makefile | 1 - drivers/staging/irda/drivers/bfin_sir.c | 819 driver

[PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set o

[PATCH v6 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2018-03-14 Thread Razvan Stefanescu
Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version v4: - no changes v5: - no changes v6: - use SPDX license identifier drivers/staging/

[PATCH v6 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2018-03-14 Thread Razvan Stefanescu
Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes v4: - adjust to moving MC-bus out of staging -

[PATCH v6 5/6] staging: fsl-dpaa2/ethsw: Add README

2018-03-14 Thread Razvan Stefanescu
Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes v6: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106 +++

[PATCH v6 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in ethsw_port_add_vlan() - rename err2 to ret in ethsw_port_add/del

[PATCH v6 6/6] staging: fsl-dpaa2/ethsw: Add TODO

2018-03-14 Thread Razvan Stefanescu
Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - remove fsl-mc bus driver dependency as it is out of staging v5: - no changes v6:

[PATCH v6 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

2018-03-14 Thread Razvan Stefanescu
Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes v6: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3c2b75..20d7bf2 100644 --- a/MAINTA

[PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so the timer trigger driver is now obsolete. Since this is the last remaining iio trigger driver in staging, I'm removing the entire directory. I'm not sure about the other staging iio drivers though: almost all of them are for Analog Devices devices l

Re: [PATCH v5 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 5:03 AM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: > https://sourceware.org/ml/libc-alpha/2015-05/

[PATCH 0/2] hv: license identfiers

2018-03-14 Thread Stephen Hemminger
A couple trivial patches to add SPDX license tag to some files related to Hyper-V VMBUS. Stephen Hemminger (2): hv: add SPDX license to trace hv: add SPDX license id to Kconfig drivers/hv/Kconfig| 2 ++ drivers/hv/hv_trace.c | 2 ++ drivers/hv/hv_trace.h | 2 ++ 3 files changed, 6 insert

[PATCH 1/2] hv: add SPDX license to trace

2018-03-14 Thread Stephen Hemminger
Missing license on Hyper-V VMBUS tracing files. Signed-off-by: Stephen Hemminger --- drivers/hv/hv_trace.c | 2 ++ drivers/hv/hv_trace.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/hv/hv_trace.c b/drivers/hv/hv_trace.c index df47acd01a81..38d359cf1e70 100644 --- a/drivers/hv/h

[PATCH 2/2] hv: add SPDX license id to Kconfig

2018-03-14 Thread Stephen Hemminger
Missing license on Kconfig file. Signed-off-by: Stephen Hemminger --- drivers/hv/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 50b89ea0e60f..97954f575c3f 100644 --- a/drivers/hv/Kconfig +++ b/drivers/hv/Kconfig @@ -1,3 +1,5 @@ +# SPDX

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Greg Kroah-Hartman
On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so this > driver is now obsolete. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/irda/drivers/Kconfig| 45 -- > drivers/staging/irda/drivers/Makefile | 1 - > drivers

Re: [PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Greg Kroah-Hartman
On Wed, Mar 14, 2018 at 04:36:00PM +0100, Arnd Bergmann wrote: > The blackfin architecture is getting removed, so the timer trigger > driver is now obsolete. Since this is the last remaining iio trigger > driver in staging, I'm removing the entire directory. > > I'm not sure about the other stagin

Re: [PATCH 46/47] staging: irda: remove bfin_sir driver

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 5:32 PM, Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:35:59PM +0100, Arnd Bergmann wrote: >> The blackfin architecture is getting removed, so this >> driver is now obsolete. >> >> Signed-off-by: Arnd Bergmann >> --- >> drivers/staging/irda/drivers/Kconfig|

[PATCH v3] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Peter Seiderer
Enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count = 141 - ts: 0:00:08.330177332 Signed-off-by: Peter Seiderer --- Changes in v2: - fill vb2_v4l2_buffer sequence entry in imx-i

Re: [PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Jonathan Cameron
On Wed, 14 Mar 2018 17:32:07 +0100 Greg Kroah-Hartman wrote: > On Wed, Mar 14, 2018 at 04:36:00PM +0100, Arnd Bergmann wrote: > > The blackfin architecture is getting removed, so the timer trigger > > driver is now obsolete. Since this is the last remaining iio trigger > > driver in staging, I'm

RE: [PATCH v3 6/6] PCI: hv: fix 2 hang issues in hv_compose_msi_msg()

2018-03-14 Thread Dexuan Cui
> From: Lorenzo Pieralisi > Sent: Wednesday, March 14, 2018 04:50 > On Tue, Mar 13, 2018 at 06:23:39PM +, Dexuan Cui wrote: > > [...] > > > Hi Lorenzo, Bjorn, and all, > > Do you need more ACKs? Currently Michael and Haiyang reviewed and ack'd > > the patchset. > > > > Should I send a v4 tha

Re: [PATCH v3] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Steve Longerbeam
Hi Peter, On 03/14/2018 09:51 AM, Peter Seiderer wrote: Enables gstreamer v4l2src lost frame detection, e.g: 0:00:08.685185668 348 0x54f520 WARN v4l2src gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count = 141 - ts: 0:00:08.330177332 Signed-off-by: Peter Seiderer --- Ch

[PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

2018-03-14 Thread Sridhar Pitchai
Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even with that when a first device is added to the bus, it overrides bus domain ID with the device serial number. Sometime this can result in BUS ID not being unique. In this case, when PCI_BUS and a device added to the bus, even be

[PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

2018-03-14 Thread Sridhar Pitchai
Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even with that when a first device is added to the bus, it overrides bus domain ID with the device serial number. Sometime this can result in BUS ID not being unique. In this case, when PCI_BUS and a device added t

[PATCH 0/7] staging:iio:ade7854: Cleanup on I2C/SPI code

2018-03-14 Thread Rodrigo Siqueira
This patchset reworks the I2C/SPI code from meter module. The set of patches try to reduce the code duplication and make the communication reliable. The current version of the module had many code duplications, which make the code more error-prone and hard to read. Jonh Syne identified some wrong e

[PATCH 1/7] staging:iio:ade7854: Rework I2C write function

2018-03-14 Thread Rodrigo Siqueira
The write operation using I2C has many code duplications and four different interfaces per data size. This patch introduces a single function that centralizes the main tasks. The central function inserted by this patch can easily replace all the four functions related to the data size. However, th

[PATCH 2/7] staging:iio:ade7854: Rework SPI write function

2018-03-14 Thread Rodrigo Siqueira
The write operation using SPI has a many code duplications (similar to I2C) and four different interfaces per data size. This patch introduces a single function that centralizes the main task related to SPI. Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7854-spi.c | 100 ++

[PATCH 3/7] staging:iio:ade7854: Replace many functions for one function

2018-03-14 Thread Rodrigo Siqueira
This patch removes code duplications related to the write_reg_* functions and centralizes them in a single function. Also, it eliminates the legacy functions and replaces them by a unique signature that is used by SPI and I2C. Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7854

[PATCH 4/7] staging:iio:ade7854: Rework I2C read function

2018-03-14 Thread Rodrigo Siqueira
The read operation for the I2C function has many duplications that can be generalized into a single function. This patch reworks the read operation for I2C to centralizes all similar code in a single function. Part of the rework includes a proper error handling and a fix on the i2c_master_recv for

[PATCH 5/7] staging:iio:ade7854: Rework SPI read function

2018-03-14 Thread Rodrigo Siqueira
Rework read SPI function to reduce the code duplication and centralizes all the task in a single function. Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7854-spi.c | 132 ++-- 1 file changed, 41 insertions(+), 91 deletions(-) diff --git a/drivers/s

[PATCH 6/7] staging:iio:ade7854: Remove read_reg_* duplications

2018-03-14 Thread Rodrigo Siqueira
The original code had a read function per data size; after updates, all read functions tasks were centralized in a single function, but the old signature was kept to maintain the module working without problems. This patch removes a set of duplications associated with read_reg_*, and update the are

[PATCH 7/7] staging:iio:ade7854: Add proper error handling condition

2018-03-14 Thread Rodrigo Siqueira
There is some improper error handling for IRQ and device register. This patch adds a proper verification. The IRQ correction was extracted from John Syne patches. Signed-off-by: Rodrigo Siqueira Signed-off-by: John Syne --- drivers/staging/iio/meter/ade7854.c | 4 ++-- 1 file changed, 2 insert

RE: [PATCH v2]PCI: hv: fix PCI-BUS domainID corruption

2018-03-14 Thread Michael Kelley (EOSG)
> -Original Message- > From: Sridhar Pitchai > Sent: Wednesday, March 14, 2018 11:08 AM > To: Lorenzo Pieralisi ; Michael Kelley (EOSG) > > Cc: Bjorn Helgaas ; Jake Oshins ; > Haiyang > Zhang ; Stephen Hemminger ; > Dexuan > Cui ; KY Srinivasan ; > de...@linuxdriverproject.org; linux-...

[PATCH] staging: fsl-dpaa2/eth: Fix incorrect kfree

2018-03-14 Thread Ioana Radulescu
Use netdev_alloc_frag() instead of kmalloc to allocate space for the S/G table of egress multi-buffer frames. This fixes a bug where an unaligned pointer received from the allocator would be overwritten with the 64B aligned value, leading to a wrong address being later passed to kfree. Signed-off

Re: [PATCH 47/47] staging: iio: remove iio-trig-bfin-timer driver

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 6:06 PM, Jonathan Cameron wrote: > On Wed, 14 Mar 2018 17:32:07 +0100 > Greg Kroah-Hartman wrote: >> On Wed, Mar 14, 2018 at 04:36:00PM +0100, Arnd Bergmann wrote: >> > I'm not sure about the other staging iio drivers though: almost >> > all of them are for Analog Devices

[PATCH 03/13] staging: mt7621-gpio: ralink: add mt7621 gpio controller

2018-03-14 Thread NeilBrown
From: John Crispin Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2 drivers/staging/Makefile |1 drivers/staging/mt7621-gpio/Kconfig |6 drivers/staging/mt7621-gpio/Makefile |3 drivers/stagin

[PATCH 07/13] staging: mt7621-eth: Document ralink/mediatek SoC ethernet binding

2018-03-14 Thread NeilBrown
From: John Crispin Add possible dt binding for mediatek gigabit switches. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee Cc: devicet...@vger.kernel.org Signed-off-by: NeilBrown --- .../devicetree/bindings/net/mediatek-net-gsw.txt | 48 +++

[PATCH 04/13] staging: mt7621-spi: add mt7621 support

2018-03-14 Thread NeilBrown
From: John Crispin NeilBrown: The code will fail with a warning if asked to transfer more than 32 bytes at a time. So used max_transfer_size interface to tell users about this. Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2

[PATCH 02/13] staging: mt7621-pinctrl: ralink: add pinctrl driver

2018-03-14 Thread NeilBrown
From: John Crispin Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2 drivers/staging/Makefile|1 drivers/staging/mt7621-pinctrl/Kconfig |4 drivers/staging/mt7621-pinctrl/Makefile

[PATCH 05/13] staging: mt7621-dma: ralink: add rt2880 dma engine

2018-03-14 Thread NeilBrown
From: John Crispin Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2 drivers/staging/Makefile |1 drivers/staging/mt7621-dma/Kconfig | 12 drivers/staging/mt7621-dma/Makefile |4 drivers/staging/mt

[PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-14 Thread NeilBrown
Hi Greg, I'd like to submit the following drivers to staging. They are all for components of the mt7621 MIPS-based SOC from Mediatek. I lifted them out of libreCMC and (for the ethernet code) out of email posts from about 2 years ago. I forward-ported them to mainline, fixed enough bugs that

[PATCH 01/13] staging: mt7621-pci: MIPS/ralink: add MT7621 pcie driver

2018-03-14 Thread NeilBrown
From: John Crispin NeilBrown: forward port and hack to work on GNUBEE1 Signed-off-by: John Crispin Signed-off-by: NeilBrown --- drivers/staging/Makefile|1 drivers/staging/mt7621-pci/Makefile |1 drivers/staging/mt7621-pci/TODO | 12 drivers/staging/mt

[PATCH 13/13] staging: mt7621-dts: add dts files

2018-03-14 Thread NeilBrown
Add device tree source for mt7621 and gnubee1 to make testing easier. Signed-off-by: NeilBrown --- drivers/staging/Kconfig|2 drivers/staging/Makefile |1 drivers/staging/mt7621-dts/Kconfig |5 drivers/staging/mt7621-dts/Makefile|3 drive

[PATCH 7/7] staging: pi433: fix CamelCase for dagc enum

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_enum.h | 4 ++-- 3 files chan

[PATCH 09/13] staging: mt7621-eth: add gigabit switch driver (GSW)

2018-03-14 Thread NeilBrown
From: John Crispin The GSW is found in all of the 1000mbit SoCs. it has 5 external ports, 1-2 cpu ports and 1 further port that the internal HW offloading engine connects to. The switch core used is a MT7530, which also exists as a standalone chip. Although these SoCs (mt7620/1/3) share the same

[PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c

[PATCH 08/13] staging: mt7621-eth: add the drivers core files

2018-03-14 Thread NeilBrown
From: John Crispin Original comment: This patch adds the main chunk of the driver. The ethernet core is used in all of the Mediatek/Ralink Wireless SoCs. Over the years we have seen various changes to * the register layout * the type of ports (single/dual gbit, internal FE/Gbit switch) * dma eng

[PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 12/13] staging: mt7621-eth: mediatek: add Kconfig and Makefile

2018-03-14 Thread NeilBrown
From: John Crispin This patch adds the Makefile and Kconfig required to make the driver build. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee Signed-off-by: NeilBrown --- drivers/staging/Kconfig |2 ++ drivers/staging/Makefile

[PATCH 10/13] staging: mt7621-eth: add mdio support for mt762X family

2018-03-14 Thread NeilBrown
From: John Crispin NeilBrown: this patch originally contained soc-mt7620.c but as I cannot test that, I removed it. Some functions from mdio-mt7620.c are needed for soc-mt7621.c support - fixed mt7620_has_carrier() to read correct register. Original comment: Add support for SoCs from th

[PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 16 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/

[PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e

[PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e11

[PATCH 11/13] staging: mt7621-eth: add support for mt7621

2018-03-14 Thread NeilBrown
From: John Crispin Add support for SoCs from the mt7621 family. These all have 2 GMAC ports, both of which are attached to the same internal 1000MBit switch. Currently we only support GMAC1 as the sole CPU port. MT7621 is very similar to MT7620 with only a few registers having different offsets.

[PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable

2018-03-14 Thread Valentin Vidic
Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index b2c54999b022..b57d3f4e9321 100644 --- a

Re: [Y2038] [PATCH v4 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-14 Thread Arnd Bergmann
On Wed, Mar 14, 2018 at 4:50 AM, Deepa Dinamani wrote: > The file arch/arm64/kernel/process.c needs asm/compat.h also to be > included directly since this is included conditionally from > include/compat.h. This does seem to be typical of arm64 as I was not > completely able to get rid of asm/compa

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2018-03-14 Thread Andrew Lunn
On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages > switch objects discovered on the fsl-mc bus. A description of the driver > can b

Re: [PATCH 00/13] staging: add drivers to support Mediatek mt7621 in gnubee-pc1

2018-03-14 Thread NeilBrown
On Thu, Mar 15 2018, NeilBrown wrote: > Hi Greg, > I'd like to submit the following drivers to staging. They > are all for components of the mt7621 MIPS-based SOC from Mediatek. > I lifted them out of libreCMC and (for the ethernet code) out > of email posts from about 2 years ago. I forward

[PATCH v3]PCI: hv: fix PCI-BUS domainID corruption

2018-03-14 Thread Sridhar Pitchai
Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even with that when a first device is added to the bus, it overrides bus domain ID with the device serial number. Sometime this can result in BUS ID not being unique. In this case, when PCI_BUS and a device to bus is added, the firs

Re: [Y2038] [PATCH v4 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-14 Thread Deepa Dinamani
On Wed, Mar 14, 2018 at 1:52 PM, Arnd Bergmann wrote: > On Wed, Mar 14, 2018 at 4:50 AM, Deepa Dinamani > wrote: >> The file arch/arm64/kernel/process.c needs asm/compat.h also to be >> included directly since this is included conditionally from >> include/compat.h. This does seem to be typical

Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-14 Thread Kirill Marinushkin
On 03/13/18 22:23, Andy Shevchenko wrote: > On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin > wrote: >> In the current implementation, `rmmod snd_bcm2835` does not release >> resources properly. It causes an oops when trying to list sound devices. >> >> This commit fixes it. > Nice catch! > >

Re: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR

2018-03-14 Thread John Syne
Hi Jonathan, I have been looking at the IIO ABI docs and if I understand correctly, the idea is to use consistent naming conventions? So for example, looking at the ADE7854 datasheet, the naming matching the ADE7854 registers would be as follows: {direction}_{type}_{index}_{modifier}_{info_mask

[PATCH] staging: lustre: o2iblnd: Fix FastReg map/unmap for MLX5

2018-03-14 Thread Doug Oucharek
The FastReg support in ko2iblnd was not unmapping pool items causing the items to leak. In addition, the mapping code is not growing the pool like we do with FMR. This patch makes sure we are unmapping FastReg pool elements when we are done with them. It also makes sure the pool will grow when w