On Fri, Mar 02, 2018 at 05:21:42AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: 501b9cb070bc35073f4195b58e74098a9d31375c
> commit: 501b9cb070bc35073f4195b58e74098a9d31375c [217/217] staging: nvec: add
> er
There are so many rules for kernel developers to deal with. Is it worse
to go over the 80 character limit or align the parameters properly? Is
it OK to start the subject with a lower case letter? I get in trouble
for using the wrong prefix but I'm the first person to patch a driver so
how on ear
And no top posting on email threads... So don't you forget it. :P
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Bogdan,
On 03/01/2018 07:47 PM, Bogdan Purcareata wrote:
> Move the source files out of staging into their final locations:
> - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
> - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
>to the other interna
> -Original Message-
> From: Laurentiu Tudor
> Sent: Friday, March 02, 2018 11:18 AM
> To: Bogdan Purcareata ; gre...@linuxfoundation.org;
> Ruxandra Ioana Ciocoi Radulescu
> Cc: stuyo...@gmail.com; Ioana Ciornei ; Nipun Gupta
> ; Roy Pledge ; Horia Geantă
> ; de...@driverdev.osuosl.org; l
You've got two subjects which are the same. That's not allowed, sorry.
You could just say:
[PATCH 1/2] staging: most: Add a blank line
[PATCH 2/2] staging: most: Silence a long line warning
regards,
dan carpenter
___
devel mailing list
de...@linuxdriv
Move the source files out of staging into their final locations:
- dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
- dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
to the other internally used APIs
- dpbp.h gets merged into include/linux/fsl/mc.h, exposi
Move the source files out of staging into their final locations:
- dpcon.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
- dpcon-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
to the other internally used APIs
- dpcon.h gets merged into include/linux/fsl/mc.h, exp
Previous submission: https://lkml.org/lkml/2018/3/1/733
Commit 6bd067c48ef ("staging: fsl-mc: Move core bus out of staging")
moves the fsl-mc bus driver infrastructure out of staging to
drivers/bus/fsl-mc. The next step is moving a couple of tightly
connected DPAA2 objects - DPBP (Data Path Buffer
Remove condition where if and else branch are identical.
Issue found using cond_no_effect.cocci Coccinelle script.
Signed-off-by: Santha Meena Ramamoorthy
---
Changes in v2:
- Change commit message
- Add new recipients
drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c | 8 ++--
1 file c
Hi Fabio,
On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote:
> On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote:
>
> > Oh, this only works for csi ports that have pinctrl in their csi port
> > node, like:
> >
> > &ipu1_csi0 {
> > pinctrl-names = "default";
> > pinctrl-0
This patchset has been introduced for the cleanup of
adis16209 driver.
This patchset cleans up miscellaneous code fragments
and improves the code readability.
Shreeya Patel (6):
Staging: iio: adis16209: Arrange headers in alphabetical order
Staging: iio: adis16209: Change the definition name
Arrange the headers in alphabetical order for cleanup
purpose.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16209.c
b/drivers/staging/iio/accel/adis16209.c
index 7fcef
The change in the definition name makes it then obvious
what the units are throughout the driver and there will
be no need of the comment.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagin
The defined names for registers does not make it very
clear that they are registers and hence, add _REG postfix.
This improves the readability of the code.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis16209.c | 85 ++-
1 file changed, 43 insertio
Remove some unnecessay comments and group the control
register and register field macros together.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis16209.c | 116 ++
1 file changed, 19 insertions(+), 97 deletions(-)
diff --git a/drivers/staging/iio/
Some of the register names does not make it's puporse
very clear and hence, add some comments for more
information.
Also there are certain unit based comments which are not
providing sufficient information, so expand those comments.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis
Use sign_extend32 function instead of manually coding it.
Also, adjust a switch block to explicitly match channels
and return -EINVAL as default case which makes the code
semantically more clear.
Signed-off-by: Shreeya Patel
---
drivers/staging/iio/accel/adis16209.c | 15 ++-
1 file
This patch series contains fixes for open parenthesis mismatch and line
over 80 char issue found by checkpatch script.
Ajay Singh (3):
staging: wilc1000: fix open parenthesis mismatch in
wilc_wlan_cfg_get()
staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()
staging: wilc1000
Fix 'line over 80 characters' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 37 ++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging
Fix 'Alignment should match open parenthesis' issue found by
checkpatch.pl script. Reduce the leading tab, to make space for open
parenthesis match.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-
Refactor wilc_wlan_handle_rxq() to fix line over 80 character issue
found by checkpatch.pl script. Added a new function to split
'wilc_wlan_handle_rxq' function code.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c | 114 +++
1 file changed, 63
Fix 'line over 80 char' issues found by checkpatch.pl script in
handle_cfg_param(). Rename variables and used temporary variables
to fix the line over 80 characters issue.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 175 +-
1 file changed
Fix 'line over 80 character' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
Fix "Avoid camelCase" issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
i
Fix 'line over 80 char' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
inde
Fix few smatch warning related to 'warn: always true condition'.
handle_cfg_param() warn: always true condition
'(cfg_param_attr->auth_timeout < 65536) => (0-u16max < 65536)'
handle_cfg_param() warn: always true condition
'(cfg_param_attr->rts_threshold < 65536) => (0-u16max < 65536)'
handle_cfg_p
Fix 'line over 80 characters' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 216 +++---
1 file changed, 108 insertions(+), 108 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/
Fix 'line over 80 characters' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfac
This patch series contains fixes for checkpatch.pl reported issue & 'always true
condition' smatch warning.
Ajay Singh (13):
staging: wilc1000: rename enuEvent to avoid camelCase
staging: wilc1000: remove always 'true' check from 'if' statement
staging: wilc1000: fix line over 80 char in ha
Fix 'line over 80 characters' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interfac
Fix 'Avoid camelCase' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 119 +++---
1 file changed, 59 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wi
Fix 'Avoid camelCase' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/ho
Fix 'line over 80 character' issues found by checkpatch.pl script by
use of temporary variable and avoided leading tab.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/dr
Fix 'line over 80 character' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
Fix 'Avoid camelCase' issue found by checkpatch.pl script.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Thursday, March 1, 2018 6:32 PM
To: Ruxandra Ioana Ciocoi Radulescu
Cc: de...@driverdev.osuosl.org; Roy Pledge ; Bogdan
Purcareata ; linux-ker...@vger.kernel.org; Laurentiu
Tudor
Subject: Re: [PATCH 4/4] staging
This patch fixes the checks reported by checkpatch.pl for alignment
should match open parenthesis.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/st
On Fri, 2 Mar 2018, Arushi Singhal wrote:
> This patch fixes the checks reported by checkpatch.pl for alignment
> should match open parenthesis.
>
> Signed-off-by: Arushi Singhal
Your Signed-off-by email address should be the same as the one in the From
line. You have arushisinghal19971...@gm
From: Arushi Singhal
Add spaces around arithmetic operator '+', to fix the checkpatch
issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h
b/drivers/staging/
From: Arushi Singhal
Add spaces around '|' to fix the checkpatch issue.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 2 +-
2 files changed, 2 insertions(+),
From: Arushi Singhal
Remove extra blank line(s) that were causing checkpatch issues.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712/rtl8712_cmdctrl_regdef.h | 2 --
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
Fix issues found with checkpatch.pl for rtl8712 driver.
Arushi Singhal (4):
staging: rtl8712: Remove multiple blank line(s)
staging: rtl8712: Added spaces around '+'.
staging: rtl8712: Add spaces around '|'
staging: rtl8712: remove unnecessary parentheses
drivers/staging/rtl8712/os_intfs
On Mon, Jan 15, 2018 at 06:18:10PM -0800, Deepa Dinamani wrote:
> All the current architecture specific defines for these
> are the same. Refactor these common defines to a common
> header file.
>
> The new common linux/compat_time.h is also useful as it
> will eventually be used to hold all the d
Change the initialization order so that the device is ready to transmit
(ie connect vsp is completed) before setting the internal reference
to the device with RCU.
This avoids any races on initialization and prevents retry issues
on shutdown.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyp
When VF is used for accelerated networking it will likely have
more queues (and different policy) than the synthetic NIC.
This patch defers the queue policy to the VF so that all the
queues can be used. This impacts workloads like local generate UDP.
Signed-off-by: Stephen Hemminger
---
drivers/
There is a race between napi_reschedule and re-enabling interrupts
which could lead to missed host interrrupts. This occurs when
interrupts are re-enabled (hv_end_read) and vmbus irq callback
(netvsc_channel_cb) has already scheduled NAPI.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv
Since the netvsc_channel_cb is already called in interrupt
context from vmbus, there is no need to do irqsave/restore.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hy
Block setup of multiple channels earlier in the teardown
process. This avoids possible races between halt and subchannel
initialization.
Suggested-by: Haiyang Zhang
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/rndis_filter.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driv
Don't wake transmit queues if link is not up yet.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc_drv.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index c5584c2d440e..fa6cf18e7719 100
These are improvements to netvsc driver. They aren't functionality
changes so not targeting net-next; and they are not show stopper
bugs that need to go to stable either.
v2
- drop the irq flags patch, defer it to net-next
- split the multicast filter flag patch out
- change propogate rx
Need to delete NAPI association if vmbus_open fails.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 686900d61374..ff97a85b2e9d 100644
--- a/driver
The netvsc driver was always enabling all multicast and broadcast
even if netdevice flag had not enabled it.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/rndis_filter.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/net/hyperv/rndis_f
The netvsc device should propagate filters to the SR-IOV VF
device (if present). The flags also need to be propagated to the
VF device as well. This only really matters on local Hyper-V
since Azure does not support multiple addresses.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvs
On Fri, 2 Mar 2018 13:49:00 -0800, Stephen Hemminger wrote:
>- change propogate rx mode patch to handle startup of vf
Thanks! :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-d
On 02/24, Jonathan Cameron wrote:
> On Wed, 21 Feb 2018 16:54:35 -0300
> Rodrigo Siqueira wrote:
>
> > This patch fixes the checkpatch.pl warning:
> >
> > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
> > argument 'struct device *' should also have an identifier name...
>
No functional change.
Signed-off-by: Dexuan Cui
Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access")
Cc: Vitaly Kuznetsov
Cc: sta...@vger.kernel.org
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1
When we hot-remove the device, we first receive a PCI_EJECT message and
then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == 0.
The first message is offloaded to hv_eject_device_work(), and the second
is offloaded to pci_devices_present_work(). Both the paths can be running
list_
1. With the patch "x86/vector/msi: Switch to global reservation mode"
(4900be8360), the recent v4.15 and newer kernels always hang for 1-vCPU
Hyper-V VM with SR-IOV. This is because when we reach hv_compose_msi_msg()
by request_irq() -> request_threaded_irq() -> __setup_irq()->irq_startup()
-> __
The pci-hyperv driver's channel callback hv_pci_onchannelcallback() is not
really a hot path, so we don't need to mark it as a perf_device, meaning
with this patch all HV_PCIE channels' target_cpu will be CPU0.
This patch can help to avoid a potential ABBA deadlock in the busy loop
of Hyper-V PCI
I didn't really hit a bug, but just happened to notice the redundant line.
Signed-off-by: Dexuan Cui
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
Cc: sta...@vger.kernel.org
---
drivers/hv/hv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index fe96aab9e794
Fix issues found with checkpatch.pl to conform to the Linux
kernel coding style.
Changes in v2:
* From and Signed-off emails were not same in v1.
* Added detailed commit message
Arushi Singhal (6):
staging: rtl8712: Fixed 'tabstop' coding style warning
staging: rtl8712: match alignment with o
Add spaces around arithmetic operator '+', to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_c
Remove extra blank line(s) to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712/rtl8712_cmdctrl_regd
Add spaces around '|' to conform to the Linux
kernel coding style. Issue found using checkpatch.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 2 +-
2 files ch
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
Delete/Add tabs and spaces to align the code to fix the
checkpatch issue: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/drv_types
On Sat, 3 Mar 2018, Arushi Singhal wrote:
> Fix issues found with checkpatch.pl to conform to the Linux
> kernel coding style.
For the series:
Acked-by: Julia Lawall
>
> Changes in v2:
> * From and Signed-off emails were not same in v1.
> * Added detailed commit message
>
> Arushi Singhal (
70 matches
Mail list logo
