Re: [PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int()

On Fri, 16 Feb 2018 20:15:53 +0200 Claudiu Beznea wrote: > On 14.02.2018 13:10, Ajay Singh wrote: > > Refactor wilc_spi_read_int() to fix the line over 80 char issues reported > > by checkpatch.pl script. > > > > Signed-off-by: Ajay Singh > > --- > > drivers/staging/wilc1000/wilc_spi.c | 57 >

Re: [PATCH 04/12] staging: wilc1000: fix open parenthesis alignment mismatch in wilc_parse_network_info()

On Fri, Feb 16, 2018 at 08:41:41PM +0530, Ajay Singh wrote: > Fix "Alignment should match open parenthesis" issue found by > checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/coreconfigurator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

Re: [PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue.

On Fri, Feb 16, 2018 at 01:40:08PM -0800, Quytelda Kahja wrote: > @@ -728,17 +731,21 @@ static void gdm_lte_pdn_table(struct net_device *dev, > char *buf, int len) > { > struct nic *nic = netdev_priv(dev); > struct hci_pdn_table_ind *pdn_table = (struct hci_pdn_table_ind *)buf; > +

Re: [PATCH 1/4] Staging: ks7010: sdio: Fix multiple use of arguments in RX/TX queue macros.

On Fri, Feb 16, 2018 at 06:20:50PM -0800, Quytelda Kahja wrote: > Use GCC extensions to prevent macro arguments from accidentally being > evaluated > multiple times when the macro is called. > Don't over engineer code. These bugs are never going to occur in real life because of how the macros a

[no subject]

Good Day, This is the second time i am sending you this mail. I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, need your alliance in a deal that will be of mutual benefit. Email me back for more details. Regards.

Re: [PATCH] staging: iio/meter: add name to function definition arguments

Hi Jonathan, > On Fri, 16 Feb 2018 11:16:58 -0200 > Rodrigo Siqueira wrote: > > > Hi Daniel > > > > > Hi Rodrigo, > > > > > > I think this is a nice finding. One comment inline: > > > > > > On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > > > > This patch fixes the checkpatch.pl w

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

Hi Ajay, On 16.02.2018 17:11, Ajay Singh wrote: > Refactor sdio_clear_int_ext() function to remove "Too many leading tabs" > warning reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_sdio.c | 134 > +-- > 1 fil

Re: [PATCH 11/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack()

On 16.02.2018 17:11, Ajay Singh wrote: > Fix "line over 80 characters" issue reported by checkpatch.pl. > Use temporary variable to avoid checkpatch.pl issue. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 16 +--- > 1 file changed, 13 insertions(+), 3

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch: git://linuxtv.org/hver

[PATCH 04/14] staging: wilc1000: rename pstrHostIfRemainOnChan to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/ho

[PATCH 02/14] staging: wilc1000: rename strHostIfSetMulti to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_int

[PATCH 01/14] staging: wilc1000: rename s8PowerMode & strPowerMgmtParam to avoid camelCase

Fix "Avoid camelCase" issues found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interfac

[PATCH 03/14] staging: wilc1000: rename host_int_get_assoc_res_info() parameters to avoid camelCase

Fix "Avoid camelCase" issues reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/

[PATCH 00/14] staging: wilc1000: fix to avoid cameCase & unnecessary parentheses

This patch series removes the issues found by checkpatch.pl script in host_interface.c/.h file. Ajay Singh (14): staging: wilc1000: rename s8PowerMode & strPowerMgmtParam to avoid camelCase staging: wilc1000: rename strHostIfSetMulti to avoid camelCase staging: wilc1000: rename host_int_

[PATCH 06/14] staging: wilc1000: rename strHostIfStaInactiveT to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 05/14] staging: wilc1000: rename pstrHostIfRegisterFrame to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c in

[PATCH 07/14] staging: wilc1000: rename pstrRcvdGnrlAsyncInfo to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/

[PATCH 09/14] staging: wilc1000: rename functions starting with Handle_ to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 98 +++ 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wi

[PATCH 08/14] staging: wilc1000: rename pstrRcvdNetworkInfo to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c in

[PATCH 10/14] staging: wilc1000: rename functions starting with TimerCB_ to avoid camelCase

Fix "Avoid camelCase" issues found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c i

[PATCH 12/14] staging: wilc1000: rename GetPeriodicRSSI to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 11/14] staging: wilc1000: rename ListenTimerCB to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 14/14] staging: wilc1000: remove Unnecessary parentheses around 'hif_set_mc->cnt'

Fix "Unnecessary parentheses around 'hif_set_mc->cnt'" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wil

[PATCH 13/14] staging: wilc1000: rename wilc_remove_key() parameters to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: > Ion is designed to be a framework used by other clients who perform > operations on the buffer. Use the DRM vgem client as a simple consumer. > In conjunction with the dma-buf sync ioctls, this tests the full attach/map > path for the

[PATCH v2] staging:iio:meter: Add name to function definition arguments

This patch fixes the checkpatch.pl warning: drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition argument 'struct device *' should also have an identifier name... This commit adds arguments names to the signature declared in the ade7854_state struct. For consistency reason, It al

Re: [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c

On Sat, Feb 17, 2018 at 12:12:36AM +0530, Yash Omer wrote: > This patch fixes up line should not end with open parenthesis found by > checkpatch.pl script. > > Signed-off-by: Yash Omer > --- > drivers/staging/xgifb/vb_setmode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

Re: [PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue.

On Fri, Feb 16, 2018 at 01:40:08PM -0800, Quytelda Kahja wrote: > Fix a coding style problem causing warnings from checkpatch.pl. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/gdm724x/gdm_lte.c | 50 > ++- > 1 file changed, 28 insertions(+), 22 de

Re: [PATCH 2/4] Staging: ks7010: hostif: Fix multiple use of arguments in SME queue macros.

On Fri, Feb 16, 2018 at 06:25:01PM -0800, Quytelda Kahja wrote: > Use GCC extensions to prevent macro arguments from accidentally being > evaluated > multiple times when the macro is called. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks_hostif.c | 19 +-- >

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Philipp, On 02/19/2018 08:23 AM, Philipp Zabel wrote: Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: Hi all, I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ER

Re: [PATCH 3/4] Staging: ks7010: hostif: Fix multiple use of arguments in rate and event masking macros.

On Fri, Feb 16, 2018 at 06:25:02PM -0800, Quytelda Kahja wrote: > Use GCC extensions to prevent macro arguments from accidentally being > evaluated > multiple times when the macro is called. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/ks7010/ks_hostif.h | 74 > +++

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On 02/19/2018 07:31 AM, Daniel Vetter wrote: On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: Ion is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls, this

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: > On 02/19/2018 07:31 AM, Daniel Vetter wrote: > > On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: > > > Ion is designed to be a framework used by other clients who perform > > > operations on the buffer. Use the DRM vgem c

RE: BANK-IN SLIP

Dear Sir/Ma, Kindly find attached bank-in slip for your kind perusal. Please kindly follow the instruction to open the secured payment slip as we ensure the recipient to be the right person to do the needful confirmation and get back to me asap! Payment made for invoice: 1. Inv. 1009408 - $

RE: BANK-IN SLIP

Dear Sir/Ma, Kindly find attached bank-in slip for your kind perusal. Please kindly follow the instruction to open the secured payment slip as we ensure the recipient to be the right person to do the needful confirmation and get back to me asap! Payment made for invoice: 1. Inv. 1009408 - $

RE: BANK-IN SLIP

Dear Sir/Ma, Kindly find attached bank-in slip for your kind perusal. Please kindly follow the instruction to open the secured payment slip as we ensure the recipient to be the right person to do the needful confirmation and get back to me asap! Payment made for invoice: 1. Inv. 1009408 - $

[PATCH v2 1/3] Staging: ks7010: sdio: Convert RX/TX queue macros into real functions.

Convert the unsafe macros into inline functions. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 46 ++-- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010

[PATCH v2 2/3] Staging: ks7010: hostif: Convert SME queue macros to real functions.

Convert the unsafe macros into inline functions. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 975dbb

[PATCH v2 3/3] Staging: ks7010: hostif: Convert the ps_confirm_wait_inc() macro to a real function.

Convert the unsafe macro into an inline function. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index f554477fe6bc..74a08

[PATCH v2] Staging: bcm2048: Fix function argument alignment in radio-bcm2048.c.

Fix a coding style problem. Signed-off-by: Quytelda Kahja --- This is the patch without the unnecessary fixes for line length. drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/bcm2048

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

> On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote: ^^^ This looks good, but you need to fix your from email header. regards, dan carpenter ___ devel mailing list de...@linuxdriverp

[PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h

... since u64 has a hidden header dependency that was not there before using it (i.e. it breaks our VMM build). Also, __u64 is the right way to expose the data type through UAPI. Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support") Signed-off-by: KarimAllah Ahmed Cc: K. Y. Sriniv