Re: [PATCH v4] Staging: iio: ade7758: Expand buf_lock to cover both buffer and state protection

2018-02-04 Thread Jonathan Cameron
On Sat, 3 Feb 2018 21:01:32 +0530 Shreeya Patel wrote: > iio_dev->mlock is to be used only by the IIO core for protecting > device mode changes between INDIO_DIRECT and INDIO_BUFFER. > > This patch replaces the use of mlock with the already established > buf_lock mutex. > > Introducing 'unlock

Re: [PATCH] staging: lustre: llite: replace variable length array

2018-02-04 Thread Sven Dziadek
On 01/30/2018 03:04 AM, Dilger, Andreas wrote: > On Jan 27, 2018, at 14:42, Sven Dziadek wrote: >> >> The functionality of the removed variable length array is already >> implemented by the function xattr_full_name in fs/xattr.c >> >> This fixes the sparse warning: >> warning: Variable length arra

[PATCH 3/4] staging:r8188eu: Remove struct pkt_file from rtw_xmitframe_coalesce()

2018-02-04 Thread Ivan Safonov
Struct pkt_file is a base to simple wrapper for skb_copy_bits(). Eliminate struct pkt_file usage in rtw_xmitframe_coalesce(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/s

[PATCH 1/4] staging:r8188eu: Remove struct pkt_file from set_qos()

2018-02-04 Thread Ivan Safonov
Struct pkt_file is a base to simple wrapper for skb_copy_bits(). Use skb_copy_bits() without wrappers. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl818

[PATCH 2/4] staging:r8188eu: Remove struct pkt_file from update_attrib()

2018-02-04 Thread Ivan Safonov
Struct pkt_file is a base to simple wrapper for skb_copy_bits(). Do not use struct pkt_file in update_attrib(). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 4/4] staging:r8188eu: Remove unused struct pkt_file

2018-02-04 Thread Ivan Safonov
Struct pkt_file is unused now, so remove it and correponding functions. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/xmit_osdep.h | 13 - drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 37 -- 2 files changed, 50 deletions(-) diff --git a/dr

Re: [PATCH v4] Staging: iio: ade7758: Expand buf_lock to cover both buffer and state protection

2018-02-04 Thread Shreeya Patel
On Sun, 2018-02-04 at 11:10 +, Jonathan Cameron wrote: > On Sat,  3 Feb 2018 21:01:32 +0530 > Shreeya Patel wrote: > > > > > iio_dev->mlock is to be used only by the IIO core for protecting > > device mode changes between INDIO_DIRECT and INDIO_BUFFER. > > > > This patch replaces the use of

Re: [PATCH v4] Staging: iio: ade7758: Expand buf_lock to cover both buffer and state protection

2018-02-04 Thread Jonathan Cameron
On 4 February 2018 21:03:05 GMT, Shreeya Patel wrote: >On Sun, 2018-02-04 at 11:10 +, Jonathan Cameron wrote: >> On Sat,  3 Feb 2018 21:01:32 +0530 >> Shreeya Patel wrote: >> >> > >> > iio_dev->mlock is to be used only by the IIO core for protecting >> > device mode changes between INDIO

[PATCH 2/2] staging: android: ion: Return void instead of int

2018-02-04 Thread Yisheng Xie
Now, nobody care about the return value of ion_page_pool_add, therefore we can just make it return void. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/ion_page_pool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c b

[PATCH 1/2] staging: android: ion: Remove dead code in ion_page_pool_free

2018-02-04 Thread Yisheng Xie
ion_page_pool_add will always return 0, however ion_page_pool_free will call ion_page_pool_free_pages when ion_page_pool_add's return value is not 0, so it is a dead code which can be removed. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/ion_page_pool.c | 6 +- 1 file changed,