Re: [PATCH] drivers/staging/greybus: fix max dup length for kstrndup

Hi Ma, Thanks for your patch. Please make sure you use scripts/get_maintainer.pl so that your patches goes to the right lists and people. I CC's them now. ;) On Tue 12 Dec 2017 at 09:25, Ma Shimiao wrote: > If source string longer than max, kstrndup will alloc max+1 space. > So, we should make s

Re: [PATCH v2] staging: comedi: ni_*: Fix style warnings.

On Thu, 2017-12-14 at 00:27 -0600, Aniruddha Shastri wrote: > Three of these warnings are now line-too-long warnings. I think these > warnings are preferable to the ones listed below. The longest line > is only 87 chars wide, which is reasonable. [] > diff --git a/drivers/staging/comedi/drivers/n

[PATCH 02/10] staging: ccree: clean up PM registration

Clean up power management registration. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 16 +++- drivers/staging/ccree/ssi_pm.c | 4 drivers/staging/ccree/ssi_pm.h | 3 +++ 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/driver

[PATCH 01/10] staging: ccree: drop ifdef CONFIG_OF in code

As we already depend on CONFIG_OF via Kconfig no need to support conditional build without it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c in

[PATCH 06/10] staging: ccree: remove useless debug code

Remove a bunch of useless debug code ifdef'ed out Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 45 - drivers/staging/ccree/ssi_config.h | 3 --- drivers/staging/ccree/ssi_driver.c | 13 -- drivers/staging/ccree/s

[PATCH 05/10] staging: ccree: remove CC_IRQ_DELAY dead code

Remove dead code from older version which is not supported in current hardware. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_config.h | 1 - drivers/staging/ccree/ssi_driver.c | 11 --- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/ccree/ssi_config.h b

[PATCH 00/10] staging: ccree: cleanups & fixes

- More cleanups and dead code removal. - Handle TODO item of moving none standard sysfs interface to debugfs - One fix to FIPS event irq handling code Gilad Ben-Yossef (10): staging: ccree: drop ifdef CONFIG_OF in code staging: ccree: clean up PM registration staging: ccree: add explicit m

[PATCH 03/10] staging: ccree: add explicit module init/exit func

We need to do a module global scope init/exit operation to support the debugfs interface we are about to introduce in the next patch, so wean the module of the boiler plate saving macro as it will no longer be sufficient. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 1

[PATCH 04/10] staging: ccree: staging: ccree: replace sysfs by debugfs interface

The ccree driver has had a none standard sysfs interface for debugging. Replace it with a proper debugfs interface. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 3 +- drivers/staging/ccree/cc_debugfs.c | 114 +++ drivers/staging/ccree/cc_de

[PATCH 08/10] staging: ccree: remove ssi_config.h

Now that the only thing left in ssi_config is the maximum DMA mask length we get move that to ssi_driver.h and get rid of the file. All of ccree is now runtime configurable or under Kbuild control. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_debugfs.c | 1 - drivers/stagi

[PATCH 09/10] staging: ccree: fix fips event irq handling build

When moving from internal for kernel FIPS infrastructure the FIPS event irq handling code was left with the old ifdef by mistake. Fix it. Fixes: b7e607bf33a2 ("staging: ccree: move FIPS support to kernel infrastructure") Cc: sta...@vger.kernel.org Signed-off-by: Gilad Ben-Yossef --- drivers/sta

[PATCH 07/10] staging: ccree: turn compile time debug log to params

The ccree driver has some support to dump runtime data to kernel log to assist in debugging. The code used to be enabled by a build time flag. Refactor to enable it via module/kernel parameters. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_config.h | 2 -- drivers/staging/

[PATCH 10/10] staging: ccree: update TODO

Update TODO with handling on sysfs -> debugfs transition Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/TODO | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ccree/TODO b/drivers/staging/ccree/TODO index f44edcd..6d8702b 100644 --- a/drivers/stagin

Re: [PATCH 04/10] staging: ccree: staging: ccree: replace sysfs by debugfs interface

Gilad, On Thu, Dec 14, 2017 at 3:02 PM, Gilad Ben-Yossef wrote: > The ccree driver has had a none standard sysfs interface for debugging. > Replace it with a proper debugfs interface. > > Signed-off-by: Gilad Ben-Yossef > --- /dev/null > +++ b/drivers/staging/ccree/cc_debugfs.c > @@ -0,0 +1,1

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

You'll need to resend everything. The thread is too messy. On Wed, Dec 13, 2017 at 06:44:44PM +0100, Valentin Vidic wrote: > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index f77ecd60f43a..0889c65d5a31 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/stag

[PATCH 6/8 v4] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values v4: - drop the whole function since it

rf69_get_lna_gain

Hi! This is an information for all of you, doing experiments with real hardware! I wanted to explain, what this lna_gain stuff is used for: If you are receiving messages from different sender (let's say several thermometers), it may happen (e. g. due to different distance and different batter

Re: [PATCH] hyperv: make HYPERV a menuconfig to ease disabling it all

On 12/13/2017 11:51 PM, Greg KH wrote: > On Wed, Dec 13, 2017 at 01:23:38PM -0800, Stephen Hemminger wrote: >> On Wed, 13 Dec 2017 09:54:19 +0100 >> Vincent Legoll wrote: >> >>> Hello, >>> >>> On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger >>> wrote: Will this break existing configs? >

Re: rf69_get_lna_gain

On Thu, Dec 14, 2017 at 06:08:11PM +0200, Marcus Wolf wrote: > Hi! > > This is an information for all of you, doing experiments with real hardware! > > I wanted to explain, what this lna_gain stuff is used for: > > If you are receiving messages from different sender (let's say several > thermome

Re: [PATCH] android: binder: Check for errors in binder_alloc_shrinker_init().

On Thu, Dec 14, 2017 at 10:52:28AM -0800, Todd Kjos wrote: > On Fri, Dec 8, 2017 at 3:08 AM, Dan Carpenter > wrote: > > On Wed, Dec 06, 2017 at 02:05:58PM -0500, Sherry Yang wrote: > >> Hi Tetsuo, > >> > >> It looks like this patch was not submitted to LKML. Perhaps you want > >> to send it to th

[PATCH 1/3] staging: vchiq_arm: Remove useless comments

Signed-off-by: Mikhail Shvetsov --- .../interface/vchiq_arm/vchiq_kern_lib.c | 35 +- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c b/drivers/staging/vc04_services/interface/vchiq_arm

[PATCH 3/3] staging: vchiq_arm: Fixing code lines over 80 characters

Signed-off-by: Mikhail Shvetsov --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchi

[PATCH 0/3] staging: vchiq_arm: code style fixing

Mikhail Shvetsov (3): Remove useless comments Fixing code style of comments Fixing code lines over 80 characters .../interface/vchiq_arm/vchiq_kern_lib.c | 50 +- 1 file changed, 11 insertions(+), 39 deletions(-) -- 2.11.0 ___

[PATCH 2/3] staging: vchiq_arm: Fixing code style of comments

Signed-off-by: Mikhail Shvetsov --- .../vc04_services/interface/vchiq_arm/vchiq_kern_lib.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c b/drivers/staging/vc04_services/interface/vchiq_arm

Re: [PATCH 1/3] staging: vchiq_arm: Remove useless comments

On Thu, Dec 14, 2017 at 11:40:03PM +0300, Mikhail Shvetsov wrote: > Signed-off-by: Mikhail Shvetsov I can't take patches without any changelog text at all. Please fix all of these up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriv

syzbot bug reports

Btw, Todd, you may have seen these but the syzbot reported a couple bugs right before we added you to MAINTAINERS. kernel BUG at drivers/android/binder_alloc.c:LINE! http://lkml.iu.edu/hypermail/linux/kernel/1712.0/00907.html general protection fault in binder_poll http://lkml.iu.edu/hypermail/li

[PATCH v2 3/9] media: staging/imx: of: allow for recursing downstream

Calling of_parse_subdev() recursively to a downstream path that has already been followed is ok, it just means that call will return immediately since the subdevice was already added to the async list. With that there is no need to determine whether a subdevice's port is a sink or source, so 'num_

[PATCH v2 5/9] media: staging/imx: pass fwnode handle to find/add async subdev

Pass the subdev's fwnode_handle to imx_media_find_async_subdev() and imx_media_add_async_subdev(), instead of a device_node. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 20 ++-- drivers/staging/media/imx/imx-media-of.c | 7 +++ drivers/st

[PATCH v2 1/9] media: staging/imx: get CSI bus type from nearest upstream entity

The imx-media driver currently supports a device tree graph of limited complexity. This patch is a first step in allowing imx-media to work with more general OF graphs. The CSI subdevice assumes the originating upstream subdevice (the "sensor") is connected directly to either the CSI mux or the MI

[PATCH v2 2/9] media: staging/imx: remove static media link arrays

Remove the static list of media links that were formed at probe time. These links can instead be created after all registered async subdevices have been bound in imx_media_probe_complete(). The media links between subdevices that exist in the device tree, can be created post-async completion by us

[PATCH v2 8/9] media: staging/imx: reorder function prototypes

Re-order some of the function prototypes in imx-media.h to group them correctly by source file. No functional changes. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/stag

[PATCH v2 0/9] media: imx: Add better OF graph support

This is a set of patches that improve support for more complex OF graphs. Currently the imx-media driver only supports a single device with a single port connected directly to either the CSI muxes or the MIPI CSI-2 receiver input ports. There can't be a multi-port device in between. This patch set

[PATCH v2 7/9] media: staging/imx: convert static vdev lists to list_head

Although not technically necessary because imx-media has only a maximum of 8 video devices, and once setup the video device lists are static, in anticipation of moving control ineritance to v4l2-core, make the vdev lists more generic by converting to dynamic list_head's. After doing that, 'struct

[PATCH v2 6/9] media: staging/imx: remove static subdev arrays

For more complex OF graphs, there will be more async subdevices registered. Remove the static subdev[IMX_MEDIA_MAX_SUBDEVS] array, so that imx-media places no limits on the number of async subdevs that can be added and registered. There were two uses for 'struct imx_media_subdev'. First was to act

[PATCH v2 9/9] media: staging/imx: update TODO

Update TODO file: - Remove TODO info about the OV564x driver, while this still needs to be done (add a OV5642 driver or merge with OV5640 driver), it is not relevant here. - Update TODO about methods for retrieving CSI bus config. - Add some TODO's about OF graph parsing restrictions. Signe

[PATCH v2 4/9] media: staging/imx: remove devname string from imx_media_subdev

A separate string for the device name, for DEVNAME async match, was never needed. Just assign the asd device name to the passed platform device name pointer in imx_media_add_async_subdev(). Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 3 +-- drivers/staging/med