Re: [PATCH V3 22/29] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-29 Thread Sakari Ailus
Hi Sinan, On Mon, Nov 27, 2017 at 11:57:59AM -0500, Sinan Kaya wrote: > diff --git > a/drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c > b/drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c > index 4631b1d..51dcef57 100644 > --- a/drivers/staging/medi

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-29 Thread Jeremy Sowden
On 2017-11-29, at 03:04:53 +0300, Dan Carpenter wrote: > On Tue, Nov 28, 2017 at 11:33:37PM +, Jeremy Sowden wrote: > > On 2017-11-28, at 17:15:24 +0300, Dan Carpenter wrote: > > > On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > > > > The "address" member of struct ia_css_host_

Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging

2017-11-29 Thread Laurentiu Tudor
Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to d

Re: [PATCH 3/3] media: staging: atomisp: prefer s16 to int16_t.

2017-11-29 Thread Sakari Ailus
On Mon, Nov 27, 2017 at 11:30:54AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden I'd just leave it as-is, int16_t is a standard type. The commit message would be needed, too. -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing l

Re: [PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

2017-11-29 Thread Sakari Ailus
On Tue, Nov 28, 2017 at 10:27:24AM +, Jeremy Sowden wrote: > Fixed some sparse warnings in the Atom ISP staging driver. > > This time with longer commit messages. :) > > I've chosen to ignore checkpatch.pl's suggestion to change the types of > the arrays in the second patch from int16_t to s1

I need your cooperation

2017-11-29 Thread Ahmed Hassan
Dear Friend, I know that this mail will come to you as a surprise as we have never met before, but need not to worry as I am contacting you independently of my investigation and no one is informed of this communication. I need your urgent assistance in transferring the sum of $11.3million immediat

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-29 Thread Sakari Ailus
Hi Greg, On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > > Signed-off-by: Jeremy Sowden > > --- > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > > +++--- > > 1 file changed, 12 insertions(+

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-29 Thread Greg KH
On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > > > Signed-off-by: Jeremy Sowden > > > --- > > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-29 Thread Sakari Ailus
On Wed, Nov 29, 2017 at 10:15:06AM +0100, Greg KH wrote: > On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > > Hi Greg, > > > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > > > > Signed-off-by: Jeremy

Re: [PATCH v2] Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'

2017-11-29 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 02:46:18PM +0300, Roman Storozhenko wrote: > There are two reasons for that: > 1) As Linus Torvalds said we should use kernel types: > http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html > > 2) There are only few places in the lustre codebase that use such types. >

Re: [PATCH Resend] staging: media: lirc: style fix - replace hard-coded function names

2017-11-29 Thread Sean Young
On Tue, Nov 28, 2017 at 06:47:08PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > Instead of hard coding the function name the __func__ variable > should be used. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Sakari Ailus
Hi Mauro, Thanks for the patch. On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote: > A recent change on Kernel 4.15-rc1 causes all tags with > /** to be handled as kernel-doc markups. Well, several > atomisp modules, it doesn't use kernel-doc, but some other > documentation ma

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Nov 2017 14:14:54 +0200 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the patch. > > On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote: > > A recent change on Kernel 4.15-rc1 causes all tags with > > /** to be handled as kernel-doc markups. Well, several > > a

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Nov 2017 10:24:57 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 29 Nov 2017 14:14:54 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > Thanks for the patch. > > > > On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote: > > > A recent change on Kernel 4.15-

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Sakari Ailus
On Wed, Nov 29, 2017 at 10:28:26AM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 29 Nov 2017 10:24:57 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 29 Nov 2017 14:14:54 +0200 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > Thanks for the patch. > > > > > > On Wed, Nov 29, 2

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Andrew Lunn
On Wed, Nov 29, 2017 at 04:00:01PM +0530, Souptick Joarder wrote: Hi Souptick Please trim the code when giving reviews. We don't want to have to page through 8K lines of code it find a few comments mixed in. Just keep the beginning of the function you are commented on to make the context clear. C

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-29 Thread Alan Cox
> There are 35 defaults defined by macros like this, most of them much > more complicated that IA_CSS_DEFAULT_ISP_MEM_PARAMS, and a few members > are initialized to non-zero values. My plan, therefore, is to convert > everything to use designated initializers, and then start removing the > zeroes

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-29 Thread Benjamin Gaignard
2017-11-28 14:32 GMT+01:00 Greg KH : > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >> Getting an entry per heap could allow to se

[PATCH] staging: android: ashmem: Check for register_shrinker() failure.

2017-11-29 Thread Tetsuo Handa
register_shrinker() might return -ENOMEM error since Linux 3.12. Signed-off-by: Tetsuo Handa Cc: Robert Love Cc: Marco Nelissen Cc: John Stultz Cc: Greg Kroah-Hartman Cc: Michal Hocko --- drivers/staging/android/ashmem.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --g

[PATCH] android: binder: Check for errors in binder_alloc_shrinker_init().

2017-11-29 Thread Tetsuo Handa
Both list_lru_init() and register_shrinker() might return an error. Signed-off-by: Tetsuo Handa Cc: Sherry Yang Cc: Greg Kroah-Hartman Cc: Michal Hocko --- drivers/android/binder.c | 4 +++- drivers/android/binder_alloc.c | 12 +--- drivers/android/binder_alloc.h | 2 +- 3 fil

Re: [PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-29 Thread David Miller
The net-next tree is closed, please resubmit this when the net-next tree opens again. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: android: ion: Check for register_shrinker() failure.

2017-11-29 Thread Tetsuo Handa
register_shrinker() might return -ENOMEM error since Linux 3.12. But since callers of ion_device_add_heap() are not ready to receive an error and it is not simple enough to fix within this patch, this patch just prints a warning line when register_shrinker() failed. Signed-off-by: Tetsuo Handa Cc

[PATCH] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the lirc module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'read', this function's name, in a string Sign

Re: [PATCH Resend] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the cxd2099 module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this function's name, in a st

[PATCH Resend] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the cxd2099 module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this function's name, in a st

[PATCH] staging: nvec: Fix usleep_range is preferred over udelay

2017-11-29 Thread Joshua Abraham
Signed-off-by: Joshua Abraham This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nv

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: > On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: >> From: Carlos Munoz >> >> The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O >> hardware that is significantly different from previous generations of >> the family. >>

Re: [PATCH] staging: nvec: Fix usleep_range is preferred over udelay

2017-11-29 Thread Josh Abraham
On Wed, Nov 29, 2017 at 06:07:53PM +0200, Mikko Perttunen wrote: > On 11/29/2017 06:00 PM, Joshua Abraham wrote: > > Signed-off-by: Joshua Abraham > > > > This patch fixes the issue: > > > > CHECK: usleep_range is preferred over udelay; see > > Documentation/timers/timers-howto.txt > > > > ---

[PATCH v3] staging: lustre: Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'

2017-11-29 Thread Roman Storozhenko
There are two reasons for that: 1) As Linus Torvalds said we should use kernel types: http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html 2) There are only few places in the lustre codebase that use such types. In the most cases it uses 'u32' and 'u64'. Signed-off-by: Roman Storozhenko

[PATCH] staging: pi433: pi433_if.c codestyle fix space around kthread

2017-11-29 Thread Oliver Graute
This patch fixes the following checkpatch.pl errors: ERROR: space prohibited after that open parenthesis '(' #499: FILE: pi433_if.c:499: + if ( kthread_should_stop() ) ERROR: space prohibited before that close parenthesis ')' #499: FILE: pi433_if.c:499: + if ( kthread_

[PATCH] staging: pi433: pi433_if.c codestyle brace on previous line

2017-11-29 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: that open brace { should be on the previous line in pi433_if.c as requested by TODO file Signed-off-by: Oliver Graute --- drivers/staging/pi433/pi433_if.c | 38 +- 1 file changed, 13 insertions(+), 2

Re: [PATCH] staging: nvec: Fix usleep_range is preferred over udelay

2017-11-29 Thread Mikko Perttunen
On 11/29/2017 06:00 PM, Joshua Abraham wrote: Signed-off-by: Joshua Abraham This patch fixes the issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: android: ion: Check for register_shrinker() failure.

2017-11-29 Thread Greg KH
On Wed, Nov 29, 2017 at 10:33:39PM +0900, Tetsuo Handa wrote: > register_shrinker() might return -ENOMEM error since Linux 3.12. > But since callers of ion_device_add_heap() are not ready to receive an > error and it is not simple enough to fix within this patch, this patch > just prints a warning

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Dan Carpenter
On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote: > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, > >> struct port_status status) > >> +{ > >> + u64 data; > >> + u64 prtx; > >> + u64 miscx; > >> + int timeout; > >>

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 08:07 AM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: From: Carlos Munoz The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O hardware that is significantly different from prev

Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-29 Thread Arnd Bergmann
On Wed, Nov 29, 2017 at 12:17 AM, Deepa Dinamani wrote: > On Tue, Nov 28, 2017 at 6:17 AM, Arnd Bergmann wrote: >> On Mon, Nov 27, 2017 at 11:29 PM, Deepa Dinamani >> wrote: > Right. There are three options: > > 1. Use two configs to identify which syscalls need not be supported by > new archit

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Andrew Lunn
On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote: > On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote: > > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, > > >> struct port_status status) > > >> +{ > > >> + u64 data; > > >> + u6

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Andrew Lunn
On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote: > +static int bgx_probe(struct platform_device *pdev) > +{ > + struct mac_platform_data platform_data; > + const __be32 *reg; > + u32 port; > + u64 addr; > + struct device_node *child; > + struct platform_device *n

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread David Daney
On 11/29/2017 02:56 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:39PM -0800, David Daney wrote: +static int bgx_probe(struct platform_device *pdev) +{ + struct mac_platform_data platform_data; + const __be32 *reg; + u32 port; + u64 addr; + struct device_node

RE: [PATCH 0/4] hv_balloon: fixes for num_pages_onlined accounting and misc improvements

2017-11-29 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 28, 2017 8:30 AM > To: Alex Ng ; KY Srinivasan > Cc: linux-ker...@vger.kernel.org; Haiyang Zhang ; > Stephen Hemminger ; Dexuan Cui > ; de...@linuxdriverproject.org > Subject: Re: [PATCH

[PATCH] staging: xgifb: remove unused macro XGIPART3

2017-11-29 Thread Joshua Abraham
Signed-off-by: Joshua Abraham This patch removes the unused macro XGIPART3. --- drivers/staging/xgifb/XGI_main.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h index a3af1cbbf8ee..5f55d0a39bc1 100644 --- a/drivers/staging/x

Re: [PATCH] staging: xgifb: remove unused macro XGIPART3

2017-11-29 Thread Dan Carpenter
On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote: > Signed-off-by: Joshua Abraham > > This patch removes the unused macro XGIPART3. > The Signed-off-by line goes after the changelog. > --- > drivers/staging/xgifb/XGI_main.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

RE: [PATCH 0/4] hv_balloon: fixes for num_pages_onlined accounting and misc improvements

2017-11-29 Thread Dexuan Cui
> -Original Message- > From: Haiyang Zhang > Sent: Wednesday, November 29, 2017 16:55 > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Vitaly Kuznetsov writes: > > > > > While doing routing code review I noticed that commit 6df8d9aaf3af > > > ("Dri

Re: [PATCH v3] staging: lustre: Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'

2017-11-29 Thread Dan Carpenter
On Wed, Nov 29, 2017 at 07:46:21PM +0300, Roman Storozhenko wrote: > There are two reasons for that: In my email client the subject line and body are not next to each other. It looks like this: https://marc.info/?l=linux-arm-kernel&m=151187366315885&w=2 So it took me a while to realize what you

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-29 Thread Souptick Joarder
Hi David, Dan, On Thu, Nov 30, 2017 at 12:50 AM, David Daney wrote: > On 11/29/2017 08:07 AM, Souptick Joarder wrote: >> >> On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder >> wrote: >>> >>> On Wed, Nov 29, 2017 at 6:25 AM, David Daney >>> wrote: From: Carlos Munoz The Ca