Re: [staging:staging-testing 104/105] drivers/staging//fsl-mc/bus/fsl-mc-bus.c:663:9: warning: 'error' may be used uninitialized in this function

2017-11-27 Thread Greg Kroah-Hartman
On Fri, Nov 24, 2017 at 06:02:08PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 01:01:18AM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: f3145c023966af8e207b6b3cdb6187c35e7f9e95 > > commi

[PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread laurentiu.tudor
From: Laurentiu Tudor Fix this warning triggering on a powerpc build: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/stag

Re: [staging:staging-testing 104/105] drivers/staging//fsl-mc/bus/fsl-mc-bus.c:663:9: warning: 'error' may be used uninitialized in this function

2017-11-27 Thread Laurentiu Tudor
Hi Greg, On 11/27/2017 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, Nov 24, 2017 at 06:02:08PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Nov 25, 2017 at 01:01:18AM +0800, kbuild test robot wrote: >>> tree: >>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Fix this warning triggering on a powerpc build: > warning: 'error' may be used uninitialized in this function > [-Wmaybe-uninitialized] > > Signed-off-by: Laurentiu Tudor > --- You forgot a re

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread Laurentiu Tudor
On 11/27/2017 11:08 AM, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> Fix this warning triggering on a powerpc build: >> warning: 'error' may be used uninitialized in this function >> [-Wmaybe-uninitialized] >> >> Signed

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 09:31:21AM +, Laurentiu Tudor wrote: > > > On 11/27/2017 11:08 AM, Greg KH wrote: > > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> Fix this warning triggering on a powerpc build: > >> warning: 'error' ma

Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

2017-11-27 Thread Dan Carpenter
On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: > This patch to ddk750_sii164.h fixes line length warnings found by the > checkpatch.pl script and reformats comments uniformly. > > Signed-off-by: Jeremy Lacomis > --- > drivers/staging/sm750fb/ddk750_sii164.h | 57 > +

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Ian Abbott
On 26/11/17 01:50, Alex Frappier Lachapelle wrote: Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Benjamin Gaignard
2017-11-09 22:17 GMT+01:00 Laura Abbott : > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: >> >> Instead a getting only one common device "/dev/ion" for >> all the heaps this patch allow to create one device >> entry ("/dev/ionX") per heap. >> Getting an entry per heap could allow to set security

Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

2017-11-27 Thread Geert Uytterhoeven
On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter wrote: > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: >> This patch to ddk750_sii164.h fixes line length warnings found by the >> checkpatch.pl script and reformats comments uniformly. >> >> Signed-off-by: Jeremy Lacomis >> --- >>

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-27 Thread Johannes Berg
Hi, So I removed those call-through place because private wext operations are a really bad idea and should just die. We don't want drivers to require specially patched hostapd versions to work right, like here. I suppose in staging you might want to work around that like here, but that really mea

[PATCH 1/3] media: staging: atomisp: address member of struct ia_css_host_data is a pointer-to-char, so define default as NULL.

2017-11-27 Thread Jeremy Sowden
Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isp_param/interface/ia_css_isp_param_types.h b/drivers/staging

[PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-27 Thread Jeremy Sowden
Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/at

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote: > 2017-11-09 22:17 GMT+01:00 Laura Abbott : > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > >> > >> Instead a getting only one common device "/dev/ion" for > >> all the heaps this patch allow to create one device > >> entry (

[PATCH 3/3] media: staging: atomisp: prefer s16 to int16_t.

2017-11-27 Thread Jeremy Sowden
Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 25 +++--- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/at

[PATCH 0/3] Sparse fixes for the Atom ISP Staging Driver

2017-11-27 Thread Jeremy Sowden
Fixed some sparse warnings in the Atom ISP staging driver and the checkpatch warnings that affected my patches. Jeremy Sowden (3): media: staging: atomisp: address member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. media: staging: atomisp: defined as static

Re: [PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-27 Thread Johannes Berg
In addition to what Dan said, > +static iw_handler rtw_handlers_private[] = { > + NULL, /* Empty */ > + rtw_hostapd_sta_flush_pvt, /* RTL871X_HOSTAPD_FLUSH */ > + rtw_add_sta_pvt, /* RTL871X_HOSTAPD_ADD_STA */ > + rtw_del_sta_pvt,

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden > --- > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > +++--- > 1 file changed, 12 insertions(+), 12 deletions(-) I can never take patches without any changelog text, and so

[PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

2017-11-27 Thread Jeremy Sowden
Changed the types of some arrays from int16_t to s16. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 25 +++--- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/e

[PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

2017-11-27 Thread Jeremy Sowden
Fixed some sparse warnings in the Atom ISP staging driver and the checkpatch warnings that affected my patches. This time with longer commit messages. :) Jeremy Sowden (3): media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings. media: staging: atomisp: fix

[PATCH v2 2/3] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings.

2017-11-27 Thread Jeremy Sowden
Defined some const arrays as static since they don't need external linkage. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2

[PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-27 Thread Jeremy Sowden
The "address" member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/at

[PATCH 4/8] [media] staging: bcm2835-camera use ktime_t for timestamps

2017-11-27 Thread Arnd Bergmann
struct timeval is deprecated for in-kernel use, and converting this function to use ktime_t makes it simpler as well. Signed-off-by: Arnd Bergmann --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 37 ++ .../vc04_services/bcm2835-camera/bcm2835-camera.h | 2 +- 2 fil

[PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Arnd Bergmann
timespec overflows in 2038 on 32-bit architectures, and the getnstimeofday() suffers from possible time jumps, so the timestamps here are better done using ktime_get(), which has neither of those problems. In case of ov2680, we don't seem to use the timestamp at all, so I just remove it. Signed-o

[PATCH 8/8] [media] staging: imx: use ktime_t for timestamps

2017-11-27 Thread Arnd Bergmann
The imx media driver passes around monotonic timestamps in the deprecated 'timespec' format. This is not a problem for the driver, as they won't overflow, but moving to either timespec64 or ktime_t is preferred. I'm picking ktime_t for simplicity here. frame_interval_monitor() is the main function

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

2017-11-27 Thread Christian Gromm
On 24.11.2017 16:31, Greg KH wrote: On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: This patch set fixes bugs and integrates the driver to the kernel's device model by revising its architecture. Part of this change is rearranging the directory layout, renaming of files and folde

[PATCH] staging: lustre: Fix line over 80 characters

2017-11-27 Thread Talat Batheesh
This patch fix the line over 80 characters warning that was detected using checkpatch.pl script. Signed-off-by: Talat Batheesh --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/class

[PATCH 3/3] staging: most: make DEVICE_ATTR structures static

2017-11-27 Thread Christian Gromm
In order to limit the scope of the DEVICE_ATTR structure this patch adds the keywork static. Signed-off-by: Christian Gromm --- drivers/staging/most/dim2/sysfs.c | 2 +- drivers/staging/most/usb/usb.c| 30 +++--- 2 files changed, 16 insertions(+), 16 deletions(-) di

[PATCH 2/3] staging: most: remove legacy folders

2017-11-27 Thread Christian Gromm
This patch removes the legacy folders of the modules. It is needed to clean up the driver's source tree. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/Makefile| 4 drivers/staging/most/aim-network/Makefile | 4 drivers/staging/most/aim-sound/Makefile | 4

[PATCH 0/3] staging: most: fix open issues

2017-11-27 Thread Christian Gromm
This patch set fixes open driver issues that have been identified by Greg Kroah-Hartman. Christian Gromm (3): staging: most: fix Makefile staging: most: remove legacy folders staging: most: make DEVICE_ATTR structures static drivers/staging/most/Makefile | 14 +++--- d

[PATCH 1/3] staging: most: fix Makefile

2017-11-27 Thread Christian Gromm
This patch fixes the names of the CONFIG symbols and the subfolders make is supposed to enter in order to build the selected modules. Signed-off-by: Christian Gromm --- drivers/staging/most/Makefile | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/stagin

Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

2017-11-27 Thread Jeremy Lacomis
On Mon, Nov 27, 2017 at 11:45:00AM +0100, Geert Uytterhoeven wrote: > On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter > wrote: > > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: > >> This patch to ddk750_sii164.h fixes line length warnings found by the > >> checkpatch.pl script an

Re: [PATCH 00/50] staging: most: rework driver architecture and fix defects

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 02:38:34PM +0100, Christian Gromm wrote: > On 24.11.2017 16:31, Greg KH wrote: > > On Tue, Nov 21, 2017 at 03:04:34PM +0100, Christian Gromm wrote: > > > This patch set fixes bugs and integrates the driver to the kernel's device > > > model by revising its architecture. Part

Re: [PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Andy Shevchenko
On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In case of ov2680, we do

[PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Arnd Bergmann
timespec overflows in 2038 on 32-bit architectures, and the getnstimeofday() suffers from possible time jumps, so the timestamps here are better done using ktime_get(), which has neither of those problems. In case of ov2680, we don't seem to use the timestamp at all, so I just remove it. Signed-o

Re: [PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Andy Shevchenko
On Mon, 2017-11-27 at 16:21 +0100, Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In case of ov2680, we do

Re: [Y2038] [PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 4:05 PM, Andy Shevchenko wrote: > On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote: >> timespec overflows in 2038 on 32-bit architectures, and the >> getnstimeofday() suffers from possible time jumps, so the >> timestamps here are better done using ktime_get(), which

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-27 Thread Laurentiu Tudor
On 11/03/2017 05:17 PM, Greg KH wrote: > On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: >> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: >>> From: Stuart Yoder >>> >>> Move the source files out of staging into their final locations: >>>-include files in d

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 12:43:57PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote: > > 2017-11-09 22:17 GMT+01:00 Laura Abbott : > > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > > >> > > >> Instead a getting only one common device "/dev/

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Mark Brown
On Mon, Nov 27, 2017 at 05:12:23PM +0100, Daniel Vetter wrote: > commit model ftw, we have 400+ patches for 4.16 already merged and tested > and all ready, right when -rc1 gets tagged. Makes the merge window the > most relaxed time of all, because all the other maintainers are drowning > and wont

[PATCH V3 22/29] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-27 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function. Since ISP always uses domain 0, hard-code it in the code when call

[PATCH V3 23/29] staging: rts5208: remove rtsx_read_pci_cfg_byte()

2017-11-27 Thread Sinan Kaya
Remove unused rtsx_read_pci_cfg_byte() function. Signed-off-by: Sinan Kaya --- drivers/staging/rts5208/rtsx.c | 17 - drivers/staging/rts5208/rtsx.h | 2 -- 2 files changed, 19 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index 89e2c

[PATCH v3] binder: fix proc->files use-after-free

2017-11-27 Thread Todd Kjos
proc->files cleanup is initiated by binder_vma_close. Therefore a reference on the binder_proc is not enough to prevent the files_struct from being released while the binder_proc still has a reference. This can lead to an attempt to dereference the stale pointer obtained from proc->files prior to p

[PATCH] staging: pi433: pi433_if.c fix codestyle on two long lines

2017-11-27 Thread Oliver Graute
This patch fixes the following checkpatch.pl warning: WARNING: line over 80 characters #1233: FILE: pi433_if.c:1233: + unregister_chrdev(MAJOR(pi433_dev), pi433_spi_driver.driver.name); WARNING: line over 80 characters #1240: FILE: pi433_if.c:1240: + unregister_chrdev

Re: [PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Alan Cox
On Mon, 27 Nov 2017 16:21:41 +0100 Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In case of ov2680, we

Re: [PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

2017-11-27 Thread Alan Cox
On Mon, 27 Nov 2017 12:44:50 + Jeremy Sowden wrote: > Changed the types of some arrays from int16_t to s16W Which are the same type, except int16_t is the standard form. No point. Alan ___ devel mailing list de...@linuxdriverproject.org http://d

RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Hartley Sweeten
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: >> +const struct comedi_lrange *lrange; > > NAK. The following lines of source code allocate memory pointed to by > 'lrange' and modify it, so 'const' is not appropriate here.

[PATCH v2 02/10] include: Move compat_timespec/ timeval to compat_time.h

2017-11-27 Thread Deepa Dinamani
All the current architecture specific defines for these are the same. Refactor these common defines to a common header file. The new common linux/compat_time.h is also useful as it will eventually be used to hold all the defines that are needed for compat time types that support non y2038 safe typ

[PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-27 Thread Deepa Dinamani
The series is a preparation series for individual architectures to use 64 bit time_t syscalls in compat and 32 bit emulation modes. This is a follow up to the series Arnd Bergmann posted: https://sourceware.org/ml/libc-alpha/2015-05/msg00070.html [1] Big picture is as per the lwn article: https:/

[PATCH] staging: most: Fix build errors

2017-11-27 Thread Chris Coffey
This patch fixes build errors that occur when trying to build the MOST modules. For example, the cdev module build fails with: make[3]: *** No rule to make target 'drivers/staging/most/aim-cdev/cdev.o', needed by 'drivers/staging/most/aim-cdev/aim_cdev.o'. Stop. scripts/Makefile.build:569: recip

Re: [PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

2017-11-27 Thread Jeremy Sowden
On 2017-11-27, at 19:09:38 +, Alan Cox wrote: > On Mon, 27 Nov 2017 12:44:50 + Jeremy Sowden wrote: > > Changed the types of some arrays from int16_t to s16 > > Which are the same type, except int16_t is the standard form. > > No point. Righto, so this would be one of those cases in which

Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 8:30 PM, Deepa Dinamani wrote: > The series is a preparation series for individual architectures > to use 64 bit time_t syscalls in compat and 32 bit emulation modes. > > This is a follow up to the series Arnd Bergmann posted: > https://sourceware.org/ml/libc-alpha/2015-05/

Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-27 Thread Deepa Dinamani
>> I decided against using LEGACY_TIME_SYSCALLS to conditionally compile >> legacy time syscalls such as sys_nanosleep because this will need to >> enclose compat_sys_nanosleep as well. So, defining it as >> >> config LEGACY_TIME_SYSCALLS >> def_bool 64BIT || !64BIT_TIME >> >> will not include

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory poin

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread kbuild test robot
Hi Alex, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.15-rc1 next-20171127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread g...@kroah.com
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory poin

Re: [PATCH] staging: most: Fix build errors

2017-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 27, 2017 at 09:12:39PM +, Chris Coffey wrote: > This patch fixes build errors that occur when trying to build the > MOST modules. For example, the cdev module build fails with: > > make[3]: *** No rule to make target 'drivers/staging/most/aim-cdev/cdev.o', > needed by 'drivers/sta