[PATCH v2 0/5] staging: fsl-dpaa2/eth: Frame buffer work

2017-10-29 Thread Bogdan Purcareata
This patchset does some refactoring in the frame buffer area, in order for it to be in line with firmware (MC) configuration. Patches 1 - 2 do some label cleanup and move the buffer layout setup to a dedicated function. Patch 3 updates tx_data_offset - the offset for Tx frame buffers - to not acc

[PATCH v2 2/5] staging: fsl-dpaa2/eth: Split function

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Since setup_dpni() became a bit too long, move the buffer layout configuration to a separate function. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 79 +++-

[PATCH v2 1/5] staging: fsl-dpaa2/eth: Label cleanup

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Clean up goto labels in a couple of functions, by removing/renaming redundant ones. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 35 +++--- 1 file changed,

[PATCH v2 5/5] staging: fsl-dpaa2/eth: Extra headroom in RX buffers

2017-10-29 Thread Bogdan Purcareata
The needed headroom that we ask the stack to reserve for us in TX skbs is larger than the headroom available in RX frames, which leads to skb reallocations in forwarding scenarios involving two DPNI interfaces. Configure the hardware to reserve some extra space in the RX frame headroom to avoid th

[PATCH v2 3/5] staging: fsl-dpaa2/eth: Don't account SWA in tx_data_offset

2017-10-29 Thread Bogdan Purcareata
When configuring the Tx buffer layout, the software annotation size is mentioned, and MC accounts for it when configuring the frame tx_data_offset. No need to handle it in the driver as well. This results in 64B less memory allocated per frame. Signed-off-by: Bogdan Purcareata --- v1 -> v2: - ad

[PATCH v2 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment

2017-10-29 Thread Bogdan Purcareata
The WRIOP hardware block v1.0.0 (found on LS2080A board) requires data in RX buffers to be aligned to 256B, but newer revisions (e.g. on LS2088A, LS1088A) only require 64B alignment. Check WRIOP version and decide at runtime which alignment requirement to configure for ingress buffers. Signed-off

[PATCH] staging: greybus: spilib: fix use-after-free after deregistration

2017-10-29 Thread Johan Hovold
Remove erroneous spi_master_put() after controller deregistration which would access the already freed spi controller. Note that spi_unregister_master() drops our only controller reference. Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbridge driver") Cc: stable # 4.9 Cc: Greg Kroah-Har

Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

2017-10-29 Thread Viresh Kumar
On 29-10-17, 13:01, Johan Hovold wrote: > Remove erroneous spi_master_put() after controller deregistration which > would access the already freed spi controller. > > Note that spi_unregister_master() drops our only controller reference. > > Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbrid

Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

2017-10-29 Thread Johan Hovold
On Sun, Oct 29, 2017 at 06:13:28PM +0530, Viresh Kumar wrote: > On 29-10-17, 13:01, Johan Hovold wrote: > > Remove erroneous spi_master_put() after controller deregistration which > > would access the already freed spi controller. > > > > Note that spi_unregister_master() drops our only controller

Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

2017-10-29 Thread Viresh Kumar
On 29-10-17, 13:51, Johan Hovold wrote: > That's right, and I already posted a fix for that use-after-free: > > https://lkml.kernel.org/r/20171029115625.32385-1-jo...@kernel.org Great :) -- viresh ___ devel mailing list de...@linuxdriverproject.

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Joe Perches
On Sat, 2017-10-28 at 22:46 -0400, Kien Ha wrote: > From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > From: Kien Ha > Date: Fri, 27 Oct 2017 14:07:55 -0400 > Subject: [PATCH] Fix line too long warning > > Signed-off-by: Kien Ha Hi. Instead of merely shutting up checkpatc

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Yury Norov
Hi Kien, On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > >From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > From: Kien Ha > Date: Fri, 27 Oct 2017 14:07:55 -0400 > Subject: [PATCH] Fix line too long warning > > Signed-off-by: Kien Ha > --- > drivers/staging/rt

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Yury Norov
On Sun, Oct 29, 2017 at 06:54:09PM +0300, Yury Norov wrote: > Hi Kien, > > On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > > >From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > > From: Kien Ha > > Date: Fri, 27 Oct 2017 14:07:55 -0400 > > Subject: [PATCH] Fix line

[PATCH v2] Fix line too long warning

2017-10-29 Thread Kien Ha
>From dbe17bd47c0e76372a5ca391543dc15ddb35c9dd Mon Sep 17 00:00:00 2001 From: Kien Ha Date: Fri, 27 Oct 2017 14:07:55 -0400 Subject: [PATCH v2] Fix line too long warning Signed-off-by: Kien Ha --- drivers/staging/rtlwifi/base.c | 25 - 1 file changed, 8 insertions(+), 17

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Kien Ha
On Sun, 2017-10-29 at 18:54 +0300, Yury Norov wrote: > Hi Kien, > > On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > > > From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 > > > 2001 > > > > From: Kien Ha > > Date: Fri, 27 Oct 2017 14:07:55 -0400 > > Subject: [PATCH] Fix

Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

2017-10-29 Thread Rui Miguel Silva
Hi Johan, Thanks for the patch. On Sun 29 Oct 2017 at 12:01, Johan Hovold wrote: > Remove erroneous spi_master_put() after controller deregistration which > would access the already freed spi controller. > > Note that spi_unregister_master() drops our only controller reference. > > Fixes: ba3e670

[PATCH] staging: lustre: Replaces 'uint32_t' with '__u32' and 'uint64_t' with '__u64'.

2017-10-29 Thread Roman Storozhenko
There are two reasons for that: 1) As Linus Torvalds said we should use kernel types: http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html 2) There are only few places in the lustre codebase that use such types. In the most cases it uses '__u32' and '__u64'. Signed-off-by: Roman Storozhen

[PATCH 0/2] Drivers: hv: vmbus: Miscellaneous enhancements

2017-10-29 Thread kys
From: "K. Y. Srinivasan" Reply-To: k...@microsoft.com Miscellaneous enhancements. K. Y. Srinivasan (1): Drivers: hv: vmbus: Make pannic reporting to be more useful Stephen Hemminger (1): Drivers: hv: vmbus: Expose per-channel interrupts and events counters Documentation/ABI/stable/sysfs-

[PATCH 2/2] Drivers: hv: vmbus: Make pannic reporting to be more useful

2017-10-29 Thread kys
From: "K. Y. Srinivasan" Hyper-V allows the guest to report panic and the guest can pass additional information. All this is logged on the host. Currently Linux is passing back information that is not particularly useful. Make the following changes: 1. Windows uses crash MSR P0 to report bugchec

[PATCH 1/2] Drivers: hv: vmbus: Expose per-channel interrupts and events counters

2017-10-29 Thread kys
From: Stephen Hemminger When investigating performance, it is useful to be able to look at the number of host and guest events per-channel. This is equivalent to per-device interrupt statistics. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- Documentation/ABI/stable/sysf

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Yury Norov
On Sun, Oct 29, 2017 at 10:28:27AM -0700, Joe Perches wrote: > On Sun, 2017-10-29 at 18:54 +0300, Yury Norov wrote: > > At second, and most important, refer Documentation/process/coding-style.rst: > > Now, some people will claim that having 8-character indentations makes > > the code move too far t

[PATCH 02/17] hyper-v: trace vmbus_on_message()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to vmbus_on_message() which is called when we start processing a blocking from work context. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 5 + 2 files changed, 7 inse

[PATCH 00/17] Drivers: hv: vmbus: Add tracing to VMBus

2017-10-29 Thread kys
From: "K. Y. Srinivasan" Reply-To: k...@microsoft.com Messages between guest and host are used in Hyper-V as control flow. To simplify debugging various issues which are often hard to reproduce add tracepoints to all message senders and handlers. This is not a performance critical path and traci

[PATCH 06/17] hyper-v: trace vmbus_ongpadl_created()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_GPADL_CREATED handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 17 + 2 files changed, 19 insertions(+) diff --git a/drivers/hv/channe

[PATCH 03/17] hyper-v: trace vmbus_onoffer()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_OFFERCHANNEL handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 37 + 2 files changed, 39 insertions(+) diff --git

[PATCH 01/17] hyper-v: trace vmbus_on_msg_dpc()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracing subsystem to Hyper-V VMBus module and add tracepoint to vmbus_on_msg_dpc() which is called when we receive a message from host. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/Makefile | 4 +++- drivers/hv/hv_trace.c

[PATCH 13/17] hyper-v: trace vmbus_teardown_gpadl()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_GPADL_TEARDOWN sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 2 ++ drivers/hv/hv_trace.h | 18 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/hv/channel.c b/d

[PATCH 07/17] hyper-v: trace vmbus_ongpadl_torndown()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_GPADL_TORNDOWN handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 8 2 files changed, 10 insertions(+) diff --git a/drivers/hv/channel_mgmt.c b

[PATCH 09/17] hyper-v: trace vmbus_request_offers()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_REQUESTOFFERS sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 4 +++- drivers/hv/hv_trace.h | 8 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/hv/c

[PATCH 14/17] hyper-v: trace vmbus_negotiate_version()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_INITIATE_CONTACT sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/connection.c | 3 +++ drivers/hv/hv_trace.h | 26 ++ 2 files changed, 29 insertions(+) diff --git a/drivers/h

[PATCH 04/17] hyper-v: trace vmbus_onoffer_rescind()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_RESCIND_CHANNELOFFER handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 8 2 files changed, 10 insertions(+) diff --git a/drivers/hv/channel_mg

[PATCH 12/17] hyper-v: trace vmbus_establish_gpadl()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_GPADL_HEADER/CHANNELMSG_GPADL_BODY sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 6 ++ drivers/hv/hv_trace.h | 42 ++ 2 files changed, 48 inse

[PATCH 17/17] hyper-v: trace channel events

2017-10-29 Thread kys
From: Vitaly Kuznetsov Added an additional set of trace points for when channel gets notified or signals host. Suggested-by: Stephen Hemminger Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c| 2 ++ drivers/hv/connection.c | 2 ++ drivers/hv/hv_t

[PATCH 15/17] hyper-v: trace vmbus_release_relid()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_RELID_RELEASED sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 7 +-- drivers/hv/hv_trace.h | 16 2 files changed, 21 insertions(+), 2 deletions(-) diff --git

[PATCH 08/17] hyper-v: trace vmbus_onversion_response()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_VERSION_RESPONSE handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 3 +++ drivers/hv/hv_trace.h | 11 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/hv/channel_

[PATCH 16/17] hyper-v: trace vmbus_send_tl_connect_request()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_TL_CONNECT_REQUEST sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 7 ++- drivers/hv/hv_trace.h | 20 2 files changed, 26 insertions(+), 1 deletion(-) diff --git

[PATCH 05/17] hyper-v: trace vmbus_onopen_result()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_OPENCHANNEL_RESULT handler. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ drivers/hv/hv_trace.h | 17 + 2 files changed, 19 insertions(+) diff --git a/drivers/hv/c

[PATCH 11/17] hyper-v: trace vmbus_close_internal()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_CLOSECHANNEL sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 2 ++ drivers/hv/hv_trace.h | 15 +++ 2 files changed, 17 insertions(+) diff --git a/drivers/hv/channel.c b/driver

[PATCH 10/17] hyper-v: trace vmbus_open()

2017-10-29 Thread kys
From: Vitaly Kuznetsov Add tracepoint to CHANNELMSG_OPENCHANNEL sender. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 2 ++ drivers/hv/hv_trace.h | 27 +++ 2 files changed, 29 insertions(+) diff --git a/drivers/hv/channel

RE: [PATCH char-misc 1/1] Hyper-V: Remove x86-isms from architecture independent Hyper-V drivers

2017-10-29 Thread KY Srinivasan
> -Original Message- > From: mikel...@exchange.microsoft.com > [mailto:mikel...@exchange.microsoft.com] > Sent: Wednesday, October 25, 2017 3:31 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > vkuzn..

Re: [PATCH] Fix line too long warning

2017-10-29 Thread Joe Perches
On Sun, 2017-10-29 at 18:54 +0300, Yury Norov wrote: > At second, and most important, refer Documentation/process/coding-style.rst: > Now, some people will claim that having 8-character indentations makes > the code move too far to the right, and makes it hard to read on a > 80-character terminal

Re: [PATCH 10/17] hyper-v: trace vmbus_open()

2017-10-29 Thread Greg KH
On Sun, Oct 29, 2017 at 12:21:09PM -0700, k...@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > Add tracepoint to CHANNELMSG_OPENCHANNEL sender. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/channel.c | 2 ++ > drivers/hv/hv_trace.h | 27