[patch 1/3] genirq: Add config option for reservation mode

2017-10-17 Thread Thomas Gleixner
The interrupt reservation mode requires reactivation of PCI/MSI interrupts. Create a config option, so the PCI code can set the corresponding flag when required. Signed-off-by: Thomas Gleixner --- kernel/irq/Kconfig |3 +++ 1 file changed, 3 insertions(+) --- a/kernel/irq/Kconfig +++ b/kern

[patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere

2017-10-17 Thread Thomas Gleixner
Dexuan reported that the recent rework of the vector allocation mode in x86 broke HyperV PCI passtrough because the rework missed to add the MSI_FLAG_MUST_REACTIVATE flag to the HyperV/PCI interrupt domain info. The simple solution would be to set the flag in the HyperV/PCI driver but it's better

[patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE

2017-10-17 Thread Thomas Gleixner
Select CONFIG_GENERIC_IRQ_RESERVATION_MODE so PCI/MSI domains get the MSI_FLAG_MUST_REACTIVATE flag set in pci_msi_create_irq_domain(). Remove the explicit setters of this flag in the apic/msi code as they are not longer required. Fixes: 4900be83602b ("x86/vector/msi: Switch to global reservation

[patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code

2017-10-17 Thread Thomas Gleixner
If interrupt reservation mode is enabled then the PCI/MSI interrupts must be reactivated after early activation. Make sure that all callers of pci_msi_create_irq_domain() have the MSI_FLAG_MUST_REACTIVATE set when reservation mode is enabled. Signed-off-by: Thomas Gleixner --- drivers/pci/msi.c

Re: [PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-17 Thread Sakari Ailus
On Mon, Oct 16, 2017 at 04:24:56PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mauro Carvalho Chehab > Cc: Greg K

Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-17 Thread Sakari Ailus
On Tue, Oct 17, 2017 at 08:10:15AM +1100, Tobin C. Harding wrote: > On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > > diff --git > > a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c > > b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_plat

Re: [PATCH] staging/comedi: Convert timers to use timer_setup()

2017-10-17 Thread Ian Abbott
On 17/10/17 00:25, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Adds pointer back to comedi device from private struct. Cc: Ian Abbott

Re: [PATCH v2 0/2] staging: atomisp: memory allocation cleanups

2017-10-17 Thread Sakari Ailus
Hi Aishwarya, On Sat, Oct 14, 2017 at 07:24:00PM +0530, Aishwarya Pant wrote: > Patch series performs minor code cleanups using coccinelle to simplify memory > allocation tests and remove redundant OOM log messages. > > Changes in v2: > Rebase and re-send patches > > Aishwarya Pant (2): > stag

Re: [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code

2017-10-17 Thread Thomas Gleixner
On Tue, 17 Oct 2017, Thomas Gleixner wrote: > If interrupt reservation mode is enabled then the PCI/MSI interrupts must > be reactivated after early activation. > > Make sure that all callers of pci_msi_create_irq_domain() have the > MSI_FLAG_MUST_REACTIVATE set when reservation mode is enabled.

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-17 Thread Benjamin Gaignard
2017-10-17 0:09 GMT+02:00 Laura Abbott : > On 10/10/2017 02:11 AM, Mark Brown wrote: >> On Mon, Oct 09, 2017 at 05:10:37PM -0700, Laura Abbott wrote: >>> On 10/09/2017 03:08 PM, Mark Brown wrote: On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: >> > Anyway, to move this forwar

[PATCH v3 0/2] staging: atomisp: memory allocation cleanups

2017-10-17 Thread Aishwarya Pant
Patch series performs minor code cleanups using coccinelle to simplify memory allocation tests and remove redundant OOM log messages. Changes in v3: Rebase changes over atomisp-next branch of the media tree Changes in v2: Rebase and re-send patches Aishwarya Pant (2): staging: atomisp2: cleanup

[PATCH v3 1/2] staging: atomisp2: cleanup null check on memory allocation

2017-10-17 Thread Aishwarya Pant
For memory allocation functions that fail with a NULL return value, it is preferred to use the (!x) test in place of (x == NULL). Changes in atomisp2/css2400/sh_css.c were done by hand. Done with the help of the following cocci script: @@ type T; T* p; statement s,s1; @@ p = \(devm_kzalloc\|d

[PATCH v3 2/2] staging: atomisp: cleanup out of memory messages

2017-10-17 Thread Aishwarya Pant
Logging of explicit out of memory messages is redundant since memory allocation failures produce a backtrace. Done with the help of the following cocci script: @@ expression ex, ret; statement s; constant char[] c; constant err; identifier f, l; @@ ex = \(kmalloc\|kmalloc_array\|kzalloc\|kcalloc

Re: [PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-17 Thread Kees Cook
On Tue, Oct 17, 2017 at 1:23 AM, Sakari Ailus wrote: > On Mon, Oct 16, 2017 at 04:24:56PM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer point

Re: [PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-17 Thread Sakari Ailus
On Tue, Oct 17, 2017 at 08:16:03AM -0700, Kees Cook wrote: > On Tue, Oct 17, 2017 at 1:23 AM, Sakari Ailus wrote: > > On Mon, Oct 16, 2017 at 04:24:56PM -0700, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to > >> all timer callbacks, switch to usin

Re: [PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR_ERR

2017-10-17 Thread Steve Longerbeam
On 10/17/2017 10:19 AM, Gustavo A. R. Silva wrote: Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate. The proper pointer to be passed as argument is sensor. This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall Signed-off-by: Gustavo A. R. Silva --- This code w

[PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-17 Thread Cathy Avery
When running multipath on a VM if all available paths go down the driver can schedule large amounts of storvsc_remove_lun work items to the same lun. In response to the failing paths typically storvsc responds by taking host->scan_mutex and issuing a TUR per lun. If there has been heavy IO to the f

[PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-17 Thread Cathy Avery
When running multipath on a VM if all available paths go down the driver can schedule large amounts of storvsc_remove_lun work items to the same lun. In response to the failing paths typically storvsc responds by taking host->scan_mutex and issuing a TUR per lun. If there has been heavy IO to the f

[PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR_ERR

2017-10-17 Thread Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate. The proper pointer to be passed as argument is sensor. This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. drivers/staging/medi

[PATCH v2] media: staging/imx: do not return error in link_notify for unknown sources

2017-10-17 Thread Steve Longerbeam
imx_media_link_notify() should not return error if the source subdevice of the link is not found in the list of subdevices that registered via async. If the subdev has controls they will be inherited via a link_notify that starts from a known source async subdev. Signed-off-by: Steve Longerbeam -

[PATCH v2] staging: fbtft: differentiate between buffer and data types to fix sparse warning

2017-10-17 Thread Alfonso Lima Astor
sparse was complaning about an incorrect type cast: drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-bus.c:60:1:expected unsigned short [unsigned] [short] [usertype] drivers/staging/fbtft/fbtft-bus.c:60:1:got

RE: [patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE

2017-10-17 Thread Dexuan Cui
> From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Tuesday, October 17, 2017 12:55 AM > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -95,7 +95,7 @@ config X86 > select GENERIC_IRQ_MATRIX_ALLOCATOR if X86_LOCAL_APIC > select GENERIC_IRQ_MIGRATIONif SMP >

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-17 Thread Rob Herring
On Wed, Oct 11, 2017 at 11:08:11PM +0300, Dmitry Osipenko wrote: > Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of > video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports > decoding of CAVLC H.264 only. > > Signed-off-by: Dmitry Osipenko > --- > .../bind

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-17 Thread Thierry Reding
On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: [...] > > diff --git > > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt > > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt [...] > > +- resets : Must contain an entry for each entry in reset-n

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-17 Thread Rob Herring
On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding wrote: > On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: > [...] >> > diff --git >> > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt >> > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt > [...

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-17 Thread Dmitry Osipenko
On 18.10.2017 00:13, Rob Herring wrote: > On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding > wrote: >> On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: >> [...] diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bi

[PATCH 2/2] staging: fix return codes in gdm_lte

2017-10-17 Thread Andrii Vladyka
replace -1 return codes with appropriate values Signed-off-by: Andrii Vladyka --- drivers/staging/gdm724x/gdm_lte.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 42fcf9b..682c4e5 100

staging: gdm7234x clean-up

2017-10-17 Thread Andrii Vladyka
This patch series performs the following clean-ups in gdm7234x driver: - check for skb->len in gdm_lte_emulate_arp - fix return codes in gdm_lte ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/

[PATCH 1/2] staging: check for skb->len in gdm_lte_emulate_arp

2017-10-17 Thread Andrii Vladyka
check for skb->len in gdm_lte_emulate_arp Signed-off-by: Andrii Vladyka --- drivers/staging/gdm724x/gdm_lte.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 9ab6ce2..42fcf9b 100644 --- a/drivers/staging/gdm724

RE: [patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE

2017-10-17 Thread Thomas Gleixner
On Tue, 17 Oct 2017, Dexuan Cui wrote: > > From: Thomas Gleixner [mailto:t...@linutronix.de] > > Sent: Tuesday, October 17, 2017 12:55 AM > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -95,7 +95,7 @@ config X86 > > select GENERIC_IRQ_MATRIX_ALLOCATOR if X86_LOCAL_APIC > >

Re: [PATCH 02/20] staging: lustre: lnet: socklnd: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This isn't strictly necessary, since LASSERT() never returns, but not harmful either.

Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva This could also just be "continue;", but doesn't appear harmful. Reviewed-by: Andreas

Re: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/selftest/module.c

Re: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
> On Oct 12, 2017, at 10:17, Gustavo A. R. Silva > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Not sure why you moved the "for mode = 0" comment to a separate line? Not the en

Re: [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1271166 > Addresses-Coverity-ID: 1271167 > Addresses-Coverity-ID: 1271168 > Addresses-Coverity-ID: 1

Re: [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ldlm/ldlm_request.

Re: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ptlrpc/pack_generi

Re: [PATCH 20/20] staging: lustre: rpc: mark expected switch fall-throughs

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1077604 > Addresses-Coverity-ID: 1077605 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas

Re: [PATCH 12/20] staging: lustre: lnet: selftest: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/selftest/conctl.c |

[PATCH v2] staging: ccree: Fix bool comparison

2017-10-17 Thread sunil . m
From: Suniel Mahesh Comparision operator "equal to" not required on a variable "foo" of type "bool". Bool has only two values, can be used directly or with logical not. This fixes the following coccinelle warning: WARNING: Comparison of bool to 0/1 Signed-off-by: Suniel Mahesh --- Changes for

[PATCH v2] staging: ccree: fix boolreturn.cocci warning

2017-10-17 Thread sunil . m
From: Suniel Mahesh Return "false" instead of 0. This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Signed-off-by: Suniel Mahesh --- Changes for v2: - Changed the commit log to give a more accurate description of the changes

Re: [PATCH v2] staging: ccree: Fix bool comparison

2017-10-17 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 07:40:14AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Comparision operator "equal to" not required on a variable > "foo" of type "bool". Bool has only two values, can be used > directly or with logical not. > > This fixes the following coccinelle warning

Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for controlling the USB-role mux

2017-10-17 Thread Chanwoo Choi
Hi Hans, On 2017년 09월 23일 03:37, Hans de Goede wrote: > Cherry Trail SoCs have a built-in USB-role mux for switching between > the host and device controllers, rather then using an external mux > controller by a GPIO. > > There is a driver using the mux-subsys to control this mux, this > commit a

Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning

2017-10-17 Thread Tobin C. Harding
On Wed, Oct 18, 2017 at 07:42:53AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Return "false" instead of 0. > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. So close! The order of problem description and

Re: [PATCH 18/20] staging: lustre: osc: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1077598 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging

Re: Two rtlwifi drivers?

2017-10-17 Thread Kalle Valo
Pkshih writes: >> My recommendation is to avoid accumulating patches at all cost and start >> submitting them as soon as you can. This way you get patches committed >> much more smoother. So do not wait until _all_ patches are ready, >> instead start submitting patches as soon as you have _some_

[PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-17 Thread sunil . m
From: Suniel Mahesh This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. return "false" instead of 0. Signed-off-by: Suniel Mahesh --- Changes for v3: - Changed the commit log even more to give an accurate description of the c