Hi Dan. Thanks for your comments. I can fix all of those.
Probably there is also some upgrade needed for the MSI stuff.
pci_disable_msi() is not there anymore, so I have to use
pci_alloc_irq_vectors(). Doing tests with my PCIe HW I had some
problems with masking the legacy IRQs. Probably uio_pci_ge
From: Suniel Mahesh
Platform devices are expected to use wrapper functions,
platform_{get,set}_drvdata() with platform_device as argument,
for getting and setting the driver data. dev_{get,set}_drvdata()
are using &plat_dev->dev.
For wrapper functions we can directly pass a struct platform_device
On Wed, Oct 04, 2017 at 07:24:49AM +, Stahl, Manuel wrote:
> Hi Dan. Thanks for your comments. I can fix all of those.
> Probably there is also some upgrade needed for the MSI stuff.
> pci_disable_msi() is not there anymore, so I have to use
> pci_alloc_irq_vectors(). Doing tests with my PCIe H
On Thu, Sep 21, 2017 at 08:58:50PM -0700, k...@exchange.microsoft.com wrote:
> From: Stephen Hemminger
>
> When investigating performance, it is useful to be able to look at
> the number of host and guest events per-channel. This is equivalent
> to per-device interrupt statistics.
>
> Signed-off
This patch fixes the following checkpatch.pl warning.
WARNING: externs should be avoided in .c files
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/staging
On Mi, 2017-10-04 at 10:59 +0300, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 07:24:49AM +, Stahl, Manuel wrote:
> > Hi Dan. Thanks for your comments. I can fix all of those.
> > Probably there is also some upgrade needed for the MSI stuff.
> > pci_disable_msi() is not there anymore, so I ha
From 51081d316eb3078bf9ded4335fb6f5167e1ec93d Mon Sep 17 00:00:00 2001
From: Manuel Stahl
Date: Mon, 2 Oct 2017 16:23:19 +0200
Subject: [PATCH] Add new uio device for PCI with dynamic memory allocation
This device combines the uio_pci_generic driver and the uio_dmem_genirq
driver since PCI uses a
Sounds good.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote:
> It is entirely possible and easy in android/ueventd to create those nodes
> under "/dev/ion/". (assuming the heap 'subsystem' for these new devices will
> point to 'ion').
The reason I didn't say /dev/ion/foo initially is that if p
On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> Use list_for_each_entry_safe when the list elements may get deleted
> during traversal.
This patch is fine as a cleanup but none of these are actually buggy.
regards,
dan carpenter
___
d
On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote:
> This patch fixes the following checkpatch.pl warning.
> WARNING: externs should be avoided in .c files
Nope.
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
> b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -17,12 +17,6 @@
On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote:
> Hi Joe,
>
> Thanks for your responses. I have already compiled and the below is the
> logs for the same
>
> Please let me know if am I missing/doing wrong
Your commit message is incomplete.
checkpatch is a guide, but it's not what you shoul
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma
---
drivers/staging/rtl8188e
Use list_for_each_entry_safe to make the code more compact. Done
by the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m,list_del_init,f;
type T1;
T1* pos;
iterator name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_en
Use list_for_each_entry_safe to make code more compact. Done
using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m,list_del_init,f;
type T1;
T1* pos;
iterator name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_e
Use list_for_each_entry_safe to make the code more compact.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m, list_del_init, f;
type T1;
T1* pos;
iterator name list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_ea
Again, you have three patches on different files with the same subject
line. You could add the file name eg rtw_ap: to the subject line to make
them unique.
julia
On Wed, 4 Oct 2017, Srishti Sharma wrote:
> Use list_for_each_entry_safe to make the code more compact. Done
> by the following sema
Replaces upstream commit 0b2e9e7947e7 ("media: staging/imx: remove
confusing IS_ERR_OR_NULL usage")
We get a harmless warning about a potential uninitialized variable
use in the driver:
drivers/staging/media/imx/imx-media-of.c: In function 'of_parse_subdev':
drivers/staging/media/imx/imx-media-of
On Wed, 4 Oct 2017, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > Use list_for_each_entry_safe when the list elements may get deleted
> > during traversal.
>
> This patch is fine as a cleanup but none of these are actually buggy.
I'm not sure what yo
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Wednesday, October 4, 2017 1:49 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; lean
Stephen Hemminger writes:
> On Thu, 21 Sep 2017 10:17:18 +0200
> Vitaly Kuznetsov wrote:
>
>> Steven Rostedt writes:
>>
>> > On Wed, 20 Sep 2017 19:21:53 +0200
>> > Vitaly Kuznetsov wrote:
>> >
>> >> diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h
>> >> index 9a29ef55477d..72911d
Stephen Hemminger writes:
> I added an additional set of trace points for when channel gets notified or
> signals host.
>
Will add this in v3, thanks!
> diff -urNp linux-msft/drivers/hv/channel.c msft-4.14-rc3/drivers/hv/channel.c
> --- linux-msft/drivers/hv/channel.c 2017-10-03 10:06:54.893
This patch fixes all the following checkpatch.pl warning in rtl8723bs
WARNING: externs should be avoided in .c files
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b
On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Dan Carpenter wrote:
>
> > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > > Use list_for_each_entry_safe when the list elements may get deleted
> > > during traversal.
> >
> > This patch
On Wed, 4 Oct 2017, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 4 Oct 2017, Dan Carpenter wrote:
> >
> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > > > Use list_for_each_entry_safe when the list elements may
On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Dan Carpenter wrote:
>
>> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
>> >
>> >
>> > On Wed, 4 Oct 2017, Dan Carpenter wrote:
>> >
>> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
> Again, you have three patches on different files with the same subject
> line. You could add the file name eg rtw_ap: to the subject line to make
> them unique.
>
And the subject needs to start with [PATCH v3] and then after the
Sig
On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
>> Again, you have three patches on different files with the same subject
>> line. You could add the file name eg rtw_ap: to the subject line to make
>> them unique.
>>
>
> And the
On Wed, 4 Oct 2017, Srishti Sharma wrote:
> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter
> wrote:
> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
> >> Again, you have three patches on different files with the same subject
> >> line. You could add the file name eg rtw_ap: to
On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Srishti Sharma wrote:
>
>> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter
>> wrote:
>> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
>> >> Again, you have three patches on different files with the sam
This is a cleanup patch and doesn't change runtime behaviour. It
changes an open coded list traversal to use list_for_each_entry_safe.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m,list_del_init,f;
type T1;
T1* pos;
iterator name list_f
This is a cleanup patch and doesn't change runtime behaviour. It
changes an open coded list traversal to use list_for_each_entry_safe.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m,list_del_init,f;
type T1;
T1* pos;
iterator name list_fo
This is a cleanup patch and doesn't change runtime behaviour. It
changes an open coded list traversal to use list_for_each_entry_safe.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
expression e;
identifier m, list_del_init, f;
type T1;
T1* pos;
iterator name list
Removed all the unnecessary extern from rtl8723bs
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c
Removed warning from
0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after
running checkpatch.pl
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723b
sparse was complaning about an incorrect type cast:
drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment
(different base types)
drivers/staging/fbtft/fbtft-bus.c:60:1:expected unsigned short [unsigned]
[short] [usertype]
drivers/staging/fbtft/fbtft-bus.c:60:1:got
From: Suniel Mahesh
There is no need to create a local pointer variable "dev" and
pass it various API's, instead use plat_dev which is enumerated
by platform core on successful probe.
Signed-off-by: Suniel Mahesh
---
Note:
- Patch was tested and built(ARCH=arm) on staging-testing.
- No build is
Removed all unnecessary externs warnings in rtl8723bs
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_efuse.c| 7 +--
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c| 1 -
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --
drivers/staging/rtl8723b
Removed all the unnecessary extern from rtl8723bs
Signed-off-by: Srinivasan Shanmugam
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c
Make sure and initialize reserved fields in messages to host,
rather than passing stack junk.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index efd5db743319..9f48f454bde0 100644
--- a/
As part of removing the timer_list.data field, this converts the wilc1000
driver to using from_timer and an explicit per-timer data field, since
there doesn't appear to be a way to sanely resolve vif from hif_drv.
Cc: Aditya Shankar
Cc: Ganesh Krishna
Cc: Greg Kroah-Hartman
Cc: linux-wirel...@v
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Larry Finger
Cc: Florian Schilhabel
Cc: Greg Kroah-Hartman
Cc: Tejaswini Poluri
Cc: Scott Matheina
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Greg Kroah-Hartman
Cc: Derek Robson
Cc: simran singhal
Cc: Riccardo Marotti
Cc: Fabrizio Perria
Cc:
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Mauro Carvalho Chehab
Cc: Greg Kroah-Hartman
Cc: Alan Cox
Cc: Daeseok Youn
Cc: Arnd Bergmann
Cc: li
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Greg Kroah-Hartman
Cc: Juliana Rodrigues
Cc: Ivan Safonov
Cc: Gargi Sharma
Cc: sayli karnik
Cc: Yam
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Greg Kroah-Hartman
Cc: Derek Robson
Cc: Suniel Mahesh
Cc: Malcolm Priestley
Cc: Gargi Sharma
Cc: Ju
On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote:
> Removed warning from
> 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after
> running checkpatch.pl
>
> Signed-off-by: Srinivasan Shanmugam
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
> 1 file
47 matches
Mail list logo
