[PATCH] staging: unisys: visorbus: Declared char * array as static const

2017-09-09 Thread Harsha Sharma
State explicitly that individual entries in array will not change. Signed-off-by: Harsha Sharma --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/viso

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 9 Sep 2017, Srishti Sharma wrote: >> > >> >> Merge the assignment and return statements to return the value >> >> di

Re: [PATCH] staging: unisys: visorbus: Declared char * array as static const

2017-09-09 Thread Greg KH
On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote: > State explicitly that individual entries in array will not change. > > Signed-off-by: Harsha Sharma > --- > drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH v4] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
Merge the assignment and the return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v4: -Edit commit message so that it respects 80 character limit -Rem

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. >> >> @@ >> local idexpression ret; >> expression e; >> @@ >> >> -ret = >> +return >> e;

Re: [Outreachy kernel] Re: [PATCH] staging: unisys: visorbus: Declared char * array as static const

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Greg KH wrote: > On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote: > > State explicitly that individual entries in array will not change. > > > > Signed-off-by: Harsha Sharma > > --- > > drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- > > 1 file change

Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos

2017-09-09 Thread Dan Carpenter
On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote: > >> /* > >> - * Select the source PDO providing the most power while staying > >> within > >> - * the board's voltage limits. Prefer PDO providing exp > >> + * Select the source PDO providing the most pow

Re: [PATCH 7/8] staging: ccree: replace noop macro with inline

2017-09-09 Thread Dan Carpenter
On Sun, Sep 03, 2017 at 11:56:49AM +0300, Gilad Ben-Yossef wrote: > Replace noop macro with a noop inline function > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/ssi_driver.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ccree/ss

Re: [PATCH 1/1] x86/hyper-V: Allocate the IDT entry early in boot

2017-09-09 Thread Thomas Gleixner
On Fri, 8 Sep 2017, K. Y. Srinivasan wrote: > Allocate the hypervisor callback IDT entry early in the boot sequence. > > Signed-off-by: K. Y. Srinivasan > --- > arch/x86/kernel/cpu/mshyperv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mshyp

[PATCH] staging: sm750fb: Remove extra blank lines

2017-09-09 Thread Harsha Sharma
This was reported by checkpatch.pl Signed-off-by: Harsha Sharma --- drivers/staging/sm750fb/sm750_cursor.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index aa47a16..6b27b06 100644 --- a/drivers/staging/s

[PATCH] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deleti

Re: [PATCH 1/1] x86/hyper-V: Allocate the IDT entry early in boot

2017-09-09 Thread Dan Carpenter
On Fri, Sep 08, 2017 at 04:15:57PM -0700, k...@exchange.microsoft.com wrote: > From: "K. Y. Srinivasan" > > Allocate the hypervisor callback IDT entry early in the boot sequence. > I'm guessing this fixes a NULL dereference or something? The changelog doesn't really say why we are doing this.

Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos

2017-09-09 Thread Guenter Roeck
On Sat, Sep 09, 2017 at 11:48:48AM +0300, Dan Carpenter wrote: > On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote: > > >> /* > > >> - * Select the source PDO providing the most power while staying > > >> within > > >> - * the board's voltage limits. Prefer PDO

Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps

2017-09-09 Thread Guenter Roeck
On Fri, Sep 08, 2017 at 09:13:25PM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 08, 2017 at 10:29:52AM -0700, Badhri Jagan Sridharan wrote: > > On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman > > wrote: > > > On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: > > >> The s

Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON

2017-09-09 Thread Greg KH
On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote: > This patch is the fix for the below checkpatch issue: > CHECK: Avoid crashing the kernel - try using WARN_ON & > recovery code rather than BUG() or BUG_ON() > + BUG(); > > Ideally this condition should never occur. But even if occu

[PATCH] staging: rtl8723bs: Do not initialise statics to 0

2017-09-09 Thread Harsha Sharma
Static variables are initialised to 0 by gcc Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 48 ++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/o

RE: [PATCH 1/1] x86/hyper-V: Allocate the IDT entry early in boot

2017-09-09 Thread KY Srinivasan
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Saturday, September 9, 2017 2:40 AM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

RE: [PATCH 1/1] x86/hyper-V: Allocate the IDT entry early in boot

2017-09-09 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Saturday, September 9, 2017 4:04 AM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.

[PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Harsha Sharma
This coding style (foo *bar) is more common for the kernel code. Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os

Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Greg KH
On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote: > This coding style (foo *bar) is more common for the kernel code. You also did something else in this patch that you did not mention here, which is not ok :( Remember, only one type of thing per patch. thanks, greg k-h

Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps

2017-09-09 Thread Guenter Roeck
On 09/08/2017 12:13 PM, Greg Kroah-Hartman wrote: On Fri, Sep 08, 2017 at 10:29:52AM -0700, Badhri Jagan Sridharan wrote: On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman wrote: On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: The source and sink caps should follow th

Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps

2017-09-09 Thread Guenter Roeck
On 09/09/2017 09:54 AM, Guenter Roeck wrote: On 09/08/2017 12:13 PM, Greg Kroah-Hartman wrote: On Fri, Sep 08, 2017 at 10:29:52AM -0700, Badhri Jagan Sridharan wrote: On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman wrote: On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wro

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and return statements to return the value > directly. Done using coccinelle. Coccinelle is not always perfect about pretty printing, so you have to watch out for it. > > @@ > local idexpression ret; > expression e; > @@ > > -ret

Re: [Outreachy kernel] [PATCH] staging: sm750fb: Remove extra blank lines

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Harsha Sharma wrote: > This was reported by checkpatch.pl > > Signed-off-by: Harsha Sharma Acked-by: Julia Lawall > --- > drivers/staging/sm750fb/sm750_cursor.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_cursor.c > b/driver

Re: [Outreachy kernel] [PATCH v4] Staging: ccree: Merge assignment with return

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Srishti Sharma wrote: > Merge the assignment and the return statements to return the value > directly. Done using coccinelle. > > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Srishti Sharma Acked-by: Juli

[PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

2017-09-09 Thread Harsha Sharma
This coding style (foo *bar) is more common for the kernel code. Change foo* bar to foo *bar. Change foo * bar to foo *bar. Change (foo*) to (foo *). Signed-off-by: Harsha Sharma --- Change in v2: -Updated log message and subject drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +- 1

[PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Harsha Sharma
Use one space around most binary operators Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Julia Lawall
On Sat, 9 Sep 2017, Harsha Sharma wrote: > Use one space around most binary operators > > Signed-off-by: Harsha Sharma > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rtl87

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Add spaces around '=', '|', '<<'

2017-09-09 Thread Julia Lawall
On Sun, 10 Sep 2017, Harsha Sharma wrote: > Hi,Thanks for your feedback. > I checked patch with checkpatch.pl and thought will add spaces around '+' in > another patch as there are no. of such warnings. > Should I add them in this patch only or send another patch for it? Indeed, I only looked a

[PATCH 1/2] staging: rtl8723bs: Convert LIST_CONTAINOR to use kernel container_of

2017-09-09 Thread Joe Perches
These are similar macros so use the normal kernel one. As well, there are odd games being played with casting a plist to a union recv_frame by using LIST_CONTAINOR. Just use a direct cast to union recv_frame instead. Signed-off-by: Joe Perches --- drivers/staging/rtl8723bs/core/rtw_recv.c

[PATCH 1/2] staging: rtl8723bs: convert private allocation functions to return void *

2017-09-09 Thread Joe Perches
Using char * for a return from allocation functions means the code has to cast generic allocations to specific types. Allow the compiler to not need casts on the allocations. Signed-off-by: Joe Perches --- drivers/staging/rtl8723bs/include/osdep_service.h | 4 ++-- drivers/staging/rtl8723bs/os

[PATCH 2/2] staging: rtl8723bs: Remove unnecessary rtw_z?malloc casts

2017-09-09 Thread Joe Perches
These functions now return void * and no longer need casts. Signed-off-by: Joe Perches --- drivers/staging/rtl8723bs/core/rtw_ap.c | 10 ++- drivers/staging/rtl8723bs/core/rtw_cmd.c | 84 +++ drivers/staging/rtl8723bs/core/rtw_mlme.c | 8 +-- drive

[PATCH 0/2] staging: rtl8723bs: Convert allocation returns from u8 * to void *

2017-09-09 Thread Joe Perches
Joe Perches (2): staging: rtl8723bs: convert private allocation functions to return void * staging: rtl8723bs: Remove unnecessary rtw_z?malloc casts drivers/staging/rtl8723bs/core/rtw_ap.c | 10 ++- drivers/staging/rtl8723bs/core/rtw_cmd.c | 84 +++ driv

[PATCH 2/2] staging: rtl8723bs: Convert LIST_CONTAINOR to container_of

2017-09-09 Thread Joe Perches
Use the normal kernel macro. Remove the now ununsed LIST_CONTAINOR macro. Signed-off-by: Joe Perches --- drivers/staging/rtl8723bs/core/rtw_ap.c| 16 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_debug.c | 4 +

Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

2017-09-09 Thread Joe Perches
On Sat, 2017-09-09 at 18:50 +0200, Greg KH wrote: > On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote: > > This coding style (foo *bar) is more common for the kernel code. > > You also did something else in this patch that you did not mention here, > which is not ok :( what is that?

E-Book "Kredit"

2017-09-09 Thread Marcel Ziegler
Hallo, ich biete auf http://www.kreditzentrale.com/thema/kredit-angebote ein E-Book mit dem Titel "Kredit" zum kostenlosen Download an. Da ich bei meiner Themen-Recherche auch Ihre Webseite gefunden habe, dachte ich, das könnte Sie interessieren. Wäre es möglich, dass Sie meine Webseite bzw. d

[PATCH v2] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
Merge the assignment and return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma --- Changes in v2: -Correct coding style problems driv

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

2017-09-09 Thread Srishti Sharma
On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. > > Coccinelle is not always perfect about pretty printing, so you have to > watch out for it

[PATCH 0/5] Drivers: hv: Miscellaneous fixes

2017-09-09 Thread kys
From: "K. Y. Srinivasan" Miscellaneous fixes. Dexuan Cui (2): vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() vmbus: suppress uevents for hv_sock devices Olaf Hering (1): Drivers: hv: fcopy: restore correct transfer length Stephen Hemminger (2): vmbus: add per-channe

[PATCH 2/5] vmbus: suppress uevents for hv_sock devices

2017-09-09 Thread kys
From: Dexuan Cui hv_sock driver is automatically loaded when an application creates an AF_VSOCK socket, so we don't really need to trigger uevents to the user space udevd. And hv_sock devices can appear and disappear frequency, e.g. 100 per second, so triggering the udevents can cause a high cpu

[PATCH 5/5] Drivers: hv: vmbus: Expose per-channel event counters

2017-09-09 Thread kys
From: Stephen Hemminger When investigating performance, it is useful to be able to look at the number of host and guest events per-channel. This is equivalent to per-device interrupt statistics. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- Documentation/ABI/stable/sysf

[PATCH 3/5] Drivers: hv: fcopy: restore correct transfer length

2017-09-09 Thread kys
From: Olaf Hering Till recently the expected length of bytes read by the daemon did depend on the context. It was either hv_start_fcopy or hv_do_fcopy. The daemon had a buffer size of two pages, which was much larger than needed. Now the expected length of bytes read by the daemon changed slight

[PATCH 1/5] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister()

2017-09-09 Thread kys
From: Dexuan Cui Due to commit 54a66265d675 ("Drivers: hv: vmbus: Fix rescind handling"), we need this patch to resolve the below deadlock: after we get the mutex in vmbus_hvsock_device_unregister() and call vmbus_device_unregister() -> device_unregister() -> ... -> device_release() -> vmbus_dev

[PATCH 4/5] vmbus: add per-channel sysfs info

2017-09-09 Thread kys
From: Stephen Hemminger This extends existing vmbus related sysfs structure to provide per-channel state information. This is useful when diagnosing issues with multiple queues in networking and storage. The existing sysfs only displayed information about the primary channel. The one place it re

[PATCH] staging: ccree: Add missing newlines

2017-09-09 Thread Joe Perches
Logging without newlines are still prone to interleaving. Add newlines where necessary. Miscellanea: o Coalesce formats o Realign arguments o Fix a couple misindented lines with the above logging changes Signed-off-by: Joe Perches --- drivers/staging/ccree/ssi_aead.c| 17 ++-- drivers