correct the following warning from checkpatch.pl:-
WARNING: Prefer using '"%s...", __func__' to using 'speak_char', this
function's name, in a string
Signed-off-by: Justin Skists
Acked-by: Samuel Thibault
---
drivers/staging/speakup/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Let me try send a v2 and see what you think.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> On Aug 31, 2017, at 1:54 PM, Stefan Hajnoczi wrote:
>
> On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote:
>>> On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote:
>> If we allow multiple host side transports, virtio host side support and
>> vmci should be able to coexist regardless
When a virtual device is added dynamically (via host console), then
the vmbus sends an offer message for the primary channel. The processing
of this message for networking causes the network device to then
initialize the sub channels.
The problem is that setting up the sub channels needs to wait u
This is one fix for problems with hot add of network device
on Windows Server.
Stephen Hemminger (1):
hv_netvsc: fix deadlock on hotplug
drivers/net/hyperv/hyperv_net.h | 1 +
drivers/net/hyperv/netvsc_drv.c | 8 +--
drivers/net/hyperv/rndis_filter.c | 106 ++---
With gcc-4.1.2:
drivers/staging/pi433/rf69.c: In function ‘rf69_set_dio_mapping’:
drivers/staging/pi433/rf69.c:566: warning: ‘regaddr’ may be used
uninitialized in this function
drivers/staging/pi433/rf69.c:565: warning: ‘shift’ may be used
uninitialized in this function
drivers/
Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
Signed-off-by: Harsha Sharma
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 6b9b7df..6a10
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, September 6, 2017 11:19 AM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org
> Subject: [PATCH net-next 1/1] hv_netvsc:
Please find enclosed in the next two emails the two patches for LU-6808 ported
to the in-tree staging lustre client driver in the 4.12 release.
https://jira.hpdd.intel.com/browse/LU-6808
Fan Yong (1):
LU-6808 ptlrpc: properly set "rq_xid" for 4MB IO
Niu Yawei (1):
LU-6808 ptlrpc: no need to
From: Niu Yawei
It's not necessary reassgin & re-adjust rq_mbits for replay
request in ptlrpc_set_bulk_mbits(), they all must have already
been correctly assigned before.
Such unecessary reassign could make the first matchbit not
PTLRPC_BULK_OPS_MASK aligned, that'll trigger LASSERT in
ptlrpc_re
From: Fan Yong
The commit d099fdd6 replaced the "rq_xid" with "rq_mbits" as
the matchbits of bulk data transferring. To be interoperable
with old servers, it introduced the new connection flag:
OBD_CONNECT_BULK_MBITS. If the server does not support such
feature, then the "rq_xid" would be set the
On Wed, 6 Sep 2017 16:23:45 +
Haiyang Zhang wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Wednesday, September 6, 2017 11:19 AM
> > To: KY Srinivasan ; Haiyang Zhang
> > ; Stephen Hemminger
> > Cc: de...@linuxdriverproject.org
On Wed, Sep 06, 2017 at 12:04:04PM -0400, Tyson Whitehead wrote:
> Please find enclosed in the next two emails the two patches for LU-6808
> ported to the in-tree staging lustre client driver in the 4.12 release.
What does that mean? What can I do with these? 4.12 is about to be
end-of-life in
Correct spelling of counter in comment .
Signed-off-by: Srishti Sharma
---
drivers/staging/ccree/ssi_cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers/s
On Wednesday, September 6, 2017 7:28:52 PM EDT Greg Kroah-Hartman wrote:
> On Wed, Sep 06, 2017 at 12:04:04PM -0400, Tyson Whitehead wrote:
> > Please find enclosed in the next two emails the two patches for LU-6808
> > ported to the in-tree staging lustre client driver in the 4.12 release.
>
> W
On Sun, Sep 03, 2017 at 11:56:50AM +0300, Gilad Ben-Yossef wrote:
> @@ -1154,7 +1150,8 @@ static inline int ssi_buffer_mgr_aead_chain_data(
> //if have reached the end of the sgl, then this is unexpected
> if (!areq_ctx->src_sgl) {
> SSI_LOG_ERR("re
> From: Jorgen S. Hansen [mailto:jhan...@vmware.com]
> Sent: Wednesday, September 6, 2017 7:11 AM
>> ...
> > I'm currently working on NFS over AF_VSOCK and sock_diag support (for
> > ss(8) and netstat-like tools).
> >
> > Multi-transport support is lower priority for me at the moment. I'm
> > happ
On Wed, 6 Sep 2017, Srishti Sharma wrote:
>
>
> On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma
> wrote:
> Correct spelling of counter in comment .
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_cipher.c | 2 +-
> 1 file
Only need to wakeup the initiator after all sub-channels
are opened.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/rndis_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c
b/drivers/net/hyperv/rndis_filter.c
index 731bc7c
One serious deadlock, and one minor optimization.
Stephen Hemminger (2):
hv_netvsc: fix deadlock on hotplug
hv_netvsc: avoid unnecessary wakeups on subchannel creation
drivers/net/hyperv/hyperv_net.h | 3 +
drivers/net/hyperv/netvsc.c | 3 +
drivers/net/hyperv/netvsc_drv.c | 1
When a virtual device is added dynamically (via host console), then
the vmbus sends an offer message for the primary channel. The processing
of this message for networking causes the network device to then
initialize the sub channels.
The problem is that setting up the sub channels needs to wait u
Edited comment to make it more comprehensible.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
drivers/staging/ccree/ssi_cipher.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Edited comment to make it more comprehensible.
>
> Signed-off-by: Srishti Sharma
> ---
> Changes in v2:
> - Make comment more comprehensible , instead of just correcting typos.
> drivers/staging/ccree/ssi_cipher.c | 4 +++-
> 1 file changed, 3 inser
On Thu, Sep 7, 2017 at 2:28 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Edited comment to make it more comprehensible.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> Changes in v2:
>> - Make comment more comprehensible , instead of just correcting typos.
>> drive
On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_cipher.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c
>
On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/ccree/ssi_cipher.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletio
Remove local variable inflight_counter ,as it is never used.
Signed-off-by: Srishti Sharma
---
Changes in v3:
- There was no longer a need to make the comment more comprehensible as
I have deleted the variable associated with it because it is unused .
drivers/staging/ccree/ssi_cipher.c | 5 +
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove local variable inflight_counter ,as it is never used.
"counter ,as" -> "counter, as"
> Signed-off-by: Srishti Sharma
> ---
> Changes in v3:
> - There was no longer a need to make the comment more comprehensible as
>I have deleted the var
On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Remove local variable inflight_counter ,as it is never used.
>
> "counter ,as" -> "counter, as"
>
>> Signed-off-by: Srishti Sharma
>> ---
>> Changes in v3:
>> - There was no longer a need to
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
> >
> >
> > On Thu, 7 Sep 2017, Srishti Sharma wrote:
> >
> >> Remove local variable inflight_counter ,as it is never used.
> >
> > "counter ,as" -> "counter, as"
> >
> >> Signed-off-by: Srishti Shar
On Thu, Sep 7, 2017 at 2:56 AM, Julia Lawall wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall wrote:
>> >
>> >
>> > On Thu, 7 Sep 2017, Srishti Sharma wrote:
>> >
>> >> Remove local variable inflight_counter ,as it is never used.
>> >
>> > "
Always compile your patches.
CC [M] drivers/staging/ccree/ssi_cipher.o
drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
‘inflight_counter’ [-Wunused-variable]
u32 inflight_counter;
^
On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
> ‘inflight_counter
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not based on the original patch, hence
crc32_init is using unnecessary else condition. Cleaningup this function
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 42 +--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_securi
On Thu, 2017-09-07 at 00:32 +0300, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
> ‘inflight_coun
One last detail. The subject line above is not in the same format as that
of all of the other subject lines one commits affecting this file. You
can use git log --oneline to see what others have done. It is not really
possible to guess correctly. However, one does not generally include the
exte
37 matches
Mail list logo
