On Fri, 2017-07-28 at 08:59 -0700, Stephen Hemminger wrote:
> This includes a bunch of fixups for issues reported by
> lockdep.
> * ethtool routines can assume RTNL
> * send is done with RCU lock (and BH disable)
> * avoid refetching internal device struct (netvsc)
> instead pass it a
This patch solves the following warning shown by the checkpatch script
WARNING: Comparisons should place the constants on the right side of
the test
Signed-off-by: Janani Sankara Babu
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
This patch is created to solve the following coding style issue reported
by the checkpatch script.
CHECK: spaces preffered around that '&' (ctx:VxV)
Signed-off-by: Janani Sankara Babu
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
This patch is created to solve the CamelCase issue. The members 'IEs' and
'IELength' of struct wlan_bssid_ex are being modified to 'ies' and
'ie_length' to solve the issue. And all the places where these variables
are referenced inside the rtl8188eu driver are also changed.
Signed-off-by: Janani
Smatch is distrustful of the "capab" value and marks it as user
controlled. I think it actually comes from the firmware? Anyway, I
looked at other drivers and they added a bounds check and it seems like
a harmless thing to have so I have added it here as well.
Signed-off-by: Dan Carpenter
diff
Dan Carpenter writes:
> Smatch is distrustful of the "capab" value and marks it as user
> controlled. I think it actually comes from the firmware? Anyway, I
> looked at other drivers and they added a bounds check and it seems like
> a harmless thing to have so I have added it here as well.
>
>
On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
>
> Signed-off-by: Shurong Zhang
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/
On Thu, Aug 24, 2017 at 02:58:06PM +0530, Janani Sankara Babu wrote:
> This patch is created to solve the CamelCase issue. The members 'IEs' and
> 'IELength' of struct wlan_bssid_ex are being modified to 'ies' and
> 'ie_length' to solve the issue. And all the places where these variables
> are ref
On 08/24/2017 07:14 AM, Kalle Valo wrote:
Dan Carpenter writes:
Smatch is distrustful of the "capab" value and marks it as user
controlled. I think it actually comes from the firmware? Anyway, I
looked at other drivers and they added a bounds check and it seems like
a harmless thing to have
This printk doesn't really add anything worthwhile.
Signed-off-by: Shurong Zhang
---
drivers/staging/olpc_dcon/olpc_dcon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
b/drivers/staging/olpc_dcon/olpc_dcon.c
index f7f3a78..82bffd9 100644
--- a/drive
This is a patch to the ion_cma_heap.c file in
/drivers/staging/andrioid/ion that fixes a blank line and
kmalloc size warning found by the checkpatch.pl tool.
Signed-off-by: Abhishek V Ashok
---
drivers/staging/android/ion/ion_cma_heap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
On Tue, Aug 22, 2017 at 09:40:01PM +, Dexuan Cui wrote:
> > From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
> > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote:
> > > > > +static bool hvs_stream_allow(u32 cid, u32 port)
> > > > > +{
> > > > > + static const u32 valid_cids[] =
On 08/24/2017 08:40 AM, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
>
You've done two things in this patch, please stick to a single
change per patch.
>
On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Applied to pci/misc for v4.14, thanks!
> ---
> drivers/pci/endpoint/pci-epf
On Sat, 19 Aug 2017, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/i2c/soc_camera/mt9t031.
On Sat 19 Aug 01:22 PDT 2017, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Applied, thanks.
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_core.c | 2 +-
>
Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 08/24/2017 05:08 AM, Dan Carpenter wrote:
Smatch is distrustful of the "capab" value and marks it as user
controlled. I think it actually comes from the firmware? Anyway, I
looked at other drivers and they added a bounds check and it seems like
a harmless thing to have so I have added it her
On 08/23/2017 10:07 AM, Colin King wrote:
From: Colin Ian King
The call to _rtl_dbg_trace via macro HALMAC_RT_TRACE will trigger a null
pointer deference on the null driver_adapter. Fix this by assigning
driver_adapter earlier to halmac_adapter->driver_adapter before the tracing
call so that a
On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
gcc notices a very complicated way to check a value
for being equal to one, and warns about it:
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c: In function
'halbtc8822b1ant_set_ext_ant_switch':
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c
On Thu, Aug 24, 2017 at 09:10:50PM +0530, Abishek V Ashok wrote:
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct
> ion_buffer *buffer,
> if (!pages)
> return -ENOMEM;
>
> - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> + table =
On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
Like the version in drivers/net/wireless, this driver requires the
MAC80211 framework, otherwise we run into a link error:
ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlw
On Wed, Aug 23, 2017 at 08:46:41AM -0700, Sherry Yang wrote:
> Binder driver allocates buffer meta data in a region that is mapped
> in user space. These meta data contain pointers in the kernel.
>
> This patch allocates buffer meta data on the kernel heap that is
> not mapped in user space, and u
On Thu, 2017-08-24 at 21:10 +0530, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c
> b/drivers/sta
The changes in this commit are also being sent to the main rtlwifi
drivers in wireless-next; however, these changes will also be useful for
any debugging of r8822be before it gets moved into the main tree.
Use debugfs to dump register and btcoex status, and also write registers
and h2c.
We create
On Fri, 11 Aug 2017 10:03:59 -0700
k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> This patch handles the following issues that were observed when we are
> handling racing channel offer message and rescind message for the same
> offer:
>
> 1. Since the host does not respond to m
These are false positives; lockdep is complaining about things that are safe
It is just that annotations were missing or incorrect.
-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org]
Sent: Thursday, August 24, 2017 1:37 AM
To: Stephen Hemminger ; KY Srinivasan
; Haiyan
Rename dftEpsId variable to dft_eps_ID to be consistent with other
variables in the source file.
Signed-off-by: Nick Fox
---
drivers/staging/gdm724x/hci_packet.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724
On Thu, Aug 24, 2017 at 02:23:08PM -0500, Larry Finger wrote:
> On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> > Like the version in drivers/net/wireless, this driver requires the
> > MAC80211 framework, otherwise we run into a link error:
> >
> > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtl
On Thu, Aug 24, 2017 at 10:49:28AM +0800, Jisheng Zhang wrote:
> As noted in commit d0bdff0db809 ("staging: Fix build issues with new
> binder API"), we can add back the choice for 32bit ARM "once a 64bit
> __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
> 8091/2: add get_use
This reverts commit d0bdff0db809 ("staging: Fix build issues with new
binder API"), because commit e38361d032f1 ("ARM: 8091/2: add get_user()
support for 8 byte types") has added the 64bit __get_user_asm_*
implementation.
Signed-off-by: Jisheng Zhang
---
Since v2:
- fix the commit msg again.
From: Dexuan Cui
Date: Wed, 23 Aug 2017 04:52:14 +
> +#define VMBUS_PKT_TRAILER(sizeof(u64))
This is not the packet trailer, it's the size of the packet trailer.
Please make this macro name match more accurately what it is.
> + /* Have we sent the zero-length packet (FIN)? */
> +
On Thu, Aug 24, 2017 at 04:28:08PM -0500, Larry Finger wrote:
> The changes in this commit are also being sent to the main rtlwifi
> drivers in wireless-next; however, these changes will also be useful for
> any debugging of r8822be before it gets moved into the main tree.
>
> Use debugfs to dump
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, August 24, 2017 18:20
> > +#define VMBUS_PKT_TRAILER (sizeof(u64))
>
> This is not the packet trailer, it's the size of the packet trailer.
Thanks! I'll change it to VMBUS_PKT_TRAILER_SIZE.
> > + /* Have we sent the zero-lengt
34 matches
Mail list logo
