Hallo Hans :-)
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
> On some devices the USB Type-C port power (USB PD 2.0) negotiation is
> done by a separate port-controller IC, while the current limit is
> controlled through another (charger) IC.
>
> It has been decided to model this by mode
Hi Hans,
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
> Now that drivers/i2c/busses/i2c-cht-wc.c uses
> "input-current-limit-from-supplier" instead of "extcon-name" the last
> user of the bq24190 extcon code is gone, remove it.
>
> Signed-off-by: Hans de Goede
> ---
> drivers/power/supp
Hi Hans,
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
> Register the 5V boost converter as a regulator named
> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because
> the bq24190 family is also used on ACPI devices where there are no
> device-tree phandles, so regulator_g
Hi,
On 08-08-17 10:39, Liam Breck wrote:
Hi Hans,
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
Register the 5V boost converter as a regulator named
"regulator-bq24190-usb-vbus". Note the name includes "bq24190" because
the bq24190 family is also used on ACPI devices where there are no
Hi,
On 08-08-17 10:24, Liam Breck wrote:
Hallo Hans :-)
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
On some devices the USB Type-C port power (USB PD 2.0) negotiation is
done by a separate port-controller IC, while the current limit is
controlled through another (charger) IC.
It ha
Hi,
On 08-08-17 10:27, Liam Breck wrote:
Hi Hans,
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
Now that drivers/i2c/busses/i2c-cht-wc.c uses
"input-current-limit-from-supplier" instead of "extcon-name" the last
user of the bq24190 extcon code is gone, remove it.
Signed-off-by: Hans d
dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by work with const
dev_pm_ops. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/ccree/ssi_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 08/08/17 08:42, Chi-Chun Hsu wrote:
Fixed a coding style issue.
Signed-off-by: Chi-Chun Hsu
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c
b/drivers/staging/comedi
On Mon, Aug 07, 2017 at 09:20:05PM +0200, Hans de Goede wrote:
> On 07-08-17 17:41, Mark Brown wrote:
> > I2C has a perfectly good platform_data pointer in the board info for
> > this stuff.
> True, so you are suggesting that I define a bq24190_platform_data
> struct with a regulator_init_data po
On Fri, Aug 04, 2017 at 02:09:45PM +0200, Julia Lawall wrote:
> These videobuf_queue_ops structures are only passed as the second
> argument to videobuf_queue_vmalloc_init, which is declared as const.
> Thus the videobuf_queue_ops structures themselves can be const.
>
> Done with the help of Cocci
As noted in commit d0bdff0db809 ("staging: Fix build issues with new
binder API"), we can add back the choice for 32bit ARM "once a 64bit
__get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
8091/2: add get_user() support for 8 byte types") has added the
support, so it's time to l
Hi Arnd,
Am Mittwoch, den 26.07.2017, 15:53 +0200 schrieb Arnd Bergmann:
> When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is
> built-in, we get a link error:
>
> drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind':
> etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34):
The structures of type v4l2_subdev_ops are only passed as the second
argument of v4l2_subdev_init or as the third argument of
v4l2_i2c_subdev_init, both of which are const. The structures of type
v4l2_subdev_core_ops, v4l2_subdev_pad_ops, v4l2_subdev_sensor_ops,
v4l2_subdev_video_ops are only stor
These structures are both stored in fields of v4l2_subdev_ops
structures, all of which are const, so these structures can be
const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/staging/media/atomisp/i2c/ap1302.c |2 +-
drivers/staging/media/atomisp/i2c
> This patch is incomplete (the 'tsk_Current' member is also used in
> "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by
> "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in
> kernel version 4.9 by commit a6672530f6fc ("staging: comedi: addi_apci_3
This patch is intended to fix coding style issues in order to comply
with kernel coding style guide as requested by TODO file.
It fixes the following checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
Note:
"WARNING: line over 80 characters" remains valid here and could be fixed
by ano
On 2017-08-07 11:21, Daniel Vetter wrote:
> On Fri, Aug 04, 2017 at 12:45:06PM +0200, Peter Rosin wrote:
>> The redundant fb helpers .load_lut, .gamma_set and .gamma_get are
>> no longer used. Remove the dead code that was not doing anything
>> sensible anyway.
>>
>> Signed-off-by: Peter Rosin
>>
Reviewed-by: Marcus Wolf
Thank you Marcin!
> Marcin Ciupak hat am 8. August 2017 um 15:54
> geschrieben:
>
>
> This patch is intended to fix coding style issues in order to comply
> with kernel coding style guide as requested by TODO file.
>
> It fixes the following checkpatch.pl error:
>
> ERR
I'm all for fixing memory leaks, but freeing a block while it is still
being used is a recipe for hard-to-debug kernel exceptions.
1) There is already a vchi method for freeing the instance, so use it.
2) Only call it on error, and then only before initted is false.
Signed-off-by: Phil Elwell
Fi
On Mon, 2017-08-07 at 21:44 +0800, Geliang Tang wrote:
> Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc()
> /atomisp_kernel_zalloc().
>
> Signed-off-by: Geliang Tang
Definitely better now we have kvmalloc/kvzalloc.
Thanks
Alan
___
devel
On 3 August 2017 at 18:53, Dan Carpenter wrote:
> On Thu, Aug 03, 2017 at 06:23:54PM +0530, hari prasath wrote:
>> On 3 August 2017 at 11:52, kbuild test robot wrote:
>> > Hi Hari,
>> >
>> > [auto build test WARNING on staging/staging-testing]
>> > [also build test WARNING on next-20170802]
>> >
On Wed, Aug 02, 2017 at 01:11:06AM -0700, Joe Perches wrote:
> On Wed, 2017-08-02 at 18:00 +1000, Sergei A. Trusov wrote:
> > The calloc function returns either a null pointer or a pointer to the
> > allocated space. Add the second case that is missed.
>
> gads.
>
> Bug added by commit da22013f7d
This patch fixes the behavior of the hv_set_ifconfig script when setting
the interface ip. Sometimes the interface has already been configured by
network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
exists error"; in order to avoid this error this patch makes sure double
checks the
Stephen Hemminger writes:
> Previous fix was incomplete.
>
Not really related to this patch series (which btw fixes my issue,
thanks!), but I found one addition issue. Systemd fails to rename VF
interface:
kernel: mlx4_core 0002:00:02.0 eth2: joined to eth1
kernel: hv_netvsc 33b7a6f9-6736-451
Fixed a potential memory leak inside skb_ether_to_p80211()
When the wep_encrypt() fails the code return 2 directly
Which causes the p80211_wep->data dangling
Add a kfree statement to reclaim that memory allocated
Signed-off-by: Lynn Lei
---
drivers/staging/wlan-ng/p80211conv.c
On Tue, 08 Aug 2017 16:03:56 +0200
Vitaly Kuznetsov wrote:
> Stephen Hemminger writes:
>
> > Previous fix was incomplete.
> >
>
> Not really related to this patch series (which btw fixes my issue,
> thanks!), but I found one addition issue. Systemd fails to rename VF
> interface:
>
> kerne
Stephen Hemminger writes:
> On Tue, 08 Aug 2017 16:03:56 +0200
> Vitaly Kuznetsov wrote:
>
>> Stephen Hemminger writes:
>>
>> > Previous fix was incomplete.
>> >
>>
>> Not really related to this patch series (which btw fixes my issue,
>> thanks!), but I found one addition issue. Systemd fai
On Tue, 08 Aug 2017 17:24:03 +0200
Vitaly Kuznetsov wrote:
> Stephen Hemminger writes:
>
> > On Tue, 08 Aug 2017 16:03:56 +0200
> > Vitaly Kuznetsov wrote:
> >
> >> Stephen Hemminger writes:
> >>
> >> > Previous fix was incomplete.
> >> >
> >>
> >> Not really related to this patch s
Stephen Hemminger writes:
> On Tue, 08 Aug 2017 17:24:03 +0200
> Vitaly Kuznetsov wrote:
>
>> Stephen Hemminger writes:
>>
>> > On Tue, 08 Aug 2017 16:03:56 +0200
>> > Vitaly Kuznetsov wrote:
>> >
>> >> Stephen Hemminger writes:
>> >>
>> >> > Previous fix was incomplete.
>> >> >
>>
Make the structure const as it is only passed to the function
drm_fb_helper_prepare and the corresponding argument is of type
const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal
---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
The following would allow udev a chance at the device.
>From 37fb240a6107834c3dd3f57caede9d73b807f414 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger
Date: Tue, 8 Aug 2017 08:39:24 -0700
Subject: [PATCH] netvsc: delay setup of VF device
When VF device is discovered, delay bring it automatical
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.
Arvind Yadav (3):
[PATCH 1/3] staging: most: usb: constify usb_device_id
[PATCH 2/3] staging: rtl8188eu: constify us
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote:
> Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
> was incomplete and didn't update a check in binder_mmap(), causing all
> mmap() calls into the binder driver to fail.
>
> Signed-off-by: Martijn Coenen
> ---
> driv
On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote:
> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote:
> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
> > was incomplete and didn't update a check in binder_mmap(), causing all
> > mmap() calls into the bi
On Tue, Aug 8, 2017 at 11:08 AM, Greg KH wrote:
> On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote:
>> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen wrote:
>> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
>> > was incomplete and didn't update a check in b
On Tue, Aug 8, 2017 at 2:00 AM, Hans de Goede wrote:
> Hi,
>
> On 08-08-17 10:39, Liam Breck wrote:
>>
>> Hi Hans,
>>
>> On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
>>>
>>> Register the 5V boost converter as a regulator named
>>> "regulator-bq24190-usb-vbus". Note the name includes "bq24
Thanks Dan. I just noticed your mail after getting back from vacation.
Greg- what is the best remedy for this? As Dan mentions, line 3622
should be "e->cmd" instead of "cmd". This problem can't really cause
any damage, but results in bogus "cmd" in trace output and can cause
some stats to be incre
Hi,
On 08/08/2017 04:42 PM, Mark Brown wrote:
On Tue, Aug 08, 2017 at 02:56:46PM +0100, Hans de Goede wrote:
Hi,
Please don't take things off-list unless there is a really strong reason
to do so. Sending things to the list ensures that everyone gets a
chance to read and comment on things.
Hi,
On 08/08/2017 08:57 PM, Liam Breck wrote:
On Tue, Aug 8, 2017 at 2:00 AM, Hans de Goede wrote:
Hi,
On 08-08-17 10:39, Liam Breck wrote:
Hi Hans,
On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede wrote:
Register the 5V boost converter as a regulator named
"regulator-bq24190-usb-vbus". No
On Tue, Aug 08, 2017 at 01:33:54PM -0700, Todd Kjos wrote:
> Thanks Dan. I just noticed your mail after getting back from vacation.
>
> Greg- what is the best remedy for this? As Dan mentions, line 3622
> should be "e->cmd" instead of "cmd". This problem can't really cause
> any damage, but result
commit 26549d177410 ("binder: guarantee txn complete / errors delivered
in-order") passed the locally declared and undefined cmd
to binder_stat_br() which results in a bogus cmd field in a trace
event and BR stats are incremented incorrectly.
Change to use e->cmd which has been initialized.
Signe
Just submitted a bugfix.
On Tue, Aug 8, 2017 at 2:13 PM, Greg KH wrote:
> On Tue, Aug 08, 2017 at 01:33:54PM -0700, Todd Kjos wrote:
>> Thanks Dan. I just noticed your mail after getting back from vacation.
>>
>> Greg- what is the best remedy for this? As Dan mentions, line 3622
>> should be "e->
platform_get_irq() returns an error code, but the dim2_hdm driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/gi
From: Stephen Hemminger
Date: Mon, 7 Aug 2017 11:30:00 -0700
> Go back to switching datapath directly in the notifier callback.
> Otherwise datapath might not get switched on unregister.
>
> No need for calling the NOTIFY_PEERS notifier since that is only for
> a gratitious ARP/ND packet; but t
From: Eduardo Otubo
Date: Tue, 8 Aug 2017 15:53:45 +0200
> This patch fixes the behavior of the hv_set_ifconfig script when setting
> the interface ip. Sometimes the interface has already been configured by
> network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> exists error"; i
48 matches
Mail list logo
