Re: Send a large patch right now or is it better to do it later?

On Fri, Jul 28, 2017 at 05:16:56PM +0200, Marcus Wolf wrote: > Hi Greg, > > according to the proposals of Walter Harms, I revised the rf69.c: I replaced > some macros with inline functions and removed some obsolete ifdefs. According > to > walter this will improve the resource situation. In addi

Re: [PATCH] Staging: pi433: fix some warnings detected using sparse

On Fri, 2017-07-28 at 17:17 +0300, Dan Carpenter wrote: > On Fri, Jul 28, 2017 at 02:56:26PM +0200, Elia Geretto wrote: > > This patch corrects some visibility issues regarding some functions > > and > > solves a warning related to a non-matching union. After this patch, > > sparse produces only on

Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

Hi Greg, already had a discussion concerning that patch with Dan yesterday. I really don't know what's going on there. I detached the patch once more from my outbox and had a very close look in an editor and looked at it with a difftool. In my outbox the patch is fine. I really don't knwo why it

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

Hi Greg, also had a very close look to this patch. Even in your reply I can't find any problems with line wraps or other corruptions :-/ But we have alternative patches, solving these problems as well. You e.g. could use the patch [PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_

Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Hi Greg, there is another patch from me (see subject). I sent it 19/07/2017. Most probably, there is also something wrong with the patch, but maybe you can get it to work. The patch would be important. It doesn't fix any warnings or errors of static code analysis, but it fixes true implementati

[PATCH] staging: pi433: Use matching enum types calling rf69_set_packet_format

This patch fixes the following four warnings found using sparse: drivers/staging/pi433/pi433_if.c:211:9: warning: mixing different enum types drivers/staging/pi433/pi433_if.c:211:9: int enum optionOnOff versus drivers/staging/pi433/pi433_if.c:211:9: int enum packetFormat drivers/staging/p

Undelivered Mail Returned to Sender

This is the mail system at host vscan68.melbpc.org.au. I'm sorry to have to inform you that your message could not be delivered to one or more recipients. It's attached below. For further assistance, please send mail to postmaster. If you do so, please include this problem report. You can delete

Re: [PATCH v2] staging: octeon: fix line over 80 characters

Hi John, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/catalinnow-gmail-com/staging-oct

Re: Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

On Sat, Jul 29, 2017 at 11:16:11AM +0200, Marcus Wolf wrote: > Hi Greg, > > there is another patch from me (see subject). I sent it 19/07/2017. > > Most probably, there is also something wrong with the patch, but maybe you can > get it to work. > > The patch would be important. It doesn't fix a

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

On Sat, Jul 29, 2017 at 11:09:23AM +0200, Marcus Wolf wrote: > Hi Greg, > > also had a very close look to this patch. Even in your reply I can't find any > problems with line wraps or other corruptions :-/ > Here are the relevant lines from Greg's email: > +++ b/drivers/staging/pi433/rf69.c >

Re: Concerning [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Hi Dan, the "big" patch, I was telling about yesterday will touch exactly that file. So if you are planning deep changes, we will most probably run into conflicts. If I'll find some time (maybe tomorrow), I'll try to send that long patch, so you can see. Already nervous about next failing patch

Re: [PATCH] Staging: pi433: fix some warnings detected using sparse

/Staging-pi433-fix-some-warnings-detected-using-sparse/20170729-205713 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

[PATCH] Staging: rtl8723bs: Do not initialise static to 0.

Do not initialise static to 0. Static variables by default initialise to 0. This patch fixes the errors found by checkpatch. Signed-off-by: Shreeya Patel --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/c

Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

On Sat, Jul 29, 2017 at 10:51:15AM +0200, Marcus Wolf wrote: > Hi Greg, > > already had a discussion concerning that patch with Dan yesterday. > I really don't know what's going on there. I detached the patch once more from > my outbox and had a very close look in an editor and looked at it with

Re: [PATCH net-next v3 0/7] netvsc: minor fixes and optimization

From: Stephen Hemminger Date: Fri, 28 Jul 2017 08:59:40 -0700 > This is a subset of earlier submission with a few more fixes > found during testing. The are two small optimizations, one is to > better manage the receive completion ring, and the other is removing > one unneeded level of indirectio