Re: [PATCH] staging: vboxvideo: make a couple of symbols static

22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of sparse warnings: >> symbol

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

Reviewed-by: Marcus Wolf Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking the style rules - but for sur

Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs

Reviewed-by: Marcus Wolf >From my point of view, the rearrangement of the block of SET_CHECKED reduces >the readability a lot. I like same stuff to be aligned (all brakets below each other as a column, all spi->dev below each other and so on) But if it is necessary to fullfill the rules, we hav

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Reviewed-by: Marcus Wolf Thanks for your work, Derek! > Derek Robson hat am 22. Juli 2017 um 05:50 geschrieben: > > > Fixed the alignment of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/pi433/pi433_if.c | 38 +++-- > drivers/staging

[GIT PULL] Staging driver fixes and a new driver for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.13-rc2 for you to fetch changes up to 5a1d4c5dd4

[PATCH] staging: pi433: use IS_ERR to check kthread_run return value

Fix compiler warning: ordered comparison of pointer with integer zero Signed-off-by: Paolo Cretaro --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 1bc478a7f49e..79bd

Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value

On 22/07/2017 12:27, Paolo Cretaro wrote: > Fix compiler warning: ordered comparison of pointer with integer zero Sorry, just noticed a similar patch has been submitted a few days ago, please ignore this patch. Paolo > > Signed-off-by: Paolo Cretaro > --- > drivers/staging/pi433/pi433_if.c |

[PATCH] staging: vboxvideo: remove unused variables

Fix compiler warnings: vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used Signed-off-by: Paolo Cretaro --- drivers/staging/vboxvideo/vbox_mode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/st

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

invite Jack from expressif 在 2017/7/21 22:35, Quentin Schulz 写道: From: Hans de Goede Some sdio devices have a multiple stage bring-up process. Specifically the esp8089 (for which an out of tree driver is available) loads firmware on the first call to its sdio-drivers' probe function and then r

[PATCH] Staging: lustre: Place the open brace on previous line.

Remove errors by placing the open braces on previous line. This saves the vertical space of the code. Problem found by checkpatch. Signed-off-by: Shreeya Patel --- drivers/staging/lustre/lnet/libcfs/hash.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --g

Re: [PATCH] Staging: lustre: Place the open brace on previous line.

On Sat, 2017-07-22 at 22:26 +0530, Shreeya Patel wrote: > Remove errors by placing the open braces on previous line. > This saves the vertical space of the code. > > Problem found by checkpatch. No. These are checkpatch false positives. > diff --git a/drivers/staging/lustre/lnet/libcfs/hash.c

[PATCH 2/2] staging: wlan-ng: Fix the types of the hfa384x_comm_tallies_16/32 members

Running sparse revealed that the members of hfa384x_comm_tallies_16/32 were defined as u16/u32, but were actually used as __le16/__le32. This patch changes the member types to reflect their use. Signed-off-by: Christopher H Pezley --- drivers/staging/wlan-ng/hfa384x.h | 84 ++-

[PATCH 1/2] staging: wlan-ng: Fix the types of the hfa384x_commsquality members

Running sparse revealed that the members of hfa384x_commsquality were defined as u16, but were actually used as __le16: drivers/staging/wlan-ng/prism2sta.c:375:46: warning: cast to restricted __le16 This patch changes the member types to reflect their use. Signed-off-by: Christopher H Pezley --

Re: [PATCH] staging: vboxvideo: remove unused variables

Hi, On 22-07-17 12:55, Paolo Cretaro wrote: Fix compiler warnings: vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used Signed-off-by: Paolo Cretaro Patch looks good to me: Acked-by: Hans de Goede Regards,

Re: [PATCH v1 2/6] mei: Switch to use new generic UUID API

Hi Andy, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Convert-rest-users-to-new-

Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

Hi Andy, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc1] [cannot apply to next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Convert-

Re: [PATCH v1 5/6] uuid: Kill uapi/uuid.h

Hi Andy, [auto build test WARNING on linus/master] [also build test WARNING on v4.13-rc1] [cannot apply to next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/uuid-Conv

Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

Acked-by: Steve Longerbeam On 07/21/2017 09:21 AM, Arnd Bergmann wrote: Without this, I get a build error: drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt': drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit declaration of function 'v4l2_subdev_get_try_

Re: [PATCH v3 2/3] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission

On Wed, 19 Jul 2017 17:55:56 +0530 Jaya Durga wrote: > Replace symbolic permissions with their > octect representation to fix checkpatch warnings. > > Signed-off-by: Jaya Durga The IIO drivers in staging are handled via the iio tree on git.kernel.org from which Greg pulls a few times a cycle (w

Re: [PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

On Wed, 19 Jul 2017 17:55:57 +0530 Jaya Durga wrote: > CHECK: Macro argument reuse 'addr' - possible side-effects? > > convert AD7280A_DEVADDR to ad7280a_devaddr static function > to fix checkpath check > > v3: small style changes > > Signed-off-by: Jaya Durga This patch is fine so I've appl

[PATCH] media: imx: prpencvf: enable double write reduction

For the write channels with 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by at least 25% (more with rotation enabled). Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 11 +

Re: [PATCH] media: imx: prpencvf: enable double write reduction

Hi Philipp, This is the same as your patch to CSI, applied to ic-prpencvf. I'm not really sure what this cpmem bit is doing. The U/V planes in memory are already subsampled by 2 in both width and height. This must be referring to what the IDMAC is transferring on the bus, but why would it place