On Tue, Jun 20, 2017 at 10:56:43PM +0300, Dan Carpenter wrote:
> On Tue, Jun 20, 2017 at 05:11:51PM +0200, Christian Gromm wrote:
> > @@ -411,21 +428,31 @@ static int aim_rx_data(struct mbo *mbo)
> > struct sk_buff *skb;
> > struct net_device *dev;
> > unsigned int skb_len;
> > + int
Currently the media subsystem has a very creative abuse of the
KERNEL_VERSION macro to encode an arbitrary version triplet for media
drivers and device hardware revisions.
This series introduces a new macro called MEDIA_REVISION which encodes
a version triplet like KERNEL_VERSION does, but clearly
Use MEDIA_REVISION instead of KERNEL_VERSION to encode the
CX25821_VERSION_CODE.
Signed-off-by: Johannes Thumshirn
---
drivers/media/pci/cx25821/cx25821.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx25821/cx25821.h
b/drivers/media/pci/cx25821/cx25821.
Currently the media code abuses the KERNEL_VERSION macro to encode a
version triplet.
Introduce a MEDIA_REVISION macro to get rid of the confusing and
creative KERNEL_VERSION usage in the media subsystem.
Signed-off-by: Johannes Thumshirn
---
include/uapi/linux/media.h | 4 +++-
1 file changed,
Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver
version.
Signed-off-by: Johannes Thumshirn
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-core.c
b/drivers/media/platfor
Update the documentation to introduce the use of MEDIA_REVISON instead
of KERNEL_VERSION for the verison triplets of a media drivers hardware
revision or driver version.
Signed-off-by: Johannes Thumshirn
---
Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst| 2 +-
Documentation/media/
Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver
version of the Atom ISP driver.
Signed-off-by: Johannes Thumshirn
---
drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/inc
Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048
driver version.
Signed-off-by: Johannes Thumshirn
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/stag
Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use
MEDIA_REVISION instead.
Signed-off-by: Johannes Thumshirn
---
drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c
b/drivers
Ah. Thanks for the explanation.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Tue, 2017-06-20, 23:05 +0300-യ്ക്ക, Dan Carpenter എഴുതിയിരിക്കുന്നു:
> On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> > The locking and unlocking code used by copy routines is common, so
> > moved it to a macro.
> >
> > Signed-off-by: Dhananjay Balan
> > ---
> > drivers/stagi
On Wed, Jun 21, 2017 at 10:59:01AM +0200, Dhananjay Balan wrote:
> Tue, 2017-06-20, 23:05 +0300-യ്ക്ക, Dan Carpenter എഴുതിയിരിക്കുന്നു:
> > On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> > > The locking and unlocking code used by copy routines is common, so
> > > moved it to a m
Use the current logging style.
Coalesce formats where appropriate.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 ++-
1 file changed, 14 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> The locking and unlocking code used by copy routines is common, so
> moved it to a macro.
Ick, no, never "hide" locks like this, that's not good at all. We want
to see the locks in the code where it happens, otherwise it is not
ob
On Wed, 2017-06-21 at 17:49 +0530, simran singhal wrote:
> Use the current logging style.
> Coalesce formats where appropriate.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
[]
> @@ -236,8 +236,8 @@ ieee80211_rx_frame_mgmt
This structure member is hidden behind CONFIG_SYSFS, and we
get a build error when that is disabled:
drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no
member named 'num_rx_queues'; did you mean 'num_tx_que
> -Original Message-
> From: Arnd Bergmann [mailto:a...@arndb.de]
> Sent: Wednesday, June 21, 2017 6:17 PM
> To: Stephen Hemminger
> Cc: Arnd Bergmann ; KY Srinivasan ;
> Haiyang Zhang ; David S. Miller
> ; Simon Xiao ;
> de...@linuxdriverproject.org; net...@vger.kernel.org; linux-
> ker
On Thu, 22 Jun 2017 00:16:37 +0200
Arnd Bergmann wrote:
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_de
From: Jaya Durga
Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x'
may be better as '(x)' to avoid precedence issues.
Signed-off-by: Jaya Durga
---
drivers/staging/rtl8712/osdep_intf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os
19 matches
Mail list logo
