Make return value void since function never return meaningfull value
Signed-off-by: Yuval Shaia
Acked-by: Sergei Shtylyov
---
v0 ->v1:
* These files were missing in v0
* drivers/net/ethernet/renesas/ravb_main.c
* drivers/net/ethernet/renesas/sh_eth.c
This patch implements changes proposed by checkpatch.pl:
* Remove redundant lines.
* Don't use structure name to get size of memory to allocate.
Signed-off-by: Aliaksei Karaliou
---
drivers/staging/android/ion/ion_system_heap.c | 8 +++-
1 file changed, 3 insertions(+), 5 del
On Thu, May 18, 2017 at 03:56:26PM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote:
> > This patch adds tabs into macro definitions so all rhs are on same column.
> > Move MHz macro from ddk_chip.c to ddk_chip.h.
> >
> > Signed-off-by: Matej Dujava
> > ---
> >
On Tue, Jun 13, 2017 at 10:33:25AM +0300, Aliaksei Karaliou wrote:
> This patch implements changes proposed by checkpatch.pl:
> * Remove redundant lines.
> * Don't use structure name to get size of memory to allocate.
Please never do different things in the same patch, no matter how
"s
On Tue, Jun 13, 2017 at 11:57:59AM +0530, bincy_k_phi...@yahoo.co.in wrote:
> From: bincy
>
> Signed-off-by: bincy
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Also can not take this due to the previously reported issues.
thanks,
gre
On Tue, Jun 13, 2017 at 07:33:10AM +, Bincy K Philip wrote:
> Hi Greg,
> Thanks for the reply.I have send an updated patch.
> I am not sure why getting a Failure message from
> "linux-ker...@vger.kernel.org"
Because you are sending html email to a public mailing list that rejects
it.
Please
On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote:
> Remove redundant parenthesis
>
> Signed-off-by: Aviya Erenfeld
> ---
> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging
On Mon, Jun 12, 2017 at 10:45:38PM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> The following type mismatch warnings reported by sparse
> have been amended:
> warning: cast to restricted __le16
> warning: incorrect type in assignment (different base types)
>
> Signed-off-by: Suni
On Fri, Jun 09, 2017 at 04:30:52PM +0300, Roman Storozhenko wrote:
> Fixes a style problems. Replaces non-standard 'Lx' specifier with a
> standard 'llx'.
>
> Signed-off-by: Roman Storozhenko
> ---
> drivers/staging/lustre/lustre/fid/fid_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
On Thu, Jun 08, 2017 at 08:17:07PM +1200, Derek Robson wrote:
> Fix checkpatch.pl warnings of the form "function definition argument
> 'foo' should also have an identifier name" in header files.
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/sm750fb/sm750.h | 24
On Mon, Jun 05, 2017 at 09:31:36AM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
> rtsx_enter_ss
> rtsx_power_off_card
> sd_cleanup_work
> sd_stop_seq_mode
> s
On Sun, Jun 11, 2017 at 10:54:42AM +, ? ? wrote:
> From: Pan Li
>
> Makes header access happy by shared the memory between
> __le16 and u16.
Why are you indenting your changelog line?
And I can not understand this sentence, sorry, please be more
descriptive about why you are making a ch
On Sun, Jun 11, 2017 at 10:53:19AM +, ? ? wrote:
> From: Pan Li
>
> Convertn __le to cpu type when access pd_header count.
Please do not indent, and please spell check where ever possible.
thanks,
greg k-h
___
devel mailing list
de...@linuxdr
From: bincy
trivial fix for space alignment error
Signed-off-by: bincy
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c7ec71a 10064
From: bincy
trivial fix for space alignment error
Signed-off-by: bincy
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c7ec71a 10064
On Tue, Jun 13, 2017 at 03:25:12PM +0530, bincy_k_phi...@yahoo.co.in wrote:
> From: bincy
>
> trivial fix for space alignment error
>
> Signed-off-by: bincy
I need a "real" name here, somthing you sign legal documents with.
And you sent 2 copies of this patch, which one am I supposed to take?
From: bincy
trivial fix for space alignment error
Signed-off-by: bincy
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c7ec71a 10064
On Tue, Jun 06, 2017 at 10:00:38AM -0500, Ioana Radulescu wrote:
> Reorder fields in the device's private structure such that
> the ones most used on the hotpath are at the beginning of
> the structure.
>
> This brings a small performance improvement due to better
> cache usage.
Really? What kin
On Wed, Jun 07, 2017 at 11:57:08AM +0200, Antoine BLIN wrote:
> From: Antoine
>
> Fix the following sparse endianness warnings:
>
> drivers/staging/wlan-ng/prism2sta.c:1949:17: warning: cast to restricted
> __le16
> drivers/staging/wlan-ng/prism2sta.c:1949:17: warning: cast to restricted
> __l
Sorry for that and thank you for reply.
Regarding scripts/get_maintainer.pl, it seems that trying to avoid
disturbing too much people it turned out vice versa. And it was wrong
idea to ignoring vger mailing list since I need this patch to be in public.
Best regards,
Aliaksei.
Aliaksei Karaliou (1
Use variable name instead of structure name to get size
of memory to allocate as proposed by checkpatch.pl
Signed-off-by: Aliaksei Karaliou
---
drivers/staging/android/ion/ion_system_heap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ion/ion_
On Thu, Jun 08, 2017 at 05:28:47PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
>
> Several macros were triggering this checkpatch.pl warning:
> "Macro argument reuse '$arg' - possible side-effects?"
> Fix the warning by avoiding multiple macro argument use.
>
> Signed-off-by:
From: bincy
trivial fix for space alignment error
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c7ec
On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Stuart Yoder
>
> Move the source files out of staging into their final locations:
> -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
> -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
The driver may sleep under a spin lock, and the function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
sd_cleanup_work
sd_stop_seq_mode
sd_switch_clock
sd_ddr_tuning
sd_ddr_pre_tuning_
12.06.2017 18:03, Greg Kroah-Hartman wrote:
> On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 12-06-17 13:44, Greg Kroah-Hartman wrote:
>>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> The most important thing is for the driver to be atomic if
On Tue, Jun 13, 2017 at 03:45:32PM +0530, bincy_k_phi...@yahoo.co.in wrote:
> From: bincy
>
> trivial fix for space alignment error
>
> Signed-off-by: bincy k philip
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
First off, please slow
On Tue, Jun 13, 2017 at 01:50:16PM +0200, Michael Thayer wrote:
> 12.06.2017 18:03, Greg Kroah-Hartman wrote:
> > On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 12-06-17 13:44, Greg Kroah-Hartman wrote:
> >>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Go
On Sun, Jun 11, 2017 at 11:57:55PM +0530, Jaya Durga wrote:
> Fixed coding style issue
>
> Renamed IEs to ie_s
>
> Signed-off-by: Jaya Durga
Where are patches 1-6 for this series?
Please fix and resend.
thanks,
greg k-h
___
devel mailing list
de...
On Sun, Jun 11, 2017 at 11:57:57PM +0530, Jaya Durga wrote:
> Fixed coding style issue
>
> Renamed Ssid to ssid
> Renamed Ssid_Length to ssid_length
>
> Signed-off-by: Jaya Durga
Where are patches 1-8 of this series?
___
devel mailing list
de...@linu
On Mon, Jun 12, 2017 at 03:43:35PM -0400, Gabriel L. Somlo wrote:
> Signed-off-by: Gabriel Somlo
> ---
> drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can't take patches without any changelog test at all, sorry.
greg k-h
___
On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote:
> This patch adds spaces around the binary operators '-' and '+', which
> is the preferred style, and reformats a pointer argument declaration
> to fix a false positive "spaces preferred around that '*'" message
> reported by checkpatch.
On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote:
> Fixed alignment so that it matched open parenthesis.
>
> Signed-off-by: srishti sharma
> ---
> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dri
On Tue, Jun 13, 2017 at 02:58:43PM +0200, Greg KH wrote:
> On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote:
> > This patch adds spaces around the binary operators '-' and '+', which
> > is the preferred style, and reformats a pointer argument declaration
> > to fix a false positive "sp
On 12 June 2017 at 20:46, Fabian Wolff wrote:
> This patch adds spaces around the binary operators '-' and '+', which
> is the preferred style, and reformats a pointer argument declaration
> to fix a false positive "spaces preferred around that '*'" message
> reported by checkpatch.pl.
>
> Signed-
13.06.2017 14:48, Greg Kroah-Hartman wrote:
[Discussion of vboxvideo coding style.]
> Once your code is accepted into the main kernel tree, why would you
> continue to work in an out-of-tree repo anyway? That's ripe for
> disaster, what's keeping you from just working with the in-tree version?
On
Resolving checkpatch issue:
CHECK: 'successfuly' may be misspelled - perhaps 'successfully'?
Signed-off-by: Gabriel Somlo
---
On Tue, Jun 13, 2017 at 02:57:40PM +0200, Greg KH wrote:
> On Mon, Jun 12, 2017 at 03:43:35PM -0400, Gabriel L. Somlo wrote:
> > Signed-off-by: Gabriel Somlo
> > ---
> >
On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote:
> 13.06.2017 14:48, Greg Kroah-Hartman wrote:
> [Discussion of vboxvideo coding style.]
> > Once your code is accepted into the main kernel tree, why would you
> > continue to work in an out-of-tree repo anyway? That's ripe for
> > di
On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote:
> On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote:
>> Fixed alignment so that it matched open parenthesis.
>>
>> Signed-off-by: srishti sharma
>> ---
>> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
>> 1 file chan
Kernel style is to have spaces around the operators. This is staging
code so we do all the style fixes. We don't always update older drivers
but sometimes we do. No one is planning to change those drivers though
so I guess the answer is no we're not going to update those unless you
are?
regards
On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote:
> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote:
> > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote:
> >> Fixed alignment so that it matched open parenthesis.
> >>
> >> Signed-off-by: srishti sharma
> >> ---
> >> dr
13.06.2017 15:59, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote:
>> 13.06.2017 14:48, Greg Kroah-Hartman wrote:
>> [Discussion of vboxvideo coding style.]
>>> Once your code is accepted into the main kernel tree, why would you
>>> continue to work in an
On Tue, Jun 13, 2017 at 05:00:15PM +0200, Michael Thayer wrote:
> 13.06.2017 15:59, Greg Kroah-Hartman wrote:
> > On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote:
> >> 13.06.2017 14:48, Greg Kroah-Hartman wrote:
> >> [Discussion of vboxvideo coding style.]
> >>> Once your code is acc
Fixed WARNING: line over 80 characters
Signed-off-by: Jaya Durga
---
drivers/staging/rtl8712/ieee80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/rtl8712/ieee80211.c
index 97ef063..b823656 100644
--- a/drivers/stag
On Tue, Jun 13, 2017 at 01:50:16PM +0200, Michael Thayer wrote:
> 12.06.2017 18:03, Greg Kroah-Hartman wrote:
> > On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 12-06-17 13:44, Greg Kroah-Hartman wrote:
> >>> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Go
On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote:
> On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote:
> > This problem was found by strace ioctl list generator.
> >
> > Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and
> > ion_client")
As this commit fixes a
Greg is never going to merge your patches until you fix your numbering
so you may as well do that before anything else.
This patch fixes a bug in a patch which is never going to be merged so
it's not needed. Google "how to send a v2 patch".
regards,
dan carpenter
___
This patch improves the formatting of block comments and removes one
commented-out line of code entirely (keeping it would be redundant
thanks to version control).
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
v1->v2: refresh patch
drivers/staging/rtl8723bs/os_dep/wifi_re
This patch adds spaces around the binary operators '-' and '+'.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
v1->v2: apply changes only to arithmetic operators
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
This patch implements the suggestions of checkpatch.pl to remove
unnecessary spaces before function pointer arguments as well as in
statements of the form "foo * bar" (which should be "foo *bar").
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
v1->v2: refresh patch
drivers
This patch adjusts the alignment of several lines to match their
respective opening parenthesis.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
v1->v2: refresh patch
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
This patch inserts a missing blank line after variable declarations.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
v1->v2: refresh patch
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_
v1->v2: Refresh patches and restrict the first patch to arithmetic operators
This patch series fixes all errors and warnings generated by
checkpatch.pl for wifi_regd.c.
Fabian Wolff (5):
staging: rtl8723bs: wifi_regd.c: put spaces around binary operators
staging: rtl8723bs: wifi_regd.c: fix c
These are similar macros so use the normal kernel one.
As well, there are odd games being played with casting a plist to
a union recv_frame by using LIST_CONTAINOR. Just use a direct cast
to union recv_frame instead.
Signed-off-by: Joe Perches
---
drivers/staging/rtl8723bs/core/rtw_recv.c
Joe Perches (2):
staging: rtl8723bs: Convert LIST_CONTAINOR to use kernel container_of
staging: rtl8723bs: Convert LIST_CONTAINOR to container_of
This is basically a simple substitution of a spelling typo of a macro
with an addition to simplify some odd uses of the macro.
I have no objection
Fix the following sparse warnings:
prism2mib.c:717:45: warning: cast to restricted __le16
prism2mib.c:720:45: warning: incorrect type in assignment (different base types)
prism2mib.c:720:45:expected unsigned short [unsigned] [addressable]
[usertype] datalen
prism2mib.c:720:45:got restrict
Use the normal kernel macro.
Remove the now ununsed LIST_CONTAINOR macro.
Signed-off-by: Joe Perches
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 16
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_debug.c | 4 +
On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter wrote:
> On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote:
>> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH wrote:
>> > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote:
>> >> Fixed alignment so that it matched open parenthesis
The function converts strings like ttyS0 and ttyUSB0 to dev_t like
(4, 64) and (188, 0). Subsequent patch in this set will call it to
convert user-supplied device into device number. The function does
some basic sanity checks on the string passed in. It currently supports
ttyS*, ttyUSB* and, for se
Hi,
These patches extend speakup support to ttyUSB* and lp*. They introduce
a new module param dev whose function is similar to ser but instead of
taking serial port number as argument, it takes strings like ttyS0 or
ttyUSB0. First patch just adds functionality to convert such strings
into dev_t.
This patch introduces new module parameter, dev, which takes a string
representing the device that the external synth is connected to, e.g.
ttyS0, ttyUSB0 etc. This is then used to communicate with the synth.
That way, speakup can support more than ttyS*. As of this patch, it
only supports ttyS*, t
On Fri, 9 Jun 2017 15:27:33 +0200
Vitaly Kuznetsov wrote:
> To support implementing remote TLB flushing on Hyper-V with a hypercall
> we need to make vp_index available outside of vmbus module. Rename and
> globalize.
>
> Signed-off-by: Vitaly Kuznetsov
> Reviewed-by: Andy Shevchenko
This is
Stephen Hemminger writes:
> On Fri, 9 Jun 2017 15:27:33 +0200
> Vitaly Kuznetsov wrote:
>
>> To support implementing remote TLB flushing on Hyper-V with a hypercall
>> we need to make vp_index available outside of vmbus module. Rename and
>> globalize.
>>
>> Signed-off-by: Vitaly Kuznetsov
>>
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, June 13, 2017 19:29
>
> Stephen Hemminger writes:
>
> > On Fri, 9 Jun 2017 15:27:33 +0200
> > Vitaly Kuznetsov wrote:
> >
> >> To support implementing remote TLB flushing on Hyper-V with a
> >> hypercall we need to make vp_
On Tue, Jun 13, 2017 at 09:17:05PM +0300, Gleb Fotengauer-Malinovskiy wrote:
> On Tue, May 30, 2017 at 04:33:57PM -0700, Laura Abbott wrote:
> > On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote:
> > > This problem was found by strace ioctl list generator.
> > >
> > > Fixes: 15c6098cfec5 (
On Wed, Jun 14, 2017 at 03:15:11AM +0530, srishti sharma wrote:
> On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter
> wrote:
> > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote:
> >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH
> >> wrote:
> >> > On Sat, Jun 10, 2017 at 02:37:22AM +0530
Driver ks7010 does not currently have a maintainer.
Take ownership of the driver and add an entry for the ks7010 driver to
the maintainers database.
Signed-off-by: Tobin C. Harding
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f6ef3f3
Current driver implements the WEXT interface. WEXT is in maintenance
mode, we need to re-write the driver using the cfg80211 API. The current
driver is handy as a reference for the new implementation, we can keep
it in tree for now.
Move WEXT driver to sub directory, add dummy Makefile and Kconfig
WEXT code has been moved to a sub directory and is no longer included
in the module build. We should make a note of this for future
developers.
Add note to WEXT code TODO file informing developers that code is not
included in module build.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7
Current ks7010 driver uses the WEXT interface. This series is the
initial stage of re-writing the driver to use cfg80211.
This patch set includes the code that was submitted as an RFC
Subject: [RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL
The RFC has been in flight for two weeks. All
70 matches
Mail list logo
