Fixed a comment coding style issue , block comments use * on subsequent lines.
Signed-off-by: srishti sharma
---
drivers/staging/ccree/ssi_aead.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h
index 9cf
On Sun, May 21, 2017 at 10:15:11AM +0100, d...@acm.org wrote:
> From: Richard Porter
>
> Fixes sparse warnings:
> drivers/staging/ks7010/ks_hostif.c:339:21: warning: cast to restricted __be16
> drivers/staging/ks7010/ks_hostif.c:430:21: warning: cast to restricted __be16
> drivers/staging/ks7010/
On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote:
> Fixed a pointer declaration error , the dereferencing operator was misplaced.
Odd use of a ,
Also, I don't understand what was "misplaced" here? There does not seem
to be a "error" fixed here...
__
On Mon, Apr 24, 2017 at 11:28:58AM +0100, Andrea della Porta wrote:
> Fixed the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/llite//file.c
> drivers/staging/lustre/lustre/llite//file.c:441:24: warning: incorrect
> type in assignment (different base types)
> drivers/s
On Wed, May 31, 2017 at 06:24:55PM +0530, srishti sharma wrote:
> Fixed a comment coding style issue that generated a warning stating that
> block comments should align the * on each line.
>
Please properly line-wrap your changelog comments :(
You also sent 2 different patches, that did differe
On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote:
> CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
> Replace with use of BIT macro.
>
> Signed-off-by: Gilad Ben-Yossef
> ---
> drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
> 1 file changed, 1 insertion(+),
On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
>
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
>
> Found with checkpatch.pl who was issuing this
> message:
> "Macro argument 'id' may be bett
On Wed, May 31, 2017 at 04:00:41PM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> cfs_wi_exit (acquire the lock by spin_lock)
> LASSERT
> lbug_with_loc
> libcfs_debug_dumplog
> schedule and kthread_run --> may sleep
>
> To fi
On Mon, May 29, 2017 at 11:58:52PM +0200, Mateusz Nowotyński wrote:
> This is patch fixing code alignment style issue in
> android/ion/ion-ioctl.c file
>
> Signed-off-by: Mateusz Nowotyński
> ---
> drivers/staging/android/ion/ion-ioctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-
On Wed, May 31, 2017 at 01:58:52PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Stuart Yoder
Your subject says 'v4' yet the other patches here in the series do not,
they say nothing, or 'v2', and the 0/10 patch says 'v6'!
Please fix up and do this correctly. The _whole_ patch series is
version
On Fri, Jun 02, 2017 at 02:59:32AM +, ? ? wrote:
> From: Pan Li
>
> Pan Li (1):
> Restrict read pointer to 16 bit of tcpci_read16.
Please fix up your subject line to properly describe what part of the
kernel you are modifying.
thanks,
greg k-h
On Tue, May 30, 2017 at 06:09:54PM +1200, Derek Robson wrote:
> Fixed block comment alignment, Style fix only
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/ccree/ssi_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does not apply to my tree :(
_
On Thu, Jun 01, 2017 at 11:43:35AM +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
> rtsx_enter_ss
> rtsx_power_off_card
> sd_cleanup_work
> sd_stop_seq_mode
> s
On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote:
> Fixed block comments across whole ccree driver
>
> Version #1 has some trailing white space issue in a few patches
Some of these applied, some did not :(
___
devel mailing list
de...@linuxd
Hey,
checkpatch.pl generated two errors , because the dereferencing
operator was placed next to the structure name instead of being placed
with the pointer .
for eg:
struct scatterlist* srcSgl; (this was giving an error)
whereas
struct scatterlist *srcSgl; (this did not give an error)
Both
Hi Sakari,
On 05/29/2017 11:56 PM, Sakari Ailus wrote:
Hi Steve,
On Mon, May 29, 2017 at 02:50:34PM -0700, Steve Longerbeam wrote:
+
+static int ov5640_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+ struct v4l2_subdev *sd = ctrl_to_sd(ctrl);
+ struct ov5640_dev *sensor = to_ov5640_dev(sd)
On 06/01/2017 01:26 AM, Sakari Ailus wrote:
Hi Pavel,
On Wed, May 31, 2017 at 09:58:21PM +0200, Pavel Machek wrote:
Hi!
+/* min/typical/max system clock (xclk) frequencies */
+#define OV5640_XCLK_MIN 600
+#define OV5640_XCLK_MAX 2400
+
+/*
+ * FIXME: there is no subdev API to set t
Hi!
> >>>+ /* Auto/manual exposure */
> >>>+ ctrls->auto_exp = v4l2_ctrl_new_std_menu(hdl, ops,
> >>>+ V4L2_CID_EXPOSURE_AUTO,
> >>>+ V4L2_EXPOSURE_MANUAL, 0,
> >>>+ V4L2
On Sat, Jun 03, 2017 at 09:51:39PM +0200, Pavel Machek wrote:
> Hi!
>
> > >>>+/* Auto/manual exposure */
> > >>>+ctrls->auto_exp = v4l2_ctrl_new_std_menu(hdl, ops,
> > >>>+ V4L2_CID_EXPOSURE_AUTO,
> > >>>+
Hi!
> > > According to the docs V4L2_CID_EXPOSURE_ABSOLUTE is in 100 usec units.
> > >
> > > OTOH V4L2_CID_EXPOSURE has no defined unit, so it's a better fit IMO.
> > > >Way more drivers appear to be using EXPOSURE than EXPOSURE_ABSOLUTE, too.
> > >
> > > Done, switched to V4L2_CID_EXPOSURE. It
From: Colin Ian King
Replace cant with cannot, argumetns with arguments and
add line break to overly long DBG_871X statement.
Signed-off-by: Colin Ian King
---
drivers/staging/rtl8723bs/hal/hal_com.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl87
From: Colin Ian King
I found one more spelling mistake in a DBG_8192C debug message,
replace "avaliable" with "available", add some spacing between
text and a number and split overly long line
Signed-off-by: Colin Ian King
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ++-
1 file c
From: Colin Ian King
Trivial fix to spelling mistake in SSI_LOG_ERR message
Signed-off-by: Colin Ian King
---
drivers/staging/ccree/ssi_buffer_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c
b/drivers/staging/ccree/ssi_buffer_mg
From: Colin Ian King
Trivial fix to spelling mistake in SSI_LOG_ERR message
Signed-off-by: Colin Ian King
---
drivers/staging/ccree/ssi_buffer_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c
b/drivers/staging/ccree/ssi_buffer_mg
Added * on subsequent lines of a comment block.
Signed-off-by: srishti sharma
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
index ac39d34..6ee51b8 100644
This patchset contains a series of comment coding style issues fixes.
srishti sharma (4):
Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a
comment block.
Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment
block
Staging: ccree: cc_crypto_ctx.h: Fixe
Fixed trailing */ style issue in a block comment.
Signed-off-by: srishti sharma
---
drivers/staging/ccree/cc_crypto_ctx.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
index 6ee51b8..27a59
Fixed the alignment of * in a comment block.
Signed-off-by: srishti sharma
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
index 27a5914..03164624 10
Added *'s on subsequent lines of a comment block to fix coding style issues.
Signed-off-by: srishti sharma
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_
On Sat, 2017-06-03 at 23:21 +0100, Colin King wrote:
> Replace cant with cannot, argumetns with arguments and
> add line break to overly long DBG_871X statement.
[]
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c
> b/drivers/staging/rtl8723bs/hal/hal_com.c
[]
> @@ -26,7 +26,7 @@ u8 rtw_hal_
On 06/03/2017 02:57 PM, Sakari Ailus wrote:
On Sat, Jun 03, 2017 at 09:51:39PM +0200, Pavel Machek wrote:
Hi!
+ /* Auto/manual exposure */
+ ctrls->auto_exp = v4l2_ctrl_new_std_menu(hdl, ops,
+V4L2_CID_EXPOSURE_AUTO,
+
On Sat, Jun 3, 2017 at 11:46 AM, Greg Kroah-Hartman
wrote:
> On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote:
>> CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
>> Replace with use of BIT macro.
>>
>> Signed-off-by: Gilad Ben-Yossef
>> ---
>> drivers/stagi
32 matches
Mail list logo
