Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

On 05/25/2017 02:29 AM, Steve Longerbeam wrote: From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

On 05/25/2017 02:29 AM, Steve Longerbeam wrote: This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam Acked-by: Hans Verkuil Thanks, Hans --- d

Re: [PATCH v7 00/34] i.MX Media Driver

Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: - video-mux: switched to Philipp's latest video-mux driver and updated bindings docs, that makes use of the mmio-mux framework. - mmio-mux: includes Philipp's temporary patch that adds mmio-mux support to video-mux d

Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

On Mon, 2017-05-29 at 15:37 +0200, Hans Verkuil wrote: > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > > > - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX > > > > Signed-off-by: Steve Longerbeam > > --- > > Documentation/me

Re: [PATCH v7 15/34] add mux and video interface bridge entity functions

On 05/29/2017 03:51 PM, Philipp Zabel wrote: On Mon, 2017-05-29 at 15:37 +0200, Hans Verkuil wrote: On 05/25/2017 02:29 AM, Steve Longerbeam wrote: From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Docu

Re: [PATCH v7 00/34] i.MX Media Driver

On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: > Hi Steve, > > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > > In version 7: > > > > - video-mux: switched to Philipp's latest video-mux driver and updated > >bindings docs, that makes use of the mmio-mux framework. > > > > - mmio-m

Re: [PATCH v7 00/34] i.MX Media Driver

On 05/29/2017 04:15 PM, Philipp Zabel wrote: On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: - video-mux: switched to Philipp's latest video-mux driver and updated bindings docs, that makes use of the mmio-mux

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

On 05/25/2017 03:31 PM, Ruxandra Ioana Radulescu wrote: >> -Original Message- >> From: Laurentiu Tudor >> Sent: Wednesday, May 24, 2017 3:34 PM >> To: Ruxandra Ioana Radulescu ; >> gre...@linuxfoundation.org >> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; >> ag...@suse.de

Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: > lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct > lov_user_md pointer from user- or kernel-space. This changes the > behavior of copy_from_user() on SPARC and may result in a misaligned > access exception which i

Re: [PATCH 01/12] staging: ccree: correct coding style violations

On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > cc_crypto_ctx.h had multiple coding style violations reported by > checkpatch. Fix them all. Sorry, no. You need to do only one-thing-per-patch, and "fix all coding style issues is not "one thing". I wouldn't take this kind of p

Re: [PATCH] staging: ks7010: define ether_hdr.h_proto to be big-endian

On Sun, May 21, 2017 at 10:15:11AM +0100, d...@acm.org wrote: > From: Richard Porter > > Fixes sparse warnings: > drivers/staging/ks7010/ks_hostif.c:339:21: warning: cast to restricted __be16 > drivers/staging/ks7010/ks_hostif.c:430:21: warning: cast to restricted __be16 > drivers/staging/ks7010/

Re: [PATCH 04/12] staging: ccree: cleanup lli access macro

On Sun, May 28, 2017 at 05:40:29PM +0300, Gilad Ben-Yossef wrote: > The Linked List Item descriptors were being accessed via > a baroque set of defines and macro. Re-factor for structs > and inline function for readability and sanity. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/c

Re: [PATCH 02/12] staging: ccree: move to kernel bitfields/bitops

On Sun, May 28, 2017 at 05:40:27PM +0300, Gilad Ben-Yossef wrote: > ccree had a lot of boilerplate code for dealing with bitops > and bitfield register access. Move it over to the generic kernel > infrastructure used for doing the same. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging

Re: [PATCH 12/27] Drivers: ccree: ssi_fips_ll.c - align block comments

On Wed, May 24, 2017 at 04:43:52PM +1200, Derek Robson wrote: > Fixed block comment alignment, Style fix only > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/ccree/ssi_fips_ll.c | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) > > d

Re: [PATCH 01/11] Staging: android: Fix style issue in ion-ioctl.c

On Sun, May 28, 2017 at 09:56:15PM +0200, Mateusz Nowotyński wrote: > This is patch fixing code alignment style issue in > android/ion/ion-ioctl.c file > Signed-off-by: Mateusz Nowotyński I need a blank line before the signed-off-by: line please. Can you fix this up and resend all of these? tha

Re: [PATCH v7 00/34] i.MX Media Driver

On 05/29/2017 04:21 PM, Hans Verkuil wrote: On 05/29/2017 04:15 PM, Philipp Zabel wrote: On Mon, 2017-05-29 at 15:46 +0200, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: - video-mux: switched to Philipp's latest video-mux driver and updated

Re: [PATCH v7 00/34] i.MX Media Driver

Hi Hans, On Mon, May 29, 2017 at 03:46:08PM +0200, Hans Verkuil wrote: > Hi Steve, > > On 05/25/2017 02:29 AM, Steve Longerbeam wrote: > >In version 7: > > > >- video-mux: switched to Philipp's latest video-mux driver and updated > > bindings docs, that makes use of the mmio-mux framework. > >

Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()

On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote: >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct >> lov_user_md pointer from user- or kernel-space. This changes the >> behavior of copy_from_user() on

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

Hi Steve, A few comments below. On Wed, May 24, 2017 at 05:29:31PM -0700, Steve Longerbeam wrote: > This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta > branch, modified heavily to bring forward to latest interfaces and code > cleanup. > > Signed-off-by: Steve Longerbeam

Re: [PATCH v7 00/34] i.MX Media Driver

On 05/29/2017 05:36 PM, Sakari Ailus wrote: Hi Hans, On Mon, May 29, 2017 at 03:46:08PM +0200, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: - video-mux: switched to Philipp's latest video-mux driver and updated bindings docs, that makes use o

Re: [PATCH 01/12] staging: ccree: correct coding style violations

On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > > cc_crypto_ctx.h had multiple coding style violations reported by > > checkpatch. Fix them all. > > Sorry, no. You need to do only one-thing-per-patch, and "fix all

Re: [PATCH 01/12] staging: ccree: correct coding style violations

On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: >> On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: >> > cc_crypto_ctx.h had multiple coding style violations reported by >> > checkpatch. Fix them all. >> >> Sorry,

Re: [PATCH 02/12] staging: ccree: move to kernel bitfields/bitops

On Mon, May 29, 2017 at 5:38 PM, Greg Kroah-Hartman wrote: > On Sun, May 28, 2017 at 05:40:27PM +0300, Gilad Ben-Yossef wrote: >> ccree had a lot of boilerplate code for dealing with bitops >> and bitfield register access. Move it over to the generic kernel >> infrastructure used for doing the sam

Re: [PATCH v7 00/34] i.MX Media Driver

Hi Hans, thanks for the reply... On 05/29/2017 06:46 AM, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: What is the status as of v7? From what I can tell patch 2/34 needs an Ack from Rob Herring, Yes still missing that Ack. I think the issu

Re: [PATCH v7 00/34] i.MX Media Driver

On 05/29/2017 07:23 PM, Steve Longerbeam wrote: Hi Hans, thanks for the reply... On 05/29/2017 06:46 AM, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: What is the status as of v7? From what I can tell patch 2/34 needs an Ack from Rob Herrin

Re: [PATCH 04/12] staging: ccree: cleanup lli access macro

On Mon, May 29, 2017 at 5:41 PM, Greg Kroah-Hartman wrote: > On Sun, May 28, 2017 at 05:40:29PM +0300, Gilad Ben-Yossef wrote: >> The Linked List Item descriptors were being accessed via >> a baroque set of defines and macro. Re-factor for structs >> and inline function for readability and sanity.

Re: [PATCH 01/12] staging: ccree: correct coding style violations

On Mon, May 29, 2017 at 8:36 PM, Joe Perches wrote: > On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote: >> On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: >> > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: >> > > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yoss

Re: [PATCH v7 00/34] i.MX Media Driver

Hi Sakari, On 05/29/2017 08:36 AM, Sakari Ailus wrote: Hi Hans, On Mon, May 29, 2017 at 03:46:08PM +0200, Hans Verkuil wrote: Hi Steve, On 05/25/2017 02:29 AM, Steve Longerbeam wrote: In version 7: - video-mux: switched to Philipp's latest video-mux driver and updated bindings docs, tha

[PATCH] Staging: gdm724x: Change spaces to tabs

This patch fixes the following checkpatch.pl warning in gdm_usb.c: WARNING: suspect code indent for conditional statements (8, 12) Signed-off-by: Mart Lubbers --- drivers/staging/gdm724x/gdm_usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gdm724x

Re: [PATCH 01/12] staging: ccree: correct coding style violations

On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote: > On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: > > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: > > > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > > > > cc_crypto_ctx.h had multiple coding styl

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

Hi Sakari, On 05/29/2017 08:55 AM, Sakari Ailus wrote: Hi Steve, A few comments below. On Wed, May 24, 2017 at 05:29:31PM -0700, Steve Longerbeam wrote: This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces

[PATCH v2 04/11] Staging: android: remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index e10c696..11acbe2 100644 --- a/drivers/sta

[PATCH v2 05/11] Staging: android: Fix code alignment issue

Fixes code alignment issue in ion/ion_carveout_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_carveout_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carve

[PATCH v2 01/11] Staging: android: Fix style issue in ion-ioctl.c

This is patch fixing code alignment style issue in android/ion/ion-ioctl.c file Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android

[PATCH v2 02/11] Staging: android: NULL comparasion in ion.c file

Fixes NULL comparison coding style issues in android/ion/ion.c file Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 03d3a

[PATCH v2 03/11] Staging: android: Fix alignment issue in ion.c

Fixes code alignment style issues in android/ion/ion.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 73f90e6..e10c696 1

[PATCH v2 07/11] Staging: android: fix sizeof style issue

Converts sizeof(type) to sizeof(variable) in android/ion/ion_cma_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/i

[PATCH v2 10/11] Staging: android: Fix code alignment issue

Fixes code alignment issue in ion/ion.h Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index ace8416..4f04f65 100644 --- a/d

[PATCH v2 11/11] Staging: android: use BIT macro

Use BIT macro instead of left shifting in android/ion/ion.h Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index 4f04f65..6cc720

[PATCH v2 08/11] Staging: android: Remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion_system_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_system_heap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c

[PATCH v2 06/11] Staging: android: remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion_cma_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_cma_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index a0949bc

[PATCH v2 09/11] Staging: android: fix sizeof style issue

Converts sizeof(type) to sizeof(variable) in android/ion/ion_system_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_system_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/stagin

[PATCH V2 00/27] Drivers: ccree - align block comments

Fixed block comments across whole ccree driver Version #1 has some trailing white space issue in a few patches Derek Robson (27): Drivers: ccree: ssi_sysfs.h - align block comments Drivers: ccree: ssi_sysfs.c - align block comments Drivers: ccree: ssi_request_mgr.h - align block comments

[PATCH V2 02/27] Drivers: ccree: ssi_sysfs.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c index 89021c009872..

[PATCH V2 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.h b/drivers/staging/ccree/ssi_sysfs.h index cd456c5dccc4..48

[PATCH V2 03/27] Drivers: ccree: ssi_request_mgr.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_request_mgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.h b/drivers/staging/ccree/ssi_request_mgr.h inde

[PATCH V2 04/27] Drivers: ccree: ssi_request_mgr.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_request_mgr.c | 37 - 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/

[PATCH V2 05/27] Drivers: ccree: ssi_pm_ext.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm_ext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_pm_ext.h b/drivers/staging/ccree/ssi_pm_ext.h index 9049e6ffa8d3.

[PATCH V2 06/27] Drivers: ccree: ssi_pm_ext.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm_ext.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/ssi_pm_ext.c b/drivers/staging/ccree/ssi_pm_ext.c inde

[PATCH V2 07/27] Drivers: ccree: ssi_pm.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_pm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_pm.h b/drivers/staging/ccree/ssi_pm.h index f1fe1777c04a..8b0d8be95199

[PATCH V2 09/27] Drivers: ccree: ssi_hash.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_hash.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_hash.h b/drivers/staging/ccree/ssi_hash.h index b821d0c854b5..7c9466

[PATCH V2 08/27] Drivers: ccree: ssi_ivgen.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_ivgen.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_ivgen.c b/drivers/staging/ccree/ssi_ivgen.c index 1bb6f89191

[PATCH V2 10/27] Drivers: ccree: ssi_hash.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_hash.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index 8585f73161b

[PATCH V2 11/27] Drivers: ccree: ssi_fips_local.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_local.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_local.c b/drivers/staging/ccree/s

[PATCH V2 12/27] Drivers: ccree: ssi_fips_ll.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_ll.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_ll.c b/drivers/staging/ccree/ssi_fip

[PATCH V2 13/27] Drivers: ccree: ssi_fips_ext.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_ext.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_ext.c b/drivers/sta

[PATCH V2 14/27] Drivers: ccree: ssi_fips_data.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips_data.h | 93 +-- 1 file changed, 46 insertions(+), 47 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_data.h b/drivers/st

[PATCH V2 15/27] Drivers: ccree: ssi_fips.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h index 607c64b8c458..

[PATCH V2 16/27] Drivers: ccree: ssi_fips.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_fips.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips.c b/drivers/staging/ccree/ssi_fips.c index 25e

[PATCH V2 17/27] Drivers: ccree: ssi_driver.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_driver.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h i

[PATCH V2 18/27] Drivers: ccree: ssi_config.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_config.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_config.h b/drivers/staging/ccree/ssi_config.h index 431b518d

[PATCH V2 19/27] Drivers: ccree: ssi_cipher.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_cipher.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h index 7d58b56fc2c7.

[PATCH V2 20/27] Drivers: ccree: ssi_buffer_mgr.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_buffer_mgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.h b/drivers/staging/ccree/ssi_buffer_mgr.h index 4

[PATCH V2 21/27] Drivers: ccree: ssi_buffer_mgr.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_buffer_mgr.c | 87 +++--- 1 file changed, 49 insertions(+), 38 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/s

[PATCH V2 22/27] Drivers: ccree: ssi_aead.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_aead.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h index 654a181729d7.

[PATCH V2 24/27] Drivers: ccree: hash_defs.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/hash_defs.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/hash_defs.h b/drivers/staging/ccree/hash_defs.h index

[PATCH V2 23/27] Drivers: ccree: ssi_aead.c - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/ssi_aead.c | 45 ++-- 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/

[PATCH V2 25/27] Drivers: ccree: cc_regs.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_regs.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ccree/cc_regs.h b/drivers/staging/ccree/cc_regs.h index 8b89f0603

[PATCH V2 27/27] Drivers: ccree: cc_crypto_ctx.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_crypto_ctx.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_cryp

[PATCH V2 26/27] Drivers: ccree: cc_hw_queue_defs.h - align block comments

Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/ccree/cc_hw_queue_defs.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

Hello Derek, On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > Fixed block comments across whole ccree driver Since all these commits are doing the same logical change across a single driver, you could probably squash them all into a single one. Thanks! Antoine -- Antoine Ténart,

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

Hi Steve, On Mon, May 29, 2017 at 02:50:34PM -0700, Steve Longerbeam wrote: > > > > > >>+ > >>+static int ov5640_s_ctrl(struct v4l2_ctrl *ctrl) > >>+{ > >>+ struct v4l2_subdev *sd = ctrl_to_sd(ctrl); > >>+ struct ov5640_dev *sensor = to_ov5640_dev(sd); > >>+ int ret = 0; > >>+ > >>+ mutex_