Re: [PATCH] staging: iio: ad7152: Fix deadlock in ad7152_write_raw_samp_freq()

On 05/27/2017 12:53 AM, Alexey Khoroshilov wrote: > ad7152_write_raw_samp_freq() is called by ad7152_write_raw() with > chip->state_lock held. So, there is unavoidable deadlock when > ad7152_write_raw_samp_freq() locks the mutex itself. > > The patch removes unneeded locking. > > Found by Linux D

Firmware for staging atomisp driver

Hi All, I've been trying to get the atomisp driver from staging to work on a couple of devices I have. I started with an Asus T100TA after fixing 2 oopses in the sensor driver there I found out that the BIOS does not allow to put the ISP in PCI mode and that there is no code to drive it in ACPI

[PATCH 1/7] staging: atomisp: Fix calling efivar_entry_get() with unaligned arguments

efivar_entry_get has certain alignment requirements and the atomisp platform code was not honoring these, causing an oops by triggering the WARN_ON in arch/x86/platform/efi/efi_64.c: virt_to_phys_or_null_size(). This commit fixes this by using the members of the efivar struct embedded in the efiva

[PATCH 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control

menu controls are not allowed to have a step size, set step to 0 to fix an oops from the WARN_ON in v4l2_ctrl_new_custom() triggering because of this. Signed-off-by: Hans de Goede --- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 7/7] staging: atomisp: Make ov2680 driver less chatty

There is no reason for all this printk spamming and certainly not at an error log level. Signed-off-by: Hans de Goede --- drivers/staging/media/atomisp/i2c/ov2680.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/st

[PATCH 2/7] staging: atomisp: Do not call dev_warn with a NULL device

Do not call dev_warn with a NULL device, this silence the following 2 warnings: [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO We could switch to using pr_warn for dev == NULL instead, but as co

[PATCH 6/7] staging: atomisp: Ignore errors from second gpio in ov2680 driver

As the existing comment in the driver indicates the sensor has only 1 pin, but some boards may have 2 gpios defined and we toggle both as we we don't know which one is the right one. However if the ACPI resources table defines only 1 gpio (as expected) the gpio1_ctrl call will always fail, causing

[PATCH 4/7] staging: atomisp: Add INT0310 ACPI id to gc0310 driver

Signed-off-by: Hans de Goede --- drivers/staging/media/atomisp/i2c/gc0310.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c index 1ec616a15086..350fd7fd5b86 100644 --- a/drivers/staging/media/atomisp/i2c/

[PATCH 5/7] staging: atomisp: Add OVTI2680 ACPI id to ov2680 driver

Signed-off-by: Hans de Goede --- drivers/staging/media/atomisp/i2c/ov2680.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/staging/media/atomisp/i2c/ov2680.c index 566091035c64..449aa2aa276f 100644 --- a/drivers/staging/media/atomisp/i2c/

Re: [PATCH 2/7] staging: atomisp: Do not call dev_warn with a NULL device

On Sun, May 28, 2017 at 3:31 PM, Hans de Goede wrote: > Do not call dev_warn with a NULL device, this silence the following 2 > warnings: > > [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO > [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO > >

[PATCH 00/12] staging: ccree: addtional driver cleanups

This is another batch of clean ups for the ccree driver. Mostly comprised of: - Coding Style fixes - Move to kernel infrastructure from custom constructs - Removal of dead code Gilad Ben-Yossef (12): staging: ccree: correct coding style violations staging: ccree: move to kernel bitfields/bitop

[PATCH 03/12] staging: ccree: remove 48 bit dma addr sim

Remove no longer needed code used to simulate 48 bit dma addresses on 32 bit platforms for development purposes. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 19 drivers/staging/ccree/ssi_buffer_mgr.c | 83 - drivers/stag

[PATCH 01/12] staging: ccree: correct coding style violations

cc_crypto_ctx.h had multiple coding style violations reported by checkpatch. Fix them all. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_crypto_ctx.h | 66 +-- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/staging/ccree/cc_

[PATCH 04/12] staging: ccree: cleanup lli access macro

The Linked List Item descriptors were being accessed via a baroque set of defines and macro. Re-factor for structs and inline function for readability and sanity. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_lli_defs.h| 65 +++--- drivers/staging/c

[PATCH 05/12] staging: ccree: remove cycle count debug support

The ccree driver had support for rough performance debugging via cycle counting which has bit rotted and can easily be replcaed with perf. Remove it from the driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 13 drivers/staging/ccree/ssi_aead.c

[PATCH 07/12] staging: ccree remove custom bitfield macros

With all users removed or re-factored to use the standard kernel bit fields ops we can now drop the custom bit field macros. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_bitops.h| 40 drivers/staging/ccree/cc_hw_queue_defs.h | 2 +- drivers/staging/c

[PATCH 11/12] staging: ccree: remove dead code

Remove some unused macro definitions from hash definitions. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/hash_defs.h | 31 +++ 1 file changed, 3 insertions(+), 28 deletions(-) diff --git a/drivers/staging/ccree/hash_defs.h b/drivers/staging/ccree/hash_d

[PATCH 08/12] staging: ccree: remove unused struct

struct SepHashPrivateContext is not used anywhere in the code. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/hash_defs.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/ccree/hash_defs.h b/drivers/staging/ccree/hash_defs.h index 61389

[PATCH 06/12] staging: ccree: move request_mgr to generic bitfield ops

request_mgr was using custom bit field macros. move over to standard kernel bitfield ops. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_regs.h | 5 + drivers/staging/ccree/ssi_request_mgr.c | 19 +-- 2 files changed, 14 insertions(+), 10 deletions(-)

[PATCH 09/12] staging: ccree: use snake_case for hash enums

Hash enum were named using CamelCase, move over to snake_case. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 4 ++-- drivers/staging/ccree/hash_defs.h| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queu

[PATCH 12/12] staging: ccree: whitespace fixes

A bunch of whitespace fixes pointed to by checkpatch. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_regs.h| 4 +- drivers/staging/ccree/dx_crys_kernel.h | 308 - drivers/staging/ccree/dx_host.h| 256 +-- 3 f

[PATCH 10/12] staging: ccree: drop no longer used macro

MSB64 macro is no longer used or needed. Drop it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h index ec2113a..f12761a 100644 -

Re: [PATCH] staging: iio: ad7152: Fix deadlock in ad7152_write_raw_samp_freq()

On Sun, 28 May 2017 11:47:04 +0200 Lars-Peter Clausen wrote: > On 05/27/2017 12:53 AM, Alexey Khoroshilov wrote: > > ad7152_write_raw_samp_freq() is called by ad7152_write_raw() with > > chip->state_lock held. So, there is unavoidable deadlock when > > ad7152_write_raw_samp_freq() locks the mutex

[PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)

Fix "symbol 'xxx' was not declared. Should it be static?" sparse warnings. Signed-off-by: Chen Guanqiao --- drivers/staging/media/atomisp/i2c/lm3554.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/lm3554.c b/drivers/staging/media/a

[PATCH 09/11] Staging: android: fix sizeof style issue

Converts sizeof(type) to sizeof(variable) in android/ion/ion_system_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_system_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging

[PATCH 07/11] Staging: android: fix sizeof style issue

Converts sizeof(type) to sizeof(variable) in android/ion/ion_cma_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/io

[PATCH 06/11] Staging: android: remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion_cma_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_cma_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index a0949bc.

[PATCH 08/11] Staging: android: Remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion_system_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_system_heap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c

[PATCH 04/11] Staging: android: remove unnecessary blank lines

Removes unnecessary blank lines in android/ion/ion.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index e10c696..11acbe2 100644 --- a/drivers/stag

[PATCH 02/11] Staging: android: NULL comparasion in ion.c file

Fixes NULL comparison coding style issues in android/ion/ion.c file Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 03d3a4

[PATCH 03/11] Staging: android: Fix alignment issue in ion.c

Fixes code alignment style issues in android/ion/ion.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 73f90e6..e10c696 10

[PATCH 01/11] Staging: android: Fix style issue in ion-ioctl.c

This is patch fixing code alignment style issue in android/ion/ion-ioctl.c file Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion-ioctl.c b/drivers/staging/android/

[PATCH 10/11] Staging: android: Fix code alignment issue

Fixes code alignment issue in ion/ion.h Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index ace8416..4f04f65 100644 --- a/dr

[PATCH 11/11] Staging: android: use BIT macro

Use BIT macro instead of left shifting in android/ion/ion.h Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index 4f04f65..6cc720b

[PATCH 05/11] Staging: android: Fix code alignment issue

Fixes code alignment issue in ion/ion_carveout_heap.c Signed-off-by: Mateusz Nowotyński --- drivers/staging/android/ion/ion_carveout_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveo

Re: [PATCH] staging: atomisp: lm3554: fix sparse warnings(was not declared. Should it be static?)

On Mon, 29 May 2017 02:06:41 +0800 Chen Guanqiao wrote: > Fix "symbol 'xxx' was not declared. Should it be static?" sparse warnings. > > Signed-off-by: Chen Guanqiao > --- Reviewed-by: Alan Cox ___ devel mailing list de...@linuxdriverproject.or