Re: [PATCH] staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed coding style issue

2017-05-03 Thread Joe Perches
On Tue, 2017-05-02 at 20:24 -0400, Fabrizio Perria wrote: > Fixed checkpatch.pl issue > ERROR: that open brace { should be on the previous line [] > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c > b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c [] > @@ -338,8 +338,7 @@ boo

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter
On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: Surender Polsani > --- > Changes for v2: > corrected subject line as suggested > Changes for v3: > modified from line as suggested by G

[PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Surender Polsani
kernel coding style doesn't allow the return statement in void function. Signed-off-by: Surender Polsani --- Changes for v2: corrected subject line as suggested Changes for v3: modified from line as suggested by Greg KH placed a semicolon in label for fixing build error Changes for v4: removed la

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter
Nope. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192u: ieee80211: rtl819x_TSProc: Fixed brace placement issues

2017-05-03 Thread Fabrizio Perria
Fixed multiple checkpatch.pl issues regarding open brace placement, else (after a brace) placement, unnecessary braces (single statement branches) and space before closing brace. To get the list of errors, the following command has been executed: ./scripts/checkpatch.pl --show-types --strict \

[PATCH] staging: vt6656: rtxt.c Fix CODE_INDENT type errors

2017-05-03 Thread Salvatore Benedetto
Fix all CODE_INDENT type errors reported by checkpatch in rtxt.c Signed-off-by: Salvatore Benedetto --- drivers/staging/vt6656/rxtx.c | 49 ++- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/

[PATCH] staging: android: ion: Align with open parenthesis

2017-05-03 Thread Richard Porter
Fix checkpatch.pl warning: CHECK: Alignment should match open parenthesis + fd = ion_alloc(data.allocation.len, + data.allocation.heap_id_mask, Signed-off-by: Richard Porter --- drivers/staging/android/ion/ion-ioctl.c | 4 ++-- 1 file

RE: [PATCH] staging: unisys: Solve sparse warning

2017-05-03 Thread Kershner, David A
> -Original Message- > From: Marcos Paulo de Souza [mailto:marcos.souza@gmail.com] > Sent: Tuesday, May 2, 2017 11:28 PM > Cc: Marcos Paulo de Souza ; Kershner, David > A ; Greg Kroah-Hartman > ; Sell, Timothy C ; > Binder, David Anthony ; Erik Arfvidson > ; Wadgaonkar, Sameer Laxmikant

Re: [PATCH] staging: ccree: Fix trailing whitespace checkpatch warnings

2017-05-03 Thread Greg KH
On Wed, May 03, 2017 at 06:47:07PM +0200, Timothée Isnard wrote: > Signed-off-by: Timothée Isnard I can't take patches without any changelog text at all :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

[PATCH v1] vmbus: Reuse uuid_le_to_bin() helper

2017-05-03 Thread Andy Shevchenko
Instead of open coded variant use generic helper to convert UUID strings to binary format. Signed-off-by: Andy Shevchenko --- drivers/hv/vmbus_drv.c | 51 ++ 1 file changed, 10 insertions(+), 41 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/d

Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper

2017-05-03 Thread Andy Shevchenko
On Wed, 2017-05-03 at 20:07 +0300, Andy Shevchenko wrote: > Instead of open coded variant use generic helper to convert UUID > strings > to binary format. > @@ -677,12 +644,14 @@ static ssize_t remove_id_store(struct > device_driver *driver, const char *buf, >  { >   struct hv_driver *drv = dr

Re: [PATCH] staging: ccree: Fix trailing whitespace checkpatch warnings

2017-05-03 Thread Gilad Ben-Yossef
Hi Timothée, On Wed, May 3, 2017 at 8:01 PM, Greg KH wrote: > On Wed, May 03, 2017 at 06:47:07PM +0200, Timothée Isnard wrote: >> Signed-off-by: Timothée Isnard > Was this sent to the list? My email client disavow any knowledge of the email this seems to be in reply to... > I can't take patch

Re: [PATCH] staging: ccree: Fix trailing whitespace checkpatch warnings

2017-05-03 Thread Greg KH
On Wed, May 03, 2017 at 09:08:10PM +0300, Gilad Ben-Yossef wrote: > Hi Timothée, > > On Wed, May 3, 2017 at 8:01 PM, Greg KH wrote: > > On Wed, May 03, 2017 at 06:47:07PM +0200, Timothée Isnard wrote: > >> Signed-off-by: Timothée Isnard > > > > Was this sent to the list? > > My email client di

Re: [PATCH] staging: ccree: Fix trailing whitespace checkpatch warnings

2017-05-03 Thread Timothée Isnard
On Wed, May 03, 2017 at 09:08:10PM +0300, Gilad Ben-Yossef wrote: > Hi Timothée, > > On Wed, May 3, 2017 at 8:01 PM, Greg KH wrote: > > On Wed, May 03, 2017 at 06:47:07PM +0200, Timothée Isnard wrote: > >> Signed-off-by: Timothée Isnard > > > > Was this sent to the list? It seems to have bounce

[bug report] staging: typec: Fairchild FUSB302 Type-c chip driver

2017-05-03 Thread Dan Carpenter
Hello Yueyao Zhu, The patch c034a43e72dd: "staging: typec: Fairchild FUSB302 Type-c chip driver" from Apr 27, 2017, leads to the following static checker warning: drivers/staging/typec/fusb302/fusb302.c:492 tcpm_init() warn: odd binop '0x40 & 0x80' drivers/staging/typec/fusb302/f

[PATCH] staging: typec: fusb302: Fix module autoload

2017-05-03 Thread Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the OF and I2C device ID table entries as module aliases, using the MODULE_DEVICE_TABLE() macro. Before