[PATCH 3/3] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

2017-04-29 Thread Tuomo Rinne
commit 9304b5b0d4fe8498d3d059db4bb8a7de253355a5 adds casting of le16 values to cpu to get rid of sparse warnings. The u4bAcParam is therefore constructed using machines endianess. However, the parameter ought to be casted back to little endian to keep the function logic the same as before. Unfort

[PATCH 2/3] staging: rtl8192u: Improve code readability

2017-04-29 Thread Tuomo Rinne
Split the u4bAcParam parameter construction to multiple lines for easier readability. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/driv

[PATCH 1/3] staging: rtl8192u: Remove unnecessary scope

2017-04-29 Thread Tuomo Rinne
Remove scope unnecessary scope that is already enforced by the if statements scope. Signed-off-by: Tuomo Rinne --- drivers/staging/rtl8192u/r8192U_dm.c | 66 +--- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c

[PATCH 2/4] staging: vt6656: always call vnt_update_ifs on short time change.

2017-04-29 Thread Malcolm Priestley
short time change needs to synchronize parameters in vnt_update_ifs so a call to the function is always necessary. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/main_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt665

[PATCH 1/4] staging: vt6656: vnt_update_ifs set max_min based on short slot time.

2017-04-29 Thread Malcolm Priestley
Short slot time is controlled by mac80211 so there is no need to find odfm rates. Merge PK_TYPE_11B and PK_TYPE_11GA & PK_TYPE_11GB into one else and switch on short slot time. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/card.c | 29 ++--- 1 file changed,

[PATCH 4/4] staging: vt6656: Only call vnt_set_bss_mode on basic rates change.

2017-04-29 Thread Malcolm Priestley
To ensure the bss is always synchronized only call on basic rate change. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/main_usb.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.

[PATCH 3/4] staging: vt6556: vnt_start Fix missing call to vnt_key_init_table.

2017-04-29 Thread Malcolm Priestley
The key table is not intialized correctly without this call. Signed-off-by: Malcolm Priestley Cc: # v3.17+ --- drivers/staging/vt6656/main_usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9237930991ca..06f7

[PATCH] staging: wilc1000: Refactor handling of HT caps fields

2017-04-29 Thread Jason Litzinger
This addresses the following sparse warnings: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:expected unsigned short [unsigned] [assigned] [usertype] ht_capa_inf

[PATCH] staging: lustre: fix sparse warnings on assignment

2017-04-29 Thread Valentin Vidic
Fixes the following sparse warnings: drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: warning: invalid assignment: |= drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23:left side has type restricted __le32 drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23:right side has type int d

Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd

2017-04-29 Thread Stuart Yoder
On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă wrote: > > While dpaa2_fd.simple structure fields are marked __leXX, > corresponding cpu_to_leXX / leXX_to_cpu conversions are missing. > > While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits > sharing the 16-bit field with BPID are not aff

Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd

2017-04-29 Thread Horia Geantă
On 4/29/2017 7:32 PM, Stuart Yoder wrote: > On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă wrote: >> >> While dpaa2_fd.simple structure fields are marked __leXX, >> corresponding cpu_to_leXX / leXX_to_cpu conversions are missing. >> >> While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits

[PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

2017-04-29 Thread Cezary Gapinski
Sparse spits out a warnings about __le16 and unsigned short assignment. Change the type of size and event members of struct hostif_hdr to __le16 and correct conversion to the proper cpu type. Signed-off-by: Cezary Gapinski --- drivers/staging/ks7010/ks7010_sdio.c | 10 ++ drivers/staging

Re: [PATCH 3/3] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction

2017-04-29 Thread kbuild test robot
Hi Tuomo, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20170428] [cannot apply to v4.11-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tuomo-Rinne/s

[PATCH] staging: atomisp: Add __printf validation and fix fallout

2017-04-29 Thread Joe Perches
__printf validation adds format and argument validation. Fix the various broken format/argument mismatches. Signed-off-by: Joe Perches --- I'm not at all sure all the modifications are appropriate. Some maybe should use the original format types like %x instead of %p with *pointer instead of j

[patch 3/6] staging: speakup: add tty-based comms functions

2017-04-29 Thread Okash Khawaja
This adds spk_ttyio.c file. It contains a set of functions which implement those methods in spk_synth struct which relate to sending bytes out using serial comms. Implementations in this file perform the same function but using TTY subsystem instead. Currently synths access serial ports, directly p

[patch 4/6] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio

2017-04-29 Thread Okash Khawaja
This changes the above five synths to TTY-based comms. They were chosen as a first pass because their serial comms are straightforward, i.e. they don't use serial input and don't do internal port knocking. Signed-off-by: Okash Khawaja Reviewed-by: Samuel Thibault Index: linux-staging/drivers/st

[patch 6/6] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout

2017-04-29 Thread Okash Khawaja
This patch simply uses the changes introduced in previous patches and migrates apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward function pointer updates. Signed-off by: Okash Khawaja Reviewed-by: Samuel Thibault Index: linux-staging/drivers/staging/speakup/speakup

[patch 2/6] tty: export tty_open_by_driver

2017-04-29 Thread Okash Khawaja
This applies on top of the changes already in staging-next branch which allow kernel access to TTY dev. Signe-doff-by: Okash Khawaja Reviewed-by: Samuel Thibault Index: linux-staging/drivers/tty/tty_io.c === --- linux-staging.orig/

[patch 1/6] staging: speakup: make input functionality swappable

2017-04-29 Thread Okash Khawaja
This moves functions which take input from external synth, into struct spk_io_ops. The calling code then uses serial implementation of those methods through spk_io_ops. That way we can add a parallel TTY-based implementation and simply replace serial with TTY. That is what the next patch in this se

[patch 0/6] staging: speakup: migrate synths to use TTY-based comms

2017-04-29 Thread Okash Khawaja
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[patch 5/6] staging: speakup: add send_xchar, tiocmset and input functionality for tty

2017-04-29 Thread Okash Khawaja
This patch adds further TTY-based functionality, specifically implementation of send_xchar and tiocmset methods, and input. send_xchar and tiocmset methods simply delegate to corresponding TTY operations. For input, it implements the receive_buf2 callback in tty_ldisc_ops of speakup's ldisc. If a

Re: [patch 0/6] staging: speakup: migrate synths to use TTY-based comms

2017-04-29 Thread Okash Khawaja
Hi, Forgot to add intro. Following is what I wanted to say: This patchset migrates all external synths from using raw serial i/o to using tty-based comms. The synths not migrated are internal ones - plugged directly into motherboard, communicating over ISA etc. It's important to note that these p

[PATCH 0/8] Avoid CamelCases in ks7010 driver

2017-04-29 Thread Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic which will be replaced by kernel implementation in the future. Janusz Lisiecki (8): staging: ks7010: avoid CamelCase in fields of struct local_gain_t staging: ks7010: avoid CamelCase: receiveDTIMs staging: ks7010: avoid CamelCa

[PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - FhParms_t - DsParms_t - CfParms_t - IbssParms_t - ErpParams_t Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 20 ++-- 1 file changed, 10 inse

[PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 6 +++--- drivers/staging/ks7010/ks_wlan.h | 8 drivers/staging/ks7010/ks_wlan_net.c | 20 ++---

[PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase association_request_t and association_response_t struct field names with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 10 +- drivers/staging/ks7010/ks_hostif.h | 6 +++--- 2 files c

[PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 25 +---

[PATCH 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) d

[PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - maxDuration - durRemaining Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010

[PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields

2017-04-29 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - dwellTime - hopSet - hopPattern - hopIndex Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH V2] staging: atomisp: Add __printf validation and fix fallout

2017-04-29 Thread Joe Perches
__printf validation adds format and argument validation. Fix the various broken format/argument mismatches. Signed-off-by: Joe Perches --- v2: bah, now without unrelated changes to other staging files... I'm not at all sure all the modifications are appropriate. Some maybe should use the orig

Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd

2017-04-29 Thread Dan Carpenter
On Sat, Apr 29, 2017 at 05:18:04PM +, Horia Geantă wrote: > On 4/29/2017 7:32 PM, Stuart Yoder wrote: > > On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă wrote: > >> > >> While dpaa2_fd.simple structure fields are marked __leXX, > >> corresponding cpu_to_leXX / leXX_to_cpu conversions are missin