hello

DR.MAHOMED HAASHIM AUDITING AND ACCOUNTING MANAGER, AFRICAN DEVELOPMENT BANK 50-54 RUE DE THOMPSON, OUAGADOUGOU, BURKINA FASO, WEST AFRICA Dear Friend, Greetings and how are you doing? I want you to be my partner in the transfer of the sum of $23.6 Million dollars discovered in my department i

[PATCH] staging: iio: tsl2x7x: Replace deprecated macros (S_IRUGO, S_IWUSR)

Use octal digits as suggested by checkpatch instead of deprecated macros. Signed-off-by: Paolo Cretaro --- drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/stagi

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

On Mon, Apr 24, 2017 at 04:06:37PM -0700, John Hubbard wrote: > First, a tiny nit about the patch: it would be good to add "Fixing a problem > that was introduced with commit <4a9b0933bdfc>", in the patch commit > message. > Please use the Fixes tag. Fixes: 123456789012 ("blah blah blah") regar

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

Hi John, please fix your quoting of the previous mails, thanks! What ACPI defines does not matter at all. Linux uses 32-bit domains IDs, and on x86 specifily uses those for non-ACPI enumarated domains (e.g. VMD). You've also not demontrated any issue with any Linux driver yet. > Also...it wou

[PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement

Combine two separate set GPIO(30 & 31) operations into one statement. Signed-off-by: Lynn Lei --- drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c index 68

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

On Tue, 25 Apr 2017, Christoph Hellwig wrote: > Hi John, > > please fix your quoting of the previous mails, thanks! Shoot, sorry about any quoting issues. I'm sufficiently new to conversing on these lists that I'm not even sure which mistake I made. > > > What ACPI defines does not matter at

[PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function

This is a single straightforward conversion from kmap to sg_map. We also create the i915_gem_object_unmap function to common up the unmap code. Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 27 --- 1 file changed, 16 insert

[PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites

Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe Cc: Alasdair Kergon Cc: Mike Snitzer --- drivers/md/dm-crypt.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/md/dm-crypt

[PATCH v2 00/21] Introduce common scatterlist map function

Changes since v1: * Rebased onto next-20170424 * Removed the _offset version of these functions per Christoph's suggestion * Added an SG_MAP_MUST_NOT_FAIL flag which will BUG_ON in future cases that can't gracefully fail. This removes a bunch of the noise added in v1 to a couple of the drive

[PATCH v2 02/21] libiscsi: Add an internal error code

This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe --- dri

[PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites

Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with th

[PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function

Straightforward conversion, except due to the lack of an error path we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Adrian Hunter Cc: Ulf Hansson --- drivers/mmc/host/sdhci.c | 14 +- 1 file changed, 9 insertio

[PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe Cc: Johannes Thumshirn --- drivers/scsi/csiost

[PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function

Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Acked-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers

[PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper

Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Brian King Cc: Artur Paszkiewicz --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42 +- drivers/scsi/pmcraid.c

[PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function

Straightforward conversion to sg_map helper. Seeing there is no cleare error path, SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Wolfram Sang Cc: Ulf Hansson --- drivers/mmc/host/tmio_mmc.h | 7 +-- drivers/mmc/host/tmio_mmc_p

[PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function

This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of t

[PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function

This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Cc: Sascha Sommer Cc: Ulf Hansson --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdric

[PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function

Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but t->offs

[PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

Straightforward conversion to the new helper, except due to the lack of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" --- dr

[PATCH v2 21/21] memstick: Make use of the new sg_map helper function

Straightforward conversion, but we have to make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Alex Dubov --- drivers/memstick/host/jmb38x_ms.c | 11 ++- drivers/memstick/host/tifm_ms.c | 11 ++- 2 files changed,

[PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe Cc: Adaptec OEM Raid Solutions Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S --- drivers/scsi/arcmsr/arcmsr_hba.c | 16 drivers/scsi/ips.c | 8 drivers/scsi/me

[PATCH v2 10/21] RDS: Make use of the new sg_map helper function

Straightforward conversion except there's no error path, so we make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Santosh Shilimkar Cc: "David S. Miller" --- net/rds/ib_recv.c | 8 1 file changed, 4 insertions(+), 4 del

[PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function

We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe Cc: Ulf Hansson --- drivers/mmc/host/mmc_spi.c | 26

[PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Achim Leubner Cc: John Garry --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 13 +---

[PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support sgls that contain io memory. In order for that to wo

[PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function

Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We use ISCSI_TCP_INTERNAL_ERR error type that was prepared earlier for this. Signed-off-by: Logan Gunthorpe Cc: Lee Duncan Cc: Chris Leech --- drivers/

[PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

Very straightforward conversion to the new function in the caam driver and shash library. Signed-off-by: Logan Gunthorpe Cc: Herbert Xu Cc: "David S. Miller" --- crypto/shash.c| 9 ++--- drivers/crypto/caam/caamalg.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletio

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote: > > Change video.c to use %s, __func__ instead of function names. > Warnings flagged by checkpatch.pl > > Signed-off-by: Chandra Annamaneni Why is this indented? Why is your subject a "Re:"? __

Re: [PATCH v2] staging: android: ion: Remove whitespace before quoted newline

On Fri, Apr 21, 2017 at 12:11:19AM +0200, Paolo Cretaro wrote: > Fix checkpatch.pl warning about unnecessary whitespace before a > quoted newline. > > Signed-off-by: Paolo Cretaro > --- > drivers/staging/android/ion/ion_chunk_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH] staging: android: ion: fix coding style issue

On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote: > Use tab instead of spaces for indentation, as reported by checkpatch.pl > > Signed-off-by: Adheer Chandravanshi > --- > drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote: > Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c What type of warnings? What checks? It builds just fine for me here. You need to be very specific. And only do one type of thing per patch, a big "fixes all t

[PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c Signed-off-by: Ilia Sergachev Cc: de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org --- drivers/staging/ks7010/ks_wlan_net.c | 81 ++-- 1 file changed, 49 insertions(+), 32 deletions(-)

Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c

On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote: > Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c You're going to have to split this into multiple patches. > > Signed-off-by: Ilia Sergachev > Ugh... What kind of email address is that? > Cc: de...@driver

[PATCH v3] staging: android: ion: Remove whitespace before quoted newline

Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- Sorry seems in v2 some white spaces corrupted the patch drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH] lustre: remove useless return statements

All statements removed from the end of void functions as reported by checkpatch. Signed-off-by: Valentin Vidic --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 1 - drivers/staging/lustre/lustre/lmv/lproc_lmv.c | 1 - drivers/staging/lustre/lustre/lov/lov_obd.c | 1 - 3 files changed, 3 del

[PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c

This is a patch to the ks_wlan_net.c file that fixes up the following warning found by the checkpatch.pl tool: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Ilia Sergachev --- drivers/staging/ks7010/ks_wlan_net.c | 43 ++-- 1 file cha

Re: [PATCH] staging: ks7010: Change capability field to __le16

On Mon, Apr 24, 2017 at 08:44:38PM +1000, Tobin C. Harding wrote: > On Thu, Apr 20, 2017 at 09:02:26PM +0200, Johan Svensson wrote: > > > > On 2017-04-18 20:38, Greg KH wrote: > > > On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote: > > >> Change capability field to __le16 in struct a

[PATCH 00/19] staging: ks7010: refactor host interface

This is an attempt to improve the readability of the host interface code, and ease future development. Refactoring only, no changes to the functionality of the code. Patch 01 renames a constant to use adjective instead of noun. Patch 02 removes redundant code. Patch 03 removes unused local varia

[PATCH 03/19] staging: ks7010: remove unused local variable eap_key

Code declares and assigns to a local variable that is never used, it can be safely removed. Remove unused local variable. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/ks7010/ks

[PATCH 01/19] staging: ks7010: rename constant SLP_SLEEP to SLP_ASLEEP

Constant SLP_SLEEP is ambiguous, if it were named SLP_ASLEEP the code would be less ambiguous and easier to read. Rename constand SLP_SLEEP to SLP_ASLEEP. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- drivers/staging/ks7010/ks_hostif.c | 4 +- drivers/st

[PATCH 04/19] staging: ks7010: move skb null check near allocation

Currently, after allocating an sk_buff, driver fills the sk_buff within code block guarded by a NULL check on the sk_buff. If a NULL check is done immediately after the allocation, and code returns on error, then the subsequent code need not be guarded and the level of indentation may be reduced. T

[PATCH 11/19] staging: ks7010: fix checkpatch LINE_SPACING

Checkpatch emits CHECK: Please don't use multiple blank lines. Remove multiple blank lines. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 3a

[PATCH 12/19] staging: ks7010: make abbreviation mgmt uniform

Driver currently uses abbreviations 'mgt' and 'mngmt' for 'management'. Also 'power' is sometimes abbreviated to 'pow' and other times not. It makes the code easier to read and easier to modify if one abbreviation is used throughout the driver. 'mgmt' is widely accepted as an abbreviation of 'manag

[PATCH 10/19] staging: ks7010: add enum sleep_mode_type

Driver uses preprocessor directives to define SLP_ASLEEP and SLP_ACTIVE. These can be defined using an enumeration type. Doing so adds to the readability and gives the usual compiler benefits of having an enum. Functions that currently accept integer types can now use the new enumeration type, furt

[PATCH 15/19] staging: ks7010: clean up macro ps_confirm_wait_inc

Macro includes commented out code. Removing dead code line enables braces to be removed. Macro is easier to read if the code is clean. Clean up macro ps_confirm_wait_inc. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 10 +- 1 file changed, 5 insertions(+), 5 d

[PATCH 13/19] staging: ks7010: remove cast from netdev_priv()

The returned pointer from netdev_priv() (void *) does not need to be cast. Remove unnecessary cast of void * returned by netdev_priv(). Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_wlan_net.c | 184 --- 1 file changed, 64 insertions(+), 120 delet

[PATCH 02/19] staging: ks7010: remove unnecessary address check

Currently source and destination ethernet addresses are checked twice, once in hostif_data_indication() and then again in hostif_data_indication_wpa(). The second of these functions is called from the first right after the address check is done. This check is a duplicate and is unnecessary. Remove

[PATCH 05/19] staging: ks7010: remove magic numbers

Driver includes magic numbers. Defining constants or using existing constants aids the readability of the code. Magic number '12' is used for two ethernet addresses (6 bytes each). ETH_ALEN is already defined within the kernel to 6. We can us the expression '2 * ETH_ALEN' to make this code explici

[PATCH 07/19] staging: ks7010: clean memory allocation

Memory allocation code contains unneeded debug statements, failed kmalloc() calls typically do not require a debug message. Introduction of a local 'size' variable allows kmalloc() call to be marginally cleaner, still uses magic numbers but these require a more substantial fix. Moving the magic num

[PATCH 16/19] staging: ks7010: add enum multicast_filter_type

Driver uses preprocessor directives to define multicast filter constants. These can be defined using an enumeration type. Doing so adds to the readability and gives the assists the compiler. Add enumeration type multicast_filter_type to replace preprocessor defined constants. Signed-off-by: Tobin

[PATCH 18/19] staging: ks7010: rename ks_hostif to hostif

Driver uses non-uniform file names. Both in respect to itself and in respect to other SDIO drivers. If we name files in a similar fashion to in-tree SDIO drivers then we are following the principle of least surprise. Looking at in-tree SDIO drivers, hif.c would be the file name of choice for the h

[PATCH 19/19] staging: ks7010: rename ks_hostif to hostif

Driver uses non-uniform file names. Both in respect to itself and in respect to other SDIO drivers. If we name files in a similar fashion to in-tree SDIO drivers then we are following the principle of least surprise. Looking at in-tree SDIO drivers, 'sdio' is the name of choice for SDIO code. Ren

[PATCH 06/19] staging: ks7010: remove duplicate code

Current switch statement has duplicate code in branches. This code can be put after the switch statement so as to remove the duplication. Move code to after switch statement, remove duplicate code. Make error branch return so as not to execute the moved code block. Do not change the program logic.

[PATCH 09/19] staging: ks7010: abstract connection status

Host interface connection status is handled using a 32 bit type. Top byte is used as for FORCE_DISCONNECT status, low bits are used for connect/disconnect status. Driver masks and checks integers to ascertain status. If functions are defined to do the masking and equality check then the details of

[PATCH 08/19] staging: ks7010: add hostif_generic_request()

Driver contains duplicate code. Host interface has numerous request functions which allocate memory for a request header. Each request header is different but all contain, as the first member, a hostif_hdr structure. This structure has size and event members which need to be set. By defining a help

[PATCH 17/19] staging: ks7010: fix enumeration tags

Driver header declares enumeration types without tags. Using informative tags makes the code easier to understand and eliminates the need to comment the enum. Add tags to enumeration types. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.h | 9 - 1 file changed, 4 i

[PATCH 14/19] staging: ks7010: continue from loop on unmatched mac

Inside loop, code block is guarded with an 'if' statement. Instead of guarding the block we can invert the 'if' statement conditional and continue the loop. Doing so allows subsequent code indentation to be reduced and aids the readability of the code. Invert 'if' statement conditional, continue l

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

I assumed the email should be a reply to the previous email so it appears in the thread. As to the leading spaces, it was a problem with my mail client. Ill resend the patch. -- Chandra On Tue, 25 Apr 2017, Greg KH wrote: > On Mon, Apr 24, 2017 at 11:20:22PM -0700, Chandra Annamaneni wrote:

Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c

On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote: > This is a patch to the ks_wlan_net.c file that fixes up the following warning > found by the checkpatch.pl tool: > WARNING: Block comments use a trailing */ on a separate line Good work resubmitting this following Greg's comments. M

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

On Tue, 2017-04-25 at 19:28 -0700, Chandra Annamaneni wrote: > I assumed the email should be a reply to the previous email so it appears > in the thread. As to the leading spaces, it was a problem with my mail > client. > > Ill resend the patch. Did you read my suggestion to just delete these l

[PATCH RFC] staging: wilc1000: Refactor handling of HT caps fields

The patch with this RFC addresses the following sparse warnings: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:expected unsigned short [unsigned] [assigned] [u

Re: [PATCH RFC] staging: wilc1000: Refactor handling of HT caps fields

> + strStaParams.ht_capa = *params->ht_capa; Doh, that's completely wrong. I had a few iterations of this and sent the wrong version. There's an embedded array in that struct (not an embedded struct as I though during one read through). Will fix and re-send, sorry for the spa

Re: [PATCH] staging: iio: tsl2x7x: Replace deprecated macros (S_IRUGO, S_IWUSR)

On 25/04/17 14:00, Paolo Cretaro wrote: > Use octal digits as suggested by checkpatch instead of deprecated macros. > > Signed-off-by: Paolo Cretaro Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/

Re: [PATCH RFC] staging: wilc1000: Refactor handling of HT caps fields

On Tue, Apr 25, 2017 at 10:54:16PM -0600, Jason Litzinger wrote: > > + strStaParams.ht_capa = *params->ht_capa; > Doh, that's completely wrong. I had a few iterations of this and sent No, it wasn't. The PATCH RFC I sent initally is correct. Apologies, had a C brain gap and worr

Re: [PATCH v3 0/2] staging: iio: isl29028: move out of staging

On 25/04/17 02:34, Brian Masney wrote: > Minor cleanup to the proximity sampling to move this driver out of > staging. > > Datasheet: > http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29028.pdf > > Changes since v2: > - Reject any value that is not in the > in_proximity_sampling_

Re: [PATCH v3 1/2] staging: iio: isl29028: correct proximity sleep times

On 25/04/17 02:34, Brian Masney wrote: > The sysfs attribute in_proximity_sampling_frequency_available currently > shows the values 1 3 5 10 13 20 83 100. These values are supposed to > correspond to the sleep values 800 400 200 100 75 50 12.5 0 (all in ms). > When passing in a sampling frequency o

Re: [PATCH v3 2/2] staging: iio: isl29028: move out of staging

On 25/04/17 02:34, Brian Masney wrote: > Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. > > Signed-off-by: Brian Masney Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/light/Kconfig| 10 + > drivers/iio/light/Makefile

Re: [PATCH v3 2/2] staging: iio: isl29028: move out of staging

On Wed, 2017-04-26 at 06:30 +0100, Jonathan Cameron wrote: > On 25/04/17 02:34, Brian Masney wrote: > > Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. > > > > Signed-off-by: Brian Masney Hey Brian. Next time it's better to use git format-patch -M to reduce the patch size

Re: [PATCH v3 2/2] staging: iio: isl29028: move out of staging

On 26/04/17 06:49, Joe Perches wrote: > On Wed, 2017-04-26 at 06:30 +0100, Jonathan Cameron wrote: >> On 25/04/17 02:34, Brian Masney wrote: >>> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline. >>> >>> Signed-off-by: Brian Masney > > Hey Brian. > > Next time it's better to