On Fri, Mar 17, 2017 at 11:26:51AM -0400, David Kershner wrote:
> This series cleans up several different checkpatch, sparse and other
> miscellaneous code issues found throughout the Unisys s-Par driver stack.
> It also cleans up the comments surrounding #defines.
>
> Note: Acceptence of this pat
Changelog from v2:
Fixed the message subject line.
Changelog from v1:
1. fixed kbuild warning for i386 build as reported by kbuild robot
2. split initialization code in two patches.
Pranay Kr. Srivastava (3):
return same error value from spk_set_key_info
remove unece
This patch removes the unnecessary allocation of
current foreground vc during initialization.
This initialization is already handled in the loop
that follows it for all available virtual consoles.
Signed-off-by: Pranay Kr. Srivastava
Reviewed-by: Samuel Thibault
---
drivers/staging/speakup/mai
This patch makes spk_set_key_info return -EINVAL
in case of failure instead of returning 4 different
values for the type of error that occurred.
Print the offending values instead as debug message.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speakup/main.c | 27 +++-
speakup_allocate used GFP_ATOMIC for allocations
even while during initialization due to it's use
in notifier call.
Pass GFP_ flags as well to speakup_allocate depending
on the context it is called in.
Signed-off-by: Pranay Kr. Srivastava
---
drivers/staging/speakup/main.c | 8
1 file
Hi Elena,
On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations
On Fri, Mar 17, 2017 at 02:56:42PM -0700, Michael Zoran wrote:
> From: Dave Stevenson
>
> The API for port_parameter_get() requires that the
> filled length is returned, or if insufficient space
> that the required space is returned.
>
> Signed-off-by: Dave Stevenson
>
> Changed path:
> From:
On Fri, Mar 17, 2017 at 02:56:43PM -0700, Michael Zoran wrote:
> Fix port_paremeter_get function blindly subtracts 8 from a reply
> size without checking that the size is at lest 8 bytes. This can
> casue a large buffer to be copied since the size is unsigned.
>
> Add a WARN_ON, and also add min a
On Wed, Mar 15, 2017 at 12:01:08PM +0530, Pushkar Jambhlekar wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
> 1 file changed, 1 insertion(+),
On Sun, Mar 19, 2017 at 03:46:11AM -0700, absh...@gmail.com wrote:
> From: Abhishek Bhardwaj
>
> Use __func__ to print dgnc_tty_send_xchar function name.
>
> Signed-off-by: Abhishek Bhardwaj
> ---
> drivers/staging/dgnc/dgnc_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> Fixed style of all block comments across whole driver
> Found by checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
> drivers/staging/ks7010/ks_hostif.h | 35 +
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 35 +++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers/stagin
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m
Moved logical AND operators to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/driv
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (7):
staging: speakup: Moved logical to previous line.
staging: speakup: Remove multiple assignments
staging: speakup: Simplify "NULL" comparisons
staging: speakup: fixes braces {} should be used
Moved logical OR operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/sta
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 21e76b
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-off-by: Arushi Singhal
---
drivers/staging/spea
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/varhandlers.c
On Tue, 2017-03-21 at 08:27 +0100, Greg KH wrote:
> On Fri, Mar 17, 2017 at 02:56:42PM -0700, Michael Zoran wrote:
> > From: Dave Stevenson
> >
> > The API for port_parameter_get() requires that the
> > filled length is returned, or if insufficient space
> > that the required space is returned.
>
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (4):
staging: speakup: Removed Unnecessary parentheses.
staging: speakup: Simplify the NULL comparisons
staging: speakup: Match alignment with open parenthesis.
staging: speakup: Fix alignment wit
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/main.c| 32 ++
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions(+
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/serialio.c | 2 +-
drivers/staging/speakup/speakup_acntpc.c |
Unnecessary parentheses are removed to improve readability.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index afb61e153592..ca8547
From: Suniel Mahesh
This patch simplifies code by replacing explicit NULL comparison
with ! or unmark operator
Reported by checkpatch.pl for comparison to NULL could be
written '!foo' or 'foo'
Signed-off-by: Suniel Mahesh
---
Changes for v5:
- Changed email address from suni...@techveda.org to
From: Suniel Mahesh
Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl
Signed-off-by: Suniel Mahesh
---
Changes for v5:
- Changed email address from suni...@techveda.org to suniel.spar...@gmail.com,
reason being few patches were being dropped and not getting delivered,
c
From: Suniel Mahesh
Changed email address from suni...@techveda.org to suniel.spar...@gmail.com,
reason being few patches were being dropped and not getting delivered,
couldn't resolve that issue.
Split earlier patches into multiple commits for easy review as
suggested by Dan Carpenter.
Modified
From: Suniel Mahesh
Fixed the following checkpatch.pl warning:
Possible unnecessary 'out of memory' message
If it is out of memory, function should return with an
appropriate error code. Since this function is of type void,
a return statement is used.
Signed-off-by: Suniel Mahesh
---
Changes fo
From: Suniel Mahesh
Fixed the following checkpatch.pl warnings:
Block comments should align the * on each line
Block comments use * on subsequent lines
Signed-off-by: Suniel Mahesh
---
Changes for v5:
- Changed email address from suni...@techveda.org to suniel.spar...@gmail.com,
reason being
From: Suniel Mahesh
Fixed the following checkpatch.pl checks:
spaces preferred around that 'operator', spacing provided
Logical continuations should be on the previous line, modified accordingly
Unnecessary parentheses around variables, removed
Please use a blank line after function/struct/union/
From: Suniel Mahesh
Fixed the following checkpatch.pl checks:
Blank lines aren't necessary after an open brace '{'
and before a close brace '}', removed
No space is necessary after a cast, removed
Please don't use multiple blank lines, removed
Signed-off-by: Suniel Mahesh
---
Changes for v5:
-
You're fixing a bug you introduced in [PATCH 1/5]. Don't do that. Just
fix Dave's patch and add a note in the commit log.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listin
On 2017-03-20 16:57:54 +0100, Hans Verkuil wrote:
> On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote:
> > On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote:
> >> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote:
> >>> It's what I have - remember, not everyone is happy to cons
On 03/21/17 11:42, Niklas Söderlund wrote:
> On 2017-03-20 16:57:54 +0100, Hans Verkuil wrote:
>> On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote:
>>> On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote:
On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote:
> It's what I
Hi!
> > Making use of the full potential of the hardware requires using a more
> > expressive interface.
>
> That's the core of the problem: most users don't need "full potential
> of the hardware". It is actually worse than that: several boards
> don't allow "full potential" of the SoC capabili
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedefs from struct
staging: sm750fb: Remove typedefs from enum
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h | 19 ---
drivers/staging/sm750fb/s
This patch removes typedefs from structure and renames them as
per kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h | 8 +++-
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 files changed, 9 i
This patch removes typedefs from enum and renames them as
per kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.h | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.h
b/drivers/staging/
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
> @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv,
> incc = imx_media_find_mbus_format(infmt->code,
> CS_SEL_ANY, true);
>
> - if (sdformat
On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> that. Just
> fix Dave's patch and add a note in the commit log.
>
> regards,
> dan carpenter
>
OK, thanks I'm still learning about the whole process. It looks like
Dave's ve
On Tue, Mar 21, 2017 at 11:59:02AM +0100, Hans Verkuil wrote:
> Ah, good to hear that -s works with MC. I was not sure about that.
> Thanks for the feedback!
Not soo good on iMX6:
$ v4l2-compliance -d /dev/video10 -s --expbuf-device=/dev/video0
...
Input ioctls:
test VIDIOC_G/S_TUNER/ENUM
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (11):
staging: speakup: Moved logical to previous line.
staging: speakup: Remove multiple assignments
staging: speakup: Simplify "NULL" comparisons
staging: speakup: fixes braces {} should be used
Moved logical operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/s
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/varhandlers.c
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 21e76b
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 35 +++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers/stagin
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/main.c| 32 ++
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-off-by: Arushi Singhal
---
drivers/staging/spea
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/serialio.c | 2 +-
drivers/staging/speakup/speakup_acntpc.c |
Unnecessary parentheses are removed to improve readability.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index afb61e153592..ca8547
Moved logical OR operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/sta
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions(+
On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote:
> On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> > You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> > that. Just
> > fix Dave's patch and add a note in the commit log.
> >
> > regards,
> > dan carpenter
> >
>
On Tue, 2017-03-21 at 14:45 +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote:
> > On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> > > You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> > > that. Just
> > > fix Dave's patch and add a
On Tue, Mar 21, 2017 at 04:56:38PM +0530, Arushi Singhal wrote:
> This patch removes typedefs from structure and renames them as
> per kernel coding standards.
In the subject, and in the text, say _which_ typedef you changed, and
what you changed it to.
Same for your patch 2/2.
thanks,
greg k-h
On Tue, Mar 21, 2017 at 04:51:03AM -0700, Michael Zoran wrote:
> The original version seems to have been applied at this point. The
> whole function looks like it could use some cleanup in general. Should
> I just submit those an independent patch when I get to it or should I
> submit a V2 the wa
On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote:
> Checkpatch emits CHECK: Unbalanced braces around else
> statement. Statements in question are single statements so we do not
> need braces. Checkpatch also warns about multiple line dereference for
> this code.
>
> Fix if/else/els
Replace simple_strtoul with kstrtoint.
simple_strtoul is marked for obsoletion as reported by checkpatch.pl
Signed-off-by: Marcin Ciupak
---
v2:
-improving kstrtoint error handling
-updating commit message
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 16
On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote:
> Comparison, equal to zero, is redundant
>
> 'if (foo == 0)' is equal to 'if (!foo)'
>
> Typical kernel coding style is to use the shorter form.
>
> Remove unnecessary zero comparison.
Not exactly. If you're talking about the
On Tue, Mar 21, 2017 at 01:37:12PM +1100, Tobin C. Harding wrote:
> static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32
> address,
> unsigned char *data, unsigned int size)
> {
> - int rc;
> + int ret;
> unsigned char *read_buf;
>
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
> Resolving 2 checkpatch warnings generated due to:
> CHECK: spaces preferred around that '-'
>
> Signed-off-by: Matthew Giassa
> ---
> drivers/staging/vt6656/rf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> d
Patchseries of IIO coding tasks
Arushi Singhal (2):
staging: ad7759: Replace mlock with driver private lock
staging: iio: ade7759: Move header content to implementation file
drivers/staging/iio/meter/ade7759.c | 56 +--
drivers/staging/iio/meter/ade7759.h
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
The contents of ade7759.h are only used in ade7759.c.
Move the header contents to the implemtation file,
and delete the header file.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 52 ++-
drivers/staging/iio/meter/ade7759.h | 54 --
* Dan Carpenter [2017-03-21 15:55:52 +0300]:
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
Resolving 2 checkpatch warnings generated due to:
CHECK: spaces preferred around that '-'
Signed-off-by: Matthew Giassa
---
drivers/staging/vt6656/rf.c | 6 +++---
1 file changed, 3
Hi simran,
[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.11-rc3 next-20170321]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/simran-singhal/staging-Use-buf_lock
Fixed coding style errors. No errors with checkpatch.pl
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c8..3a9d19a 100644
--
On Tue, Mar 21, 2017 at 8:01 PM, kbuild test robot wrote:
> Hi simran,
>
> [auto build test WARNING on iio/togreg]
> [also build test WARNING on v4.11-rc3 next-20170321]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
&g
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h |
This patch removes typedefs from struct and renames it from "typedef
struct _mode_parameter_t" to "struct mode_parameter" as per kernel
coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.c | 8
This patch removes typedefs from enum and renames it from "typedef enum
_spolarity_t" to "enum spolarity" as per kernel coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.h | 11 +--
1
This patch fixes the following:
- Replace spaces with tabs for indentation
- adds spaces around symbol '-'
- uses __func__ macro to print function name
- truncated the line such that it is within 80 char limit
as per kernel coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt665
On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> Patchseries of IIO coding tasks
This wouldn't be a patchset. Although they touch the same
driver, the changes are unrelated. See more below...
>
> Arushi Singhal (2):
> staging: ad7759: Replace mlock with driver private lock
T
On Tue, 21 Mar 2017, Arushi Singhal wrote:
> On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> wrote:
> On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > Patchseries of IIO coding tasks
>
> This wouldn't be a patchset. Although they touch the same
>
On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
Hi Simran,
I going to ask for a v7 without looking at the code ;)
Subject line needs subsystem and driver.
Subject and log message can be improved.
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c8
On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>
>
> On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
> > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> > wrote:
> > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > > Patchseries of IIO coding tasks
On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote:
> On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
>
> Hi Simran,
>
> I going to ask for a v7 without looking at the code ;)
> Subject line needs subsystem and driver.
> Subject and log message can be improved.
Hi Alison,
I
On Tue, 21 Mar 2017, Alison Schofield wrote:
> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> > > wrote:
> > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arus
On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
> wrote:
> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017
Michael Zoran writes:
> On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> Michael Zoran writes:
>>
>> > > > Since the API is completely documented, I see no reason we or
>> > > > anybody
>> > > > couldn't essentially rewrite the driver while it's in
>> > > > staging. I
>> > > > just
>>
On Tue, Mar 21, 2017 at 10:52:46PM +0530, Arushi Singhal wrote:
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
> wrote:
>
> > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> > >
> > > > On Tue, Mar 21, 2017 at 9:33
On Tue, Mar 21, 2017 at 10:34:01PM +0530, SIMRAN SINGHAL wrote:
> On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield
> wrote:
> > On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
> >
> > Hi Simran,
> >
> > I going to ask for a v7 without looking at the code ;)
> > Subject line need
The patch series replaces mlock with a private lock for driver ad9834 and
Fix coding style issues related to white spaces.
v3:
-Using new private "lock" instead of using "buf_lock"
as it can cause deadlock.
-Sending it as a series of two patches.
v2:
-Using the existing buf_lock instead
This patch removes trailing whitespaces in order to follow the Linux
coding style.
Signed-off-by: simran singhal
---
drivers/staging/iio/meter/ade7753.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7753.c
b/drivers/staging/iio/meter/ad
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
> -Original Message-
> From: Cathy Avery [mailto:cav...@redhat.com]
> Sent: Friday, March 17, 2017 8:18 AM
> To: KY Srinivasan ; h...@infradead.org; Haiyang Zhang
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com
> Cc: step...@networkplumber.org; dan.carpen...@oracle.com;
> de...@
On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall wrote:
>
>
>On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
>
>> wrote:
>> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>> >
>> >
>> > On Tue, 21 Ma
On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > Fixed style of all block comments across whole driver
> > Found by checkpatch
> >
> > Signed-off-by: Derek Robson
> > ---
> > drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
On Tue, Mar 21, 2017 at 10:25:40PM +0530, Prasant Jalan wrote:
> This patch replaces spaces with tabs for indentation as per kernel
> coding standards.
>
> Signed-off-by: Prasant Jalan
> ---
> drivers/staging/vt6656/rf.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> dif
On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote:
> On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
>
> Hi Simran,
>
> I going to ask for a v7 without looking at the code ;)
> Subject line needs subsystem and driver.
> Subject and log message can be improved.
>
>> The IIO s
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote:
> On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > > Fixed style of all block comments across whole driver
> > > Found by checkpatch
> > >
> > > Signed-off-by
On Wed, Mar 22, 2017 at 12:10:50AM +0530, Prasant Jalan wrote:
> This patch replaces spaces with tabs for indentation as per kernel
> coding standards.
>
> Signed-off-by: Prasant Jalan
> ---
> drivers/staging/vt6656/rf.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
Didn't
On Tue, Mar 21, 2017 at 11:33:54PM +0530, simran singhal wrote:
> The patch series replaces mlock with a private lock for driver ad9834 and
> Fix coding style issues related to white spaces.
Hi Simran,
I'm getting lost. Patchset Subject Line needs subsystem and driver.
The comment above says a
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote:
> Michael Zoran writes:
>
> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> > > Michael Zoran writes:
> > >
> > > > > > Since the API is completely documented, I see no reason we
> > > > > > or
> > > > > > anybody
> > > > > > could
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
1 - 100 of 139 matches
Mail list logo
