Without ACPI, some of the code fails to build:
media/atomisp/platform/intel-mid/atomisp_gmin_platform.c: In function
'atomisp_register_i2c_module':
media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:174:7: error:
dereferencing pointer to incomplete type 'struct acpi_device'
We could work
Without CONFIG_PCI, config space reads never return any data,
leading to undefined behavior that gcc warns about:
platform/intel-mid/intel_mid_pcihelpers.c: In function
'intel_mid_msgbus_read32_raw':
platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used
uninitialized in this func
ia_css_dequeue_param_buffers does not have an arguement type, causing a warning:
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function
'ia_css_dequeue_param_buffers':
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3728:6:
error: old-style function de
Defining a debug function to nothing causes a warning with an empty block
after if()/else():
drivers/staging/media/atomisp/i2c/ov2680.c: In function 'ov2680_s_stream':
drivers/staging/media/atomisp/i2c/ov2680.c:1208:55: error: suggest braces
around empty body in an 'else' statement [-Werror=empty
The plat_clock implementation fails ot build in some configurations:
platform/clock/vlv2_plat_clock.c: In function 'vlv2_plat_set_clock_freq':
platform/clock/vlv2_plat_clock.c:88:2: error: implicit declaration of function
'writel';did you mean 'wrmsrl'? [-Werror=implicit-function-declaration]
pla
I ran into a build warning on my randconfig build box:
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function
'ia_css_lace_statistics_free':
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:2845:64:
error: parameter 'me' set but not used [-Werror=unused
Without CONFIG_EFI, the driver fails to call efivar_entry_get:
drivers/staging/built-in.o: In function `gmin_get_config_var':
(.text+0x1e3b): undefined reference to `efivar_entry_get'
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
---
driv
The driver fails to build if this is disabled, so we need an explicit
Kconfig dependency:
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_cmd.c:6085:48: error:
'struct v4l2_subdev_fh' has no member named 'pad'
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-
One i2c driver already gained a dependency, but the others are equally broken:
drivers/staging/media/atomisp/i2c/ap1302.c: In function 'ap1302_remove':
drivers/staging/media/atomisp/i2c/ap1302.c:1143:31: error: 'struct v4l2_subdev'
has no member named 'entity'
drivers/staging/media/atomisp/i2c/mt
Adding the 'bool' symbol brought back a randconfig build bug that
I had fixed before:
drivers/staging/built-in.o: In function `vchiq_probe':
(.text+0x1da30): undefined reference to `rpi_firmware_get'
drivers/staging/built-in.o: In function `vchiq_platform_init':
(.text+0x27494): undefined referenc
Hi!
> > > Hah! That's the joy of being a maintainer of a driver in staging. Even
> > > if you filter out outreachy, you are going to get a lot of "basic
> > > mistakes" and other type patches cc:ed to you.
> > >
> > > I strongly suggest, that if you all don't like this type of stuff,
> > > eithe
On Mon, Mar 20, 2017 at 11:20:32AM +0100, Pavel Machek wrote:
> Hi!
>
> > > > Hah! That's the joy of being a maintainer of a driver in staging. Even
> > > > if you filter out outreachy, you are going to get a lot of "basic
> > > > mistakes" and other type patches cc:ed to you.
> > > >
> > > > I
On Sat, Mar 18, 2017 at 09:42:43PM -0700, Michael Zoran wrote:
> On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote:
> > > Michael Zoran hat am 17. März 2017 um 16:22
> > > geschrieben:
> > >
> > >
> > > From: Dave Stevenson
> > >
> > > Pi3 and Compute Module 3 have a GPIO expander that th
On Sat, Mar 18, 2017 at 10:40:06PM -0700, Michael Zoran wrote:
> On Sun, 2017-03-19 at 13:27 +0800, kbuild test robot wrote:
> > Hi Michael,
> >
> > [auto build test WARNING on staging/staging-testing]
> > [also build test WARNING on next-20170310]
> > [cannot apply to linux-rpi/for-rpi-next v4.11
I'm not going to review this because it has kbuild errors.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, 2017-03-20 at 13:43 +0300, Dan Carpenter wrote:
> On Sat, Mar 18, 2017 at 10:40:06PM -0700, Michael Zoran wrote:
> > On Sun, 2017-03-19 at 13:27 +0800, kbuild test robot wrote:
> > > Hi Michael,
> > >
> > > [auto build test WARNING on staging/staging-testing]
> > > [also build test WARNING
Em Sun, 19 Mar 2017 22:11:07 -0300
Mauro Carvalho Chehab escreveu:
> Em Sun, 19 Mar 2017 10:04:28 -0700
> Michael Zoran escreveu:
>
> > A working DT that I tried this morning with the current firmware is
> > posted here:
> > http://lists.infradead.org/pipermail/linux-rpi-kernel/2017-March/0059
Signed-off-by: Eddie Youseph
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bcm2048/radio-bcm2048.c
index d605c41..7d33bce 10
It doesn't need to have else statement after return.
Signed-off-by: Daeseok Youn
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
b/drivers/staging/medi
If v4l2_subdev_call() gets the global frame interval values,
it returned 0 and it could be checked whether numerator is zero or not.
If the numerator is not zero, the fps could be calculated in this function.
If not, it just returns 0.
Signed-off-by: Daeseok Youn
---
.../media/atomisp/pci/atomi
The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
it could not enter the next if-statement. But the "next" if-statement
has the condition to check whether the css_pipe_id equals to
'CSS_PIPE_ID_COPY' or not.
The V4L2_FIELD_ANY is zero, so the (!field) is same meaning
with (field == V4L2_FIELD_ANY) in if-statement.
Signed-off-by: Daeseok Youn
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/p
On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote:
> I'm not going to review this because it has kbuild errors.
>
> regards,
> dan carpenter
>
Hi, can you e-mail out the errors or send them to me. It worked when
I submitted it.
___
devel mailin
On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote:
> Em Sun, 19 Mar 2017 22:11:07 -0300
> Mauro Carvalho Chehab escreveu:
>
> > Em Sun, 19 Mar 2017 10:04:28 -0700
> > Michael Zoran escreveu:
> >
> > > A working DT that I tried this morning with the current firmware
> > > is
> > > p
On Mon, Mar 20, 2017 at 08:00:06PM +0900, Daeseok Youn wrote:
> The css_pipe_id was checked with 'CSS_PIPE_ID_COPY' in previous if-
> statement. In this case, if the css_pipe_id equals to 'CSS_PIPE_ID_COPY',
> it could not enter the next if-statement. But the "next" if-statement
> has the condition
On 03/17/2017 12:55 PM, Sakari Ailus wrote:
> Hi Russell,
>
> On 03/17/17 13:42, Russell King - ARM Linux wrote:
>> On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote:
>>> We're all very driver-development-driven, and userspace gets very little
>>> attention in general. So before just th
On Sun, Mar 19, 2017 at 11:17:08PM -0700, Jacob Zachariah wrote:
> Fix the following warning reported by sparse:
>
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect
> type in assignment (different base types)
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:5
On Sun, 2017-03-19 at 12:08 -0700, Steve Longerbeam wrote:
>
> On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote:
> > On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote:
> >> From: Philipp Zabel
> >>
> >> The csi_try_crop call in set_fmt should compare the cropping rectangle
>
Hi Mauro,
Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab:
Em Sun, 19 Mar 2017 22:11:07 -0300
Mauro Carvalho Chehab escreveu:
Em Sun, 19 Mar 2017 10:04:28 -0700
Michael Zoran escreveu:
A working DT that I tried this morning with the current firmware is
posted here:
http://lists.infra
The subject is too long.
On Mon, Mar 20, 2017 at 10:02:33PM +1100, unknown wrote:
> Signed-off-by: Eddie Youseph
You need to have a changelog.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
Am 20.03.2017 11:59, schrieb Daeseok Youn:
> If v4l2_subdev_call() gets the global frame interval values,
> it returned 0 and it could be checked whether numerator is zero or not.
>
> If the numerator is not zero, the fps could be calculated in this function.
> If not, it just returns 0.
>
> Si
Also fix your From header.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
> The above paragraph suggests we skip any rectangles that are not
> supported. In our case that would be 3. and 4., since the CSI can't
> compose into a larger frame. I hadn't realised that the crop selection
> currently happens on the
On Sun, Mar 19, 2017 at 09:19:20PM +0530, Arushi Singhal wrote:
> New variables are added to make the code more readable.
>
> Signed-off-by: Arushi Singhal
> ---
> changes in v4
> -try to make the code much more readable.
> - defined the variable at the top of a block.
> ---
> drivers/staging
On 03/19/2017 01:14 PM, Russell King - ARM Linux wrote:
> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote:
>> On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote:
>>> 0:00:01.955927879 20954 0x15ffe90 INFOv4l2
>>> gstv4l2object.c:3811:gst_v4l2_object_get_ca
2017-03-20 21:04 GMT+09:00 walter harms :
>
>
> Am 20.03.2017 11:59, schrieb Daeseok Youn:
>> If v4l2_subdev_call() gets the global frame interval values,
>> it returned 0 and it could be checked whether numerator is zero or not.
>>
>> If the numerator is not zero, the fps could be calculated in th
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with buf_lock in the devices
On 03/19/2017 06:54 PM, Steve Longerbeam wrote:
>
>
> On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote:
>> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote:
>>> Right, imx-media-capture.c (the "standard" v4l2 user interface module)
>>> is not implementing VIDIOC_ENUM_FRAMESI
On Mon, Mar 20, 2017 at 06:25:19PM +0530, Arushi Singhal wrote:
> On Mon, Mar 20, 2017 at 5:58 PM, Dan Carpenter
> wrote:
>
> > On Sun, Mar 19, 2017 at 09:19:20PM +0530, Arushi Singhal wrote:
> > > New variables are added to make the code more readable.
> > >
> > > Signed-off-by: Arushi Singhal
On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote:
>> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote:
>> [...]
>>> The big question, waiting for an answer on the last 8 years is
>>> who would do that? Such person
Am 20.03.2017 13:51, schrieb DaeSeok Youn:
> 2017-03-20 21:04 GMT+09:00 walter harms :
>>
>>
>> Am 20.03.2017 11:59, schrieb Daeseok Youn:
>>> If v4l2_subdev_call() gets the global frame interval values,
>>> it returned 0 and it could be checked whether numerator is zero or not.
>>>
>>> If the nu
On Sat, 2017-03-18 at 12:58 -0700, Steve Longerbeam wrote:
>
> On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote:
> > Hi Steve,
> >
> > I've just been trying to get gstreamer to capture and h264 encode
> > video from my camera at various frame rates, and what I've discovered
> > does not look
On Sun, 2017-03-19 at 12:14 +, Russell King - ARM Linux wrote:
> On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote:
> > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote:
> > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2
> > >gstv4l2object.c:3811:gst_v4l2
On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote:
> Em Tue, 14 Mar 2017 08:55:36 +0100
> Hans Verkuil escreveu:
>
>> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote:
>>> Hi Sakari,
>>>
>>> I started preparing a long argument about it, but gave up in favor of a
>>> simpler one.
>>>
>>> Em M
On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote:
> On 03/19/2017 06:54 PM, Steve Longerbeam wrote:
> >
> >
> > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote:
> >> What did you do with:
> >>
> >> ioctl(3, VIDIOC_REQBUFS, {count=0, type=0 /* V4L2_BUF_TYPE_??? */,
> >> memory=
On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 02:01:58PM +0100, Hans Verkuil wrote:
>> On 03/19/2017 06:54 PM, Steve Longerbeam wrote:
>>>
>>>
>>> On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote:
What did you do with:
ioctl(3, VIDIOC_REQBUFS
On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote:
> On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote:
> > I'm not going to review this because it has kbuild errors.
> >
> > regards,
> > dan carpenter
> >
>
> Hi, can you e-mail out the errors or send them to me. It worked when
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
> > The above paragraph suggests we skip any rectangles that are not
> > supported. In our case that would be 3. and 4., since the CSI can't
> > compose into a larger
New variables are added to make the code more readable.
Signed-off-by: Arushi Singhal
---
changes in v5
-try to make the code much more readable.
- defined the variable at the top of a block.
- change the variable from temp to tmp.
drivers/staging/sm750fb/ddk750_mode.c | 55
From: Colin Ian King
Currently, if pservice is null then service is set to NULL and immediately
afterwards service is dereferenced causing a null pointer dereference. Fix
this by bailing out early of the function with a null return.
Detected by CoverityScan, CID#1419681 ("Explicit null dereferen
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote:
> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote:
> > It's what I have - remember, not everyone is happy to constantly replace
> > their distro packages with random new stuff.
>
> This is a compliance test, which is continuously
On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > The same document says:
> >
> > Scaling support is optional. When supported by a subdev, the crop
> > rectangle on the subdev's sink pad is scaled to the size
[add Mauro to CC]
Am 20.03.2017 um 15:08 schrieb Colin King:
From: Colin Ian King
Currently, if pservice is null then service is set to NULL and immediately
afterwards service is dereferenced causing a null pointer dereference. Fix
this by bailing out early of the function with a null return.
Are you in need of a loan for business / personal loan? Apply now by email,
note, this offer is for serious minded people Only: web.loanf...@gmail.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/l
On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote:
> On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote:
> > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote:
> > > I'm not going to review this because it has kbuild errors.
> > >
> > > regards,
> > > dan carpenter
> > >
> >
Em Mon, 20 Mar 2017 04:08:21 -0700
Michael Zoran escreveu:
> On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote:
> > Em Sun, 19 Mar 2017 22:11:07 -0300
> > Mauro Carvalho Chehab escreveu:
> >
> > > Em Sun, 19 Mar 2017 10:04:28 -0700
> > > Michael Zoran escreveu:
> > >
> > > >
+Ramiro
On Thu, Mar 09, 2017 at 08:52:42PM -0800, Steve Longerbeam wrote:
> Add bindings documentation for the i.MX media driver.
>
> Signed-off-by: Steve Longerbeam
> ---
> Documentation/devicetree/bindings/media/imx.txt | 74
> +
> 1 file changed, 74 insertions(+)
>
On Mon, 20 Mar 2017 10:32:19 +0100
Arnd Bergmann wrote:
> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/)
> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void)
> {
Why keep the comment?
___
devel mailing list
de...@linuxdri
Em Mon, 20 Mar 2017 14:10:30 +0100
Hans Verkuil escreveu:
> On 03/17/2017 03:37 PM, Russell King - ARM Linux wrote:
> > On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote:
> >> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote:
> >> [...]
> >>> The big question, waitin
On Thu, Mar 09, 2017 at 08:52:43PM -0800, Steve Longerbeam wrote:
> Add device tree binding documentation for the OV5640 camera sensor.
>
> Signed-off-by: Steve Longerbeam
> ---
> .../devicetree/bindings/media/i2c/ov5640.txt | 45
> ++
> 1 file changed, 45 insertions(+
On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 20 Mar 2017 04:08:21 -0700
> Michael Zoran escreveu:
>
> > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote:
> > > Em Sun, 19 Mar 2017 22:11:07 -0300
> > > Mauro Carvalho Chehab escreveu:
> > >
> > > > Em
The contents of ade7754.h are only used in ade7754.c.
Move the header contents to the implementation file,
and delete the header file.
Signed-off-by: simran singhal
---
drivers/staging/iio/meter/ade7754.c | 87 ++-
drivers/staging/iio/meter/ade7754.h | 90
Collapse header file into source, and clean up includes in
implementation.
simran singhal (2):
staging: ade7754: Move header content to implementation file
staging: ade7754: Clean up #includes
drivers/staging/iio/meter/ade7754.c | 98 ++---
drivers/staging/ii
Alphabetize and separate kernel and subsystem headers.
Signed-off-by: simran singhal
---
drivers/staging/iio/meter/ade7754.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7754.c
b/drivers/staging/iio/meter/ade7754.c
index 42f7b06..f
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
Em Mon, 20 Mar 2017 08:11:41 -0700
Michael Zoran escreveu:
> On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 20 Mar 2017 04:08:21 -0700
> > Michael Zoran escreveu:
> >
> > > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote:
> > > > Em Sun, 19 Mar 20
Em Mon, 20 Mar 2017 14:24:25 +0100
Hans Verkuil escreveu:
> On 03/14/2017 11:21 AM, Mauro Carvalho Chehab wrote:
> > Em Tue, 14 Mar 2017 08:55:36 +0100
> > Hans Verkuil escreveu:
> >
> >> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote:
> >>> Hi Sakari,
> >>>
> >> We're all very driver
On Mon, 2017-03-20 at 12:33 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 20 Mar 2017 08:11:41 -0700
> Michael Zoran escreveu:
>
> > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote:
> > > Em Mon, 20 Mar 2017 04:08:21 -0700
> > > Michael Zoran escreveu:
> > >
> > > > On Mon, 201
On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote:
> To set and read colorimetry information:
> https://patchwork.linuxtv.org/patch/39350/
Thanks, I've applied all four of your patches, but there's a side effect
from that. Old media-ctl (modified by me):
- entity 53: imx219 0-0010 (2
On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote:
>> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote:
>>> It's what I have - remember, not everyone is happy to constantly replace
>>> their distro packages with random new s
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 20 Mar 2017 14:24:25 +0100
> Hans Verkuil escreveu:
> > I don't think this control inheritance patch will magically prevent you
> > from needed a plugin.
>
> Yeah, it is not just control inheritance. The driver needs
On Mon 2017-03-20 11:30:08, Greg KH wrote:
> On Mon, Mar 20, 2017 at 11:20:32AM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > > > Hah! That's the joy of being a maintainer of a driver in staging.
> > > > > Even
> > > > > if you filter out outreachy, you are going to get a lot of "basic
> > > > >
On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger
wrote:
> On Mon, 20 Mar 2017 10:32:19 +0100
> Arnd Bergmann wrote:
>
>> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/)
>> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void)
>> {
> Why keep the comment?
The comment
On Mon, 2017-03-20 at 15:43 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 02:20:16PM +0100, Philipp Zabel wrote:
> > To set and read colorimetry information:
> > https://patchwork.linuxtv.org/patch/39350/
>
> Thanks, I've applied all four of your patches, but there's a side effe
On Mon, Mar 20, 2017 at 05:29:07PM +0100, Philipp Zabel wrote:
> According to the documentation [1], you are doing the right thing:
>
> The struct v4l2_subdev_frame_interval pad references a non-existing
> pad, or the pad doesn’t support frame intervals.
>
> But v4l2_subdev_call returns -
On 03/20/2017 04:22 PM, Arushi Singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware
On Mon, Mar 20, 2017 at 02:17:05PM +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. When supported
Michael Zoran writes:
>> > Since the API is completely documented, I see no reason we or
>> > anybody
>> > couldn't essentially rewrite the driver while it's in staging. I
>> > just
>> > think it would be best for everyone if the new version was a drop
>> > in
>> > replacement for the original v
Hi Steve, Russell,
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. Wh
On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> Michael Zoran writes:
>
> > > > Since the API is completely documented, I see no reason we or
> > > > anybody
> > > > couldn't essentially rewrite the driver while it's in
> > > > staging. I
> > > > just
> > > > think it would be best for e
Em Mon, 20 Mar 2017 16:10:03 +
Russell King - ARM Linux escreveu:
> On Mon, Mar 20, 2017 at 12:39:38PM -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 20 Mar 2017 14:24:25 +0100
> > Hans Verkuil escreveu:
> > > I don't think this control inheritance patch will magically prevent you
> > > f
On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote:
> > On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
> > > The same document says:
> > >
> > > Scaling support is optional. When supported by a su
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Vitaly Kuznetsov
[ Upstream commit 59107e2f48831daedc46973ce4988605ab066de3 ]
There is a feature in Hyper-V ('Debug-VM --InjectNonMaskableInterrupt')
which injects NMI to the guest. We may want
On Mon, Mar 20, 2017 at 06:40:21PM +0100, Philipp Zabel wrote:
> On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote:
> > I have tripped over a bug in media-ctl when specifying both a crop and
> > compose rectangle - the --help output suggests that "," should be used
> > to separate t
On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote:
> On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> > Michael Zoran writes:
> >
> > > > > Since the API is completely documented, I see no reason we or
> > > > > anybody
> > > > > couldn't essentially rewrite the driver while it's in
>
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
On Mon, 2017-03-20 at 11:54 -0700, Michael Zoran wrote:
> On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote:
> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> > > Michael Zoran writes:
> > >
> > > > > > Since the API is completely documented, I see no reason we
> > > > > > or
> > >
On 03/20/2017 07:56 PM, Arushi Singhal wrote:
[...]
> @@ -413,6 +413,7 @@ int ad7606_probe(struct device *dev, int irq, void
> __iomem *base_address,
> st = iio_priv(indio_dev);
>
> st->dev = dev;
> + mutex_init(&st->lock);
This is nitpicking, but putting this in the middle of t
On 03/20/2017 07:00 AM, Philipp Zabel wrote:
On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote:
On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote:
The above paragraph suggests we skip any rectangles that are not
supported. In our case that would be 3. and 4., since
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Saturday, March 18, 2017 9:55 PM
> To: gre...@linuxfoundation.org; KY Srinivasan ;
> Haiyang Zhang
> Cc: sta...@vger.kernel.org; de...@linuxdriverproject.org; Stephen
> Hemminger
> Subject: [PATCH
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
During initialization, the channel initialization code schedules the
tasklet to scan the VMBUS receive event page (i.e. simulates an
interrupt). The problem was that it invokes the tasklet on a different
CPU from where it normally runs and therefore if an event is present,
it will clear the bit but
On Mon, Mar 20, 2017 at 07:53:18AM -0700, Michael Zoran wrote:
> On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote:
> > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote:
> > > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote:
> > > > I'm not going to review this because it h
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
> --8<--
> >From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001
> From: Philipp Zabel
> Date: Mon, 20 Mar 2017 17:10:21 +0100
> Subject: [PATCH] media: imx: csi: add sink selection rectangles
>
> Mov
> -Original Message-
> From: Long Li
> Sent: Sunday, March 19, 2017 7:49 PM
> To: 'Vitaly Kuznetsov'
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH] HV: properly delay KVP packets when nego
2017-03-20 22:11 GMT+09:00 walter harms :
>
>
> Am 20.03.2017 13:51, schrieb DaeSeok Youn:
>> 2017-03-20 21:04 GMT+09:00 walter harms :
>>>
>>>
>>> Am 20.03.2017 11:59, schrieb Daeseok Youn:
If v4l2_subdev_call() gets the global frame interval values,
it returned 0 and it could be checked
It doesn't need to have else statement after return.
Signed-off-by: Daeseok Youn
---
V2: one(2/4) of this series was updated so I tried to send them again.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/
1 - 100 of 127 matches
Mail list logo
