Am 17.03.2017 00:21, schrieb Colin King:
> From: Colin Ian King
>
> The pmkid data is meant be be copied to the previous item in the
> pmkidlist, however the code is just copying the data to itself because
> the src index into pmkidlist is the same as the dst index into pmkidlist.
> Fix this wi
On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote:
>
> On 03/12/2017 02:32 PM, simran singhal wrote:
> > The IIO subsystem is redefining iio_dev->mlock to be used by
> > the IIO core only for protecting device operating mode changes.
> > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_
On Thu, Mar 16, 2017 at 11:25:36PM +0100, Paolo Bonzini wrote:
> The kvmclock memory is initially zero so there is no need for the
> hypervisor to allocate anything; the point of these patches is just to
> access the data in a natural way from Linux source code.
I realize that.
> I also don't rea
On 17/03/2017 11:17, Borislav Petkov wrote:
>
>> I also don't really like the patch as is (plus it fails modpost), but
>> IMO reusing __change_page_attr and __split_large_page is the right thing
>> to do.
>
> Right, so teaching pageattr.c about memblock could theoretically come
> around and bit
On Fri, Mar 17, 2017 at 11:47:16AM +0100, Paolo Bonzini wrote:
> Theoretically or practically?
In the sense, it needs to be tried first to see how ugly it can get.
> It only looks at the E820 map, doesn't it? Why does it have to do
> anything with percpu memory areas?
That's irrelevant. What we
On 17/03/2017 11:56, Borislav Petkov wrote:
>> Theoretically or practically?
> In the sense, it needs to be tried first to see how ugly it can get.
>
>> It only looks at the E820 map, doesn't it? Why does it have to do
>> anything with percpu memory areas?
> That's irrelevant. What we want to d
On 16/03/2017 19:41, Brijesh Singh wrote:
>>
>> Please do add it, it doesn't seem very different from what you're doing
>> in LAUNCH_UPDATE_DATA. There's no need for a separate
>> __sev_dbg_decrypt_page function, you can just pin/unpin here and do a
>> per-page loop as in LAUNCH_UPDATE_DATA.
>
On Fri, Mar 17, 2017 at 12:03:31PM +0100, Paolo Bonzini wrote:
> If it is possible to do it in a fairly hypervisor-independent manner,
> I'm all for it. That is, only by looking at AMD-specified CPUID leaves
> and at kernel ELF sections.
Not even that.
What that needs to be able to do is:
On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote:
> We're all very driver-development-driven, and userspace gets very little
> attention in general. So before just throwing in the towel we should take
> a good look at the reasons why there has been little or no development: is
> it beca
Hi Russell,
On 03/17/17 13:42, Russell King - ARM Linux wrote:
> On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote:
>> We're all very driver-development-driven, and userspace gets very little
>> attention in general. So before just throwing in the towel we should take
>> a good look at
On Fri, 2017-03-17 at 11:42 +, Russell King - ARM Linux wrote:
> On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote:
> > We're all very driver-development-driven, and userspace gets very little
> > attention in general. So before just throwing in the towel we should take
> > a good lo
On Fri, Mar 17, 2017 at 01:02:07PM +0100, Philipp Zabel wrote:
> I think most of the simple, fixed pipeline use cases could be handled by
> libv4l2, by allowing to pass a v4l2 subdevice path to v4l2_open. If that
> function internally would set up the media links to the
> nearest /dev/video interfa
Em Fri, 17 Mar 2017 13:55:33 +0200
Sakari Ailus escreveu:
> Hi Russell,
>
> On 03/17/17 13:42, Russell King - ARM Linux wrote:
> > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote:
> >> We're all very driver-development-driven, and userspace gets very little
> >> attention in gener
Enclosed is a patch to the file video.c. It only fixes style warning
flagged by checkpatch.pl.
Please let me know if anything else needs to be done.
Signed-off-by: Chandra Annamaneni
Thanks.
Chandra
diff --git a/drivers/staging/most/aim-v4l2/video.c
b/drivers/staging/most/aim-v4l2/video.
Fix the patch prefix. It should be:
[PATCH v2] Staging: most: use __func__ instead of the function name
On Fri, Mar 17, 2017 at 06:36:18AM -0700, Chandra Annamaneni wrote:
>
>
> Enclosed is a patch to the file video.c. It only fixes style warning
> flagged by checkpatch.pl.
>
> Please let me
On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote:
[...]
> The big question, waiting for an answer on the last 8 years is
> who would do that? Such person would need to have several different
> hardware from different vendors, in order to ensure that it has
> a generic solution.
>
> I
On 3/16/2017 3:04 PM, Tom Lendacky wrote:
On 3/7/2017 8:59 AM, Borislav Petkov wrote:
On Thu, Mar 02, 2017 at 10:13:32AM -0500, Brijesh Singh wrote:
From: Tom Lendacky
In order for memory pages to be properly mapped when SEV is active, we
need to use the PAGE_KERNEL protection attribute as th
On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote:
> On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote:
> [...]
> > The big question, waiting for an answer on the last 8 years is
> > who would do that? Such person would need to have several different
> > hardware from diffe
On 17/03/2017 12:33, Borislav Petkov wrote:
> On Fri, Mar 17, 2017 at 12:03:31PM +0100, Paolo Bonzini wrote:
>
>> If it is possible to do it in a fairly hypervisor-independent manner,
>> I'm all for it. That is, only by looking at AMD-specified CPUID leaves
>> and at kernel ELF sections.
>
> N
On 3/17/2017 9:32 AM, Tom Lendacky wrote:
On 3/16/2017 3:04 PM, Tom Lendacky wrote:
On 3/7/2017 8:59 AM, Borislav Petkov wrote:
On Thu, Mar 02, 2017 at 10:13:32AM -0500, Brijesh Singh wrote:
From: Tom Lendacky
In order for memory pages to be properly mapped when SEV is active, we
need to use
Included in the current storvsc driver for Hyper-V is the ability
to access luns on an FC fabric via a virtualized fiber channel
adapter exposed by the Hyper-V host. The driver also attaches to
the FC transport to allow host and port names to be published under
/sys/class/fc_host/hostX. Current cus
The firmware now has a mailbox API for performing generalized gpio through
the firmware. This driver builds upon a driver written by Dave Stevenson
that was written specifically for the expander on the RPI 3, but I have
generalized for generic GPIO through the firmware.
With this change I was ab
From: Dave Stevenson
Pi3 and Compute Module 3 have a GPIO expander that the
VPU communicates with.
There is a mailbox service that now allows control of this
expander, so add a kernel driver that can make use of it.
Pwr_led node added to device-tree for Pi3.
Signed-off-by: Dave Stevenson
Stri
The original change this driver is based on adds the needed mailbox
defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not
appropriate at this time, so add the defines directly into the
driver source.
This change is based on:
https://github.com/raspberrypi/linux
Branch: rpi-4.11.y(com
Since this driver is really a generalized mechanism for doing GPIO
through the firmware, add a new compatible id for
brcm,bcm2835-firmware-gpio.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
The toplevel config for vc04_services is CONFIG_BCM2835_VCHIQ.
Since other drivers are being added that don't use vchiq,
change the toplevel Makefile to use CONFIG_BCM_VIDEOCORE.
Signed-off-by: Michael Zoran
---
drivers/staging/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
This change adds the driver to the standard kernel build system.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/Kconfig| 2 ++
drivers/staging/vc04_services/Makefile | 1 +
drivers/staging/vc04_services/bcm2835-firmware-gpio/Kconfig
This change adds the following optional DT properties:
number-gpios: Number of GPIOs the device should expose
gpio-base: GPIO base that is registered with the kernel
firmware-gpio-base: GPIO bases as viewed by the firmware
The purpose of these DT nodes is to make the driver more
general.
Signed-
Hi!
>
> Hah! That's the joy of being a maintainer of a driver in staging. Even
> if you filter out outreachy, you are going to get a lot of "basic
> mistakes" and other type patches cc:ed to you.
>
> I strongly suggest, that if you all don't like this type of stuff,
> either:
> - work to
This series cleans up several different checkpatch, sparse and other
miscellaneous code issues found throughout the Unisys s-Par driver stack.
It also cleans up the comments surrounding #defines.
Note: Acceptence of this patch series determines whether or not the team
will partake in a soft, sweet
From: Alexander Curtin
COVERQ is functionally equivalent to DIV_ROUND_UP and was only used
to define the COVER macro.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 5 +
1 file changed, 1 insertion(+), 4
From: Sameer Wadgaonkar
Removed unused functions issue_vmcall_update_physical_time() and
issue_vmcall_query_guest_virtual_time_offset() from visorchipset.c
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c
From: Sameer Wadgaonkar
Removed inline keyword from the functions in visorchipset:
* issue_vmcall_io_controlvm_addr()
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+)
From: Sameer Wadgaonkar
Removed unused function spar_check_channel_server from channel.h
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 19 ---
1 file changed, 19 deletions(-)
diff --git a/d
From: David Binder
Remove local variable on stack by directly returning the value in the
array.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorinput/visorinput.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
From: Alexander Curtin
The comment referencing virtpci was irrelevant.
Signed-off-by: Alexander Curtin
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/visorbu
From: Sameer Wadgaonkar
Removed inline keyword from the function complete_taskmgmt_command
in visorhba_main.c
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorhba/visorhba_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
From: Sameer Wadgaonkar
Removed unused macro spar_signal_init from channel.h
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/un
From: Sameer Wadgaonkar
Removed inline keyword from functions sig_read_data and
sig_write_data in visorchannel.c
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 4 ++--
1 file changed, 2 insertions(+),
From: David Binder
Addresses checkpatch check by wrapping macro argument in parenthesis.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
From: David Binder
Removes unnecessary cast of to __iomem of a non-io-mapped pointer, thereby
eliminating the following sparse warning:
visorchannel.c:159:17: warning: cast adds address space to expression ()
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
From: David Binder
Adds identifier to function definition arguments to satisfy checkpatch
warnings:
WARNING: function definition argument 'struct visor_driver *' should also
have an identifier name
WARNING: function definition argument 'struct visor_driver *' should also
have an
From: Jon Frisch
This patch removes the unused function declarations
in channel.h.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 80 +-
1 file changed, 80 deletions(-)
diff --git a/drivers
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
Renames __IOMONINTF_H__ to __VMCALLINTERFACE_H__, which more closely
reflects the naming conventions of the code.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 6 +++---
1 file change
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
Removes checks that all visor_device instances have an associated
visorchannel. Due to the design of the s-Par drivers these checks are
unnecessary.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
The function spar_check_channel_client shouldn't need to do
readq's, it is referencing a local copy of the channel
header. Simplify it to just access the fields directly.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 37 --
From: David Binder
Rename #define VMCALL_IO_CONTROLVM_ADDR to VMCALL_CONTROLVM_ADDR, as this
vmcall can be used by any partition, not just the IO partition.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c|
From: Jon Frisch
This patch removes the #pragma directive from visorchannel.h
and adds the __packed keyword to all structs to suppress structure
padding.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vbuschannel.h | 10 +++--
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: Jon Frisch
This patch removes inline functions in visornic_main.c.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/
From: Jon Frisch
This patch removes the unused macro lengthof.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/include/channel.h
b/drivers/
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
Move function add_physinfo_entries() to visornic_main.c, which is the
only function where it is used.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 37 +--
drivers/stagi
From: David Binder
In an effort to create a more uniform coding style within the Unisys
s-Par driver set, this patch adjusts the formatting of all #define
directives within this source file to match the following template,
and thereby eliminate irregular usage of whitespace:
Reviewed-by: Tim Sell
From: David Binder
Replace references to virtpci to visornic in iochannel.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/iochannel.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
From: David Binder
Removes unused #defines pertaining to visorchannel UUIDs.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/unisys/i
From: Sameer Wadgaonkar
Removed unused structure pci_id from controlvmchannel.h
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/controlvmchannel.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/stagi
From: Jon Frisch
This patch removes comments that are no longer relevant
in channel.h.
Signed-off-by: Jon Frisch
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/uni
Long Li writes:
> The host may send multiple KVP packets before the negotiation with daemon
> is finished. We need to keep those packets in ring buffer until the daemon
> is negotiated and connected.
The patch looks OK but previously we always presumed that this can't
happen for util drivers and
Hi Michael,
Am 17.03.2017 um 16:22 schrieb Michael Zoran:
The firmware now has a mailbox API for performing generalized gpio through
the firmware. This driver builds upon a driver written by Dave Stevenson
that was written specifically for the expander on the RPI 3, but I have
generalized for
On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote:
> Hi Michael,
>
>
> Am 17.03.2017 um 16:22 schrieb Michael Zoran:
> > The firmware now has a mailbox API for performing generalized gpio
> > through
> > the firmware. This driver builds upon a driver written by Dave
> > Stevenson
> > that w
On Fri, 17 Mar 2017, Pavel Machek wrote:
> Hi!
>
> >
> > Hah! That's the joy of being a maintainer of a driver in staging. Even
> > if you filter out outreachy, you are going to get a lot of "basic
> > mistakes" and other type patches cc:ed to you.
> >
> > I strongly suggest, that if you all d
Hi Michael,
> Michael Zoran hat am 17. März 2017 um 17:48 geschrieben:
>
>
> On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote:
> > Hi Michael,
> >
> >
> > Am 17.03.2017 um 16:22 schrieb Michael Zoran:
> > > The firmware now has a mailbox API for performing generalized gpio
> > > through
On Fri, 2017-03-17 at 18:24 +0100, Stefan Wahren wrote:
> Hi Michael,
>
> > Michael Zoran hat am 17. März 2017 um 17:48
> > geschrieben:
> >
> >
> > On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote:
> > > Hi Michael,
> > >
> > >
> > > Am 17.03.2017 um 16:22 schrieb Michael Zoran:
> > >
Em Fri, 17 Mar 2017 12:16:08 +
Russell King - ARM Linux escreveu:
> On Fri, Mar 17, 2017 at 01:02:07PM +0100, Philipp Zabel wrote:
> > I think most of the simple, fixed pipeline use cases could be handled by
> > libv4l2, by allowing to pass a v4l2 subdevice path to v4l2_open. If that
> > func
On 03/10/2017 12:53 AM, Sumit Semwal wrote:
> Hi Laura,
>
> Thanks for the patch.
>
> On 3 March 2017 at 03:14, Laura Abbott wrote:
>>
>> Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it
>> useful to have an explicit name attached to each region. Store the name
>> in each
Change video.c to use %s, __func__ instead of function names.
Warnings flagged by checkpatch.pl
Signed-off-by: Chandra Annamaneni
diff --git a/drivers/staging/most/aim-v4l2/video.c
b/drivers/staging/most/aim-v4l2/video.c
index e074841..59e861e 100644
--- a/drivers/staging/most/aim-v4l2/video.
We call this function with the lock held and should also return with the
lock held as well. This one error path is not-consistent because we
should return without the lock held.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
b/drivers/staging/
There are some error paths in atomisp_css_frame_allocate() which don't
initialize "res" so it could lead us to try release random memory.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/atomisp/pci/atomisp2
This series imports a improved version of the port_paramter_get function
for the camera from the github tree. The patch does not pass
checkpatch.pl but I thought it's better the change gets in.
I improved upon that patch by fixing a possible integer underrun.
I finished the TODO item of the race
From: Dave Stevenson
The API for port_parameter_get() requires that the
filled length is returned, or if insufficient space
that the required space is returned.
Signed-off-by: Dave Stevenson
Changed path:
From: drivers/media/platform/bcm2835/mmal-vchiq.c
To: drivers/staging/vc04_services/bcm
The camera currently doesn't start if vchiq hasn't connected yet.
Vchiq does have a mechanism to receive a callback when vchiq is
connected. So instead of connecting to the camera immedialy,
wait for the callback.
This fixed TODO issue #4
Signed-off-by: Michael Zoran
---
.../vc04_services/bcm28
Fix port_paremeter_get function blindly subtracts 8 from a reply
size without checking that the size is at lest 8 bytes. This can
casue a large buffer to be copied since the size is unsigned.
Add a WARN_ON, and also add min and max conditions to the size
of the data that is copied.
Signed-off-by:
The connected callback mechanism of vchiq is missing the ability
to remove a connected callback, such as when a module unloads.
So add the vchiq_remove_connected_callback to support unloading
modules that hook into vchiq.
Signed-off-by: Michael Zoran
---
.../interface/vchiq_arm/vchiq_connected.
The TODO list has port the camera to ARM64. That's done.
The list also mentions the error where the camera module won't
load if the camera isn't connected yet. vchiq already has
a mechanism to deal with calling back into consumer when vchiq
connects, so instead of adding more code hook into that
On Thu, 2 Mar 2017 12:32:55 +
Dexuan Cui wrote:
> With the recent introduction of per-channel tasklet, we need to update
> the way we handle the 3 concurrency issues:
>
> 1. hv_process_channel_removal -> percpu_channel_deq vs.
>vmbus_chan_sched -> list_for_each_entry(..., percpu_list);
>
During initialization, the channel initialization code schedules the
tasklet to scan the VMBUS receive event page (i.e. simulates an
interrupt). The problem was that it invokes the tasklet on a different
CPU from where it normally runs and therefore if an event is present,
it will clear the bit but
Mauro Carvalho Chehab writes:
> Em Wed, 15 Mar 2017 18:46:24 -0700
> Michael Zoran escreveu:
>
>> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote:
>>
>> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work.
>> > Perhaps I'm missing some other patch. I'm compiling it
Hi,
This is v2 of the series to do some serious Ion clean up in preparation for
moving out of staging. I got good feedback last time so this series mostly
attempts to address that feedback and do more still more cleanup. Highlights:
- All calls to DMA APIs should now be with a real actual proper
Frameworks (e.g. Ion) may want to iterate over each possible CMA area to
allow for enumeration. Introduce a function to allow a callback.
Signed-off-by: Laura Abbott
---
include/linux/cma.h | 2 ++
mm/cma.c| 14 ++
2 files changed, 16 insertions(+)
diff --git a/include
The align field was supposed to be used to specify the alignment of
the allocation. Nobody actually does anything with it except to check
if the alignment specified is out of bounds. Since this has no effect
on the actual allocation, just remove it.
Signed-off-by: Laura Abbott
---
drivers/stagi
The reference counting of dma_map calls was removed. Remove the
associated counter field as well.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion_priv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_priv.h
b/drivers/staging/android/ion/ion
Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it
useful to have an explicit name attached to each region. Store the name
in each CMA structure.
Signed-off-by: Laura Abbott
---
drivers/base/dma-contiguous.c | 5 +++--
include/linux/cma.h | 4 +++-
mm/cma.c
Ion currently returns a single sg_table on each dma_map call. This is
incorrect for later usage.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion.c
Ion is now moving towards a unified interfact. This makes the custom
ioctl interface unneeded. Remove it.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/compat_ion.c | 40
drivers/staging/android/ion/ion-ioctl.c | 11 -
drivers/staging/andr
Technically, calling dma_buf_map_attachment should return a buffer
properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to
ensure this happens. As a side effect, this lets Ion buffers take
advantage of the dma_buf sync ioctls.
Signed-off-by: Laura Abbott
---
drivers/staging/android/
Now that we have proper caching, stop setting the DMA address manually.
It should be set after properly calling dma_map.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/staging/androi
When CMA was first introduced, its primary use was for DMA allocation
and the only way to get CMA memory was to call dma_alloc_coherent. This
put Ion in an awkward position since there was no device structure
readily available and setting one up messed up the coherency model.
These days, CMA can b
The new method of syncing with dma_map means that the page faulting sync
implementation is no longer applicable. Remove it.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 117 --
1 file changed, 117 deletions(-)
diff --git a/drivers/stag
Device specific platform support has been haphazard for Ion. There have
been several independent attempts and there are still objections to
what bindings exist right now. Just remove everything for a fresh start.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/Kconfig
To: Sumit Semwal
To: Riley Andrews
Cc: rom...@google.com
To: a...@android.com
To: Riley Andrews
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Cc: Greg Kroah-Hartman
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-me...@vger.kernel.org
Cc:
Now that we call dma_map in the dma_buf API callbacks there is no need
to use the existing cache APIs. Remove the sync ioctl and the existing
bad dma_sync calls. Explicit caching can be handled with the dma_buf
sync API.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/compat_ion.c
1 - 100 of 109 matches
Mail list logo
