[PATCH] scsi: storvsc: remove return at end of void function

2017-03-16 Thread Miguel Bernal Marin
storvsc_on_channel_callback is a void function and the return statement at the end is not useful. Found with checkpatch. Signed-off-by: Miguel Bernal Marin --- drivers/scsi/storvsc_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c

Re: [patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 06:51:54AM +, Okash Khawaja wrote: > On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote: > > On Tue, Mar 14, 2017 at 01:41:55PM +, Okash Khawaja wrote: > > > This moves spk_synth_immediate and spk_serial_synth_probe functions into > > > serialio.c. Th

Re: [PATCH v3 0/2] staging: checkpatch cleanups

2017-03-16 Thread Greg KH
On Thu, Mar 16, 2017 at 12:02:25PM +0530, Arushi Singhal wrote: > > > On Tue, Mar 14, 2017 at 3:35 AM, Greg KH wrote: > > On Tue, Mar 14, 2017 at 01:49:52AM +0530, Arushi Singhal wrote: > > Improve readability by fixing multiple checkpatch.pl > > issues in drivers. > > > > A

Re: [PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-16 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 03:32:50PM +0900, Greg Kroah-Hartman wrote: > On Thu, Mar 16, 2017 at 03:46:58PM +1100, Tobin C. Harding wrote: > > On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote: > > > On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote: > > > > Driver code

Re: Michael MIC

2017-03-16 Thread Wolfram Sang
Hi, > Is there some technical reason why module ks7010 includes a > implementation of Michael MIC instead of using the implementation in > crypto/? > > Or is this covered by the statement from the TODO > > - check what other upstream wireless mechanisms can be used instead of the > custom ones

[patch 4/4] staging: speakup: move those functions which do outgoing serial comms, into serialio.c

2017-03-16 Thread Okash Khawaja
This moves spk_synth_immediate and spk_serial_synth_probe functions into serialio.c. These functions do outgoing serial comms. The move is a step towards collecting all serial comms in serialio.c. This also renames spk_synth_immediate to spk_serial_synth_immediate. Code inside those functions has

Re: [PATCH] staging: android: ion: reduce lock contention latency

2017-03-16 Thread junil0814....@lge.com
On 03/15/2017 2:10 AM, Laura Abbott wrote: > On 03/14/2017 12:51 AM, Junil Lee wrote: >> Replace list into lock-less list of ion page pool. >> >> Measure how mutex lock contention latency on android. >> >> 1. the test is done under android 7.0 >> 2. startup many applications circularly >> 3. find

Re: [patch 0/7] staging: speakup: introduce tty-based comms

2017-03-16 Thread Samuel Thibault
Hello, Also, could serdev also provide an send_xchar function similar to the send_xchar tty driver function? We need this to send high-priority characters. Samuel ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philipp Zabel
On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > > with those, it will likely run with any other application. > > > > > > > I would like t

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-16 Thread Mauro Carvalho Chehab
Em Wed, 15 Mar 2017 18:46:24 -0700 Michael Zoran escreveu: > On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: > > > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. > > Perhaps I'm missing some other patch. I'm compiling it from > > the Greg's staging tree (branch

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philippe De Muyter
On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > > > with those, it wil

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philipp Zabel
On Thu, 2017-03-16 at 10:47 +0100, Philippe De Muyter wrote: > On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > > > I would say: camorama, xa

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-16 Thread Borislav Petkov
On Fri, Mar 10, 2017 at 10:35:30AM -0600, Brijesh Singh wrote: > We could update this patch to use the below logic: > > * CPUID(0) - Check for AuthenticAMD > * CPID(1) - Check if under hypervisor > * CPUID(0x8000) - Check for highest supported leaf > * CPUID(0x801F).EAX - Check for SME

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philippe De Muyter
On Thu, Mar 16, 2017 at 11:01:56AM +0100, Philipp Zabel wrote: > On Thu, 2017-03-16 at 10:47 +0100, Philippe De Muyter wrote: > > On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > > > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > > > Le mercredi 15 mars 2017 à 11:50

Re: [RFC PATCH v2 23/32] kvm: introduce KVM_MEMORY_ENCRYPT_OP ioctl

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:17, Brijesh Singh wrote: > If hardware supports encrypting then KVM_MEMORY_ENCRYPT_OP ioctl can > be used by qemu to issue platform specific memory encryption commands. > > Signed-off-by: Brijesh Singh > --- > arch/x86/include/asm/kvm_host.h |2 ++ > arch/x86/kvm/x86.c

Re: [RFC PATCH v2 24/32] kvm: x86: prepare for SEV guest management API support

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:17, Brijesh Singh wrote: > ASID management: > - Reserve asid range for SEV guest, SEV asid range is obtained through >CPUID Fn8000_001f[ECX]. A non-SEV guest can use any asid outside the SEV >asid range. How is backwards compatibility handled? > - SEV guest must have

Re: [RFC PATCH v2 32/32] x86: kvm: Pin the guest memory when SEV is active

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:18, Brijesh Singh wrote: > The SEV memory encryption engine uses a tweak such that two identical > plaintexts at different location will have a different ciphertexts. > So swapping or moving ciphertexts of two pages will not result in > plaintexts being swapped. Relocating (or mi

Re: [RFC PATCH v2 26/32] kvm: svm: Add support for SEV LAUNCH_UPDATE_DATA command

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:17, Brijesh Singh wrote: > +static struct page **sev_pin_memory(unsigned long uaddr, unsigned long ulen, > + unsigned long *n) > +{ > + struct page **pages; > + int first, last; > + unsigned long npages, pinned; > + > + /* Get numbe

Re: [RFC PATCH v2 29/32] kvm: svm: Add support for SEV DEBUG_DECRYPT command

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:18, Brijesh Singh wrote: > +static int __sev_dbg_decrypt_page(struct kvm *kvm, unsigned long src, > + void *dst, int *error) > +{ > + inpages = sev_pin_memory(src, PAGE_SIZE, &npages); > + if (!inpages) { > + ret = -ENOMEM; > + goto err

Re: [RFC PATCH v2 30/32] kvm: svm: Add support for SEV DEBUG_ENCRYPT command

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:18, Brijesh Singh wrote: > + data = (void *) get_zeroed_page(GFP_KERNEL); The page does not need to be zeroed, does it? > + > + if ((len & 15) || (dst_addr & 15)) { > + /* if destination address and length are not 16-byte > + * aligned then: > +

Re: [RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:15, Brijesh Singh wrote: > Some KVM specific MSR's (steal-time, asyncpf, avic_eio) allocates per-CPU > variable at compile time and share its physical address with hypervisor. > It presents a challege when SEV is active in guest OS. When SEV is active, > guest memory is encrypted

Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names

2017-03-16 Thread Dan Carpenter
You should have put a v3 in the subject and a changelog under the --- cut off but otherwise it looks good. Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/drive

[PATCH] Staging: goldfish: use __func__ instead of embedded function names v3

2017-03-16 Thread Mohsin Shan
Embedded function names are less appropriate to use when refactoring, can cause function renaming. Prefer the use of "%s", __func__ to embedded function names Signed-off-by: Mohsin Shan --- drivers/staging/goldfish/goldfish_nand.c | 16 1 file changed, 8 insertions(+), 8 deleti

Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-16 Thread Dan Carpenter
On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > Code uses identifiers retval, ret, and rc all for function return > > values. It would be more readable if the whole driver used a single > > identifier for th

Re: [PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-16 Thread Dave Stevenson
On 16 March 2017 at 05:11, Eric Anholt wrote: > Greg KH writes: > >> On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote: >>> You've got a reason. It's GPLv2 licenced code so I have no control >>> over what happens to it. >>> Everywhere I have worked, when a patch has issues it is bett

Re: [PATCH] vc04_services: Fixing coding guideline error

2017-03-16 Thread Dan Carpenter
On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote: > Any comment? > You're too impatient. Wait for 2 weeks before asking for responses. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linux

[PATCH 4/6] staging: ks7010: use le16_to_cpu for arithmetic

2017-03-16 Thread Tobin C. Harding
Code performs arithmetic using a little endian type mixed with non-endian types. This won't work on big endian architectures. Wrap little endian type in call to le16_to_cpu before doing arithmetic. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 13 ++--- 1 file

[PATCH 3/6] staging: ks7010: set lval type of cpu_to_leXX()

2017-03-16 Thread Tobin C. Harding
Sparse emits numerous warning: incorrect type in assignment. These are all caused by calls to cpu_to_le16() and cpu_to_le32(). Any identifier that is used as an lval in a call to one of these functions should be a little endian type. The size of the type is deterministic because of the size return

[PATCH 2/6] staging: ks7010: change unsigned short to __be16

2017-03-16 Thread Tobin C. Harding
Sparse emits warning: cast to restricted __be16. This warning is caused by passing an unsigned short as argument to ntohs(). ntohs() is defined in linux/byteorder/generic.h (via __ntohs()) to __be16_to_cpu(). The argument should therefore be big endian. Change data type unsigned short -> __be16.

[PATCH 0/6] staging: ks7010: fix endian issues

2017-03-16 Thread Tobin C. Harding
Sparse emits numerous warnings highlighting endian issues. The endianess is deterministic because the function calls that are causing the issues either accept as parameters, or return as results, types of specific size and endianess. We can use these types as a guide in changing variable declaratio

[PATCH 6/6] staging: ks7010: use le16_to_cpu() to queue event

2017-03-16 Thread Tobin C. Harding
Events are stored as a circular buffer of integers. An event is of type __le16, to store this in the buffer we need to convert it to the endianess of the cpu. Call le16_to_cpu() before adding event to events buffer. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 2 +-

[PATCH 5/6] staging: ks7010: add endian non-specific variable

2017-03-16 Thread Tobin C. Harding
Sparse emits warning: restricted __le16 degrades to integer. This is caused by a comparison between an endian type and a constant. Before comparison can be safely done we need to convert the endian type to the endianess of the cpu. Declare kernel standard type and convert endian type with call to

[PATCH 1/6] staging: ks7010: rename sk_buf ptr to skb

2017-03-16 Thread Tobin C. Harding
There are 8088 struct sk_buf pointers declared in the kernel under net/ of these 6670 are call skb. This is an indication that 'skb' a better identifier than 'packet' for an sk_buf pointer. Rename packet -> skb Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 40

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-16 Thread Paolo Bonzini
On 02/03/2017 16:15, Brijesh Singh wrote: > > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, > -struct page *base) > + pte_t *pbase, unsigned long new_pfn) > { > - pte_t *pbase = (pte_t *)page_address(base); Just one comment and

Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-16 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 02:29:04PM +0300, Dan Carpenter wrote: > On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > > Code uses identifiers retval, ret, and rc all for function return > > > values. It would b

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-16 Thread Paolo Bonzini
On 10/03/2017 23:41, Brijesh Singh wrote: >> Maybe there's a reason this fires: >> >> WARNING: modpost: Found 2 section mismatch(es). >> To see full details build your kernel with: >> 'make CONFIG_DEBUG_SECTION_MISMATCH=y' >> >> WARNING: vmlinux.o(.text+0x48edc): Section mismatch in reference fro

Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names v3

2017-03-16 Thread Greg KH
On Thu, Mar 16, 2017 at 04:25:54AM -0700, Mohsin Shan wrote: > Embedded function names are less appropriate to use when > refactoring, can cause function renaming. Prefer the use > of "%s", __func__ to embedded function names > > Signed-off-by: Mohsin Shan > --- > drivers/staging/goldfish/goldf

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-16 Thread Tom Lendacky
On 3/16/2017 5:16 AM, Borislav Petkov wrote: On Fri, Mar 10, 2017 at 10:35:30AM -0600, Brijesh Singh wrote: We could update this patch to use the below logic: * CPUID(0) - Check for AuthenticAMD * CPID(1) - Check if under hypervisor * CPUID(0x8000) - Check for highest supported leaf * C

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-16 Thread Borislav Petkov
On Thu, Mar 16, 2017 at 09:28:58AM -0500, Tom Lendacky wrote: > Because there are differences between how SME and SEV behave > (instruction fetches are always decrypted under SEV, DMA to an > encrypted location is not supported under SEV, etc.) we need to > determine which mode we are in so that th

[PATCH] Staging: iio: resolver: Fix warning, statements should start on a tabstop

2017-03-16 Thread Miguel Robles
Fix checkpatch warning: Statements should start on a tabstop. Signed-off-by: Miguel Robles --- drivers/staging/iio/resolver/ad2s1210.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-16 Thread Tom Lendacky
On 3/16/2017 10:09 AM, Borislav Petkov wrote: On Thu, Mar 16, 2017 at 09:28:58AM -0500, Tom Lendacky wrote: Because there are differences between how SME and SEV behave (instruction fetches are always decrypted under SEV, DMA to an encrypted location is not supported under SEV, etc.) we need to

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-16 Thread Borislav Petkov
On Thu, Mar 16, 2017 at 11:11:26AM -0500, Tom Lendacky wrote: > Not quite. The guest still needs to understand about the encryption mask > so that it can protect memory by setting the encryption mask in the > pagetable entries. It can also decide when to share memory with the > hypervisor by not s

Re: [PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

2017-03-16 Thread Alan Cox
> + if (IS_ENABLED(CONFI_PM)) { I think not. Please actually test build both ways at the very least. Alan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 5/6] staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled

2017-03-16 Thread Alan Cox
On Wed, 2017-03-15 at 14:09 -0400, Jérémy Lefaure wrote: > When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i" > should > not be added in hmm_bo_type_strings. No the goal is to remove ifdefs - that's not the way to go with driver clean up. Instead the array size should always cover th

Re: [bug report] staging/atomisp: Add support for the Intel IPU v2

2017-03-16 Thread Alan Cox
>    457  if (ret) >    458  return ret; > ^^ > We're returning directly with the lock held.  We should either unlock > before returning or do a goto out but I'm not sure which. unlock and return (although clearly this

RE: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-16 Thread Reshetova, Elena
> On Tue, 2017-03-14 at 12:29 +, Reshetova, Elena wrote: > > > Elena Reshetova writes: > > > > > > > refcount_t type and corresponding API should be > > > > used instead of atomic_t when the variable is used as > > > > a reference counter. This allows to avoid accidental > > > > refcounter ove

Re: [RFC PATCH v2 32/32] x86: kvm: Pin the guest memory when SEV is active

2017-03-16 Thread Brijesh Singh
On 03/16/2017 05:38 AM, Paolo Bonzini wrote: On 02/03/2017 16:18, Brijesh Singh wrote: The SEV memory encryption engine uses a tweak such that two identical plaintexts at different location will have a different ciphertexts. So swapping or moving ciphertexts of two pages will not result in p

Re: [RFC PATCH v2 26/32] kvm: svm: Add support for SEV LAUNCH_UPDATE_DATA command

2017-03-16 Thread Brijesh Singh
On 03/16/2017 05:48 AM, Paolo Bonzini wrote: On 02/03/2017 16:17, Brijesh Singh wrote: +static struct page **sev_pin_memory(unsigned long uaddr, unsigned long ulen, + unsigned long *n) +{ + struct page **pages; + int first, last; + unsigned

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-16 Thread Borislav Petkov
On Fri, Mar 10, 2017 at 04:41:56PM -0600, Brijesh Singh wrote: > I can take a look at fixing those warning. In my initial attempt was to create > a new function to clear encryption bit but it ended up looking very similar to > __change_page_attr_set_clr() hence decided to extend the exiting functio

Re: [RFC PATCH v2 30/32] kvm: svm: Add support for SEV DEBUG_ENCRYPT command

2017-03-16 Thread Brijesh Singh
On 03/16/2017 06:03 AM, Paolo Bonzini wrote: On 02/03/2017 16:18, Brijesh Singh wrote: + data = (void *) get_zeroed_page(GFP_KERNEL); The page does not need to be zeroed, does it? No, we don't have to zero it. I will fix it. + + if ((len & 15) || (dst_addr & 15)) { +

Re: [RFC PATCH v2 29/32] kvm: svm: Add support for SEV DEBUG_DECRYPT command

2017-03-16 Thread Brijesh Singh
On 03/16/2017 05:54 AM, Paolo Bonzini wrote: On 02/03/2017 16:18, Brijesh Singh wrote: +static int __sev_dbg_decrypt_page(struct kvm *kvm, unsigned long src, + void *dst, int *error) +{ + inpages = sev_pin_memory(src, PAGE_SIZE, &npages); + if (!inpages) { +

Re: [PATCH] staging: android: ion: reduce lock contention latency

2017-03-16 Thread kbuild test robot
Hi Junil, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Junil-Lee/staging-android-ion-reduc

Re: [RFC PATCH v2 05/32] x86: Use encrypted access of BOOT related data with SEV

2017-03-16 Thread Tom Lendacky
On 3/7/2017 5:09 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:12:59AM -0500, Brijesh Singh wrote: From: Tom Lendacky When Secure Encrypted Virtualization (SEV) is active, BOOT data (such as EFI related data, setup data) is encrypted and needs to be accessed as such when mapped. Update

[PATCH] HV: properly delay KVP packets when negotiation is in progress

2017-03-16 Thread Long Li
The host may send multiple KVP packets before the negotiation with daemon is finished. We need to keep those packets in ring buffer until the daemon is negotiated and connected. This patch is based on the work of Nick Meier Signed-off-by: Long Li --- drivers/hv/hv_kvp.c | 9 + 1 file c

Re: [RFC PATCH v2 08/32] x86: Use PAGE_KERNEL protection for ioremap of memory page

2017-03-16 Thread Tom Lendacky
On 3/7/2017 8:59 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:13:32AM -0500, Brijesh Singh wrote: From: Tom Lendacky In order for memory pages to be properly mapped when SEV is active, we need to use the PAGE_KERNEL protection attribute as the base protection. This will insure that me

Re: [PATCH 1/2 v4] pci-hyperv: properly handle pci bus remove

2017-03-16 Thread Bjorn Helgaas
On Tue, Feb 28, 2017 at 02:19:45AM +, Long Li wrote: > hv_pci_devices_present is called in hv_pci_remove when we remove a PCI > device from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, > the bus is already removed before the call, so we don't need to rescan > the bus in the wo

Re: [PATCH] HV: properly delay KVP packets when negotiation is in progress

2017-03-16 Thread Joshua R. Poulson
This should be submitted to stable, we're seeing KVP fail to start in some tests of 4.10. On Thu, Mar 16, 2017 at 12:51 PM, Long Li wrote: > The host may send multiple KVP packets before the negotiation with daemon > is finished. We need to keep those packets in ring buffer until the daemon > is

Re: [PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-03-16 Thread Rob Herring
On Thu, Mar 09, 2017 at 08:52:41PM -0800, Steve Longerbeam wrote: > From: Philipp Zabel > > Add bindings documentation for the video multiplexer device. > > Signed-off-by: Sascha Hauer > Signed-off-by: Philipp Zabel > Signed-off-by: Steve Longerbeam > --- > .../bindings/media/video-multiplex

Re: [PATCH] staging: android: ion: reduce lock contention latency

2017-03-16 Thread kbuild test robot
Hi Junil, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Junil-Lee/staging-android-ion-r

PATCH for style warnings in drivers/staging/most/aim-v4l2

2017-03-16 Thread Chandra Annamaneni
Enclosed is a patch to the file video.c. It only fixes style warning flagged by checkpatch.pl. Please let me know if anything else needs to be done. Thanks. Chandra diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 ---

RE: [PATCH 1/2 v4] pci-hyperv: properly handle pci bus remove

2017-03-16 Thread Long Li
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Thursday, March 16, 2017 1:07 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; > de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [P

[PATCH] Staging: wilc1000: fix two typos in #define's

2017-03-16 Thread Dylan Leggio
Signed-off-by: Dylan Leggio --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index a37896fcd683..1bb63702c62

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Pavel Machek
Hi! > > > > mplayer is useful for testing... but that one already works (after you > > > > setup the pipeline, and configure exposure/gain). > > > > > > > > But thats useful for testing, not really for production. Image will be > > > > out of focus and with wrong white balance. > > > > > > > > W

[PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks

2017-03-16 Thread sunil . m
From: Suniel Mahesh Split earlier patches into multiple commits for easy review as suggested by Dan Carpenter. Modified subject, description and in few patches both for better readability as suggested by Greg KH. Dropped two patches from the earler series, as they were not adding significant val

[PATCH v4 6/6] staging: rtl8192e: Fix blank lines and space after a cast

2017-03-16 Thread sunil . m
From: Suniel Mahesh Fixed the following checkpatch.pl checks: Blank lines aren't necessary after an open brace '{' and before a close brace '}', removed No space is necessary after a cast, removed Please don't use multiple blank lines, removed Signed-off-by: Suniel Mahesh --- Changes for v4: -

[PATCH v4 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

2017-03-16 Thread sunil . m
From: Suniel Mahesh Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v4: - Dropped two patches from the series, as they were not adding significant value suggested by Dan Carpenter. staging: rtl8192e: Fix coding style, this

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-16 Thread Sakari Ailus
Hi Steve, On Tue, Mar 14, 2017 at 09:43:09AM -0700, Steve Longerbeam wrote: > > > On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: > >Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > >>On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > >>>On 03/11/2017 07:14

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-16 Thread Sakari Ailus
On Sat, Mar 11, 2017 at 12:31:24PM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 05:41 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: > >>If the pads on both sides of a link specify a frame interval, then > >>those frame interval

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-16 Thread Paolo Bonzini
On 16/03/2017 19:28, Borislav Petkov wrote: > So how hard would it be if the hypervisor allocated that memory for the > guest instead? It would allocate it decrypted and guest would need to > access it decrypted too. All in preparation for SEV-ES which will need a > block of unencrypted memory fo

[PATCH] staging: wilc1000: fix incorrect copy of pmkid data

2017-03-16 Thread Colin King
From: Colin Ian King The pmkid data is meant be be copied to the previous item in the pmkidlist, however the code is just copying the data to itself because the src index into pmkidlist is the same as the dst index into pmkidlist. Fix this with i + 1 instead of i. Detected by CoverityScan,CID#13

Re: [PATCH 5/6] staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled

2017-03-16 Thread Jérémy Lefaure
On Thu, 16 Mar 2017 17:51:06 + Alan Cox wrote: > On Wed, 2017-03-15 at 14:09 -0400, Jérémy Lefaure wrote: > > When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i" > > should > > not be added in hmm_bo_type_strings. > > No the goal is to remove ifdefs - that's not the way to go

Re: [PATCH] Staging: wilc1000: fix two typos in #define's

2017-03-16 Thread Greg KH
On Thu, Mar 16, 2017 at 05:51:12PM -0400, Dylan Leggio wrote: > Signed-off-by: Dylan Leggio I can't take patches without any changelog text at all, sorry. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.

Re: PATCH for style warnings in drivers/staging/most/aim-v4l2

2017-03-16 Thread Greg KH
On Thu, Mar 16, 2017 at 02:38:39PM -0700, Chandra Annamaneni wrote: > > Enclosed is a patch to the file video.c. It only fixes style warning flagged > by checkpatch.pl. > > Please let me know if anything else needs to be done. > > Thanks. > Chandra > > > diff --git a/drivers/staging/most/aim-v

[PATCH] Staging: wilc1000: fix two typos in #define's

2017-03-16 Thread Dylan Leggio
GAS_INTIAL_REQ should be GAS_INITIAL_REQ. GAS_INTIAL_RSP should be GAS_INITIAL_RSP. Improves readability of code. Signed-off-by: Dylan Leggio --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wil

Re: [PATCH 5/6] staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 08:15:57PM -0400, Jérémy Lefaure wrote: > On Thu, 16 Mar 2017 17:51:06 + > Alan Cox wrote: > > > On Wed, 2017-03-15 at 14:09 -0400, Jérémy Lefaure wrote: > > > When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i" > > > should > > > not be added in hmm_bo_ty

[PATCH] Revert "staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled"

2017-03-16 Thread Jérémy Lefaure
This reverts commit fde469701c7efabebf885e785edf367bfb1a8f3f. Adding a preprocessor condition is not the best solution to fix this issue. Let's revert this commit before fixing this problem in a more appropriate way. Signed-off-by: Jérémy Lefaure --- drivers/staging/media/atomisp/pci/atomisp2/h

[PATCH v2 1/6] staging: media: atomisp: add missing include in vlv2_plat_clock.c

2017-03-16 Thread Jérémy Lefaure
To use IO functions like writel, readl, ioremap_nocache and iounmap, linux/io.h should be included. Signed-off-by: Jérémy Lefaure --- drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/platform/clock/vl

Re: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks

2017-03-16 Thread Greg KH
On Fri, Mar 17, 2017 at 03:42:15AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Split earlier patches into multiple commits for easy review as > suggested by Dan Carpenter. > Modified subject, description and in few patches both for > better readability as suggested by Greg KH. >

Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

2017-03-16 Thread Greg KH
On Fri, Mar 17, 2017 at 03:22:57PM +0900, Greg KH wrote: > On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote: > > Removing mixed spaces/hard-tabs used to create a "column alignment" of > > macro names and macro values. > > > > Signed-off-by: Matthew Giassa > > --- > > drivers/stagin

Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

2017-03-16 Thread Greg KH
On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote: > Removing mixed spaces/hard-tabs used to create a "column alignment" of > macro names and macro values. > > Signed-off-by: Matthew Giassa > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] Staging: media: Unmap and release region obtained by ioremap_nocache

2017-03-16 Thread Arvind Yadav
Free memory mapping, if vpfe_ipipe_init is not successful. Signed-off-by: Arvind Yadav --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/d