On Sat, 2017-03-04 at 08:49 +0200, Ernestas Kulik wrote:
> On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote:
> >
> > struct hostif_hdr.event is declared at uint16_t
> > and not as __le16 so I believe this is incorrect
> > and actually introduces a sparse error.
>
> Sure, but I change that in t
> Sergiy Redko hat am 4. März 2017 um 06:15 geschrieben:
>
>
> On 03/03, Stefan Wahren wrote:
> > Hi Sergiy,
> >
> > Am 03.03.2017 um 09:05 schrieb Sergiy Redko:
> > > fix coding style: move brace to the line above
> >
> > please make the subject of your patch more distinct. We get a lot of
>
On Thu, Mar 02, 2017 at 02:53:55AM +0100, Samuel Thibault wrote:
> This adds 16bit character support to most of the screen reading by
> extending characters to u16 throughout the code.
>
> Non-latin1 characters are assumed to be alphabetic type for now.
>
> non-latin1 vt_notifier_call-provided ch
Currently, sparse generates many warnings for the driver. This commit
changes the types of struct fields/function variables to match the
endianness at their assignment.
Signed-off-by: Ernestas Kulik
---
Changes from v1:
* Change the type of the variable being passed to ntohs() instead of casting
On Thu, Mar 02, 2017 at 02:53:55AM +0100, Samuel Thibault wrote:
> This adds 16bit character support to most of the screen reading by
> extending characters to u16 throughout the code.
>
> Non-latin1 characters are assumed to be alphabetic type for now.
>
> non-latin1 vt_notifier_call-provided ch
Use a single string literal as the fmt argument passed to dev_err()
instead of multiple string literals split with an embedded backslash
character.
Signed-off-by: Alexander Kapshuk
---
drivers/staging/fbtft/fb_ssd1331.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
On Fri, 2017-03-03 at 23:24-0800, Joe Perches wrote:
>
> More stuff the changelog doesn't show :(
>
> On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote:
> > This fixes type warnings generated by sparse, replaces instances of
> > ntohs() with be16_to_cpu() and removes unused fields in structs.
On Fri, 3 Mar 2017, Stephen Hemminger wrote:
> static inline u64 hv_read_tsc_page(const struct ms_hyperv_tsc_page *tsc_pg)
> {
> u64 scale, offset, cur_tsc;
> u32 start;
>
> /*
>* The protocol for reading Hyper-V TSC page is specified in Hypervisor
>* Top-Level Fu
On Fri, Mar 03, 2017 at 03:01:23PM -0600, Brijesh Singh wrote:
> +merely enables SME (sets bit 23 of the MSR_K8_SYSCFG), then Linux can
> activate
> +memory encryption by default (CONFIG_AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT=y)
> or
> +by supplying mem_encrypt=on on the kernel command line. However, i
Hi Steve,
On Fri, Mar 03, 2017 at 02:43:51PM -0800, Steve Longerbeam wrote:
>
>
> On 03/03/2017 03:45 AM, Sakari Ailus wrote:
> >On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote:
> >>
> >>
> >>On 03/02/2017 07:53 AM, Sakari Ailus wrote:
> >>>Hi Steve,
> >>>
> >>>On Wed, Feb 15, 2
Copy a patch prefix that everyone else has been using:
git log --oneline drivers/staging/media/platform/bcm2835/
The subject is too vague as well.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote:
> Changes:
> V1 - Complete rewrite of the ioctl code.
> V2 - Rewrite of only ioctls that change
> between 32 bit and 64 bit.
> V3 - Minor changes.
> V4(This Version) - Abandon cleaning up the
>
Hi Russell,
On Fri, Mar 03, 2017 at 11:06:45PM +, Russell King - ARM Linux wrote:
> On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote:
> > Hi Steve,
> >
> > On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote:
> > > v4l2_pipeline_inherit_controls() will add the v4l2 co
This adds 16bit character support to most of the screen reading by
extending characters to u16 throughout the code.
Non-latin1 characters are assumed to be alphabetic type for now.
non-latin1 vt_notifier_call-provided characters are not ignored any
more, and the 16bit character returned by get_ch
This adds /dev/softsynthu, along /dev/softsynth, which emits output in
UTF-8 encoding, thus allowing to support 16bit characters. Most of the
code is shared, only the read function has to behave differently in
latin1 and in unicode mode. Since Linux only supports 16bit characters,
we can just har
Hello,
This patch series adds 16bit unicode support to speakup, through three
patches:
- extend synth buffer to 16bit unicode characters
- convert screen reading to 16bit characters
- add unicode variant of /dev/softsynth
Samuel
--
Samuel
"...Unix, MS-DOS, and Windows NT (also known as the Goo
This extends the synth buffer slots to 16bit, so as to hold 16bit
unicode characters.
synth_buffer_getc and synth_buffer_peek now return 16bit characters.
Speech synthesizers which do not support characters beyond latin1 can
use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1
chara
On Sat, Mar 04, 2017 at 10:56:23AM +0200, Ernestas Kulik wrote:
> Currently, sparse generates many warnings for the driver. This commit
> changes the types of struct fields/function variables to match the
> endianness at their assignment.
>
> Signed-off-by: Ernestas Kulik
> ---
> Changes from v1:
On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote:
> On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote:
> > Changes:
> > V1 - Complete rewrite of the ioctl code.
> > V2 - Rewrite of only ioctls that change
> > between 32 bit and 64 bit.
> > V3 - Minor c
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal
---
drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
1 file changed, 2 insertions(+), 2 de
This patch-series removes unnecessary cast on void pointer in various
drivers.
v5:
-Fixed compliation warning in lustre/lustre/llite/range_lock.c
which remain unfixed in v3.
v4:
-change the cover-letter subject
v3:
-Fixed compilation warning in lustre/lustre/llite/range_lock.c
si
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal
---
drivers/staging/rtl8712/rtl8712_recv.c | 11 +--
1 file changed, 5 insertions(+), 6
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal
---
v5:
-Fixed compilation warnings.
drivers/staging/lustre/lustre/llite/range_lock.c | 2
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal
---
drivers/staging/rts5208/rtsx_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletio
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: simran singhal
---
drivers/staging/nvec/nvec_kbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch-series removes unnecessary cast on void pointer in various
> drivers.
>
> v5:
> -Fixed compliation warning in lustre/lustre/llite/range_lock.c
>which remain unfixed in v3.
Acked-by: Julia Lawall
for the whole series.
> v4:
> -cha
On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote:
> This patch-series removes unnecessary cast on void pointer in various
> drivers.
Much better, thanks.
Trivia: (and it's probably not necessary to resend)
The cover letter should describe the subsystem being
changed or ideally something l
Improve readability by fixing multiple checkpatch.pl
issues.
Arushi Singhal (6):
staging: speakup: fixes braces {} should be used on all arms of this statement
staging: speakup: Avoid multiple assignments on same line
staging: speakup: identation should use tabs
staging: wilc1000: Alignme
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers/staging/speakup/speakup_decpc.c |
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 47cea6
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_spi.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 16
function prototype argument should have an identifier name as reported
by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/wilc_wlan.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.h
b/drivers/staging/wilc10
This patch fixes the checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/wilc1000/wilc_spi.c | 4 ++--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++--
2 files changed, 8 insertions(+)
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_decpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/speakup_decpc.c
b/drivers/staging/speakup/speakup_decpc.c
index dc860c4b
On Sat, Mar 4, 2017 at 9:22 PM, Joe Perches wrote:
> On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote:
>> This patch-series removes unnecessary cast on void pointer in various
>> drivers.
>
> Much better, thanks.
>
> Trivia: (and it's probably not necessary to resend)
>
> The cover letter s
This patch series replace "is is " with "is" in various drivers.
simran singhal (3):
staging: rtl8192u: Replace "is is" with "is"
staging: greybus: Replace "is is" with "is"
staging: comedi: Replace "is is" with "is"
drivers/staging/comedi/drivers/ni_usb6501.c | 2 +-
drivers/staging/grey
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/greybus/uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/comedi/drivers/ni_usb6501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
Using __printf allows the compiler to verify formats and arguments.
Use it and fix the single misuse found.
Signed-off-by: Joe Perches
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/spk_priv.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/st
Joe suggested to indicate the subsystem in the subject line of the cover
letter, ie staging here.
How are you finding these?
julia
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch series replace "is is " with "is" in various drivers.
>
> simran singhal (3):
> staging: rtl8192u: Replace
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch replace "is is " with "is". The replacement couldn't be
> automated because sometimes the first "is" was meant to be another
> word.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
> 1 file change
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch replace "is is " with "is". The replacement couldn't be
> automated because sometimes the first "is" was meant to be another
> word.
>
> Signed-off-by: simran singhal
Acked-by: Julia Lawall
> ---
> drivers/staging/comedi/drivers/ni_usb6
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch replace "is is " with "is". The replacement couldn't be
> automated because sometimes the first "is" was meant to be another
> word.
>
> Signed-off-by: simran singhal
Acked-by: Julia Lawall
> ---
> drivers/staging/greybus/uart.c | 2 +-
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: simran singhal
---
driver
This patch series tests if functions like kmalloc/kzalloc return NULL
on failure. When NULL represents failure, !x is commonly used.
simran singhal (3):
staging: rtl8192u: Clean up tests if NULL returned on failure
staging: speakup: Clean up tests if NULL returned on failure
staging: vc04_se
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: simran singhal
---
driver
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: simran singhal
---
driver
Sparse generates two warnings related to incorrect type in assignment.
This patch changes the types in the struct defined in unisys
Signed-off-by: Andrea Ghittino
---
Compile tested only
iochannel.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisy
On Sat, 4 Mar 2017, simran singhal wrote:
> This patch series tests if functions like kmalloc/kzalloc return NULL
> on failure. When NULL represents failure, !x is commonly used.
>
> simran singhal (3):
> staging: rtl8192u: Clean up tests if NULL returned on failure
> staging: speakup: Clean
This patch series replace "is is " with "is" in various drivers.
v1:
-change the subject
-Changed "If is a command..." to "It is a command..." in
rtl8192u/r819xU_cmdpkt.c
simran singhal (3):
staging: rtl8192u: Replace "is is" with "is"
staging: greybus: Replace "is is" with "is"
stag
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
---
v1:
-Changed "If is a command..." to "It is a command..."
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
1 file ch
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
Acked-by: Julia Lawall
---
drivers/staging/greybus/uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
This patch replace "is is " with "is". The replacement couldn't be
automated because sometimes the first "is" was meant to be another
word.
Signed-off-by: simran singhal
Acked-by: Julia Lawall
---
drivers/staging/comedi/drivers/ni_usb6501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Change to unsigned to allow removal of negative value check in
init section. Use smaller data type since the max possible
value currently is 48.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/comedi_fops.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/dri
If comedi module is loaded with the following max allowed parameter
[comedi_num_legacy_minors=48], subsequent loading of an auto-configured
device will fail.
In this case a default to auto-configuration comedi_test module failed
to load with the following messages.
comedi_test comedi_testd: ran o
Copied function argument names from definition to delcaration. This
fixes some checkpatch warnings.
Signed-off-by: Tuomo Rinne
---
drivers/staging/vt6655/rxtx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/r
On Sat, Mar 04, 2017 at 02:57:22PM +0300, Dan Carpenter wrote:
> Copy a patch prefix that everyone else has been using:
>
> git log --oneline drivers/staging/media/platform/bcm2835/
>
> The subject is too vague as well.
Is this what you are looking for?
[patch] Staging: bcm2835: fixed style of
This patch series fixes typos and prevents potential problems with
macro parameters in the rtl8188eu driver.
Sebastian Haas (3):
staging: rtl8188eu: wrap macro parameters in parentheses
staging: rtl8188eu: fix typos in comments
staging: rtl8188eu: fix typos in macros
drivers/staging/rtl818
Fix typos reported by checkpatch.pl
Signed-off-by: Sebastian Haas
---
Already existing block-comment warnings on the edited lines are
not handled by this patch.
drivers/staging/rtl8188eu/include/Hal8188EPhyReg.h| 2 +-
drivers/staging/rtl8188eu/include/odm_debug.h | 2 +-
drivers/s
Rename macro definition and usage to represent correct spelling of DEFAULT:
ODM_REG_RX_DEFUALT_A_11N => ODM_REG_RX_DEFAULT_A_11N
ODM_REG_RX_DEFUALT_B_11N => ODM_REG_RX_DEFAULT_B_11N
Signed-off-by: Sebastian Haas
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 4 ++--
drivers/staging/r
Avoid potential precedences issues by wrapping macro parameters
in parentheses.
Signed-off-by: Sebastian Haas
---
drivers/staging/rtl8188eu/include/Hal8188EPhyReg.h | 2 +-
drivers/staging/rtl8188eu/include/Hal8188ERateAdaptive.h | 16
drivers/staging/rtl8188eu/include/od
Hi All,
On Fri, Mar 3, 2017 at 4:05 AM, Georgios Emmanouil wrote:
> Fixed alignment to match parenthesis.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/wilc_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
--
Julian Calaby
E
Hi All,
On Fri, Mar 3, 2017 at 4:04 AM, Georgios Emmanouil wrote:
> Fixed comment style to the preferred kernel comment style.
Fixing comment style and other stuff like that are the _least_ of the
problems with this driver, but you've done it, so...
> Signed-off-by: Georgios Emmanouil
Reviewe
Hi All,
On Fri, Mar 3, 2017 at 4:06 AM, Georgios Emmanouil wrote:
> Fixed spelling error. 'unkmown' to 'unknown'.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/wilc_spi.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
--
Hi All,
On Fri, Mar 3, 2017 at 4:07 AM, Georgios Emmanouil wrote:
> Added blank line after function and modified comment style.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/wilc_spi.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 delet
Hi All,
On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil
Again, I'm dubious if this is needed or helpful, but
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/linux_wlan.c
Hi All,
On Fri, Mar 3, 2017 at 3:41 AM, Georgios Emmanouil wrote:
> Modified comment style to preferred kernel comment style.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/wilc_sdio.c | 13 +
> 1 file changed, 5 insertions(+), 8
Hi All,
On Fri, Mar 3, 2017 at 2:35 AM, Georgios Emmanouil wrote:
> Removed unnecessary blank line.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/host_interface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1
Hi All,
On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil wrote:
> Fixed alignment to match open parenthesis.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
--
Julia
Hi All,
On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil wrote:
> Removed unnecessary 'if' statement and integrated the condition to the
> previous 'if' statement.
>
> Signed-off-by: Georgios Emmanouil
Reviewed-by: Julian Calaby
> ---
> drivers/staging/wilc1000/host_interface.c | 12 +-
> -Original Message-
> From: k...@exchange.microsoft.com [mailto:k...@exchange.microsoft.com]
> Sent: Monday, February 27, 2017 5:26 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com
> -Original Message-
> From: k...@exchange.microsoft.com [mailto:k...@exchange.microsoft.com]
> Sent: Monday, February 27, 2017 3:18 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com
On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote:
>
> Den 02.03.2017 14.04, skrev simran singhal:
> >This patch fixes the following sparse warnings:
> >
> >drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in
> >assignment (different base types)
> >drivers/staging/fb
On 03/04/2017 02:56 AM, Sakari Ailus wrote:
Hi Steve,
On Fri, Mar 03, 2017 at 02:43:51PM -0800, Steve Longerbeam wrote:
On 03/03/2017 03:45 AM, Sakari Ailus wrote:
On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote:
On 03/02/2017 07:53 AM, Sakari Ailus wrote:
Hi Steve,
O
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal
Reviewed-by: James Simmons
> ---
>
> v5:
>-Fixed
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal
Reviewed-by: James Simmons
> ---
> drivers/staging/lu
From: Dexuan Cui
Without the patch, I always get a "BUG: spinlock bad magic" warning.
Fixes: 3716a49a81ba ("hv_utils: implement Hyper-V PTP source")
Signed-off-by: Dexuan Cui
Cc: Vitaly Kuznetsov
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
From: Stephen Hemminger
hv_ringbuffer_read cleanup.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/ring_buffer.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 52d0556..8a
From: K. Y. Srinivasan
Miscellaneous cleanup.
Stephen Hemminger (9):
vmbus: only reschedule tasklet if time limit exceeded
hyperv: fix warning about missing prototype
vmbus: remove useless return's
vmbus: remove unnecessary initialization
vmbus: fix spelling errors
hyperv: remove unn
From: Stephen Hemminger
Don't initialize variables that are then set a few lines later.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/ring_buffer.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b
From: Stephen Hemminger
Compiling with warnings enabled finds missing prototype for
hv_do_hypercall.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/hyperv/hv_init
From: Stephen Hemminger
This table is immutable and should be const.
Cleanup indentation and whitespace for this as well.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 48 ++--
drivers/hv/hyperv_vmbus
From: Stephen Hemminger
The change to reschedule tasklet if more data arrives in ring buffer
can cause performance regression if host timing is such that the
next response happens in small window.
Go back to a modified version of the original looping behavior.
If the race occurs in a small time,
From: Stephen Hemminger
Several spelling errors in comments
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c | 10 +-
drivers/hv/hv_kvp.c | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/hv/channel.
From: Stephen Hemminger
Minor changes to align hyper-v vmbus include files with current
linux kernel style.
Signed-off-by: Stephen Hemminger
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hyperv_vmbus.h | 16
include/linux/hyperv.h| 12 ++--
2 files changed, 1
On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote:
> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote:
>>
>> Den 02.03.2017 14.04, skrev simran singhal:
>> >This patch fixes the following sparse warnings:
>> >
>> >drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type
On Sun, Mar 5, 2017 at 10:10 AM, SIMRAN SINGHAL
wrote:
> On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote:
>> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote:
>>>
>>> Den 02.03.2017 14.04, skrev simran singhal:
>>> >This patch fixes the following sparse warnings:
>>> >
>>> >d
This patch fixes the following sparse warnings:
drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment
(different base types)
drivers/staging/fbtft/fbtft-io.c:74:29:expected unsigned long long
[unsigned] [long] [long long] [usertype]
drivers/staging/fbtft/fbtft-io.c:7
This fixes an error found by checkpatch about the open
brace not being on the same line as if statement.
It also adds a missing blank like to fix another
checkpatch warning.
Signed-off-by: Sergiy Redko
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 4 ++--
1 file changed,
On Sun, Mar 05, 2017 at 10:35:33AM +0530, simran singhal wrote:
> This patch fixes the following sparse warnings:
>
> drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment
> (different base types)
> drivers/staging/fbtft/fbtft-io.c:74:29:expected unsigned long long
>
The function atomisp_set_stop_timeout on being called, simply returns
back. The function hasn't been mentioned in the TODO and doesn't have
FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
removed.
Signed-off-by: simran singhal
---
drivers/staging/media/atomisp/pci/atom
Changed file permission to octal style.
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/iio/addac/adt7316.c | 108 ++--
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c
b/drivers/staging/ii
Fix these warnings:
drivers/staging//rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted
__le16
drivers/staging//rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted
__le16
drivers/staging//rtl8192u/r8192U_dm.c:2309:44: warning: cast from restricted
__le16
Signed-off-by: Matthieu
94 matches
Mail list logo
