Re: [Outreachy kernel] [PATCH v3] staging: xgifb: function definition argument should also have an identifier name

2017-02-21 Thread Julia Lawall
On Wed, 22 Feb 2017, Arushi Singhal wrote: > function definition argument like 'struct vb_device_info *','unsigned > long' etc. should also have an identifier name. Actually, this is not really clear. The definition of a function is the thing that has the actual code, like int foo(int x) { re

Re: [Outreachy kernel] [PATCH 2/7] staging: most: Using macro DIV_ROUND_UP

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, SIMRAN SINGHAL wrote: > > > On Wednesday, February 22, 2017 at 1:28:52 AM UTC+5:30, Julia Lawall wrote: > > > On Wed, 22 Feb 2017, simran singhal wrote: > > > The macro DIV_ROUND_UP performs the computation (((n) + (d) - > 1) /(d)). > > It clarifies t

<    1   2