Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Jonathan Cameron
On 20/01/17 03:47, Alison Schofield wrote: > These stand-alone trigger drivers were using iio_trigger_put() > where they should have been using iio_trigger_free(). The > iio_trigger_put() adds a module_put which is bad since they > never did a module_get. > > In the sysfs driver, module_get/put's

Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Lars-Peter Clausen
On 01/22/2017 03:25 PM, Jonathan Cameron wrote: > On 20/01/17 03:47, Alison Schofield wrote: >> These stand-alone trigger drivers were using iio_trigger_put() >> where they should have been using iio_trigger_free(). The >> iio_trigger_put() adds a module_put which is bad since they >> never did a

Re: [PATCH v2] iio: trigger: free trigger resource correctly

2017-01-22 Thread Jonathan Cameron
On 22/01/17 15:56, Lars-Peter Clausen wrote: > On 01/22/2017 03:25 PM, Jonathan Cameron wrote: >> On 20/01/17 03:47, Alison Schofield wrote: >>> These stand-alone trigger drivers were using iio_trigger_put() >>> where they should have been using iio_trigger_free(). The >>> iio_trigger_put() adds a

[PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

2017-01-22 Thread Marcos Paulo de Souza
Change uint32_t to u32, solved the issue reported by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' + uint32_t *format, uint32_t *rate, u8 *channels, CHECK: Prefer kernel type 'u32' over 'uint32_t' + uint32_t format, uint32_t rate, u8 ch

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-22 Thread Cathy Avery
I'm sorry. In my zeal to push out this patch I have done a poor job of communication on a number of levels. The first patch which deals with the fc transport changes will not set the scsi_transport_template.eh_timed_out function directly during lightweight fc_attach_transport(). It instead re

Re: [PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

2017-01-22 Thread Mark Greer
On Sun, Jan 22, 2017 at 03:49:21PM -0200, Marcos Paulo de Souza wrote: > Change uint32_t to u32, solved the issue reported by checkpatch.pl: > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t *format, uint32_t *rate, u8 *channels, > > CHECK: Prefer kernel type 'u

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-22 Thread Dan Carpenter
On Sun, Jan 22, 2017 at 01:51:13PM -0500, Cathy Avery wrote: > I'm sorry. In my zeal to push out this patch I have done a poor job > of communication on a number of levels. > > The first patch which deals with the fc transport changes will not > set the scsi_transport_template.eh_timed_out functi

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-22 Thread Steve Longerbeam
On 01/16/2017 05:47 AM, Philipp Zabel wrote: On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] +Unprocessed Video Capture: +-- + +Send frames directly from sensor to camera interface, with no +conversions: + +-> ipu_smfc -> camif I'd call this capture in

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-22 Thread Fam Zheng
On Wed, 01/18 15:28, Cathy Avery wrote: > Enable FC lightweight host option so that the luns exposed by > the driver may be manually scanned. Hi Cathy, out of curiosity: how does this relate to issue_lip operation? And how to trigger manual scan with this patch? Fam __

Re: [PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

2017-01-22 Thread Vaibhav Agarwal
On Sun, Jan 22, 2017 at 11:19 PM, Marcos Paulo de Souza wrote: > Change uint32_t to u32, solved the issue reported by checkpatch.pl: > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t *format, uint32_t *rate, u8 *channels, > > CHECK: Prefer kernel type 'u32' ove