[patch] staging: lustre: ptlrpc: silence a shift wrapping warning

2017-01-15 Thread Dan Carpenter
"svcpt->scp_hist_seq" is a u64 so static checkers complain that 1U should be 1ULL. I looked at REQS_SEQ_SHIFT() a little and it seems to be capped by the number of CPUs online and the amount of memory, but I think it could go above 32 possibly. Signed-off-by: Dan Carpenter --- I have not tested

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 01:08:15AM +0530, Kartikey Singh wrote: > On Sat, Jan 14, 2017 at 07:38:01PM +0100, Greg KH wrote: > > On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > > > do while loop removed from single statement macro > > > > > > Signed-off-by: Kartikey Singh > > > --

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 10:53:04PM +0300, Ivan Safonov wrote: > On 01/14/2017 10:40 PM, Greg KH wrote: > > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > > Even better yet, remove it and rebuild the driver and see if it > > breaks :) > > Only if the code is not between #ifn?def

Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 01:09:23PM +0530, Kartikey Singh wrote: > Removed macros not in use. > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/wifi.h | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/include

[PATCH] drivers: staging: rtl8188eu: include: wifi: Removed unnecessary defined macros

2017-01-15 Thread Kartikey Singh
Removed macros not in use. Signed-off-by: Kartikey Singh --- drivers/staging/rtl8188eu/include/wifi.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h index 9e08e68..e10de68 100644 --- a/dri

[PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree

2017-01-15 Thread Shyam Saini
vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree. Signed-off-by: Shyam Saini --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

Re: [PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity()

2017-01-15 Thread Jonathan Cameron
On 14/01/17 20:00, Brian Masney wrote: > On Sun, Dec 04, 2016 at 11:16:04AM +, Jonathan Cameron wrote: >> On 04/12/16 02:19, Brian Masney wrote: >>> isl29028_enable_proximity() has a boolean argument named enable. This >>> function is only called once and the enable flag is set to true in that

RE: [PATCH] hv: use substraction to update ring buffer index

2017-01-15 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Long Li > Sent: Thursday, January 5, 2017 12:08 > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org > Subject: [PATCH] hv: use substraction to update ring buffer

Re: [lustre-devel] [patch] staging: lustre: ptlrpc: silence a shift wrapping warning

2017-01-15 Thread Oleg Drokin
On Jan 15, 2017, at 3:14 AM, Dan Carpenter wrote: > "svcpt->scp_hist_seq" is a u64 so static checkers complain that 1U > should be 1ULL. I looked at REQS_SEQ_SHIFT() a little and it seems to > be capped by the number of CPUs online and the amount of memory, but I > think it could go above 32 pos

[PATCH] rtl8188eu: core: Remove NULL test before vfree

2017-01-15 Thread Shyam Saini
vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree(). Signed-off-by: Shyam Saini --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

[PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

2017-01-15 Thread Derek Robson
Changed bare use of 'unsigned' to the prefered us of 'unsigned int' found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/media/bcm2048

Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

2017-01-15 Thread Scott Matheina
> On Jan 15, 2017, at 10:30 PM, Derek Robson wrote: > > Changed bare use of 'unsigned' to the prefered us of 'unsigned int' > found using checkpatch Just wondering if you compiled? This patch looks exactly like a patch I tried, but it didn't compile. > Signed-off-by: Derek Robson > --- > d

Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

2017-01-15 Thread kbuild test robot
Hi Derek, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10-rc4 next-20170113] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Robson/Staging-media-bcm2048-sty

Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

2017-01-15 Thread Derek Robson
On Sun, Jan 15, 2017 at 10:40:02PM -0600, Scott Matheina wrote: > > > > On Jan 15, 2017, at 10:30 PM, Derek Robson wrote: > > > > Changed bare use of 'unsigned' to the prefered us of 'unsigned int' > > found using checkpatch > > Just wondering if you compiled? This patch looks exactly like a p

[PATCH V2] Staging: media: bcm2048: style fix - bare use of unsigned

2017-01-15 Thread Derek Robson
Changed macro to not pass signedness and size as seprate fields. This is to improve code readablity. Signed-off-by: Derek Robson --- version #1 broke the build because I missunderstood the output of checkpatch. drivers/staging/media/bcm2048/radio-bcm2048.c | 48 +-- 1 f