Re: [PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get

2017-01-11 Thread Martyn Welch
On 10 January 2017 at 10:45, Augusto Mecking Caringi wrote: > In ca91cx42_slave_get function, the value pointed by vme_base pointer is > set through: > > *vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]); > > So it must be dereferenced to be used in calculation of pci_base: > > *pci_base = (

Re: [PATCH] staging: greybus: loopback_test: fix checkpatch bad function definition error

2017-01-11 Thread Johan Hovold
On Wed, Jan 11, 2017 at 01:29:36AM +, Abdul Rauf wrote: > Fix the following Errors: > Bad function definition - void abort() should probably be void abort(void) > > Signed-off-by: Abdul Rauf Acked-by: Johan Hovold ___ devel mailing list de...@linu

[PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Roman Sommer
Note that this patch does not fix all checkpatch warnings for the affected files. Signed-off-by: Christian Bewermeyer Signed-off-by: Roman Sommer --- drivers/staging/greybus/gpio.c | 24 drivers/staging/greybus/loopback.c | 2 +- 2 files changed, 13 insertions(+),

Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Johan Hovold
On Wed, Jan 11, 2017 at 02:48:38PM +0100, Roman Sommer wrote: > Note that this patch does not fix all checkpatch warnings for the > affected files. > > Signed-off-by: Christian Bewermeyer > Signed-off-by: Roman Sommer You forgot to fix the Subject prefix ("staging: greybus: "). Care to fix tha

Re: [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI

2017-01-11 Thread Andy Shevchenko
On Tue, 2017-01-03 at 20:29 +0200, Andy Shevchenko wrote: > This series enables 64x48 OLED display and fixes the driver to work > with DMA > enabled SPI properly. > > Has been tested on Intel Edison board with Adafruit 2'8" and SSD1306 > 64x48 > (Sparkfun for Intel Edison) OLED displays at their m

Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread roman . sommer
> You forgot to fix the Subject prefix ("staging: greybus: "). > > Care to fix that up and resend? > > Thanks, > Johan > As I added the fix for loopback.c, I did not include the "gpio" prefix. This is what I thought was correct after reading your last mail. Apparently I misunderstood. What should

Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread roman . sommer
>> You forgot to fix the Subject prefix ("staging: greybus: "). >> >> Care to fix that up and resend? >> >> Thanks, >> Johan >> > > As I added the fix for loopback.c, I did not include the "gpio" prefix. > This is what I thought was correct after reading your last mail. > Apparently I misunderstood

[PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Roman Sommer
Note that this patch does not fix all checkpatch warnings for the affected files. Signed-off-by: Christian Bewermeyer Signed-off-by: Roman Sommer --- drivers/staging/greybus/gpio.c | 24 drivers/staging/greybus/loopback.c | 2 +- 2 files changed, 13 insertions(+),

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Johan Hovold
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote: > Note that this patch does not fix all checkpatch warnings for the > affected files. > > Signed-off-by: Christian Bewermeyer > Signed-off-by: Roman Sommer Next time I suggest you drop "checkpatch: " from your subject since that's no

[PATCH] staging: rtl: fix possible NULL pointer dereference

2017-01-11 Thread Arnd Bergmann
gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with a destination argument that an earlier function call may have set to NULL: staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr': staging/rtl8188eu/core/rtw_recv.c:1318:2: warning: argument 1 null where non-nul

Re: [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI

2017-01-11 Thread Noralf Trønnes
Den 11.01.2017 15:43, skrev Andy Shevchenko: On Tue, 2017-01-03 at 20:29 +0200, Andy Shevchenko wrote: This series enables 64x48 OLED display and fixes the driver to work with DMA enabled SPI properly. Has been tested on Intel Edison board with Adafruit 2'8" and SSD1306 64x48 (Sparkfun for Int

[PATCH] staging: android/ion: Fix coding style issues

2017-01-11 Thread Bogdan Purcareata
Fix following checkpatch warnings: - Lines over 80 characters - void function with return statement - Unaligned comment mark - Header function prototypes missing variable names Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion-ioctl.c | 3 ++- drivers/staging/android/ion/ion_

Re: [PATCH] staging: rtl: fix possible NULL pointer dereference

2017-01-11 Thread Larry Finger
On 01/11/2017 08:53 AM, Arnd Bergmann wrote: gcc-7 detects that wlanhdr_to_ethhdr() in two drivers calls memcpy() with a destination argument that an earlier function call may have set to NULL: staging/rtl8188eu/core/rtw_recv.c: In function 'wlanhdr_to_ethhdr': staging/rtl8188eu/core/rtw_recv.c:

[PATCH] tty_port: checkpatch: Refactored file to linux style guides

2017-01-11 Thread Fabian Arnold
The tty_port.c file is now accordingly to the linux style guidelines. Signed-off-by: Fabian Arnold Signed-off-by: Philip Thiemann --- drivers/tty/tty_port.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/drivers/tty/tty_port.c b/driv

[PATCH 1/2] staging: rtl8192u: Add character '*' in all lines of the block comments.

2017-01-11 Thread Javier Rodriguez
Correct code style error. Add a character in every line of the comment block. Signed-off-by: Javier Rodriguez --- drivers/staging/rtl8192u/r8180_93cx6.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/driv

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-11 Thread Tim Harvey
On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote: > In version 3: > > Changes suggested by Rob Herring : > > - prepended FIM node properties with vendor prefix "fsl,". > > - make mipi csi-2 receiver compatible string SoC specific: > "fsl,imx6-mipi-csi2" instead of "fsl,imx-mipi-csi2"

[PATCH 2/2] staging: rtl8192u: Removed multiple white lines.

2017-01-11 Thread Javier Rodriguez
Remove one unnecessary white line. Signed-off-by: Javier Rodriguez --- drivers/staging/rtl8192u/r8180_93cx6.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/drivers/staging/rtl8192u/r8180_93cx6.h index 8e48b24..643d465 100644 --- a/drivers/staging/rt

RE: [PATCH 01/18] Drivers: hv: vmbus: Move the definition of hv_x64_msr_hypercall_contents

2017-01-11 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 10, 2017 9:27 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; leann

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-11 Thread Steve Longerbeam
Hi Tim, On 01/11/2017 03:14 PM, Tim Harvey wrote: Hi Steve, I took a stab at testing this today on a gw51xx which has an adv7180 hooked up as follows: - i2c3@0x20 - 8bit data bus from DAT12 to DAT19, HSYNC, VSYNC, PIXCLK on CSI0 pads (CSI0_IPU1) - PWRDWN# on MX6QDL_PAD_CSI0_DATA_EN__GPIO5_I

[PATCH 5/7] staging:wilc1000:wilc_debugfs.c Removes multiple blank lines

2017-01-11 Thread Scott Matheina
Fixes checkpatch CHECK: Please don't use multiple blank lines Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/wilc_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c index 52aac75..7d32de9 1

[PATCH 7/7] staging:wilc1000:wilc_sdio.c Deleted un-needed blank lines

2017-01-11 Thread Scott Matheina
Fixes checkpatch CHECK: Blank lines aren't necessary before a close brace '}' Please don't use multiple blank lines Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/wilc_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging

[PATCH 4/7] staging:wilc1000:wilc_debugfs.c Aligns code to match open parenthesis

2017-01-11 Thread Scott Matheina
Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/wilc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c index 0

[PATCH 6/7] staging:wilc1000:wilc_sdio.c Aligns code match open parenthesis

2017-01-11 Thread Scott Matheina
Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c index 3ad7cec..e

[PATCH 1/7] staging:wlan-ng:cfg80211.c Aligned code with open parenthesis

2017-01-11 Thread Scott Matheina
Fixed Alignment should match open parenthesis checkpatch CHECK. Signed-off-by: Scott Matheina --- drivers/staging/wlan-ng/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index aa0e5a3..1

[PATCH 2/7] staging:wilc1000:host_interface.c Added braces {} on else statemement

2017-01-11 Thread Scott Matheina
Fixes checkpatch warning: braces {} should be used on all arms of this statement Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/host_interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 3/7] staging:wilc1000:linux_wlan.c Align code to match open parenthesis

2017-01-11 Thread Scott Matheina
Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 185fcd1

[PATCH RESEND] Staging: greybus: style fix, permissions as octal

2017-01-11 Thread Derek Robson
Changed permissions to be in octal style. Found by checkpatch. Signed-off-by: Derek Robson --- drivers/staging/greybus/camera.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index 0ee291ca2c72..a

Re: [greybus-dev] [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Viresh Kumar
On 11-01-17, 16:00, Roman Sommer wrote: > Note that this patch does not fix all checkpatch warnings for the > affected files. > > Signed-off-by: Christian Bewermeyer > Signed-off-by: Roman Sommer > > --- > drivers/staging/greybus/gpio.c | 24 > drivers/staging/grey

Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-11 Thread Dan Carpenter
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote: > Note that this patch does not fix all checkpatch warnings for the > affected files. > A lot of ways that display git commits put the changelog and the summary far apart. The changelog is pretty useless by itself in this case. https

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-11 Thread Greg KH
On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names That's a lot of different things to be doing

Re: [PATCH] tty_port: checkpatch: Refactored file to linux style guides

2017-01-11 Thread Greg Kroah-Hartman
On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote: > The tty_port.c file is now accordingly to the linux style guidelines. That's the vaguest changelog text ever :( Please describe what you did here, and why you did it. And if you fixed more than one "type" of style issue, you need t

[PATCH 2/4] staging: android/ion: Don't use return in void function

2017-01-11 Thread Bogdan Purcareata
Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion_of.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 46b2bb9..7791c70 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/

[PATCH 4/4] staging: android/ion: Use variable names in header

2017-01-11 Thread Bogdan Purcareata
Populate header function signatures with variable names as well, not just variable types. Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion_priv.h | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/android/i