Re: [PATCH v2] staging: wilc1000: Connect to highest RSSI value for required SSID

2017-01-09 Thread Dan Carpenter
Thanks for the changes. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 09, 2017 at 12:40:48AM -0800, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: > >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > >> On 28/12/2016 18:09, Roman Kagan wrote: > >> > Am I correct assuming that QEMU is currently the only user

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Paolo Bonzini
On 09/01/2017 09:40, h...@zytor.com wrote: > On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >> On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >>> On 28/12/2016 18:09, Roman Kagan wrote: Am I correct assuming that QEMU is currently the only user of arch/x86/inclu

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread Roman Kagan
On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: > On 28/12/2016 18:09, Roman Kagan wrote: > > Am I correct assuming that QEMU is currently the only user of > > arch/x86/include/uapi/asm/hyperv.h? > > > > Then I think we're fine withdrawing it from uapi as a whole and letting > > QEM

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2017-01-09 Thread hpa
On January 9, 2017 12:32:23 AM PST, Roman Kagan wrote: >On Mon, Jan 02, 2017 at 09:19:57AM +0100, Paolo Bonzini wrote: >> On 28/12/2016 18:09, Roman Kagan wrote: >> > Am I correct assuming that QEMU is currently the only user of >> > arch/x86/include/uapi/asm/hyperv.h? >> > >> > Then I think we'r

Re: [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup

2017-01-09 Thread Ian Abbott
On 07/01/17 11:13, Cheah Kok Cheong wrote: This series does trivial header cleanup for comedi_fops.c Cheah Kok Cheong (4): Staging: comedi: comedi_fops: Remove unused kmod.h header Staging: comedi: comedi_fops: Remove redundant init.h header Staging: comedi: comedi_fops: Remove unused vmal

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

2017-01-09 Thread Johan Hovold
On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: > commit e854ff58ed70 ("greybus: loopback: add runtime pm support") > introduces pm runtime support to the loopback code. If a > gb_pm_runtime_get_sync() fails, currently we immediately return from the > loopback thread. > > Alexand

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

2017-01-09 Thread Bryan O'Donoghue
On January 9, 2017 11:19:09 AM GMT+00:00, Johan Hovold wrote: >On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: >> commit e854ff58ed70 ("greybus: loopback: add runtime pm support") >> introduces pm runtime support to the loopback code. If a >> gb_pm_runtime_get_sync() fails, curre

Re: [PATCH 2/2] staging: greybus: loopback: fix oops on rmmod gb_loopback

2017-01-09 Thread Johan Hovold
On Sun, Jan 08, 2017 at 03:27:19PM +, Bryan O'Donoghue wrote: > Doing an rmmod gb_loopback will cause an oops with the following backtrace. > > Call Trace: > debugfs_remove+0xaf/0x180 > gb_loopback_disconnect+0x36/0x160 [gb_loopback] > greybus_remove+0x87/0x1a0 [greybus] > device_release_d

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

2017-01-09 Thread Johan Hovold
On Mon, Jan 09, 2017 at 11:29:50AM +, Bryan O'Donoghue wrote: > On January 9, 2017 11:19:09 AM GMT+00:00, Johan Hovold > wrote: > >On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: > >> commit e854ff58ed70 ("greybus: loopback: add runtime pm support") > >> introduces pm runtim

Re: [PATCH 1/2] staging: greybus: loopback: fix gb_pm_runtime_get_sync error handling

2017-01-09 Thread Bryan O'Donoghue
On January 9, 2017 11:57:36 AM GMT+00:00, Johan Hovold wrote: >On Mon, Jan 09, 2017 at 11:29:50AM +, Bryan O'Donoghue wrote: >> On January 9, 2017 11:19:09 AM GMT+00:00, Johan Hovold > wrote: >> >On Sun, Jan 08, 2017 at 03:27:18PM +, Bryan O'Donoghue wrote: >> >> commit e854ff58ed70 ("grey

Re: [PATCH v2 1/4] timekeeping: export do_adjtimex() to modules

2017-01-09 Thread Vitaly Kuznetsov
John Stultz writes: > On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: >> While do_adjtimex() is available to userspace via adjtimex syscall it is >> not available to modules which may want to implement in-kernel 'NTP >> clients'. Hyper-V hv_utils is going to be the first one. >> >> Signe

Re: [PATCH v2 4/4] hv_util: improve time adjustment accuracy by disabling interrupts

2017-01-09 Thread Vitaly Kuznetsov
John Stultz writes: > On Wed, Jan 4, 2017 at 9:24 AM, Vitaly Kuznetsov wrote: >> If we happen to receive interrupts during hv_set_host_time() execution >> our adjustments may get inaccurate. Make the whole function atomic. >> Unfortunately, we can's call do_settimeofday64() with interrupts >> di

Re: [PATCH v2] Staging: greybus: style fix, permissions as octal

2017-01-09 Thread Johan Hovold
On Fri, Jan 06, 2017 at 08:43:57PM +1300, Derek Robson wrote: > Changed permissions to be in octal style. > Found by checkpatch. > > Signed-off-by: Derek Robson > --- > > This version of patch also make the file type part of the mask with the > permissions, as per recommendation from Greg K-H >

[PATCH] staging: wlan-ng: remove unnecessary blank lines

2017-01-09 Thread Markus Buettner
checkpatch.pl complained about two unnecessary blank lines after an opening '{' in prism2mib.c. Those were removed in order to get rid of those warnings. There are more issues pointed out by checkpatch.pl. Those require additional work to be done. Signed-off-by: Markus Buettner Signed-off-by: Ar

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-09 Thread Stephen Hemminger
On Tue, 3 Jan 2017 19:48:29 + "Alex Ng (LIS)" wrote: > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Tuesday, January 3, 2017 4:32 AM > > To: Alex Ng (LIS) > > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; KY > > Srinivasan ;

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-09 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > An alternative would be for hyper-v util to provide a clocksource device and > let NTP manage the adjustment. The advantage of this would be HV util not > fighting > with NTP, and using standard API's. The downside would be the complexity of > configuring > NTP, and

[PATCH 0/7] staging: unisys: Fix errors found during s-Par recovery

2017-01-09 Thread David Kershner
During s-Par firmware recovery testing it was discovered that the visornic driver was not correctly recovering. This patch series addresses that issue as well as several other issues found during testing. David Binder (3): staging: unisys: visorbus: Remove duplicate invocation of init_rcv_bufs()

[PATCH 2/7] staging: unisys: visorbus: relocate error-check from isr to registration

2017-01-09 Thread David Kershner
From: Tim Sell It just makes more sense to do the NULL-pointer check when the function is called to enable interrupts, rather than on *every* interrupt. Signed-off-by: Tim Sell Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 10 -- 1 file changed, 8

[PATCH 3/7] staging: unisys: visorbus: Replace parser_param_start with parser_name_get

2017-01-09 Thread David Kershner
Replace the general CONTROLVM string parser setup which only handled the name string with a specific name string retrieval function. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorchipset.c | 53 +-- 1 file changed, 15 insert

[PATCH 4/7] staging: unisys: visorbus: Remove duplicate invocation of init_rcv_bufs()

2017-01-09 Thread David Kershner
From: David Binder Removes the invocation to init_rcv_bufs() in visornic_resume() because that function is already called in visornic_enable_with_timeout(). Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 2 -- 1 file changed, 2

[PATCH 5/7] staging: unisys: visornic: Reorder logic in visornic_enable_with_timeout()

2017-01-09 Thread David Kershner
From: David Binder Moves the call to napi_enable() before the call to init_rcv_bufs(), ensuring that messages are not put into the receive queue until the guest is ready to receive interrupts. Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visorn

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-09 Thread Stephen Hemminger
On Mon, 09 Jan 2017 18:40:15 +0100 Vitaly Kuznetsov wrote: > Stephen Hemminger writes: > > > An alternative would be for hyper-v util to provide a clocksource device and > > let NTP manage the adjustment. The advantage of this would be HV util not > > fighting > > with NTP, and using standard

Hello from Nicklos

2017-01-09 Thread Mathias Nicklos
Hi, don't forget about all my tasks. Thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-09 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Mon, 09 Jan 2017 18:40:15 +0100 > Vitaly Kuznetsov wrote: > >> Stephen Hemminger writes: >> >> > An alternative would be for hyper-v util to provide a clocksource device >> > and >> > let NTP manage the adjustment. The advantage of this would be HV util not >>

[PATCH 6/7] staging: unisys: visornic: Remove errant -EIO returns

2017-01-09 Thread David Kershner
From: David Binder Remove errant -EIOs that prevent us from calling either netif_start_queue() or napi_disable(). Signed-off-by: David Binder Signed-off-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 7/7] staging: unisys: remove redundant unlocks of visornic_devdata.priv_lock

2017-01-09 Thread David Kershner
From: Tim Sell These redundant unlocks of visornic_devdata.priv_lock would result in the RHEL 7.2 guests hanging during service partition recovery testing. __Testing__ * An scp of a large file was started from a remote host TO the RHEL 7.2 Linux guest. * During the scp transfer, s-Par servic

[PATCH 1/7] staging: unisys: visorbus: Remove unused enum members

2017-01-09 Thread David Kershner
Visorchipset used to parse CONTROLVM messages with a variety of string information. All but the name string have been removed, but the code to handle this information remained. This patch removes the other values and handlers. Signed-off-by: Bryan Thompson Signed-off-by: David Kershner --- driv

Re: [PATCH 3/4] hv_util: use do_adjtimex() to update system time

2017-01-09 Thread Stephen Hemminger
On Mon, 09 Jan 2017 19:14:30 +0100 Vitaly Kuznetsov wrote: > Stephen Hemminger writes: > > > On Mon, 09 Jan 2017 18:40:15 +0100 > > Vitaly Kuznetsov wrote: > > > >> Stephen Hemminger writes: > >> > >> > An alternative would be for hyper-v util to provide a clocksource device > >> > and

[PATCH] staging: unisys: fix checkpatch block comments warning

2017-01-09 Thread Abdul Rauf
Fix the following warnings: Block comments should align the * on each line Signed-off-by: Abdul Rauf --- drivers/staging/unisys/include/channel.h | 134 +++ 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/drivers/staging/unisys/include/channel.h b/dri

Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

2017-01-09 Thread Andy Shevchenko
On Sat, Jan 7, 2017 at 5:48 AM, Derek Robson wrote: > Two files change in style fix, changes are octal file permissions. Does it make any sense? Or did I miss something? -- With Best Regards, Andy Shevchenko ___ devel mailing list de...@linuxdriverpro

Re: [PATCH v2 0/4] hv_util: adjust system time smoothly

2017-01-09 Thread Thomas Gleixner
On Wed, 4 Jan 2017, Vitaly Kuznetsov wrote: > Changes since v1: > - do do_settimeofday64() when ICTIMESYNCFLAG_SYNC flag is present in the > request (Alex Ng) > - add pr_debug() for the case when do_adjtimex() fails (Alex Ng) > > Original description: > > With TimeSync version 4 protocol suppo

RE: [PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

2017-01-09 Thread Long Li
Hi Bjorn This patch is still pending. The patch has been ack'ed. Do you want me to resend this patch? Thanks Long > -Original Message- > From: KY Srinivasan > Sent: Friday, November 11, 2016 2:21 PM > To: Bjorn Helgaas ; Long Li > Cc: Haiyang Zhang ; Bjorn Helgaas > ; de...@linuxdrive

RE: [PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

2017-01-09 Thread Long Li
Hi Bjorn, The patch is still pending (along with 1/2 v3). Please let me know if you want me to resend the two patches. Thanks Long > -Original Message- > From: KY Srinivasan > Sent: Tuesday, October 4, 2016 1:49 PM > To: Long Li ; Haiyang Zhang > ; Bjorn Helgaas > Cc: de...@linuxdrive

Re: [PATCH] Staging: i4l: Correct coding style errors

2017-01-09 Thread javier
El 03/01/17 a las 16:20, Greg KH escribió: On Thu, Dec 22, 2016 at 11:32:16PM +0100, Javier Rodriguez wrote: Some lines with more than 80 characters has been corrected. Also, some printk() functions has been changed with their proper print functions suggested by checkpatch.pl script as well as

[PATCH 2/2] staging:rtl8192u:r819xU_cmdpkt.c Removes un-necessary blank lines

2017-01-09 Thread Scott Matheina
Fixes checkpatch.pl warning - Blank lines aren't necessary before a close brace '}' & Please don't use multiple blank lines Signed-off-by: Scott Matheina --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 1/2] staging:rtl8192u:r819xU_cmdpkt.c Fix Alignment should match open parenthesis

2017-01-09 Thread Scott Matheina
Fixes Alignment should match open parenthesis in checkpatch Signed-off-by: Scott Matheina --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c in

[PATCH 2/2] staging:sm750fb:ddk750_chip.c removes un-necessary blank lines

2017-01-09 Thread Scott Matheina
Fixes checkpatch warning - Please don't use multiple blank lines Signed-off-by: Scott Matheina --- drivers/staging/sm750fb/ddk750_chip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index ec33f1f..9aaf1fd 100

[PATCH 1/2] staging:sm750fb:ddk750_chip.c Adds braces to last arm of statement

2017-01-09 Thread Scott Matheina
Fixes absence of braces on last arm of statement, identified by checkpatch Signed-off-by: Scott Matheina --- drivers/staging/sm750fb/ddk750_chip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c

[PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16

2017-01-09 Thread Eric Salem
Fixed the following sparse warning: drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning: cast to restricted __le16 by correcting the variable's type (also updated sizeof). Signed-off-by: Eric Salem --- drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH 3/4] staging:vt6656:main_usb.c Aligned code to match open parenthesis

2017-01-09 Thread Scott Matheina
Fixed Alignment should match open parenthesis from checkpatch Signed-off-by: Scott Matheina --- drivers/staging/vt6656/main_usb.c | 59 --- 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6

[PATCH 2/4] staging:vt6656:mac.c Aligned code to match open parenthesis

2017-01-09 Thread Scott Matheina
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina --- drivers/staging/vt6656/mac.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac

[PATCH 4/4] staging:vt6656:main_usb.c Removed un-needed blank lines

2017-01-09 Thread Scott Matheina
Fixed the following checkpatch warnings by deleting blank lines Blank lines aren't necessary before a close brace '}' Blank lines aren't necessary after an open brace '{' Please don't use multiple blank lines Signed-off-by: Scott Matheina --- drivers/staging/vt6656/main_usb.c | 4 1 file ch

[PATCH 1/4] staging:vt6656:key.c Aligned code with open parenthesis

2017-01-09 Thread Scott Matheina
Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina --- drivers/staging/vt6656/key.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/vt6656/key.c index 0246a8f..cc18cb1 1006

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-09 Thread Rob Herring
On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus configuration of the