[PATCH] staging: fwserial: fix checkpatch alignment check

2016-12-31 Thread Abdul Rauf
Fix the following checks: Alignment should match open parenthesis. Signed-off-by: Abdul Rauf --- drivers/staging/fwserial/fwserial.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index 41a49c819

[PATCH 0/6] staging: vchiq_arm: Fine-tuning for some function implementations

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 22:42:34 +0100 Some update suggestions were taken into account from static source code analysis. Markus Elfring (6): Use kmalloc_array() in dump_phys_mem() Adjust 13 checks for null pointers One check less in dump_phys_mem() after error detection

[PATCH 1/6] staging: vchiq_arm: Use kmalloc_array() in dump_phys_mem()

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 17:50:25 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle s

[PATCH 2/6] staging: vchiq_arm: Adjust 13 checks for null pointers

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 21:23:24 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 3/6] staging: vchiq_arm: One check less in dump_phys_mem() after error detection

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 21:26:09 +0100 Adjust a jump target according to the Linux coding style convention so that a redundant check for a null pointer can be avoided in this function. Signed-off-by: Markus Elfring --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq

[PATCH 4/6] staging: vchiq_arm: Delete an error message for a failed memory allocation in dump_phys_mem()

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 21:30:31 +0100 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/staging/vc04_servic

[PATCH 5/6] staging: vchiq_arm: Combine substrings for 24 messages

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 22:00:28 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines * Thus fix the affected source code places. * Improve indentation for passed parameters. Signed-off-by: Markus Elfring -

[PATCH 6/6] staging: vchiq_arm: Delete an unnecessary return statement in two functions

2016-12-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Dec 2016 22:05:19 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in affected functions. Signed-off-by: Markus Elfring --- drivers/st