This series does trivial cleanup for COMEDI proc fs related stuff.
Cheah Kok Cheong (5):
Staging: comedi: comedi_fops: Avoid orphaned proc entry
Staging: comedi: proc: Change file permission to read only
Staging: comedi: proc: Add __init prefix
Staging: comedi: proc: Add module owner
Sta
Move comedi_proc_init to the end to avoid orphaned proc entry
if module loading failed.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/comedi_fops.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comed
As there's no write operation, change to read only.
Was inadvertantly switched to 0644 in commit 1f817b86d5e6
("comedi: Don't use create_proc_read_entry()").
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Add __init prefix so that symbol will be discarded after
module loading.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 3513f4c..6d13b51 1006
Since this is a loadable kernel module, add module ownership
to follow LKM semantics.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 6d13b51..99b23b2e 100644
The proc entry is not essential for the comedi system as
evident by the support for !CONFIG_PROC_FS. So for failure
to create, just warn and continue loading.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/proc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/d
Larry Finger wrote:
> Set IEEE80211_HW_SUPPORTS_PS when driver is fwlps
> Because mac80211 control SW-LPS only, we add constraints to avoid errors.
>
> Signed-off-by: Vincent Fann
> Signed-off-by: shaofu
> Signed-off-by: Ping-Ke Shih
> Signed-off-by: Larry Finger
Dropped per Larry's request.
Larry Finger wrote:
> From: Ping-Ke Shih
>
> The btcoexist routines for the RTL8192EE have been extensively rewritten.
>
> Signed-off-by: Ping-Ke Shih
> Signed-off-by: Larry Finger
Dropped per Larry's request.
7 patches set to Changes Requested.
9459709 [1/7] rtlwifi: btcoexist: Update rou
On Thu, Dec 29, 2016 at 11:27 PM, Steve Longerbeam
wrote:
> Add optional reset-gpios pin control. If present, de-assert the
> specified reset gpio pin to bring the chip out of reset.
>
> Signed-off-by: Steve Longerbeam
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: linux-g...@vger.kernel.or
Larry Finger wrote:
> These drivers need to be able to reference "struct ieee80211_hw" from
> the driver's private data, and vice versa. The USB driver failed to
> store the address of ieee80211_hw in the private data. Although this
> bug has been present for a long time, it was not exposed until
Larry Finger writes:
> The symbol DBG_EMERG is no longer used and is removed.
>
> In a number of places, the code has redundant messages. For example, if
> the failure for the firmware to run is logged, it is not necessary to
> log that the firmware has been started. In addition, extraneous brace
Larry Finger wrote:
> This macro can be replaced with WARN_ONCE. In addition to using a
> standard debugging macro for these critical errors, we also get
> a stack dump.
>
> In rtl8821ae/hw.c, a senseless comment was removed, and an incorrect
> indentation was fixed.
>
> This patch also fixes tw
Hi Linus, Lothar,
On 12/30/2016 05:17 AM, Linus Walleij wrote:
On Thu, Dec 29, 2016 at 11:27 PM, Steve Longerbeam
wrote:
Add optional reset-gpios pin control. If present, de-assert the
specified reset gpio pin to bring the chip out of reset.
Signed-off-by: Steve Longerbeam
Cc: Linus Wallei
On 23/12/16 18:51, Thomas Preisner wrote:
> At the end of function ad7150_write_event_config(), "return 0" seems
> improper. It may be better to return the value of ret.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188871
>
> Reported-by: Pan Bian
> Signed-off-by: Thomas Preisner
>
On 25/12/16 19:56, Scott Matheina wrote:
> The description was split into 2 lines due to the line greatly
> exceeding the 80 character soft limit.
This is often deliberately done with strings. It makes them
much easier to grep for in the source. Adding the artificial
newline may destroy attempts
On 25/12/16 19:56, Scott Matheina wrote:
> Cases of camel case were fixed by making variables lower case throughout
> the file.
>
> Signed-off-by: Scott Matheina
So of these cases might arguably be worth doing, but extreme care is needed to
ensure
that the code is not broken.
Also, you are modi
On 25/12/16 19:56, Scott Matheina wrote:
> Adds braces to second arm of if else statement.
>
> Signed-off-by: Scott Matheina
This patch is actually correct so applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316.c | 3 ++-
> 1 file changed, 2 inse
On 30/12/16 18:46, Jonathan Cameron wrote:
> On 25/12/16 19:56, Scott Matheina wrote:
>> Adds braces to second arm of if else statement.
>>
>> Signed-off-by: Scott Matheina
> This patch is actually correct so applied to the togreg branch of iio.git.
Ah, patch title could be better. Should mention
On 25/12/16 19:56, Scott Matheina wrote:
> The code wasn't aligned with preceding ( on following lines, fixes
> this coding style issue.
>
> Signed-off-by: Scott Matheina
This looks fine, but is invasive enough I suspect it won't apply without
some of the earlier patches. If you care to respin t
On 25/12/16 19:56, Scott Matheina wrote:
> The permmission code was changed to reflect octat (0644/0444) for required
> permissions.
>
> Signed-off-by: Scott Matheina
The particularly comment from Linus that lead to this 'rule' coming in recently
was
fair enough, but the rule creates a lot of c
On 25/12/16 19:56, Scott Matheina wrote:
> Lines were not aligned with (, this patch simply changes the indention, no
> substantive
> changes function of driver.
>
> Signed-Off-By: Scott Matheina
Again, this patch is fine. If you respin the good bits of the series, please
give it a suitable name
The current Hyper-V code under drivers/hv has bunch of X86 specific code.
Restructure the code and move al architecture specific code to the
appropriate files.
As I was working on this restructuring, Roman Kagan
has submitted patches to restructure the Hyper-V header files to address
a different
From: K. Y. Srinivasan
The current Hyper-V code under drivers/hv has bunch of X86 specific code.
Restructure the code and move al architecture specific code to the
appropriate files.
As I was working on this restructuring, Roman Kagan
has submitted patches to restructure the Hyper-V header file
From: K. Y. Srinivasan
Move the relevant code that programs the hypervisor to an architecture
specific file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |4
drivers/hv/hv.c | 10 +-
2 files changed, 9 insertions(+), 5 deletions(-)
dif
From: K. Y. Srinivasan
As part of the effort to interact with Hyper-V in an instruction set
architecture independent way, use the new API to get the current
tick.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_util.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a
From: K. Y. Srinivasan
As part of cleaning up architecture specific code, define APIs
to manipulate the interrupt controller state.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |3 +++
drivers/hv/hv.c |8
2 files changed, 7 insertions(+),
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
crash notification function.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c | 26 ++
arch/x86/include/asm/mshyperv.h|1 +
arch/x86/include
From: K. Y. Srinivasan
Get rid of all unused definitions.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hyperv_vmbus.h | 152 +
1 files changed, 2 insertions(+), 150 deletions(-)
diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
i
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
check for detecting if the hypercall page is setup.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c | 15 +++
arch/x86/include/asm/mshyperv.h |1 +
drivers/hv
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
definition of hv_x64_msr_hypercall_contents to x86 specific header file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h | 12
drivers/hv/hyperv_vmbus.h |
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
code for signaling end of message.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h | 37 +
drivers/hv/channel_mgmt.c |1 +
drive
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code,
extract hypervisor version information in an architecture specific
file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h | 19 +++
arch/x86/kernel/cpu/mshyperv.c | 20 +
From: K. Y. Srinivasan
The version variable while it is initialized is not used;
get rid of it.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 0afffd8..5a2a329 100644
--- a/
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
definition of generate_guest_id() to x86 specific header file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h | 43 +++
drivers/hv/hyperv
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
hypercall page setup to an architecture specific file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/Kbuild |3 ++
arch/x86/hyperv/Makefile|1 +
arch/x86/hyperv/hv_i
From: K. Y. Srinivasan
As part of cleaning up architecture specific code, define APIs
to manipulate the message page.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |3 +++
drivers/hv/hv.c |8
2 files changed, 7 insertions(+), 4 deletions(-
From: K. Y. Srinivasan
As part of cleaning up architecture specific code, define APIs
to manipulate the event page.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |3 +++
drivers/hv/hv.c |8
2 files changed, 7 insertions(+), 4 deletions(-)
From: K. Y. Srinivasan
As part of cleaning up architecture specific code, define an API
to retrieve the virtual procesor index.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |2 ++
drivers/hv/hv.c |2 +-
2 files changed, 3 insertions(+), 1 deletion
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code, move the
hypercall invocation code to an architecture specific file.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c | 54 +++---
arch/x86/include/asm/
From: K. Y. Srinivasan
As part of the effort to separate out architecture specific code,
consolidate all Hyper-V specific clocksource code to an architecture
specific code.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/hyperv/hv_init.c | 104 +++
arch/
From: K. Y. Srinivasan
As part of cleaning up architecture specific code, define APIs
to manage interrupt state.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/asm/mshyperv.h |3 +++
drivers/hv/hv.c | 12
2 files changed, 11 insertions(+), 4 deletions(-
> -Original Message-
> From: Roman Kagan [mailto:rka...@virtuozzo.com]
> Sent: Wednesday, December 28, 2016 8:57 AM
> To: KY Srinivasan
> Cc: Paolo Bonzini ; Radim Krčmář
> ; Vitaly Kuznetsov ; Thomas
> Gleixner ; Ingo Molnar ; H. Peter
> Anvin ; x...@kernel.org; Haiyang Zhang
> ; k...@v
On 11/12/16 02:47, Eva Rachel Retuya wrote:
> Eliminate the non-standard attributes in_voltage_range and
> in_voltage_range_available. Implement in_voltage_scale_available in place
> of these attributes and update the SCALE accordingly. The array
> scale_avail is introduced to hold the available sc
On 11/12/16 02:47, Eva Rachel Retuya wrote:
> Move the ad7606 driver from staging/iio/adc to iio/adc. Also, update the
> corresponding Makefile and Kconfig associated with the change.
>
> Signed-off-by: Eva Rachel Retuya
Personally (and this is much debated ;) I prefer for the odd case
of staging
From: Markus Elfring
Date: Fri, 30 Dec 2016 21:43:22 +0100
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle s
45 matches
Mail list logo
