Re: [PATCH 12/19] staging: lustre: libcfs: remove == 0 testing

On Thu, Nov 17, 2016 at 02:35:50PM -0500, James Simmons wrote: > Testing == 0 is not kernel style so remove this > type of testing from libcfs. > That's not true. Checkpatch.pl won't complain. Not everyone has thought about it or agrees with me but there are time when == 0 is idiomatic. For ex

[PATCH] Staging: wlan-ng: prism2mgmt: Fixed operators spacing style issues

Fixed spaces around operators to fix their coding style issues. Signed-off-by: Shiva Kerdel --- drivers/staging/wlan-ng/prism2mgmt.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c ind

[PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning WARNING: braces {} are not necessary for single statement blocks Fixed indentation error, noted by Dan Carpenter Signed-off-by: Rahul Krishnan --- drivers/staging/greybus/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote: > This patch fixes the following checkpath.pl warning > WARNING: braces {} are not necessary for single statement blocks > > Fixed indentation error, noted by Dan Carpenter > > Signed-off-by: Rahul Krishnan > --- > drivers/staging/

[PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Rahul Krishnan --- drivers/staging/greybus/sdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/sdio.c b/drivers/st

Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

Hi Rahul, Thanks for the patch. Now looks great. On Fri, Nov 18, 2016 at 08:45:25PM +0530, Rahul Krishnan wrote: This patch fixes the following checkpath.pl warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Rahul Krishnan Reviewed-by: Rui Miguel Silva

Re: [PATCH v3] staging: lustre: llog: fix wrong offset in llog_process_thread()

> On Thu, Nov 17, 2016 at 06:29:08PM -0500, James Simmons wrote: > > From: Mikhail Pershin > > > > - llh_cat_idx may become bigger than llog bitmap size in > > llog_cat_set_first_idx() function > > - it is wrong to use previous cur_offset as new buffer offset, > > new offset should be calcul

Re: [PATCH 12/19] staging: lustre: libcfs: remove == 0 testing

> On Thu, Nov 17, 2016 at 02:35:50PM -0500, James Simmons wrote: > > Testing == 0 is not kernel style so remove this > > type of testing from libcfs. > > > > That's not true. Checkpatch.pl won't complain. > It got lumped in with the checkpatch fixes. Also the __uXX problem is not reported by

[PATCH 03/10] staging: lustre: libcfs: name parameters for function prototypes

Give the parameters names for the function prototypes in the libcfs headers. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 ++-- .../lustre/include/linux/libcfs/libcfs_hash.h | 15 --- .../lustre/include/linux/libcfs/libcfs_private.

[PATCH 05/10] staging: lustre: libcfs: correct spelling in libcfs_cpu.h

Spell the word destroy correctly. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_cpu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_cpu.h b/drivers/staging/lustre/include/linux/libcfs/

[PATCH 04/10] staging: lustre: libcfs: remove blank line in header

The header libcfs_fail.h has a extra blank line that is not needed. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_fail.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h b/drivers/st

[PATCH 01/10] staging: lustre: libcfs: fixup all header block comments

Properly format the incorrect comments sections that were reported by checkpatch. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_crypto.h| 10 -- .../lustre/include/linux/libcfs/libcfs_fail.h | 30 +-- .../lustre/include/linux/libcfs/libc

[PATCH 06/10] staging: lustre: libcfs: use bit macro in libcfs headers

Use the BIT macros instead of (1 << ***) in libcfs headers. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/curproc.h | 18 .../lustre/include/linux/libcfs/libcfs_fail.h |4 +- .../lustre/include/linux/libcfs/libcfs_hash.h | 42 ++-

[PATCH 08/10] staging: lustre: libcfs: remove NULL comparisons in headers

Remove the NULL comparisions in the libcfs headers. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_hash.h |2 +- .../lustre/include/linux/libcfs/libcfs_private.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre

[PATCH 09/10] staging: lustre: libcfs: remove zero comparisons in headers

Remove the zero comparisions in the libcfs headers. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_crypto.h|2 +- .../lustre/include/linux/libcfs/libcfs_fail.h |4 +- .../lustre/include/linux/libcfs/libcfs_hash.h | 32 ++-- 3 files

[PATCH 10/10] staging: lustre: libcfs: use uXX instead of __uXX types in headers

The types __[u|s]XX is only used for UAPI headers and userspace. Only keep these types for the libcfs headers that are UAPI headers. The rest convert to the standard uXX types. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/curproc.h |2 +- .../lustre/include/linux

[PATCH 00/10] checkpatch fixes and style cleanups for libcfs headers

This patch set contains various cleanups that were reported with checkpatch. Also remove the NULL and 0 comparisons which is not kernel style. Lastly the uXX types are sorted out in the libcfs headers. Only the macro mess is left that needs cleaning up. James Simmons (10): staging: lustre: libcf

[PATCH 02/10] staging: lustre: libcfs: remove header's bare unsigned use

Fixup the libcfs headers to use the proper unsigned int instead of raw unsigned. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_hash.h | 28 ++-- .../lustre/include/linux/libcfs/libcfs_string.h|6 ++-- .../lustre/include/linux/libcfs/linux/

[PATCH 07/10] staging: lustre: libcfs: remove whitespace in libcfs_fail.h

One last white space is still left in libcfs_fail.h. Lets remove it. Signed-off-by: James Simmons --- .../lustre/include/linux/libcfs/libcfs_fail.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h b/drivers/

[PATCH v4] staging: lustre: llog: fix wrong offset in llog_process_thread()

From: Mikhail Pershin - llh_cat_idx may become bigger than llog bitmap size in llog_cat_set_first_idx() function - it is wrong to use previous cur_offset as new buffer offset, new offset should be calculated from value returned by llog_next_block(). - optimize llog_skip_over() to find llog

Re: [PATCH 32/35] staging: lustre: mount: fix lmd_parse() to handle commas in expr_list

> > --- a/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > +++ b/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > @@ -871,6 +871,87 @@ static int lmd_parse_mgs(struct lustre_mount_data > > *lmd, char **ptr) > > return 0; > > } > > > > +/** > > + * Find the first comma delimiter

Re: [PATCH 32/35] staging: lustre: mount: fix lmd_parse() to handle commas in expr_list

On Fri, Nov 18, 2016 at 04:54:03PM +, James Simmons wrote: > > > > --- a/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > > +++ b/drivers/staging/lustre/lustre/obdclass/obd_mount.c > > > @@ -871,6 +871,87 @@ static int lmd_parse_mgs(struct lustre_mount_data > > > *lmd, char **ptr) > > >

[PATCH v3] staging: vme: vme_user.c Spelling corrections

Make spelling corrections for 'correctly' and 'unregister' Signed-off-by: Walt Feasel Acked-by: Martyn Welch --- v2 Removed the previously submitted U.S. spelling for 'initialise' to keep the correct U.K. spelling. v3 makes changes to correct for email format patch submission drivers/staging/

[PATCH v2] staging: dgnc: dgnc_cls.h Spelling correction

Make spelling correction for 'control' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls

[PATCH v2] staging: dgnc: dgnc_cls.c Comment style modifications

Make modifications to comment style format Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_cls.c | 44 - 1 file changed, 17 insertions(+), 27 deletions(-) diff --git a/drivers/staging/

[PATCH v4] staging: slicoss: fix different address space warnings

This patchset fix the following sparse warning: warning: incorrect type in assignment (different address spaces) Changes in v2: * Remove IOMEM_GET_FIELDADDR macro * Add ioread64 and iowrite64 defines Changes in v3: * Remove ioread64 and iowrite64 defines * Split into two patches: one for 32 bits

[PATCH v4] staging: slicoss: fix different address space warnings

Remove incorrect __iomem annotation. This patch fix the following sparse warnings in slicoss driver: warning: incorrect type in assignment (different address spaces) Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/6] staging: slicoss: avoid CamelCases in slic.h

Replace CamelCases to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slic.h| 30 +++ drivers/staging/slicoss/slicoss.c | 50 +++ 2 files changed, 40 insertions(+), 40 deletion

[PATCH 6/6] staging: slicoss: avoid CamelCases slicoss.c

Replace CamelCases to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slicoss.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slic

[PATCH 0/6] staging: slicoss: fix some style issues

This patchset fix several style issues to comply with the standard kernel coding style. Sergio Paracuellos (6): staging: slicoss: avoid CamelCases in slic.h staging: slicoss: fix parenthesis alignment in slicoss.c staging: slicoss: logical continuations should be on the previous line stag

[PATCH 5/6] staging: slicoss: avoid CamelCases in slichw.h

Replace CamelCases to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slichw.h | 178 +++--- drivers/staging/slicoss/slicoss.c | 56 ++-- 2 files changed, 117 insertions(+), 117 deletions(-) di

[PATCH 4/6] staging: slicoss: braces should be used on all arms of this statement

Add braces in if statement to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slicoss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index

[PATCH 2/6] staging: slicoss: fix parenthesis alignment in slicoss.c

This patch fix open parenthesis alignment matching in slicoss.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slicoss.c | 68 +++ 1 file changed, 33 insertions(+), 35 deletions(-) diff --gi

[PATCH 3/6] staging: slicoss: logical continuations should be on the previous line

Move logical or operator to previous line to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slicoss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/

[PATCH v2 2/3] staging: dgnc: dgnc_driver.c Remove blank lines

Make suggested checkpatch modification for CHECK: Please don't use multiple blank lines Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/dgnc/dgn

[PATCH v2 0/3] staging: dgnc: dgnc_driver.c checkpatch modifications

Make Linux kernel coding style modifications for dgnc_driver.c to include: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary before a close brace '}' Comment style modifications Walt Feasel (3): staging: dgnc: dgnc_driver.c Comment style modifications staging: dg

[PATCH v2 1/3] staging: dgnc: dgnc_driver.c Comment style modifications

Make modifications to comment styles Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.c | 57 +- 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/drivers/staging/dgnc/

[PATCH v2 3/3] staging: dgnc: dgnc_driver.c Blank line before }

Make suggested checkpatch modification for CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/stag

Follow up on Ion from LPC

Hi, At LPC, I proposed a moratorium on new Ion features because of issues preventing Ion ever moving out of staging. Among other problems, the Ion caching model hasn't made much progress to a solution that is widely accepted and there are still problems with devicetree support. There were no stron

[PATCH v2 1/3] staging: dgnc: dgnc_driver.h Comment style modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.h | 170 - 1 file changed, 73 insertions(+), 97 deletions(-) diff --git a/drivers/staging/dgnc/d

[PATCH v2 0/3] checkpatch modifications dgnc_driver.h

Make Linux kernel coding style modifications for dgnc_driver.h to include: Spelling correction Comment style modifications Align columns Walt Feasel (3): staging: dgnc: dgnc_driver.h Comment style modifications staging: dgnc: dgnc_driver.h Align columns staging: dgnc: dgnc_driver.h Spelling

[PATCH v2 2/3] staging: dgnc: dgnc_driver.h Align columns

Make modifications to align columns Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/dr

[PATCH v2 3/3] staging: dgnc: dgnc_driver.h Spelling correction

Make spelling correction for 'statements' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgn

[PATCH] staging: dgnc: dgnc_mgmt.c Comment style modifications

Make modifications for comment style Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_mgmt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index 683c098..9d9b15d 100644 --- a/drivers/staging/d

[PATCH v2] staging: dgnc: dgnc_neo.c Comment style modifications

Make modifications for comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_neo.c | 111 +++- 1 file changed, 54 insertions(+), 57 deletions(-) diff --git a/drivers/staging/dgnc/

[PATCH 0/2] staging: dgnc: dgnc_neo.h checkpatch modifications

Make Linux kernel coding style modifications for dgnc_neo.h to include: Spelling correction Comment style modifications Walt Feasel (2): staging: dgnc: dgnc_neo.h Comment style modifications staging: dgnc: dgnc_neo.h Spelling correction drivers/staging/dgnc/dgnc_neo.h | 26 -

[PATCH 1/2] staging: dgnc: dgnc_neo.h Comment style modifications

Make modifications for comment style Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.h | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h index 97f0386..1aa9325 100644 --- a

[PATCH 2/2] staging: dgnc: dgnc_neo.h Spelling correction

Make spelling correction for 'control' Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h index 1aa9325..77ecd9b 100644 --- a/drivers/staging/dgnc/dgn

[PATCH v2 1/2] staging: dgnc: dgnc_sysfs.c Comment style modifications

Make modifications to comment style Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc

[PATCH v2 0/2] staging: dgnc: dgnc_sysfs.c checkpatch modifications

Make Linux kernel coding style modifications for dgnc_sysfs.c to include: Comment style modifications Remove blank line Walt Feasel (2): staging: dgnc: dgnc_sysfs.c Comment style modifications staging: dgnc: dgnc_sysfs.c Delete blank line drivers/staging/dgnc/dgnc_sysfs.c | 4 ++-- 1 file

[PATCH v2 2/2] staging: dgnc: dgnc_sysfs.c Delete blank line

Make modification to remove extra blank line Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/dgnc/dgnc_sysfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c i

Re: rtlwifi: rtl8723be: Fix bug in ant_sel code from commit c18d8f509571

Larry Finger wrote: > From: Ping-Ke Shih > > In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module > parameter"), wifi was fixed for those laptops that have only a single > antenna but have an incorrectly coded EEPROM. This error causes the > driver to select the wrong antenna.