Re: [PATCH v2] staging: slicoss: fix different address space warnings

2016-11-16 Thread Sergio Paracuellos
On Wed, Nov 16, 2016 at 8:05 AM, Greg KH wrote: > On Wed, Nov 16, 2016 at 05:07:37AM +0100, Sergio Paracuellos wrote: >> This patch fix the following sparse warnings in slicoss driver: >> warning: incorrect type in assignment (different address spaces) >> >> Changes in v2: >> * Remove IOMEM_GET_FI

Re: [bug report] staging: add bcm2708 vchiq driver

2016-11-16 Thread Dan Carpenter
On Tue, Nov 15, 2016 at 10:04:05PM -0500, Vince Weaver wrote: > On Tue, 15 Nov 2016, Michael Zoran wrote: > > > I'm still interested to know more about the MMU statement. I would > > think at least some of the RPI models have one because swapping appears > > to be at least somewhat functional on

Re: [PATCH] staging: slicoss: fix different address space warnings

2016-11-16 Thread Dan Carpenter
This can't be right... ->shmem_data is set in slic_init_adapter() and it's not iomem. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [bug report] staging: add bcm2708 vchiq driver

2016-11-16 Thread Phil Elwell
On 16/11/2016 10:21, Dan Carpenter wrote: > On Tue, Nov 15, 2016 at 10:04:05PM -0500, Vince Weaver wrote: >> On Tue, 15 Nov 2016, Michael Zoran wrote: >> >>> I'm still interested to know more about the MMU statement. I would >>> think at least some of the RPI models have one because swapping appea

[PATCH] staging: wilc1000: simplify vif[i]->ndev accesses

2016-11-16 Thread Arnd Bergmann
With gcc-7, I got a new warning for this driver: wilc1000/linux_wlan.c: In function 'wilc_netdev_cleanup': wilc1000/linux_wlan.c:1224:15: error: 'vif[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized] wilc1000/linux_wlan.c:1224:15: error: 'vif[0]' may be used uninitializ

[PATCH 1/2] staging: vc04_services: remove duplicate mutex_lock_interruptible

2016-11-16 Thread Arnd Bergmann
The driver tries to redefine mutex_lock_interruptible as an open-coded mutex_lock_killable, but that definition clashes with the normal mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC is set: staging/vc04_services/interface/vchiq_arm/vchiq_killable.h:67:0: error: "mutex_lock_inte

[PATCH 2/2] staging: vc04_services: clarify firmware dependency

2016-11-16 Thread Arnd Bergmann
The raspberrypi-firmware driver may be built as a loadable module, which causes a link-time failure if the vc04_services driver is built-in during compile-testing: drivers/staging/vc04_services/vchiq.o: In function `vchiq_probe': vchiq_connected.c:(.text.vchiq_probe+0x2c): undefined reference to

[staging:staging-testing 514/575] ERROR: "bad_dma_ops" [drivers/staging/vc04_services/vchiq.ko] undefined!

2016-11-16 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 6fde3789a2efba826d89414f8d8dcda27da9ce45 commit: abbdc56b17d662ae710bc0c30cf0d0e9da805fd4 [514/575] staging: vc04_services: add CONFIG_COMPILE_TEST ability config: m32r-allmodconfig (attached as .co

Re: [bug report] staging: add bcm2708 vchiq driver

2016-11-16 Thread Eric Anholt
Michael Zoran writes: > On Tue, 2016-11-15 at 22:04 -0500, Vince Weaver wrote: >> On Tue, 15 Nov 2016, Michael Zoran wrote: >> >> > I'm still interested to know more about the MMU statement.  I would >> > think at least some of the RPI models have one because swapping >> > appears >> > to be at

[PATCH v2 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-11-16 Thread Stuart Yoder
From: Roy Pledge Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor Cc: Ioana Radulescu --- -v2 -added setter/getter for the FD ctrl field -corrected comment for SG format_offset field

[PATCH v2 0/9] staging: fsl-mc: move bus driver out of staging, add dpio

2016-11-16 Thread Stuart Yoder
This patch series: A) addresses the final item in the staging TODO list for the fsl-mc bus driver-- adding a functional driver on top of the bus driver, and B) requests that the fsl-mc bus driver be moved out of staging. The proposed destination for the bus driver is drivers/bus. Proposed location

[PATCH v2 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-11-16 Thread Stuart Yoder
From: Ioana Radulescu Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor --- -v2 -removed unused structs and defines as suggested by Io

[PATCH v2 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions

2016-11-16 Thread Stuart Yoder
From: Roy Pledge Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor Cc: Ioana Radulescu --- -v2 -no changes include/linux/fsl/dpaa2-global.h | 203 +++

[PATCH v2 9/9] bus: fsl-mc: dpio: add maintainer for DPIO

2016-11-16 Thread Stuart Yoder
From: Roy Pledge add Roy Pledge as maintainer of DPIO Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor Cc: Ioana Radulescu --- -v2 -corrected location of maintainer entry MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v2 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2016-11-16 Thread Stuart Yoder
From: Roy Pledge The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notifications are received. Signe

[PATCH v2 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-11-16 Thread Stuart Yoder
From: Roy Pledge Add QBman APIs for frame queue and buffer pool operations. Signed-off-by: Roy Pledge Signed-off-by: Haiying Wang Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor Cc: Ioana Radulescu --- -v2 -fix bug in buffer release command, by setting bpid field -handle error (NULL)

[PATCH v2 1/9] staging: fsl-mc: move bus driver out of staging

2016-11-16 Thread Stuart Yoder
Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, providing and overview

[PATCH v2 2/9] bus: fsl-mc: dpio: add DPIO driver overview document

2016-11-16 Thread Stuart Yoder
add document describing the dpio driver and it's role, components and major interfaces Signed-off-by: Stuart Yoder Cc: Laurentiu Tudor Cc: Roy Pledge Cc: Ioana Radulescu --- -v2 -no changes Documentation/dpaa2/dpio-driver.txt | 135 1 file changed, 135

[PATCH v2 8/9] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

2016-11-16 Thread Stuart Yoder
From: Roy Pledge The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by: Roy Pledge Signed-off-by: Haiying Wan

Re: [PATCH 1/2] staging: vc04_services: remove duplicate mutex_lock_interruptible

2016-11-16 Thread Eric Anholt
Arnd Bergmann writes: > The driver tries to redefine mutex_lock_interruptible as an open-coded > mutex_lock_killable, but that definition clashes with the normal > mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC > is set: These two are: Acked-by: Eric Anholt signature.asc De

Re: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case

2016-11-16 Thread Bjorn Helgaas
On Thu, Nov 10, 2016 at 07:16:22AM +, Dexuan Cui wrote: > PATCH 1 is just a clean-up. There should be no functional change. > > PATCH 2 and 3 are for device hot-remove case. > Currently the driver will stop working or even cause panic, if we do > hot add/remove quickly a few times. With the 2

RE: [PATCH 0/3] PCI: hv: clean-up and 2 fixes to the hot-remove case

2016-11-16 Thread KY Srinivasan
> -Original Message- > From: Bjorn Helgaas [mailto:helg...@kernel.org] > Sent: Wednesday, November 16, 2016 2:49 PM > To: Dexuan Cui > Cc: Bjorn Helgaas ; linux-...@vger.kernel.org; > de...@linuxdriverproject.org; gre...@linuxfoundation.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > He

[PATCH 0/2] Lustre fixes

2016-11-16 Thread Oleg Drokin
With multiple metadata RPCs code in now, these two fixes become important. Please consider. Niu Yawei (2): staging/lustre/ptlrpc: track unreplied requests staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay .../staging/lustre/lustre/include/lustre_import.h | 5 + drivers

[PATCH 1/2] staging/lustre/ptlrpc: track unreplied requests

2016-11-16 Thread Oleg Drokin
From: Niu Yawei The request xid was used to make sure the ost object timestamps being updated by the out of order setattr/punch/write requests properly. However, this mechanism is broken by the multiple rcvd slot feature, where we deferred the xid assignment from request packing to request sendin

[PATCH 2/2] staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay

2016-11-16 Thread Oleg Drokin
From: Niu Yawei The imp_known_replied_xid should be updated when try to resend an already replied replay request, because the xid of this replay request could be less than current imp_known_replied_xid. Signed-off-by: Niu Yawei Reviewed-on: http://review.whamcloud.com/22776 Intel-bug-id: https:

[PATCH v2 0/3] staging: xgifb: vb_init.c checkpatch modifications

2016-11-16 Thread Walt Feasel
Make Linux kernel coding style modifications for vb_init.c to include: CHECK: Logical continuations should be on the previous line CHECK: Alignment should match open parenthesis Various comment style modifications Walt Feasel (3): staging: xgifb: vb_init.c Logical continuation staging: xgifb

[PATCH v2 3/3] staging: xgifb: vb_init.c Comment style

2016-11-16 Thread Walt Feasel
Make various comment style modifications. Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/vb_init.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/xgifb/vb_init

[PATCH v2 1/3] staging: xgifb: vb_init.c Logical continuation

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for: CHECK: Logical continuations should be on the previous line. Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/vb_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH v2 2/3] staging: xgifb: vb_init.c Align on parenthesis

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for: CHECK: Alignment should match open parenthesis. Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/vb_init.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions

[PATCH v2 2/7] staging: xgifb: XGI_main_26.c No space after cast

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: No space is necessary after a cast Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletio

[PATCH v2 3/7] staging: xgifb: XGI_main_26.c Logical continuation

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 20 +--- 1 file changed, 9 insertions(+), 11

[PATCH v2 6/7] staging: xgifb: XGI_main_26.c Blank line before }

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s

[PATCH v2 0/7] staging: xgifb: XGI_main_26.c checkpatch modifications

2016-11-16 Thread Walt Feasel
Make Linux kernel coding style modifications for XGI_main_26.c to include: CHECK: Alignment should match open parenthesis CHECK: No space is necessary after a cast CHECK: Logical continuations should be on the previous line CHECK: spaces preferred around that '-' CHECK: Blank lines aren't necessar

[PATCH v2 7/7] staging: xgifb: XGI_main_26.c Align match parenthesis

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 100 +--- 1 file changed, 46 insertions(+)

[PATCH v2 1/7] staging: xgifb: XGI_main_26.c Comment style modifications

2016-11-16 Thread Walt Feasel
Make comment style modifications. Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/st

[PATCH v2 5/7] staging: xgifb: XGI_main_26.c Blank line after {

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH v2 4/7] staging: xgifb: XGI_main_26.c Space around operator

2016-11-16 Thread Walt Feasel
Make suggested checkpatch modification for CHECK: spaces preferred around that '-,&' Signed-off-by: Walt Feasel --- v2 makes changes to correct for email format patch submission drivers/staging/xgifb/XGI_main_26.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v3 2/2] staging: slicoss: fix different address space warnings: 64 bits

2016-11-16 Thread Sergio Paracuellos
This patch fix the following sparse warnings in slicoss driver: warning: incorrect type in assignment (different address spaces) This changes are for 64 bits. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slic.h | 9 + 1 file changed, 9 insertions(+) diff --git a/driver

[PATCH v3 0/2] staging: slicoss: fix different address space warnings

2016-11-16 Thread Sergio Paracuellos
This patchset fix the following sparse warning: warning: incorrect type in assignment (different address spaces) Changes in v2: * Remove IOMEM_GET_FIELDADDR macro * Add ioread64 and iowrite64 defines Changes in v3: * Remove ioread64 and iowrite64 defines * Split into two patches: one for 32 bits

[PATCH v3 1/2] staging: slicoss: fix different address space warnings: 32 bits

2016-11-16 Thread Sergio Paracuellos
This patch fix the following sparse warnings in slicoss driver: warning: incorrect type in assignment (different address spaces) This changes are for 32 bit architectures. Signed-off-by: Sergio Paracuellos --- drivers/staging/slicoss/slic.h| 9 + drivers/staging/slicoss/slicoss.c | 82

Re: [1/8] rtlwifi: rtl8192de: Remove address of Free Software Foundation

2016-11-16 Thread Kalle Valo
Larry Finger wrote: > Since this driver was added to the kernel, the checkpatch script was > modified to request that the address of the FSF not be included. > > Signed-off-by: Larry Finger 8 patches applied to wireless-drivers-next.git, thanks. 0d3d253b2040 rtlwifi: rtl8192de: Remove address

Re: ssb: Fix error routine when fallback SPROM fails

2016-11-16 Thread Kalle Valo
Larry Finger wrote: > When there is a CRC error in the SPROM read from the device, the code > attempts to handle a fallback SPROM. When this also fails, the driver > returns zero rather than an error code. > > Signed-off-by: Larry Finger > Cc: Stable Patch applied to wireless-drivers-next.git,