Fixed checkpatch.pl warnings related to Block comments in
staging/rtl8192e/*.c files.
Signed-off-by: Yamanappagouda Patil
---
drivers/staging/rtl8192e/dot11d.c | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8
After following a discussion about the used integer types Dan Carpenter
pointed out that 'int' types should be used over the current change to
's16'. The reason for this is to have an upper bound instead of overflowing
the 's16' so we could still remove devices.
Signed-off-by: Shiva Kerdel
Sugges
Fixed checkpatch.pl "Missing a blank line after declarations" warnings.
Signed-off-by: Yamanappagouda Patil
---
drivers/staging/rtl8192e/rtllib_rx.c | 1 +
drivers/staging/rtl8192e/rtllib_softmac.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> ow...@vger.kernel.org] On Behalf Of feas
> Sent: Monday, November 14, 2016 7:16 PM
> To: de...@driverdev.osuosl.org; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org
> Subject: Patch procedur
On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote:
> VCHIQ/vc04_services has a userland device interface
> that includes ioctls. The current ioctl implementation
> is a single monolithic function over 1,000+ lines
> that handles 17 different ioctls through a complex
> maze of switch and
VM_IOREMAP is used to access hardware through a mechanism called
I/O mapped memory. Android binder is a IPC machanism which will
not access I/O memory.
Also VM_IOREMAP has alignment requiement which may not needed in
binder.
__get_vm_area_node()
{
...
if (flags & VM_IOREMAP)
On Mon, Nov 14, 2016 at 06:27:57PM +, James Simmons wrote:
>
> > On Thu, Nov 10, 2016 at 12:30:30PM -0500, James Simmons wrote:
> > > More fixes missing from the upstream client. Also a nice cleanup
> > > with the removal of cl_req which is no longer needed. More cleanup
> > > for lustre_idl.h
On Tue, Nov 15, 2016 at 09:30:03AM +0100, Shiva Kerdel wrote:
> After following a discussion about the used integer types Dan Carpenter
> pointed out that 'int' types should be used over the current change to
> 's16'. The reason for this is to have an upper bound instead of overflowing
> the 's16'
On Mon, Nov 14, 2016 at 05:27:00PM +, James Simmons wrote:
>
> > On Mon, Nov 14, 2016 at 04:59:48PM +, James Simmons wrote:
> > >
> > > > On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote:
> > > > > From: Gregoire Pichon
> > > > >
> > > > > This patch is the main client part
On Tue, Nov 15, 2016 at 05:55:39PM +0800, Ganesh Mahendran wrote:
> VM_IOREMAP is used to access hardware through a mechanism called
> I/O mapped memory. Android binder is a IPC machanism which will
> not access I/O memory.
>
> Also VM_IOREMAP has alignment requiement which may not needed in
> bin
Corrects style issues 'Blank line after declarations' and
'Preferred space around operators'
Walt Feasel (2):
[STYLE 1/2]staging:xgifb:vb_table.h Blank line after declarations
[STYLE 2/2]staging:xgifb:vb_table.h Preferred space around
drivers/staging/xgifb/vb_table.h | 9 +
1 file ch
Make suggested modification from checkpatch in reference
to: CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel
---
v2 corrects mailing format to link patches
and change subject line
drivers/staging/xgifb/vb_table.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
d
Make suggested modification from checkpatch in reference
to: CHECK: Please use a blank line after
function/struct/union/enum declarations
Signed-off-by: Walt Feasel
---
v2 corrects mailing format to link patches
and change subject line
drivers/staging/xgifb/vb_table.h | 1 +
1 file changed, 1 in
On Thu, Nov 10, 2016 at 07:16:39PM +0100, Sergio Paracuellos wrote:
> +#define HFA384x_CMD_AINFO ((u16)GENMASK(14, 8))
The casts to u16 are pointless because of type promotion and half of
these defines aren't used anyway (both that I looked at).
regards,
dan carpenter
On Thu, Nov 10, 2016 at 07:16:40PM +0100, Sergio Paracuellos wrote:
> -#define WLAN_GET_FC_FTYPE(n) u16)(n)) & (BIT(2) | BIT(3))) >> 2)
> -#define WLAN_GET_FC_FSTYPE(n)u16)(n)) & \
> - (BIT(4) | BIT(5) | BIT(6) | BIT(7))) >> 4)
> +#define WLAN_GET_FC_FTYP
On Thu, Nov 10, 2016 at 07:16:42PM +0100, Sergio Paracuellos wrote:
> This patch replace actual mask stuff using BIT macros with
> or operators to make use of GENMASK macro which simplifies
> code clearity and readibility.
>
> It applies for two bitwise operations included in prism2sta.c source
Replace uint8_t, uint16_t and uint32_t with preferred kernel types
u8, u16 and u32 respectively suggested by checkpatch.pl
Signed-off-by: Punit Vara
---
drivers/staging/ks7010/ks_wlan.h | 138 +--
drivers/staging/ks7010/michael_mic.c | 10 +--
drivers/staging
Hello popcornmix,
The patch 71bad7f08641: "staging: add bcm2708 vchiq driver" from Jul
2, 2013, leads to the following static checker warning:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1597
dump_phys_mem()
error: using offset into zero size array 'pages[]'
dr
Hi, Greg
2016-11-15 18:18 GMT+08:00 Greg KH :
> On Tue, Nov 15, 2016 at 05:55:39PM +0800, Ganesh Mahendran wrote:
>> VM_IOREMAP is used to access hardware through a mechanism called
>> I/O mapped memory. Android binder is a IPC machanism which will
>> not access I/O memory.
>>
>> Also VM_IOREMAP h
This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Rahul Krishnan
---
drivers/staging/greybus/sdio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/
On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Rahul Krishnan
> ---
> drivers/staging/greybus/sdio.c | 5 ++---
> 1 file changed, 2 inserti
This patch fix the following sparse warnings in slicoss driver:
warning: incorrect type in assignment (different address spaces)
Signed-off-by: Sergio Paracuellos
---
drivers/staging/slicoss/slic.h| 7
drivers/staging/slicoss/slicoss.c | 83 ++-
2 fi
On Tue, Nov 15, 2016 at 06:19:37PM +0100, Sergio Paracuellos wrote:
> This patch fix the following sparse warnings in slicoss driver:
> warning: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/slicoss/slic.h| 7
> dr
Hi Sergio,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.9-rc5 next-20161115]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sergio-Paracuellos/staging-slicoss
Hi Dan,
> Dan Carpenter hat am 15. November 2016 um 14:15
> geschrieben:
>
>
> Hello popcornmix,
>
> The patch 71bad7f08641: "staging: add bcm2708 vchiq driver" from Jul
> 2, 2013, leads to the following static checker warning:
>
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq
Hi,
On 13.11.2016 20:55, Andrew Lunn wrote:
>> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
>> +"rx_packets ",
>> +"rx_bytes ",
>> +"rx_multicasts ",
>> +"rx_errors ",
>> +"rx_buff_miss ",
>> +"rx_tp_csum ",
>> +"rx_tp_oflow",
Hi Dan,
On Mon, Nov 14, 2016 at 01:34:15PM +0300, Dan Carpenter wrote:
> Please just delete the blank lines.
Sure, if that's what you guys prefer.
> You aren't that special like a snow flake.
Someone put his grumpy pants on backwards, didn't he?
thx,
Jason.
___
Hi Walt,
Please ignore our side conversation,
On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote:
> Made suggested modifications from checkpatch in reference
> to CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Walt Feasel
Acked-by: Jason Cooper
thx,
Jason.
On 11/15/2016 12:46 PM, Lino Sanfilippo wrote:
>> Could this be pulled out into a standard PHY driver? All the SLIC
>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could
>> be a standard PHY hidden behind a single register.
>>
>>Andrew
>
> You are right, the driver should rea
Hi Sergio,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.9-rc5 next-20161115]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sergio-Paracuellos/staging-slicoss
Hi,
On 15.11.2016 21:54, Florian Fainelli wrote:
> On 11/15/2016 12:46 PM, Lino Sanfilippo wrote:
>>> Could this be pulled out into a standard PHY driver? All the SLIC
>>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could
>>> be a standard PHY hidden behind a single register.
>>
On Tue, 2016-11-15 at 10:55 +0100, Greg KH wrote:
> On Thu, Nov 10, 2016 at 10:15:31PM -0800, Michael Zoran wrote:
> > VCHIQ/vc04_services has a userland device interface
> > that includes ioctls. The current ioctl implementation
> > is a single monolithic function over 1,000+ lines
> > that handle
> The link state is retrieved by a command to the application processor that is
> running
> on the network card. Also the register to set the phy configuration is
> write-only, so
> it is not even possible to do the usual mdio bit-banging in the Phy read()
> and write()
> functions (however the
On 15.11.2016 22:59, Andrew Lunn wrote:
>> The link state is retrieved by a command to the application processor that
>> is running
>> on the network card. Also the register to set the phy configuration is
>> write-only, so
>> it is not even possible to do the usual mdio bit-banging in the Phy r
On 11/15/2016 02:34 PM, Lino Sanfilippo wrote:
> On 15.11.2016 22:59, Andrew Lunn wrote:
>>> The link state is retrieved by a command to the application processor that
>>> is running
>>> on the network card. Also the register to set the phy configuration is
>>> write-only, so
>>> it is not even
On 15.11.2016 23:39, Florian Fainelli wrote:
> On 11/15/2016 02:34 PM, Lino Sanfilippo wrote:
>> On 15.11.2016 22:59, Andrew Lunn wrote:
The link state is retrieved by a command to the application processor that
is running
on the network card. Also the register to set the phy confi
> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
> > +SLIC_PCR_AUTONEG_RST;
> > + slic_write(sdev, SLIC_REG_WPHY, val);
> Thats essentially what I meant by setting a flag in the irq handler. The mdio
> function
On 16.11.2016 00:03, Andrew Lunn wrote:
>> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG |
>> > + SLIC_PCR_AUTONEG_RST;
>> > + slic_write(sdev, SLIC_REG_WPHY, val);
>
>> Thats essentially what I meant by setting a fl
On Tue, 2016-11-15 at 20:42 +0100, Stefan Wahren wrote:
> Hi Dan,
>
> > Dan Carpenter hat am 15. November 2016
> > um 14:15
> > geschrieben:
> >
> >
> > Hello popcornmix,
> >
> > The patch 71bad7f08641: "staging: add bcm2708 vchiq driver" from
> > Jul
> > 2, 2013, leads to the following static
On Tue, 15 Nov 2016, Michael Zoran wrote:
> I'm still interested to know more about the MMU statement. I would
> think at least some of the RPI models have one because swapping appears
> to be at least somewhat functional on the later models.
All Raspberry Pi models have an MMU. I'm not sure wh
On Tue, 2016-11-15 at 22:04 -0500, Vince Weaver wrote:
> On Tue, 15 Nov 2016, Michael Zoran wrote:
>
> > I'm still interested to know more about the MMU statement. I would
> > think at least some of the RPI models have one because swapping
> > appears
> > to be at least somewhat functional on the
This patch fix the following sparse warnings in slicoss driver:
warning: incorrect type in assignment (different address spaces)
Changes in v2:
* Remove IOMEM_GET_FIELDADDR macro
* Add ioread64 and iowrite64 defines
Signed-off-by: Sergio Paracuellos
---
drivers/staging/slicoss/slicoss.c | 111 +
On Tue, Nov 15, 2016 at 01:27:14PM -0800, Michael Zoran wrote:
> I'll see what I can do, but since this is getting closer to the
> holidays I'm planing to spend less time on this. Perhaps someone else
> may be interested in cleaning up the ioctl path?
>
> Since the old code uses obsolete kernel fe
On Wed, Nov 16, 2016 at 05:07:37AM +0100, Sergio Paracuellos wrote:
> This patch fix the following sparse warnings in slicoss driver:
> warning: incorrect type in assignment (different address spaces)
>
> Changes in v2:
> * Remove IOMEM_GET_FIELDADDR macro
> * Add ioread64 and iowrite64 defines
>
On Tue, Nov 15, 2016 at 08:55:11AM +, Ioana Ciornei wrote:
>
> > -Original Message-
> > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> > ow...@vger.kernel.org] On Behalf Of feas
> > Sent: Monday, November 14, 2016 7:16 PM
> > To: de...@driverdev.osuosl.org; gre...@lin
45 matches
Mail list logo
