Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-11-01 Thread Russell King - ARM Linux
On Mon, Oct 31, 2016 at 12:53:13PM -0700, Michael Zoran wrote: > On Mon, 2016-10-31 at 11:40 -0700, Michael Zoran wrote: > > The comment is easy to change. > > > > I don't have the log available ATM, but if I remember the DMA API's > > bugcheck the first time that are used.   > > > > I think this

[PATCH] staging: greybus: arche-platform: fix device reference leak

2016-11-01 Thread Johan Hovold
Make sure to drop the device reference taken by of_find_device_by_node() before returning from arche_platform_change_state(). Note that this code is expected to be removed, but let's fix up the leak nonetheless. Fixes: 886aba558b9e ("greybus: arche-platform: Export fn to allow...") Signed-off-by:

Re: Greybus Future

2016-11-01 Thread Bryan O'Donoghue
On Mon, 2016-10-31 at 08:50 -0500, Alex Elder wrote: > My suggestion is to create a majordomo list: >     grey...@kernel.org I think this is a great idea. We need a forum where we can discuss changes to the specification and the firmware - it would be a bit anti- social to be blitzing de...@driver

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-11-01 Thread Robin Murphy
Hi Michael, On 31/10/16 19:53, Michael Zoran wrote: > On Mon, 2016-10-31 at 11:40 -0700, Michael Zoran wrote: >> On Mon, 2016-10-31 at 11:36 -0700, Eric Anholt wrote: >>> Michael Zoran writes: >>> Setting the DMA mask is optional on 32 bit but is mandatory on 64 bit. Set the DMA mask a

[PATCH] staging: nvec: remove managed resource from PS2 driver

2016-11-01 Thread Marc Dietrich
This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of the managed version of kzalloc). Serio struct should never by managed because it is refcounted. Doing so will lead to a double free oops on module remove. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec_ps2.c | 2

[PATCH v2] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg()

2016-11-01 Thread Vitaly Kuznetsov
DoS protection conditions were altered in WS2016 and now it's easy to get -EAGAIN returned from vmbus_post_msg() (e.g. when we try changing MTU on a netvsc device in a loop). All vmbus_post_msg() callers don't retry the operation and we usually end up with a non-functional device or crash. While h

Re: Greybus Future

2016-11-01 Thread Johan Hovold
On Mon, Oct 31, 2016 at 08:50:53AM -0500, Alex Elder wrote: > I'm proposing below a few things, which I'll implement this week > unless I hear people express strong opposition (or clearly better > suggestions). If you have comments, please say something. > > Git repositories. Public git reposit

RE: [PATCH v2] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg()

2016-11-01 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 1, 2016 9:34 AM > To: de...@linuxdriverproject.org > Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; > Haiyang Zhang ; Van De Ven, Arjan > > Subject: [PATCH v2] Drivers: hv: vmbus: Rais

[PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning

2016-11-01 Thread Michael Zoran
vc04_services contains a debug logging mechanism. The log is maintained in a shared memory area between the kernel and the firmware. Changing the sizes of the data in this area would require a firmware change which is distributed independently from the kernel binary. One of the items logged is t

Re: [PATCH v2 1/7] selftest: sync: basic tests for sw_sync framework

2016-11-01 Thread Gustavo Padovan
Hi Emilio, 2016-10-19 Emilio López : > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. > > Signed-off-by: Emilio López > --- > tools/testing/selftests/Makefile

Re: [PATCH] staging: vc04_services: parse_rx_slots() - Fix compiler warning

2016-11-01 Thread Eric Anholt
Michael Zoran writes: > vc04_services contains a debug logging mechanism. The log is > maintained in a shared memory area between the kernel and the > firmware. Changing the sizes of the data in this area would > require a firmware change which is distributed independently > from the kernel bin

[PATCH V2 00/14] Drivers: hv: Some miscellaneous fixes and enhancements

2016-11-01 Thread kys
From: K. Y. Srinivasan Some miscellaneous fixes and enhancements. V2: Fixed a build issue reported by Greg. Only Patch # 13 is affected. Alex Ng (6): Drivers: hv: utils: Fix the mapping between host version and protocol to use Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOT

[PATCH V2 10/14] tools: hv: fix a compile warning in snprintf

2016-11-01 Thread kys
From: Weibing Zhang hv_kvp_daemon.c: In function .kvp_mac_to_if_name.: hv_kvp_daemon.c:705:2: warning: format not a string literal and no format arguments [-Wformat-security] snprintf(dev_id, sizeof(dev_id), kvp_net_dir); ^ hv_kvp_daemon.c:705:2: warning: format not a string literal and no f

[PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count

2016-11-01 Thread kys
From: Alex Ng Balloon driver was only printing the size of the info blob and not the actual content. This fixes it so that the info blob (max page count as configured in Hyper-V) is printed out. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c |9 +++-

[PATCH V2 12/14] Drivers: hv: vmbus: Base host signaling strictly on the ring state

2016-11-01 Thread kys
From: K. Y. Srinivasan One of the factors that can result in the host concluding that a given guest in mounting a DOS attack is if the guest generates interrupts to the host when the host is not expecting it. If these "spurious" interrupts reach a certain rate, the host can throttle the guest to

[PATCH V2 01/14] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() (v2)

2016-11-01 Thread kys
From: Vitaly Kuznetsov With wrap around mappings in place we can always provide drivers with direct links to packets on the ring buffer, even when they wrap around. Do the required updates to get_next_pkt_raw()/put_pkt_raw() The first version of this commit was reverted (65a532f3d50a) to deal wi

[PATCH V2 13/14] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host

2016-11-01 Thread kys
From: K. Y. Srinivasan Signal the host when we determine the host is to be signaled. The currrent code determines the need to signal in the ringbuffer code and actually issues the signal elsewhere. This can result in the host viewing this interrupt as spurious since the host may also poll the cha

[PATCH V2 05/14] Drivers: hv: balloon: Add logging for dynamic memory operations

2016-11-01 Thread kys
From: Alex Ng Added logging to help troubleshoot common ballooning, hot add, and versioning issues. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c | 31 --- 1 files changed, 28 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH V2 11/14] tools: hv: remove unnecessary header files and netlink related code

2016-11-01 Thread kys
From: Weibing Zhang Remove unnecessary header files and netlink related code as the daemons do not use netlink to communicate with the kernel now. Signed-off-by: Weibing Zhang Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_fcopy_daemon.c |7 --- tools/hv/hv_kvp_daemon.c |7

[PATCH V2 06/14] Drivers: hv: vss: Improve log messages.

2016-11-01 Thread kys
From: Alex Ng Adding log messages to help troubleshoot error cases and transaction handling. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_snapshot.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/hv/hv_snap

[PATCH V2 04/14] Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set

2016-11-01 Thread kys
From: Alex Ng If the guest does not support memory hotplugging, it should respond to the host with zero pages added and successful result code. This signals to the host that hotplugging is not supported and the host will avoid sending future hot-add requests. Signed-off-by: Alex Ng Signed-off-b

[PATCH V2 02/14] Drivers: hv: utils: reduce HV_UTIL_NEGO_TIMEOUT timeout

2016-11-01 Thread kys
From: Vitaly Kuznetsov I discovered that at least WS2016TP5 host has 60 seconds timeout for the ICMSGTYPE_NEGOTIATE message so we need to lower guest's timeout a little bit to make sure we always respond in time. Let's make it 55 seconds. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Sri

[PATCH V2 14/14] Drivers: hv: vmbus: On the read path cleanup the logic to interrupt the host

2016-11-01 Thread kys
From: K. Y. Srinivasan Signal the host when we determine the host is to be signaled - on th read path. The currrent code determines the need to signal in the ringbuffer code and actually issues the signal elsewhere. This can result in the host viewing this interrupt as spurious since the host may

[PATCH V2 07/14] Drivers: hv: vss: Operation timeouts should match host expectation

2016-11-01 Thread kys
From: Alex Ng Increase the timeout of backup operations. When system is under I/O load, it needs more time to freeze. These timeout values should also match the host timeout values more closely. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_snapshot.c |8 ++-

[PATCH V2 09/14] tools: hv: remove unnecessary link flag

2016-11-01 Thread kys
From: Weibing Zhang The link flag pthread is not needed. Signed-off-by: Weibing Zhang Signed-off-by: K. Y. Srinivasan --- tools/hv/Makefile |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/hv/Makefile b/tools/hv/Makefile index a8c4644..0d1e61b 100644 --- a/tool

[PATCH V2 03/14] Drivers: hv: utils: Fix the mapping between host version and protocol to use

2016-11-01 Thread kys
From: Alex Ng We should intentionally declare the protocols to use for every known host and default to using the latest protocol if the host is unknown or new. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_util.c |9 ++--- 1 files changed, 6 insertions(+), 3

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-11-01 Thread Jonathan Cameron
On 31/10/16 08:05, Eva Rachel Retuya wrote: > On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote: >> On Sun, Oct 30, 2016 at 06:49:00PM +, Jonathan Cameron wrote: >>> On 30/10/16 17:46, Lars-Peter Clausen wrote: On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > On 28/10/

Re: Greybus Future

2016-11-01 Thread Joël Porquet
Hi Alex, all, On Mon, Oct 31, 2016 at 6:50 AM, Alex Elder wrote: > The Greybus kernel code, developed as part of Google's Project Ara, > is in the upstream Linux kernel tree (under drivers/staging). The > cancellation of that project makes the future for Greybus a bit less > certain. There is i

Re: [PATCH 1/6] staging: iio: set proper supply name to devm_regulator_get()

2016-11-01 Thread Lars-Peter Clausen
On 11/01/2016 05:03 AM, Matt Ranostay wrote: > On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya > wrote: >> The name passed to devm_regulator_get() should match the name of the >> supply as specified in the device datasheet. This makes it clear what >> power supply is being referred to in case

Re: Greybus Future

2016-11-01 Thread Luis de Bethencourt
On 01/11/16 11:18, Bryan O'Donoghue wrote: > On Mon, 2016-10-31 at 08:50 -0500, Alex Elder wrote: >> My suggestion is to create a majordomo list: >> grey...@kernel.org > > I think this is a great idea. We need a forum where we can discuss > changes to the specification and the firmware - it wo

[PATCH 4/4] Staging: vme: Fix parenthesis alignment.

2016-11-01 Thread Anton Leshchenko
Align broken line for code readability. Signed-off-by: Anton Leshchenko --- drivers/staging/vme/devices/vme_pio2_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c index 8e66a52..20

[PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions.

2016-11-01 Thread Anton Leshchenko
Instead of using shift operation use BIT macro for bit field definitions. Signed-off-by: Anton Leshchenko --- drivers/staging/vme/devices/vme_pio2.h | 102 - 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2.h b/

[PATCH 3/4] Staging: vme: Add required identifier names.

2016-11-01 Thread Anton Leshchenko
Add identifier names for function definition arguments. Signed-off-by: Anton Leshchenko --- drivers/staging/vme/devices/vme_pio2.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h index 9d

[PATCH 1/4] Staging: vme: Remove excessive blank lines.

2016-11-01 Thread Anton Leshchenko
To make code more readable, remove excessive blank lines. Signed-off-by: Anton Leshchenko --- drivers/staging/vme/devices/vme_pio2.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h index d5d94c4..0b280ae 100

[PATCH] pci-hyperv: move hypercall buffer from stack to heap

2016-11-01 Thread Long Li
From: Long Li We need to pass a segment from a physically continuous buffer to hv_do_hypercall. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Moving the params buffer from stack to buffer returned by kmalloc. Signed-off-by: Long Li Reported-by: Haiyang Zhang ---

[PATCH] staging: vt6655: card.c: Fixing multiple assignments

2016-11-01 Thread Nick Rosbrook
Running checkpath on card.c shows two locations where multiple assignments are used. This patch modifies the assignments into single assignments. Signed-off-by: Nick Rosbrook --- drivers/staging/vt6655/card.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/sta

Re: [PATCH] staging: greybus: arche-platform: fix device reference leak

2016-11-01 Thread Viresh Kumar
On Tue, Nov 1, 2016 at 4:25 PM, Johan Hovold wrote: > Make sure to drop the device reference taken by of_find_device_by_node() > before returning from arche_platform_change_state(). > > Note that this code is expected to be removed, but let's fix up the leak > nonetheless. > > Fixes: 886aba558b9e