[PATCH] staging: vc04_services: remove vchiq_copy_from_user

2016-10-30 Thread Michael Zoran
The vchiq_copy_from_user function is not portable and is consider "bad practice." Replace this function with a callback based mechanism that is passed downward on the stack. When it is actually time to copy the data, the callback is called to copy the data into the message. This callback is prov

Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3

2016-10-30 Thread Greg Kroah-Hartman
On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote: > From: John L. Hammond > > Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but > which allows setting of all three inode timestamps. Use this ioctl > during HSM restore to ensure that the volatile file has the same

Re: [PATCH 12/29] staging: lustre: mdc: manage number of modify RPCs in flight

2016-10-30 Thread Greg Kroah-Hartman
On Thu, Oct 27, 2016 at 06:11:46PM -0400, James Simmons wrote: > From: Gregoire Pichon > > This patch is the main client part of a new feature that supports > multiple modify metadata RPCs in parallel. Its goal is to improve > metadata operations performance of a single client, while maintening >

Re: [PATCH] Staging: ks7010: ks7010_sdio.c: Fixed a coding style issue.

2016-10-30 Thread Greg KH
On Sun, Oct 30, 2016 at 02:56:06AM +0530, Manoj Sawai wrote: > Fixed a coding style error involving use of spaces instead of tabs. > > Signed-off-by: Manoj Sawai > --- > drivers/staging/ks7010/ks7010_sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doesn't apply to my tree at all,

Re: [PATCH v3] staging : rtl8712: Free memory when kmalloc fails

2016-10-30 Thread Greg KH
On Fri, Oct 28, 2016 at 10:37:53AM +0530, Souptick Joarder wrote: > There are few functions where we need to free previously allocated memory > when kmalloc fails. Else it may lead to memory leakage. In _init_cmd_priv() > and _r8712_init_xmit_priv(), in few places we are not freeing previously > a

[PATCH] staging: comedi: ni_tio: fix warnings of uninitialized variables

2016-10-30 Thread Ted Chen
Fix the following warnings by initializing these variables to zero and add error check to return early when the check returns an error. drivers/staging/comedi/drivers/ni_tio.c: In function ‘ni_tio_set_sync_mode’: drivers/staging/comedi/drivers/ni_tio.c:492:28: warning: ‘ps’ may be used uninitializ

Re: [driver-core:driver-core-testing 2/6] drivers/built-in.o:undefined reference to `process_srcu'

2016-10-30 Thread Rafael J. Wysocki
On Friday, October 28, 2016 02:44:12 AM Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 05:48:34AM +0800, kbuild test robot wrote: > > tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > driver-core-testing > > head: ae17f29d0bb84a43b6c5f3e9fac0b124960c53f

Re: [driver-core:driver-core-testing 2/6] drivers/built-in.o:undefined reference to `process_srcu'

2016-10-30 Thread Paul E. McKenney
On Sun, Oct 30, 2016 at 05:11:55PM +0100, Rafael J. Wysocki wrote: > On Friday, October 28, 2016 02:44:12 AM Greg Kroah-Hartman wrote: > > On Fri, Oct 28, 2016 at 05:48:34AM +0800, kbuild test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Jonathan Cameron
On 28/10/16 09:26, Eva Rachel Retuya wrote: > Introduce defines for shifting and mask under the config register for > better readability. Also, introduce helper variables for index > calculation. > > Signed-off-by: Eva Rachel Retuya Looks good to me. Lars could you sanity check this one as well?

Re: [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > Add device tree support for the tsl2583 IIO driver with no custom > properties. > > Signed-off-by: Brian Masney Trivial enough that I feel I can take this without an explicit devicetree ack. Of course one is always welcome if anyone gets a chance to look

Re: [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support

2016-10-30 Thread Jonathan Cameron
On 30/10/16 17:43, Jonathan Cameron wrote: > On 28/10/16 11:00, Brian Masney wrote: >> Add device tree support for the tsl2583 IIO driver with no custom >> properties. >> >> Signed-off-by: Brian Masney > Trivial enough that I feel I can take this without an explicit devicetree > ack. Of course on

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Lars-Peter Clausen
On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > On 28/10/16 09:26, Eva Rachel Retuya wrote: >> Introduce defines for shifting and mask under the config register for >> better readability. Also, introduce helper variables for index >> calculation. >> >> Signed-off-by: Eva Rachel Retuya > Looks go

Re: [PATCH 02/10] staging: iio: tsl2583: check for error code from i2c_smbus_read_byte()

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > taos_i2c_read() and taos_als_calibrate() does not check to see if the > value returned by i2c_smbus_read_byte() was an error code. This patch > adds the appropriate error handling. > > Signed-off-by: Brian Masney Applied to the togreg branch of iio.git and

Re: [PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > taos_als_calibrate() has a code path where -1 is returned. This patch > changes the code so that a proper error code is returned. > > Signed-off-by: Brian Masney Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play

Re: [PATCH 04/10] staging: iio: tsl2583: remove redundant power_state sysfs attribute

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > IIO devices have a /sys/bus/iio/devices/iio:deviceX/power/ directory > that allows viewing and controling various power parameters. The tsl2583 > driver also has an additional custom sysfs attribute named power_state > that is not needed. This patch removes

Re: [PATCH 05/10] staging: iio: tsl2583: check return values from taos_chip_{on,off}

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > The return value from taos_chip_on() and taos_chip_off() was not > checked in taos_luxtable_store() and taos_probe(). This patch adds > proper error checking to these function calls. > > Signed-off-by: Brian Masney This does raise the question of whether w

Re: [PATCH 06/10] staging: iio: tsl2583: convert to use iio_chan_spec and {read,write}_raw

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > The tsl2583 driver directly creates sysfs attributes that should instead > be created by the IIO core on behalf of the driver. This patch adds the > iio_chan_spec array, the relevant info_mask elements and the read_raw() > and write_raw() functions to take a

Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > The illuminance0_calibscale sysfs attribute is not currently created by > the IIO core. This patch adds the appropriate mask to iio_chan_spec, > along with the appropriate data handling in the read_raw() and > write_raw() functions, so that the sysfs attribu

Re: [PATCH 08/10] staging: iio: tsl2583: use IIO_*_ATTR* macros to create sysfs entries

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > Use the IIO_CONST_ATTR, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO > macros for creating the in_illuminance_calibscale_available, > in_illuminance_integration_time_available, in_illuminance_input_target, > in_illuminance_calibrate, and in_illuminance_lux_tab

Re: [PATCH 09/10] staging: iio: tsl2583: add error code to sysfs store functions

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > in_illuminance_input_target_store() and in_illuminance_calibrate_store() > validated the data from userspace, however it would not return an > error code to userspace if an invalid value was passed in. This patch > changes these functions so that they return

Re: [PATCH 10/10] staging: iio: tsl2583: add locking to sysfs attributes

2016-10-30 Thread Jonathan Cameron
On 28/10/16 11:00, Brian Masney wrote: > in_illuminance_input_target_show(), in_illuminance_input_target_store(), > in_illuminance_calibrate_store(), and in_illuminance_lux_table_store() > accesses data from the tsl2583_chip struct. Some of these fields can be > modified by other parts of the drive

Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines

2016-10-30 Thread Jonathan Cameron
On 30/10/16 17:46, Lars-Peter Clausen wrote: > On 10/30/2016 06:41 PM, Jonathan Cameron wrote: >> On 28/10/16 09:26, Eva Rachel Retuya wrote: >>> Introduce defines for shifting and mask under the config register for >>> better readability. Also, introduce helper variables for index >>> calculation.

Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

2016-10-30 Thread Brian Masney
On Sun, Oct 30, 2016 at 06:37:40PM +, Jonathan Cameron wrote: > On 28/10/16 11:00, Brian Masney wrote: > > The illuminance0_calibscale sysfs attribute is not currently created by > > the IIO core. This patch adds the appropriate mask to iio_chan_spec, > > along with the appropriate data handlin

Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec

2016-10-30 Thread Jonathan Cameron
On 30 October 2016 20:04:09 GMT+00:00, Brian Masney wrote: >On Sun, Oct 30, 2016 at 06:37:40PM +, Jonathan Cameron wrote: >> On 28/10/16 11:00, Brian Masney wrote: >> > The illuminance0_calibscale sysfs attribute is not currently >created by >> > the IIO core. This patch adds the appropriat

[PATCH 00/15] Drivers: hv: Some miscellaneous fixes and enhancements

2016-10-30 Thread kys
From: K. Y. Srinivasan Some miscellaneous fixes and enhancements. Alex Ng (6): Drivers: hv: utils: Fix the mapping between host version and protocol to use Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set Drivers: hv: balloon: Add logging for dynamic memo

[PATCH 04/15] Drivers: hv: balloon: Disable hot add when CONFIG_MEMORY_HOTPLUG is not set

2016-10-30 Thread kys
From: Alex Ng If the guest does not support memory hotplugging, it should respond to the host with zero pages added and successful result code. This signals to the host that hotplugging is not supported and the host will avoid sending future hot-add requests. Signed-off-by: Alex Ng Signed-off-b

[PATCH 13/15] Drivers: hv: vmbus: Base host signaling strictly on the ring state

2016-10-30 Thread kys
From: K. Y. Srinivasan One of the factors that can result in the host concluding that a given guest in mounting a DOS attack is if the guest generates interrupts to the host when the host is not expecting it. If these "spurious" interrupts reach a certain rate, the host can throttle the guest to

[PATCH 10/15] tools: hv: fix a compile warning in snprintf

2016-10-30 Thread kys
From: Weibing Zhang hv_kvp_daemon.c: In function .kvp_mac_to_if_name.: hv_kvp_daemon.c:705:2: warning: format not a string literal and no format arguments [-Wformat-security] snprintf(dev_id, sizeof(dev_id), kvp_net_dir); ^ hv_kvp_daemon.c:705:2: warning: format not a string literal and no f

[PATCH 08/15] Drivers: hv: balloon: Fix info request to show max page count

2016-10-30 Thread kys
From: Alex Ng Balloon driver was only printing the size of the info blob and not the actual content. This fixes it so that the info blob (max page count as configured in Hyper-V) is printed out. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c |9 +++-

[PATCH 07/15] Drivers: hv: vss: Operation timeouts should match host expectation

2016-10-30 Thread kys
From: Alex Ng Increase the timeout of backup operations. When system is under I/O load, it needs more time to freeze. These timeout values should also match the host timeout values more closely. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_snapshot.c |8 ++-

[PATCH 11/15] tools: hv: remove unnecessary header files and netlink related code

2016-10-30 Thread kys
From: Weibing Zhang Remove unnecessary header files and netlink related code as the daemons do not use netlink to communicate with the kernel now. Signed-off-by: Weibing Zhang Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_fcopy_daemon.c |7 --- tools/hv/hv_kvp_daemon.c |7

[PATCH 05/15] Drivers: hv: balloon: Add logging for dynamic memory operations

2016-10-30 Thread kys
From: Alex Ng Added logging to help troubleshoot common ballooning, hot add, and versioning issues. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c | 31 --- 1 files changed, 28 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH 15/15] Drivers: hv: vmbus: On the read path cleanup the logic to interrupt the host

2016-10-30 Thread kys
From: K. Y. Srinivasan Signal the host when we determine the host is to be signaled - on th read path. The currrent code determines the need to signal in the ringbuffer code and actually issues the signal elsewhere. This can result in the host viewing this interrupt as spurious since the host may

[PATCH 01/15] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() (v2)

2016-10-30 Thread kys
From: Vitaly Kuznetsov With wrap around mappings in place we can always provide drivers with direct links to packets on the ring buffer, even when they wrap around. Do the required updates to get_next_pkt_raw()/put_pkt_raw() The first version of this commit was reverted (65a532f3d50a) to deal wi

[PATCH 02/15] Drivers: hv: utils: reduce HV_UTIL_NEGO_TIMEOUT timeout

2016-10-30 Thread kys
From: Vitaly Kuznetsov I discovered that at least WS2016TP5 host has 60 seconds timeout for the ICMSGTYPE_NEGOTIATE message so we need to lower guest's timeout a little bit to make sure we always respond in time. Let's make it 55 seconds. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Sri

[PATCH 12/15] vmbus: make sysfs names consistent with PCI

2016-10-30 Thread kys
From: Stephen Hemminger In commit 9a56e5d6a0ba ("Drivers: hv: make VMBus bus ids persistent") the name of vmbus devices in sysfs changed to be (in 4.9-rc1): /sys/bus/vmbus/vmbus-6aebe374-9ba0-11e6-933c-00259086b36b The prefix ("vmbus-") is redundant and differs from how PCI is represented in s

[PATCH 03/15] Drivers: hv: utils: Fix the mapping between host version and protocol to use

2016-10-30 Thread kys
From: Alex Ng We should intentionally declare the protocols to use for every known host and default to using the latest protocol if the host is unknown or new. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_util.c |9 ++--- 1 files changed, 6 insertions(+), 3

[PATCH 14/15] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host

2016-10-30 Thread kys
From: K. Y. Srinivasan Signal the host when we determine the host is to be signaled. The currrent code determines the need to signal in the ringbuffer code and actually issues the signal elsewhere. This can result in the host viewing this interrupt as spurious since the host may also poll the cha

[PATCH 06/15] Drivers: hv: vss: Improve log messages.

2016-10-30 Thread kys
From: Alex Ng Adding log messages to help troubleshoot error cases and transaction handling. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_snapshot.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/hv/hv_snap

[PATCH 09/15] tools: hv: remove unnecessary link flag

2016-10-30 Thread kys
From: Weibing Zhang The link flag pthread is not needed. Signed-off-by: Weibing Zhang Signed-off-by: K. Y. Srinivasan --- tools/hv/Makefile |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/hv/Makefile b/tools/hv/Makefile index a8c4644..0d1e61b 100644 --- a/tool

Re: [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support

2016-10-30 Thread Rob Herring
On Fri, Oct 28, 2016 at 06:00:12AM -0400, Brian Masney wrote: > Add device tree support for the tsl2583 IIO driver with no custom > properties. > > Signed-off-by: Brian Masney > --- > .../devicetree/bindings/iio/light/tsl2583.txt | 26 > ++ > drivers/staging/iio/light/t