From: Michael Zoran
The original arm implementation uses dmac_map_area which is not
portable. Replace it with an architecture neutral version
which uses dma_map_sg.
As you can see that for larger page sizes, the dma_map_sg
implementation is faster then the original unportable dma_map_area
imple
On Mon, Oct 24, 2016 at 09:27:30AM +0530, Souptick Joarder wrote:
> Hi Larry, Greg,
>
> On Thu, Oct 20, 2016 at 12:29 PM, Souptick Joarder
> wrote:
> Any Comment for this patch ?
It's only been a few days, for a staging driver patch, when loads of
other things were going on. Please be patie
Yep. That works. Thanks.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Oct 22, 2016 at 06:29:55PM +0100, Jonathan Cameron wrote:
> On 19/10/16 12:37, Dan Carpenter wrote:
> > I appologize for laughing, but I am still secretly amused in my heart.
> >
> > regards,
> > dan carpenter
> >
> Fewer beers or less caffeine for Dan!
;)
>
> Key take away here is kee
Fix the subject. Add a changelog. Add a signed-off-by. Break the
patch into three patches where each patch cleans up a specific type of
coding style warning.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.
On Sun, Oct 23, 2016 at 03:37:57PM +0300, Alex Briskin wrote:
> Sparse error fix - different lock contexts for basic block.
> Acquirement and release of spin lock was dependent on two separate
> unprotected variable evaluations. Instead the condition evaluation result
> is stored in a local boolean
On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>
No. Include the correct header file instead.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproje
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> From: Michael Zoran
>
> Signed-off-by: Michael Zoran
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/staging/vc0
On Fri, Oct 21, 2016 at 06:59:39PM +0530, Nadim Almas wrote:
> Fixed coding style issue
>
> Signed-off-by: Nadim Almas
> ---
> drivers/staging/wilc1000/host_interface.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c
> b/
On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter
wrote:
> On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
>> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>>
>
> No. Include the correct header file instead.
drivers/staging/board/board.c already includes , wh
On Mon, 2016-10-24 at 13:54 +0300, Dan Carpenter wrote:
> On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > Signed-off-by: Michael Zoran
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > | 2 +-
> > 1 file chang
On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> I didn't think it looked totally correct, but I'm not sure it's any
> more broken then what is already in the tree.
It's not more broken. But better to leave the compile warning there to
mark that it is an obvious security problem.
On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > I didn't think it looked totally correct, but I'm not sure it's any
> > more broken then what is already in the tree.
>
> It's not more broken. But better to leave the comp
On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote:
> On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > > I didn't think it looked totally correct, but I'm not sure it's any
> > > more broken then what is alread
On Monday, 24 October 2016 13:41:39 IDT Dan Carpenter wrote:
> evaluation
Hi Dan,
Thanks you for your feedback, it kind of felt like workaround.
However, it seems to me like bad design decision took place where locking/
unlocking is dependent on unprotected variable.
>From what I could understand f
On Mon, 2016-10-24 at 14:58 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:39:49AM -0700, Michael Zoran wrote:
> > On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> > > On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > > > I didn't think it looked totally correct,
I'm saying just be patient a bit. The devs are probably in CA and it's
still 5:30 AM there...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> From: Michael Zoran
>
> Signed-off-by: Michael Zoran
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/staging/vc0
On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote:
> From: Michael Zoran
>
> The original arm implementation uses dmac_map_area which is not
> portable. Replace it with an architecture neutral version
> which uses dma_map_sg.
>
> As you can see that for larger page sizes, the
Fixes all the checkpath errors/warnings for michael_mic.c:
space required before the open brace
no space before tabs
line over 80 characters
space required before the open brace '{'
space required after that close brace '}'
space prohibited after that open parenthesis '('
Fixes checkpatch error: tailing whitespace
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ks7010/michael_mic.h
b/drivers/staging/ks7010/michael_mic.h
index efaa217..9f6d23a 100644
On Mon, 2016-10-24 at 15:24 +0200, Greg KH wrote:
> On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > The original arm implementation uses dmac_map_area which is not
> > portable. Replace it with an architecture neutral version
> > which uses dm
On Mon, 2016-10-24 at 15:23 +0200, Greg KH wrote:
> On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzo...@crowfest.net wrote:
> > From: Michael Zoran
> >
> > Signed-off-by: Michael Zoran
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > | 2 +-
> > 1 file changed, 1
Hi Stuart,
On 10/21/2016 04:01 PM, Stuart Yoder wrote:
This patch series: A) addresses the final item in the staging
TODO list for the fsl-mc bus driver-- adding a functional driver
on top of the bus driver, and B) requests that the fsl-mc bus driver
be moved out of staging.
Awesome, it's grea
If you want to wait for someone else to take over that's fine. If you
want to send a patch that's also fine. There is not really strict
ownership of anything in the kernel. Greg will take patches from
anyone and he gets the last word wrt to drivers/staging/ (which sort of
contradicts what I said
The ad5933_i2c_read function returns an error code to indicate
whether it could read data or not. However ad5933_work() ignores
this return code and just accesses the data unconditionally,
which gets detected by gcc as a possible bug:
drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'a
At this point, I need to take a step back from this whole thing and
evaluate where this is all going. I started this arm64 thing for fun
as a tinker idea, and it is quickly becoming more then I think I want
to get involved with at this time.
I'm not saying I won't return to this at a later time o
The rtllib_rx_extract_addr() is supposed to set up the mac addresses
for four possible cases, based on two bits of input data. For
some reason, gcc decides that it's possible that none of the these
four cases apply and the addresses remain uninitialized:
drivers/staging/rtl8192e/rtllib_rx.c: In fu
Block comments should align the * on each line as reported by checkpatch.pl
Signed-off-by: Nadim Almas
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index cf8aefd..
ERROR: Use 4 digit octal (0777) not decimal permissions
This error was detected by checkpatch.pl
Signed-off-by: Nadim Almas
---
drivers/staging/fbtft/fb_ili9325.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ili9325.c
b/drivers/staging
Greg KH writes:
> On Sun, Oct 23, 2016 at 10:29:32PM -0700, mzo...@crowfest.net wrote:
>> From: Michael Zoran
>>
>> The original arm implementation uses dmac_map_area which is not
>> portable. Replace it with an architecture neutral version
>> which uses dma_map_sg.
>>
>> As you can see that
mzo...@crowfest.net writes:
> From: Michael Zoran
>
> The original arm implementation uses dmac_map_area which is not
> portable. Replace it with an architecture neutral version
> which uses dma_map_sg.
>
> As you can see that for larger page sizes, the dma_map_sg
> implementation is faster then
Em Sun, 2 Oct 2016 16:55:05 +0200
Greg Kroah-Hartman escreveu:
> On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > Remove including that don't need it.
> >
> > Signed-off-by: Wei Yongjun
> > Acked-by: Benjamin Gaignard
> > ---
> > drivers/staging/me
33 matches
Mail list logo
